Signed-off-by: Geert Uytterhoeven
---
drivers/net/ethernet/ti/tlan.c | 2 +-
drivers/net/wireless/atmel/atmel.c | 2 +-
include/net/iw_handler.h | 2 +-
net/socket.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/ti
Hi David,
On Thu, Mar 15, 2018 at 10:42 AM, David Howells wrote:
> Do we have anything left that still implements NOMMU?
Sure: arm, c6x, m68k, microblaze, and sh.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge.
y
> problems caused by adding 'const' to a definition will be seen by build
> errors or warnings.
Unfortunately in this particular case they could lead to failures that can only
be detected at runtime, when failing o write to a read-only piece of memory,
due to the casting aw
Submitters of device tree binding documentation may forget to CC
the subsystem maintainer if this is missing.
Signed-off-by: Geert Uytterhoeven
Cc: Kalle Valo
Cc: linux-wireless@vger.kernel.org
---
Please apply this patch directly if you want to be involved in device
tree binding documentation
data type
fdp_nci_create_conn() may return a negative error code, which is
silently ignored by assigning it to a u8.
Change conn_id from u8 to int to fix this.
Fixes: a06347c04c13e380 ("NFC: Add Intel Fields Peak NFC solution driver")
Signed-off-by: Geert Uytterhoeven
---
fdp_nci_patch
tion callback data is used to pass a (negative) error
code, it should always be signed.
2. EINPROGRESS is 150 on mips, 245 on parisc.
Hence -EINPROGRESS doesn't fit in a signed 8-bit number.
Change the callback status from "char" to "int" to fix these.
Signed-off-
ODE_AC_5G ||
wireless_mode == WIRELESS_MODE_AC_24G ||
wireless_mode == WIRELESS_MODE_AC_ONLY))
rate->flags |= IEEE80211_TX_RC_VHT_MCS;
u8 wireless_mode = 0;
enum wireless_mode {
...
WIRELESS_MODE_AC_ONLY = 0x100,
How is th
Signed-off-by: Geert Uytterhoeven
---
drivers/net/wireless/marvell/mwifiex/tdls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/tdls.c
b/drivers/net/wireless/marvell/mwifiex/tdls.c
index 9275f9c3f869bbb0..b39bf8bd954a2c71 100644
--- a
On Mon, Nov 27, 2017 at 11:01 AM, Geert Uytterhoeven
wrote:
> Below is the list of build error/warning regressions/improvements in
> v4.15-rc1[1] compared to v4.14[2].
>
> Summarized:
> - build errors: +2/-5
> [1]
> http://kisskb.eller
data type
fdp_nci_patch_otp() may return a negative error, which is silently
ignored by assigning it to a u8.
Change conn_id from u8 to int to fix this.
Signed-off-by: Geert Uytterhoeven
---
fdp_nci_patch_otp() and fdp_nci_patch_ram() are almost identical.
Please merge them, or create a common
: Geert Uytterhoeven
---
net/nfc/nci/hci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/nfc/nci/hci.c b/net/nfc/nci/hci.c
index 2aedac15cb592353..a0ab26d535dca749 100644
--- a/net/nfc/nci/hci.c
+++ b/net/nfc/nci/hci.c
@@ -676,7 +676,7 @@ int nci_hci_connect_gate(struct
en
> combined with COMPILE_TEST, do you plan to do something similar with
> HAS_IOMEM?
No plans for that.
NO_IOMEM is Richard's itch, now s390 has gained PCI support.
NO_DMA matters for UML and Sun-3.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lo
ent types of serial ports, for a
total of 18 ports, and the two ports on a board labeled 0 and 1 may not
correspond to the physical first two ports (what's "first" in a collection of
4 different types?).
Aliases may be fine for referring to the main serial console (labeled
port 0 on th
timeout = jiffies + ATH10K_SDIO_HIF_COMMUNICATION_TIMEOUT_HZ;
Same here.
Should ret be preinitialized to 0, -ECANCELED, or something else?
> + while (time_before(jiffies, timeout) && !done) {
> + ret = ath10k_sdio_mbox_proc_pending_irqs(ar, &done);
> +
ngs. Instead my preference is something like below
>> where the error handling is more explicit and easier to find where it's
>> exactly failing. But that's just an example how I would try to solve it,
>> it still lacks the handling of -ECANCEL etc.
>
> I think I wo
15 matches
Mail list logo