[PATCH] rtlwifi: remove useless code

Remove useless local variables last_read_point and last_txw_point and the code related. Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/wireless/r

[PATCH] wireless: airo: remove unnecessary static in writerids()

134129 20bf1 drivers/net/wireless/cisco/airo.o Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/net/wireless/cisco/airo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/cisco/airo.c b/drivers/net/wireless/cisco/airo.c i

Re: ti: wl18xx: add checks on wl18xx_top_reg_write() return value

Quoting Kalle Valo <kv...@codeaurora.org>: "Gustavo A. R. Silva" <garsi...@embeddedor.com> wrote: Check return value from call to wl18xx_top_reg_write(), so in case of error jump to goto label out and return. Also, remove unnecessary value check before goto label out.

[PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches

Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1415177 Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- This issue was reported by Coverity and it was tested by compilatio

[PATCH] net: wireless: ath: ath9k: remove unnecessary code

The name of an array used by itself will always return the array's address. So this test will always evaluate as true. Addresses-Coverity-ID: 1364903 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/net/wireless/ath/ath9k/eeprom.c | 2 +- 1 file changed, 1 insertion

[PATCH] net: wireless: ath: ath10k: remove unnecessary code

The name of an array used by itself will always return the array's address. So these tests will always evaluate as false and therefore the _return_ will never be executed. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/net/wireless/ath/ath10k/wmi.c | 9 -

[net-realtek-btcoexist] question about identical code for different branches

ly appreciate any comment on this. Thank you! -- Gustavo A. R. Silva

[PATCH v2] ath10k: remove unnecessary code

The array fields in struct wmi_start_scan_arg that are checked here are fixed size arrays so they can never be NULL. Addresses-Coverity-ID: 1260031 Cc: Arend Van Spriel <arend.vanspr...@broadcom.com> Cc: Kalle Valo <kv...@qca.qualcomm.com> Signed-off-by: Gustavo A. R.

Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

Hi Kalle, Quoting Kalle Valo <kv...@qca.qualcomm.com>: "Gustavo A. R. Silva" <garsi...@embeddedor.com> writes: The name of an array used by itself will always return the array's address. So these tests will always evaluate as false and therefore the _return_ will neve

Re: [PATCH] net: wireless: ath: ath9k: remove unnecessary code

Hi Kalle, Quoting Kalle Valo <kv...@qca.qualcomm.com>: "Gustavo A. R. Silva" <garsi...@embeddedor.com> writes: The name of an array used by itself will always return the array's address. So this test will always evaluate as true. Addresses-Coverity-ID: 1364903 Signe

Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

Hi Arend, Quoting Arend Van Spriel <arend.vanspr...@broadcom.com>: On 9-5-2017 7:33, Kalle Valo wrote: "Gustavo A. R. Silva" <garsi...@embeddedor.com> writes: The name of an array used by itself will always return the array's address. So these tests will al

Re: [PATCH] net: wireless: ath: ath9k: remove unnecessary code

Quoting Kalle Valo <kv...@qca.qualcomm.com>: "Gustavo A. R. Silva" <garsi...@embeddedor.com> writes: Hi Kalle, Quoting Kalle Valo <kv...@qca.qualcomm.com>: "Gustavo A. R. Silva" <garsi...@embeddedor.com> writes: The name of an array used by its

[PATCH v2] ath9k: remove unnecessary code

The array field eeprom_data in struct th9k_platform_data is a fixed size array so it can never be NULL. Addresses-Coverity-ID: 1364903 Cc: Arend Van Spriel <arend.vanspr...@broadcom.com> Cc: Kalle Valo <kv...@qca.qualcomm.com> Signed-off-by: Gustavo A. R. Silva <garsi...

[PATCH] wireless: wlcore: spi: remove unnecessary variable

Remove unnecessary variable and refactor the code. Addresses-Coverity-ID: 1365000 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/net/wireless/ti/wlcore/spi.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ti/wlcore

Re: nfc: nci: fix potential NULL pointer dereference

Hi Guenter, Please, see my comments below Quoting Guenter Roeck <li...@roeck-us.net>: On Mon, Jun 12, 2017 at 05:02:23PM -0500, Gustavo A. R. Silva wrote: NULL check at line 76: if (conn_info) {, implies that pointer conn_info might be NULL, but this pointer is being previously derefe

[PATCH] nfc: nci: fix potential NULL pointer dereference

. Addresses-Coverity-ID: 1362349 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- net/nfc/nci/core.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c index 61fff42..d2198ce 100644 --- a/net/nfc/nci/core.c +++

[PATCH] ti: wl18xx: add checks on wl18xx_top_reg_write() return value

Check return value from call to wl18xx_top_reg_write(), so in case of error jump to goto label out and return. Also, remove unnecessary value check before goto label out. Addresses-Coverity-ID: 1226938 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/net/wirel

[PATCH] ath9k: remove useless variable assignment in ath_mci_intr()

Value assigned to variable offset at line 551 is overwritten at line 562, before it can be used. This makes such variable assignment useless. Addresses-Coverity-ID: 1226941 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/net/wireless/ath/ath9k/mci.c | 2 +-

[PATCH] NFC: add NULL checks to avoid potential NULL pointer dereference

: 1364857 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/nfc/nfcsim.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/nfc/nfcsim.c b/drivers/nfc/nfcsim.c index a466e79..6e90b54 100644 --- a/drivers/nfc/nfcsim.c +++ b/drivers/nfc/nf

[net-wireless-orinoco] question about potential null pointer dereference

ON_STACK(). My question is if there is any chance that pointer tfm_michael might be NULL when calling macro SHASH_DESC_ON_STACK() ? I'm trying to figure out if this is a false positive or something that needs to be fixed somehow. I'd really appreciate any comment on this. Thank you! -- Gustavo A. R. Silva

[PATCH] rtlwifi: rtl8821ae: remove unused variable

Remove unused variable rtlhal. Addresses-Coverity-ID: 1248810 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/d

[PATCH] nfc: nci: remove unnecessary null check

Remove unnecessary NULL check for pointer conn_info. conn_info is set in list_for_each_entry() using container_of(), which is never NULL. Addresses-Coverity-ID: 1362349 Cc: Guenter Roeck <li...@roeck-us.net> Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- net/nfc/nc

[PATCH] rtl8xxxu: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Cc: Jes Sorensen <jes.soren...@gmail.com> Cc: Kalle Valo <kv...@codeaurora.org> Cc: linux-wireless@vger.kernel.org Cc: net...@vger.kernel.org Signed-off-by: Gustavo A. R.

Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches

Hi Larry, On 08/30/2017 11:37 AM, Larry Finger wrote: On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1226788 Signed-off-by: Gustavo A. R

[PATCH] rtlwifi: refactor code in halbtcoutsrc module

tc_get_wifi_rssi. Addresses-Coverity-ID: 1226793 Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- This code was reported by Coverity and it was tested by compilation only. Chances are this may be a copy/paste error in function halbtc_get_wifi_rssi. Please, verify. Also, not

[PATCH] rtlwifi: rtl8723be: fix duplicated code for different branches

Refactor code in order to avoid identical code for different branches. Addresses-Coverity-ID: 1248728 Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- This issue was reported by Coverity and it was tested by compilation only. Please, verify if this is not a copy/paste error

Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches

Hi Larry, On 08/30/2017 11:48 PM, Larry Finger wrote: On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1226788 Signed-off-by: Gustavo A. R

[PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches

Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1226788 Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- This issue was reported by Coverity and it was tested by compilatio

Re: [PATCH] rtl8xxxu: mark expected switch fall-throughs

Hi Jes, Quoting Jes Sorensen <jes.soren...@gmail.com>: On 10/11/2017 04:41 AM, Kalle Valo wrote: Jes Sorensen <jes.soren...@gmail.com> writes: On 10/10/2017 03:30 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we a

[PATCH] net: mac80211: mark expected switch fall-throughs

expecting to find. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- This code was tested by compilation only (GCC 7.2.0 was used). Please, verify that the actual intention of the code is to fall through. net/mac80211/cfg.c| 3 +++ net/mac80211/ht.c | 1 + n

[PATCH] rsi: rsi_91x_ps: remove redundant code in str_psstate

"INVALID_STATE" is already being returned in the default case and this code cannot be reached. Addresses-Coverity-ID: 1398384 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/net/wireless/rsi/rsi_91x_ps.c | 1 - 1 file changed, 1 deletion(-) diff --g

[PATCH] ath9k: dfs: use swap macro in ath9k_check_chirping

Make use of the swap macro and remove unnecessary variable temp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/net/wireless/ath/ath9k/dfs.c | 8 +++-

Re: [PATCH] rsi: fix a bug in rsi_hal_key_config()

Hi Dan, On 04/27/2018 06:44 AM, Dan Carpenter wrote: On Fri, Apr 27, 2018 at 02:32:20PM +0300, Kalle Valo wrote: Gustavo submitted an identical patch also for this one :) https://patchwork.kernel.org/patch/10365997/ Hey Gustavo, We keep on sending duplicate patches. Most of the static

[PATCH] ath9k: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/net/wireless/ath/ath9k/ar5008_phy.c | 2 ++ drivers/net/wireless/ath/ath9k/ar9002_phy.c | 1 + drivers/net/wi

[PATCH v2] ath6kl: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- Changes in v2: - Place code comments on a line of their own. drivers/net/wireless/ath/ath6kl/cfg80211.c | 3 +++

Re: [PATCH] ath6kl: mark expected switch fall-throughs

On 05/25/2018 08:30 AM, Kalle Valo wrote: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> writes: On 5/25/2018 2:13 AM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustav

Re: [PATCH] ath6kl: mark expected switch fall-throughs

On 05/25/2018 01:10 PM, Kalle Valo wrote: Yeah, I was wondering the same. Was there a particular reason for this? Sometimes people use this style for a one-line code block. I can change it to the traditional style. No problem. I would prefer that. So if you can send v2 that would be

Re: [PATCH v2] ath6kl: mark expected switch fall-throughs

On 05/25/2018 01:27 PM, Steve deRosier wrote: On Fri, May 25, 2018 at 11:23 AM Gustavo A. R. Silva <gust...@embeddedor.com> wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva

[PATCH] mwifiex: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 4 drivers/net/wireless/marvell/mwifiex/scan.c | 1 + 2

[PATCH] rtlwifi: remove duplicate code

Remove and refactor some code in order to avoid having identical code for different branches. Notice that the logic has been there since 2014. Addresses-Coverity-ID: 1426199 ("Identical code for different branches") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com>

Re: [PATCH] rtlwifi: remove duplicate code

Hi Joe, On 05/24/2018 02:24 PM, Joe Perches wrote: On Thu, 2018-05-24 at 13:54 -0500, Gustavo A. R. Silva wrote: Remove and refactor some code in order to avoid having identical code for different branches. True and nice tool and patch submittal thanks. Notice that the logic has been

[PATCH] ath6kl: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH] ath10k: htt_tx: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case, I replaced "pass through" with a proper "fall through" comment, which is what GCC is expecting to find. Signed-off-by: Gusta

[PATCH] ath5k: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/net/wireless/ath/ath5k/pcu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath

[PATCH] staging: wilc1000: fix infinite loop and out-of-bounds access

wilc1000: refactor scan() to free kmalloc memory on failure cases") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- BTW... at first sight it seems to me that variables slot_id and i should be of type unsigned instead of signed. drivers/staging/wilc1000/wilc_wfi_cfgoperat

[PATCH] net: wireless: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- This code was tested by compilation only (GCC 7.2.0 was used). Please, verify if the actual intention of th

[PATCH] ssb: return boolean instead of integer in ssb_dma_translation_special_bit

Return statements in functions returning bool should use true/false instead of 1/0. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/ssb/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage

On 03/10/2018 05:12 PM, Kees Cook wrote: On Sat, Mar 10, 2018 at 3:06 PM, Arend van Spriel wrote: On 3/9/2018 1:30 PM, Andreas Christoforou wrote: The kernel would like to have all stack VLA usage removed. I think there was a remark made earlier to give

[rtlwifi-btcoex] Suspicious code in halbtc8821a1ant driver

Hi all, While doing some static analysis I came across the following piece of code at drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c:1581: 1581 static void btc8821a1ant_act_bt_sco_hid_only_busy(struct btc_coexist *btcoexist, 1582

[PATCH] brcm80211: brcmsmac: phy_lcn: remove duplicate code

Remove and refactor some code in order to avoid having identical code for different branches. Notice that this piece of code hasn't been modified since 2011. Addresses-Coverity-ID: 1226756 ("Identical code for different branches") Signed-off-by: Gustavo A. R. Silva <gust...@e

[PATCH] qtnfmac: pearl: pcie: fix memory leak in qtnf_fw_work_handler

In case memory resources for fw were succesfully allocated, release them before jumping to fw_load_fail. Addresses-Coverity-ID: 1466092 ("Resource leak") Fixes: c3b2f7ca4186 ("qtnfmac: implement asynchronous firmware loading") Signed-off-by: Gustavo A. R. Silva <

Re: [PATCH] qtnfmac: pearl: pcie: fix memory leak in qtnf_fw_work_handler

ronous firmware loading") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 4 1 file changed, 4 insertions(+) Thanks for the patch! Glad to help. :) Reviewed-by: Sergey Matyukevich <sergey.matyukevic

[PATCH] ath9k: dfs: remove accidental use of stack VLA

e all VLAs from the kernel: https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/net/wireless/ath/ath9k/dfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/dfs.c b/drivers/net/wi

[PATCH] mt7601u: phy: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/net/wireless/mediatek/mt7601u/phy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wi

Re: [PATCH] mac80211: aes-cmac: remove VLA usage

On 03/21/2018 08:48 AM, Johannes Berg wrote: On Wed, 2018-03-21 at 08:42 -0500, Gustavo A. R. Silva wrote: In preparation to enabling -Wvla, remove VLAs and replace them with dynamic memory allocation instead. The use of stack Variable Length Arrays needs to be avoided, as they can

Re: [PATCH] mac80211: aes-cmac: remove VLA usage

On 03/21/2018 08:58 AM, Johannes Berg wrote: On Wed, 2018-03-21 at 08:57 -0500, Gustavo A. R. Silva wrote: SHA_DESC_ON_STACK is currently being used in multiple places. But, yeah, I think we can define multiple macros of the same kind and adjust to the characteristics of each the component

[PATCH] mac80211: aes-cmac: remove VLA usage

it is easy to lose track of how big a VLA can get. Thus, we can end up having runtime failures that are hard to debug. Also, fixed as part of the directive to remove all VLAs from the kernel: https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --

[PATCH] rsi_91x_usb: fix uninitialized variable

2f37 ("rsi: disable fw watchdog timer during reset") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/net/wireless/rsi/rsi_91x_usb.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_usb.c

[PATCH] rsi_91x_mac80211: fix structurally dead code

ot;) Fixes: 4fd6c4762f37 ("rsi: roaming enhancements") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/net/wireless/rsi/rsi_91x_mac80211.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x