Re: [PATCH v2 RESEND] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

2016-09-20 Thread IgorMitsyanko
On 09/17/2016 05:50 PM, Johannes Berg wrote: drivers/net/wireless/quantenna/qtnfmac/event.c: In function `qtnf_event_handle_scan_complete': drivers/net/wireless/quantenna/qtnfmac/event.c:342:2: warning: passing argument 2 of `cfg80211_scan_done' makes pointer from integer without a cast [enabled

Re: [PATCH v2 RESEND] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

2016-09-20 Thread IgorMitsyanko
On 09/17/2016 04:56 PM, Kalle Valo wrote: writes: From: Avinash Patil This patch adds support for new FullMAC WiFi driver for Quantenna QSR10G chipsets. QSR10G is Quantenna's 8x8, 160M, 11ac offering. QSR10G supports 2 simultaneous WMACs- one 5G and one 2G. 5G WMAC supports 160M, 8x8 confi

Re: [PATCH v2 RESEND] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

2016-09-20 Thread IgorMitsyanko
On 09/17/2016 04:46 PM, Kalle Valo wrote: writes: From: Avinash Patil This patch adds support for new FullMAC WiFi driver for Quantenna QSR10G chipsets. QSR10G is Quantenna's 8x8, 160M, 11ac offering. QSR10G supports 2 simultaneous WMACs- one 5G and one 2G. 5G WMAC supports 160M, 8x8 confi

Re: [PATCH v2 RESEND] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

2016-09-26 Thread IgorMitsyanko
On 09/26/2016 01:56 PM, Kalle Valo wrote: IgorMitsyanko writes: On 09/17/2016 04:46 PM, Kalle Valo wrote: writes: +/* Supported rates to be advertised to the cfg80211 */ +static struct ieee80211_rate qtnf_rates[] = { + {.bitrate = 10, .hw_value = 2, }, + {.bitrate = 20

Re: [RFC] qtn: add FullMAC firmware for Quantenna QSR10G wifi device

2016-11-10 Thread IgorMitsyanko
On 11/10/2016 12:05 AM, Johannes Berg wrote: I understand, and I understand that you/they are actually providing it when asked. However, the carl9170 project has its (entirely GPL) source tree out in the open, making it much *easier* and that was *still* thought to not be sufficient; I don't rec

Re: [RFC] qtn: add FullMAC firmware for Quantenna QSR10G wifi device

2016-11-14 Thread IgorMitsyanko
Thanks, Johannes. To clarify with you and Kalle, as persons involved with linux-wireless: is my understanding correct that submitting firmware into linux-fimware repository is a prerequisite to accepting new driver into linux-wireless? There is an option to start Quantenna device from interna

Re: [PATCH V3] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

2016-11-16 Thread IgorMitsyanko
On 11/15/2016 12:06 PM, Johannes Berg wrote: On Wed, 2016-11-09 at 17:00 +0300, igor.mitsyanko...@quantenna.com wrote: +static int +qtnf_change_virtual_intf(struct wiphy *wiphy, +struct net_device *dev, +enum nl80211_iftype type, u32 *flags, +

Re: [PATCH V3] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

2016-11-16 Thread IgorMitsyanko
Resending because previous attempt was rejected by vger.kernel.org On 11/16/2016 06:04 PM, IgorMitsyanko wrote: On 11/14/2016 12:52 PM, Johannes Berg wrote: +++ b/drivers/net/wireless/quantenna/qtnfmac/Kconfig @@ -0,0 +1,23 @@ +config QTNFMAC + tristate "Quantenna WiFi FullMAC

Re: [RFC] qtn: add FullMAC firmware for Quantenna QSR10G wifi device

2016-11-22 Thread IgorMitsyanko
Hi Ben, Kyle, could you please share what is the position of linux-firmware regarding firmware binaries that include GPL components? Does it require entire GPL components codebase be present in linux-firmware tree, or maybe having this clause in license file is enough: +Open Source Software. T

Re: [RFC] qtn: add FullMAC firmware for Quantenna QSR10G wifi device

2016-11-23 Thread IgorMitsyanko
On 11/23/2016 06:25 PM, Kalle Valo wrote: IgorMitsyanko writes: To clarify with you and Kalle, as persons involved with linux-wireless: is my understanding correct that submitting firmware into linux-fimware repository is a prerequisite to accepting new driver into linux-wireless? In my

Re: [RFC] qtn: add FullMAC firmware for Quantenna QSR10G wifi device

2016-11-25 Thread IgorMitsyanko
On 11/24/2016 02:59 PM, Kalle Valo wrote: IgorMitsyanko writes: On 11/23/2016 06:25 PM, Kalle Valo wrote: IgorMitsyanko writes: To clarify with you and Kalle, as persons involved with linux-wireless: is my understanding correct that submitting firmware into linux-fimware repository is a

Re: [RFC] qtn: add FullMAC firmware for Quantenna QSR10G wifi device

2016-11-28 Thread IgorMitsyanko
On 11/28/2016 08:33 PM, Oleksij Rempel wrote: Am 28.11.2016 um 18:10 schrieb Oleksij Rempel: Am 28.11.2016 um 17:34 schrieb Kyle McMartin: On Tue, Nov 22, 2016 at 9:44 AM, IgorMitsyanko wrote: Hi Ben, Kyle, could you please share what is the position of linux-firmware regarding firmware

Re: [RFC] qtn: add FullMAC firmware for Quantenna QSR10G wifi device

2016-11-28 Thread IgorMitsyanko
On 11/28/2016 07:34 PM, Kyle McMartin wrote: On Tue, Nov 22, 2016 at 9:44 AM, IgorMitsyanko wrote: Hi Ben, Kyle, could you please share what is the position of linux-firmware regarding firmware binaries that include GPL components? Does it require entire GPL components codebase be present in

Re: [RFC] qtn: add FullMAC firmware for Quantenna QSR10G wifi device

2016-11-29 Thread IgorMitsyanko
On 11/29/2016 06:49 AM, Oleksij Rempel wrote: Am 28.11.2016 um 20:01 schrieb IgorMitsyanko: On 11/28/2016 08:33 PM, Oleksij Rempel wrote: Am 28.11.2016 um 18:10 schrieb Oleksij Rempel: Am 28.11.2016 um 17:34 schrieb Kyle McMartin: On Tue, Nov 22, 2016 at 9:44 AM, IgorMitsyanko wrote: Hi

Re: [RFC] qtn: add FullMAC firmware for Quantenna QSR10G wifi device

2016-11-29 Thread IgorMitsyanko
On 11/29/2016 12:34 PM, Arend Van Spriel wrote: On 29-11-2016 10:10, IgorMitsyanko wrote: On 11/29/2016 06:49 AM, Oleksij Rempel wrote: Am 28.11.2016 um 20:01 schrieb IgorMitsyanko: On 11/28/2016 08:33 PM, Oleksij Rempel wrote: Am 28.11.2016 um 18:10 schrieb Oleksij Rempel: [...] Oleksij

Re: [PATCH] cfg80211: Random local address for Public Action frame exchange

2016-12-30 Thread IgorMitsyanko
On 12/20/2016 11:39 PM, Jouni Malinen wrote: From: vamsi krishna Add support to use random local address (Address 2 = SA in transmit and the same address in receive functionality) for Public Action frames in order to improve privacy of WLAN clients. Applications fill the random source address i

Re: [PATCH] cfg80211: Random local address for Public Action frame exchange

2017-01-02 Thread IgorMitsyanko
On 01/02/2017 02:28 PM, Johannes Berg wrote: On Fri, 2016-12-30 at 22:55 +0300, IgorMitsyanko wrote: The driver needs to configure receive behavior to accept frames to the specified random address during the time the frame exchange is pending and such frames need to be acknowledged similarly to

Re: [PATCH] cfg80211: size various nl80211 messages correctly

2017-01-09 Thread IgorMitsyanko
On 01/09/2017 03:39 PM, Johannes Berg wrote: - msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); + msg = nlmsg_new(100 + ie_len, GFP_KERNEL); Don't you want the '100' to be a define? I didn't want to glorify it too much - some places may need more or less over time. There's no sign

Re: [PATCH] cfg80211: size various nl80211 messages correctly

2017-01-09 Thread IgorMitsyanko
On 01/09/2017 05:28 PM, IgorMitsyanko wrote: On 01/09/2017 03:39 PM, Johannes Berg wrote: -msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); +msg = nlmsg_new(100 + ie_len, GFP_KERNEL); Don't you want the '100' to be a define? I didn't want to glorify it too mu

Re: [PATCH net-next] bridge: multicast to unicast

2017-01-11 Thread IgorMitsyanko
On 01/11/2017 12:27 AM, Felix Fietkau wrote: On 2017-01-10 11:56, Johannes Berg wrote: On Tue, 2017-01-10 at 05:18 +0100, Linus Lüssing wrote: On Mon, Jan 09, 2017 at 01:30:32PM -0800, Stephen Hemminger wrote: I wonder if MAC80211 should be doing IGMP snooping and not bridge in this environmen

Re: [PATCH net-next] bridge: multicast to unicast

2017-01-11 Thread IgorMitsyanko
On 01/11/2017 02:30 PM, Felix Fietkau wrote: On 2017-01-11 12:26, IgorMitsyanko wrote: On 01/11/2017 12:27 AM, Felix Fietkau wrote: On 2017-01-10 11:56, Johannes Berg wrote: On Tue, 2017-01-10 at 05:18 +0100, Linus Lüssing wrote: On Mon, Jan 09, 2017 at 01:30:32PM -0800, Stephen Hemminger