+ cellular + GPS chipset in a tablet or laptop.
Thanks,
Julian Calaby
Henning Rogge
On Tue, Sep 9, 2014 at 3:07 PM, Emmanuel Grumbach
emmanuel.grumb...@intel.com wrote:
From: Avraham Stern avraham.st...@intel.com
Add API to notify user-space when the device is in motion
and the motion type
,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
for
highly unlikely bugs in the future. Also, the extra processing is
compile-time not run-time.)
Thanks,
Julian Calaby
Signed-off-by: Fabian Frederick f...@skynet.be
---
drivers/net/wireless/b43/ppr.c| 2 +-
drivers/net/wireless/iwlwifi/pcie/trans.c | 2 +-
drivers/net
in writing such a driver. I'm not sure what the status of
that effort is though.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message
.
Would there be any value in doing this for _all_ cases where the
function name is written in a format string?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line unsubscribe linux-wireless
Hi Julia,
On Mon, Dec 8, 2014 at 5:43 PM, Julia Lawall julia.law...@lip6.fr wrote:
On Mon, 8 Dec 2014, Julian Calaby wrote:
Hi Julia,
On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall julia.law...@lip6.fr wrote:
These patches replace what appears to be a reference to the name of the
current
.
Maybe using one of WARN()'s siblings instead.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More
,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
of course)
In this case, you're dropping 6 characters from the line with the
function call. You then need to re-flow the arguments to suit.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line
to be dark, but if turn off the blink option here, the LED is
bright but without blinking.
Hong
I.e. it doesn't blink, it's just on when linked (isn't there a trigger
for that?) or is on solid? (echo 255
/sys/class/leds/phy0-led/brightness)
Thanks,
--
Julian Calaby
Email: julian.cal
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
Hi Arik,
On Tue, Jan 13, 2015 at 9:35 PM, Arik Nemtsov a...@wizery.com wrote:
On Tue, Jan 13, 2015 at 12:30 PM, Julian Calaby julian.cal...@gmail.com
wrote:
Hi Arik,
On Tue, Jan 13, 2015 at 9:11 PM, Arik Nemtsov a...@wizery.com wrote:
On Tue, Jan 13, 2015 at 6:26 AM, Julian Calaby
Hi Arik,
On Tue, Jan 13, 2015 at 9:11 PM, Arik Nemtsov a...@wizery.com wrote:
On Tue, Jan 13, 2015 at 6:26 AM, Julian Calaby julian.cal...@gmail.com
wrote:
Hi Arik,
On Thu, Jan 8, 2015 at 1:47 AM, Arik Nemtsov a...@wizery.com wrote:
When a system contains only self-managed regulatory
the subject lines. I'm guessing something like:
echo $PATH | sed 's/^.*\/drivers\///;s/\//: /;s/\.c$/: Remove some
unused functions/;'
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line
into the define?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Berg johannes.b...@intel.com
Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com
This signoff chain doesn't look right to me (however other people
might not care): Shouldn't Eyal have used their intel.com email
address in the author field?
Thanks,
--
Julian Calaby
Email: julian.cal
arikx.nemt...@intel.com
Reviewed-by: Johannes Berg johannes.b...@intel.com
Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com
Same here.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list
johannes.b...@intel.com
Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com
Shouldn't this be signed off by Luciano too?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line
://osu.w1.fi:/
+authorityInfoAccess = OCSP;URI:@OCSP_URI@
#@ALTNAME@
extendedKeyUsage = critical, serverAuth
keyUsage = critical, keyEncipherment
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list
Hi Ben,
On Tue, Mar 24, 2015 at 9:31 AM, Ben Greear gree...@candelatech.com wrote:
On 03/23/2015 03:16 PM, Julian Calaby wrote:
Hi Ben,
On Tue, Mar 24, 2015 at 5:03 AM, gree...@candelatech.com wrote:
From: Ben Greear gree...@candelatech.com
This lets us properly over-ride the default w1
Hi,
Firstly, reply-all and keep the mailing list (linux-wireless) cc'd,
this discussion might be useful for others in the future.
On Mon, Apr 13, 2015 at 7:42 PM, J.H. Schmidt sophie...@embarqmail.com wrote:
On Apr 12, 2015, at 8:04 PM, Julian Calaby wrote:
Hi,
On Mon, Apr 13, 2015 at 10
by default will be
Here too.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info
, WiFi speeds above 54Mbit/s) Some
of them default to n only operation and need a setting turned on to
allow b or g devices to connect.
I'd investigate the settings of the router and ensure that
compatibility for older (g) devices is turned on.
Thanks,
--
Julian Calaby
Email: julian.cal
Hi Johannes,
On Wed, Jun 3, 2015 at 5:02 PM, Johannes Berg johan...@sipsolutions.net wrote:
On Wed, 2015-06-03 at 10:57 +1000, Julian Calaby wrote:
Why not add a ieee80211_hw_clear() function? Yes, it'd only be used in
3 places, but it'd look neater.
Well, this was actually intentional
, flg) _ieee80211_hw_set(hw,
IEEE80211_HW_##flg)
+
Why not add a ieee80211_hw_clear() function? Yes, it'd only be used in
3 places, but it'd look neater.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from
into a proper struct with a function
pointer instead of adding horrible hacks on top of already horrible
code?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line unsubscribe linux-wireless
firmware names here too?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Hi Avri,
On Thu, Jun 11, 2015 at 3:29 PM, Altman, Avri avri.alt...@intel.com wrote:
-Original Message-
From: Julian Calaby [mailto:julian.cal...@gmail.com]
Sent: Thursday, June 11, 2015 6:55 AM
To: Grumbach, Emmanuel
Cc: Johannes Berg; linux-wireless; Altman, Avri
Subject: Re
broken_uapsd_workarounds(struct ieee802_11_elems *elems)
Would a better name for this function be something like
is_uapsd_broken()? We're not actually working around anything here,
just checking whether it's broken or not.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com
it be better to split the work from
ieee80211_csa_update_counter() into a separate function without
locking and call that instead?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line
-by
and Suggested-by for crediting him with the idea, that said, it's
still a little rude to add them without permission.
See section 13 of https://www.kernel.org/doc/Documentation/SubmittingPatches
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles
)
for (i = 0; i len; i++)
printf( %.02x, frame[i]);
printf(]);
+ out:
+ ; /*empty statement to avoid compiler error */
Er, why not just return in the if (!attr) block?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http
/88W8864.bin
create mode 100755 mwlwifi/88W8897.bin
You _must_ provide a licence for those files and update the WHENCE
file as described in the README:
https://git.kernel.org/cgit/linux/kernel/git/firmware/linux-firmware.git/tree/README
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
, MAX_PACKET_BUFF_SIZE);
I believe you can get rid of these void* casts, you're modifying the
line anyway.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line unsubscribe linux-wireless
this?
+ pstrWFIDrv = get_handler_from_id(id);
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More
be included in your distribution's kernel. It's
called ipw2200 and should have been loaded automatically.
You will also need the firmware. Your distribution should have
packaged it. In Debian it's in the firmware-ipw2x00 package.
Hope that helps!
--
Julian Calaby
Email: julian.cal...@gmail.com
-u32TailLen = u32TailLen;
@@ -7159,6 +7162,7 @@ s32 host_int_add_beacon(WILC_WFIDrvHandle hWFIDrv, u32
u32Interval,
WILC_FREE(pstrSetBeaconParam-pu8Tail);
}
+_fail_:
return s32Error;
}
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http
config->pipedir = __cpu_to_le32(PIPEDIR_OUT);
> + config->nbytes_max = __cpu_to_le32(2048);
> +
> + /* Map from service/endpoint to Copy Engine */
> + target_service_to_ce_map_wlan[15].pipenum = __cpu_to_le32(1);
> +}
> +
Stupid question: Why no
tristate "Marvell 8xxx Libertas WLAN driver support with thin
> firmware"
> depends on MAC80211
> + count MAC80211_NUM_DRIVERS
> + select MAC80211_DRIVER_NO_HWFLAGS
Am I missing something or are you not actually doing anything with
MAC80211_DRIVER_NO_HWF
IO to use.
I want to say that this should go in DeviceTree or equivalent, however
ath6kl doesn't have DeviceTree support, so...
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the lin
+#ifdef CONFIG_GPIOLIB
> + /* Delay to avoid pulling the plug on the chip when an irq is pending
> +* and then getting a spurious message:
> +* "ath6kl: failed to get pending recv messages: -125"
> +*/
> + msleep(300);
Is there some actual sync
+ help
> + You should enable this option unless you know for sure you have no
> + need for it, for example when using internal regdb (above.)
> +
> + If unsure, say Y.
> +
Is there a way to force the kernel builder to select at least one of
these if th
> FILE *file = NULL;
>
> if (argc < 3)
> - return -EINVAL;
> + return 1;
You should probably explain why you're changing the return values in
the commit message.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.g
63c07589832bfe5ec49f2523ddb0e94a20af0f31
author Julian Calaby julian.cal...@gmail.com 1435196810 +1000
committer Julian Calaby julian.cal...@gmail.com 1436322540 +1000
= = = = = =
Then the subject and commit message.
The numbers after the email addresses are the timestamps. They are
both almost completely
is defined, the function can not refer to the structure type.
So this patch change the argument to void type pointer.
Same comments again, why not move the structure definition?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby
,
- (counter ==
u32WIDsCount - 1), drvHandler)) {
+ (counter ==
u32WIDsCount - 1), (void *)drvHandler)) {
Again, you shouldn't need a void * cast.
Thanks,
--
Julian Calaby
Email: julian.cal
))
+ if (wilc_wlan_cfg_commit(WILC_CFG_QUERY, (tstrWILC_WFIDrv
*)drvHandler))
Ditto.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord
)) {
+ (counter ==
u32WIDsCount - 1), (void *)drvHandler)) {
If I recall correctly, you shouldn't need void * casts.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby
Hi Johnny,
On Fri, Jul 10, 2015 at 5:58 PM, Johnny Kim johnny@atmel.com wrote:
On 2015년 07월 10일 15:20, Julian Calaby wrote:
Hi Johnny,
On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim johnny@atmel.com wrote:
A argument of wilc_wlan_cfg_commit() is address of structure.
But because
Hi Johnny,
On Fri, Jul 10, 2015 at 6:11 PM, Johnny Kim johnny@atmel.com wrote:
On 2015년 07월 10일 15:25, Julian Calaby wrote:
Hi Johnny,
On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim johnny@atmel.com wrote:
Last argument of wilc_wlan_cfg_get function is actually structure's
address
,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
of pain and annoyance, to everyone who
attempted to deal with it, so I don't.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord
Hi Ola,
On Thu, Oct 1, 2015 at 9:39 AM, Ola Olsson <ola1ols...@gmail.com> wrote:
> I guess not since there is a goto statement in between. Please correct
> me if I am wrong.
Oh, wait, you are right. I'm used to goto-free code.
Sorry for the noise.
Thanks,
Julian Calaby
>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>>> the body of a message to majord...@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>> --
>>
d.
We can't do this.
> Suggested-by: Julian Calaby <julian.cal...@gmail.com>
> Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
> ---
> drivers/staging/wilc1000/host_interface.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/driver
, sizeof(struct host_if_msg));
> + if (result) {
> PRINT_ER("wilc mq send fail\n");
> - s32Error = -EINVAL;
> + result = -EINVAL;
Same comments here: Why not
return -EINVAL;
> }
>
> /* wait untill MSG Q i
nclude the name of the
project ("iw") in your subject line, i.e.
[PATCH] iw: Remove superfluous header files
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wire
VAL;
> + result = -EINVAL;
Why not just have
return -EINVAL;
here?
> }
>
> - return s32Error;
> + return result;
and
return 0;
here?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.cala
s32 s32Error = 0;
> + s32 result = 0;
>
> PRINT_D(CORECONFIG_DBG, "CoreConfiguratorDeInit()\n");
>
>
> - return s32Error;
> + return result;
Ditto.
> }
>
> /*Using the global handle of the driver*/
> diff --git a/driver
xe = ctl->desc;
> dma_addr_t dma_addr;
> struct sk_buff *skb;
> + int ret = 0, int_mask;
> + u32 value;
> +
Surely something like:
if (ch->ch_type == WCN36XX_DXE_CH_RX_L) {
value = WCN36XX_DXE_CTRL_RX_L;
int_mask = WCN36XX_DXE_INT_CH1_MASK;
} else {
most all of the changes you've proposed that have seen any
discussion whatsoever fall into the latter category.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wi
patches to remove conditions before
kfree() and friends, etc.
You need to change you attitude: just because you can see some benefit
from your patches doesn't mean others do and it doesn't mean that
they're willing to accept them.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profi
goto err;
> + goto free_reply;
> }
>
> MEI_DUMP_NFC_HDR("connect reply", >hdr);
> @@ -210,11 +210,10 @@ static int mei_nfc_connect(struct nfc_mei_phy *phy)
> connect_resp->me_hotfix, connect_resp->me_build);
>
might be to move the
conversion into the function call following these lines so that they
remain "clean".
That said, I'm not sure this particular snippet of code would work on
big-endian at all as I'm pretty sure that BIT() produces cpu-endian
values and we know from the line you remove that
ead_hwaddr(wl, addr, block,
> wl->fw_mem_block_size, false);
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majord...@vger.kernel.org
!ieee80211_hw_check(sc->hw, NEEDS_ALIGNED4_SKBS)) {
>> /*
>> * Remove MAC header padding before giving the frame back to
>> * mac80211.
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this lis
Hi Nicholas,
On Tue, Dec 22, 2015 at 6:29 PM, Nicholas Mc Guire <der.h...@hofr.at> wrote:
> On Tue, Dec 22, 2015 at 09:56:10AM +1100, Julian Calaby wrote:
>> Hi,
>>
>> On Tue, Dec 22, 2015 at 3:47 AM, Nicholas Mc Guire <hof...@osadl.org> wrote:
>> >
);
> - return 0;
> - } else {
> - return 0;
> - }
> -
This isn't equivalent code as both arms of the if statement eventually
call return 0.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
-
Hi Glen,
On Thu, Dec 24, 2015 at 2:06 PM, glen lee <glen@atmel.com> wrote:
>
>
> On 2015년 12월 24일 11:39, Julian Calaby wrote:
>>
>> Hi Glen,
>>
>> On Wed, Dec 23, 2015 at 1:33 PM, Glen Lee <glen@atmel.com> wrote:
>>>
>>>
n, " [[freq
> <HT20|HT40+|HT40-|NOHT|80MHz>]"
Should NOHT remain last in the list?
> " [basic-rates ]], [mcast-rate Mbps>]"
> " [beacon-interval ] [dtim-period ]"
> " [vendor_sync on|off] [=]*",
. Expect
> a new version shortly.
I'm only really reviewing for style, you might want to wait for Kalle
or someone else to do a technical review.
> On Mon, Nov 16, 2015 at 10:25 PM, Julian Calaby <julian.cal...@gmail.com>
> wrote:
>>>
>>> static void __exit ath6kl_
Hi Steve,
Firstly, always reply-to-all, don't drop the CCs.
On Wed, Nov 18, 2015 at 4:14 AM, Steve deRosier <deros...@gmail.com> wrote:
> Hi Julian,
>
> On Mon, Nov 16, 2015 at 10:10 PM, Julian Calaby <julian.cal...@gmail.com>
> wrote:
>>
>>
>> I wan
; +
> + ret = sdio_register_driver(_sdio_driver);
> + if (ret) {
> ath6kl_err("sdio driver registration failed: %d\n", ret);
> + goto err_register;
> + }
>
> return ret;
> +
> +err_register:
> + ath6kl_s
ch->hw_value);
Isn't a &= b equivalent to a = a & b which is inappropriate for
boolean variables?
Also, wouldn't ret be true here, so the & is unnecessary?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To
@@ -879,13 +879,13 @@ bool RFbRawSetPower(
> dwMax7230Pwr = 0x080C0B00 | ((byPwr) << 12) |
> (BY_AL7230_REG_LEN << 3) | IFREGCTL_REGW;
>
> - bResult &= IFRFbWriteEmbedded(priv, dwMax7230Pwr);
> + ret &am
xists, has that number, takes arguments
in that format and works?
Thanks,
Julian Calaby
> On Wed, Jun 8, 2016 at 8:16 PM, Valo, Kalle <kv...@qca.qualcomm.com> wrote:
>> Prasun Maiti <prasunmait...@gmail.com> writes:
>>
>>> No. I did not any test for that cas
Hugh Sipiere <hgsipi...@gmail.com>
You should separate the changes into two patches, one to change
"unsigned" to "unsigned int" and one to fix the comments.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
queuing based drivers
> achieve better performance by utilizing airtime
> more efficiently with big aggregates.
>
> Signed-off-by: Michal Kazior <michal.kaz...@tieto.com>
As this patch is passing through your hands, you need to add your
Signed-off-by too.
Thanks,
--
Julian Calaby
his patch also contains two hunks to fix
> 'line over 80 characters',
> that are spacing related". This is the second hunk, the first being
> the comments in the nl80211_fam
> definition. Should I resend with these two hunks omitted, or fix my wording?
That explains it, I m
d-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
With Kirtika's explanation, this is:
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
Julian Calaby
> ---
> net/wireless/nl80211.c | 103
> ++---
> 1 file cha
se NL80211_IFTYPE_UNSPECIFIED:
> default:
> return ERR_PTR(-EINVAL);
> }
> +
> + if (IS_ERR(wdev))
> + brcmf_err("add iface %s type %d failed: err=%d\n",
> + name, type, PTR_ERR(wdev));
> +
t;
> This also has the nice side effect that the cleanup operations are made
> in the inverse order of their counterparts, which was not the case for
> the mwifiex_add_card() error path.
>
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
This looks sens
av...@osg.samsung.com>
This looks sensible to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
> ---
>
> drivers/net/wireless/marvell/mwifiex/sdio.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.c
the property being missed shouldn't be treated as an error.
Have you checked whether it is truly optional? I.e. nothing else
breaks if this property isn't set?
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Other than that, this looks sensible to me.
Reviewed-by: Juli
ppropriate one.
>
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
This looks sensible to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
>
> ---
>
> drivers/net/wireless/marvell/mwifiex/sdio.c | 4 ++--
> 1 file changed, 2 insertions(+)
c2:0001:1: sdio platform data not available
>
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
This looks sensible to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
> drivers/net/wireless/marvell/mwifiex/sdio.c | 6 +++---
> 1 file changed, 3 inserti
the first function that failed.
>
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
This looks sensible to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
> ---
>
> drivers/net/wireless/marvell/mwifiex/sdio.c | 8
> 1 file changed,
actually failed.
>
> Since the driver/device core prints the value returned by .probe in its
> error message propagate what was returned by sdio_enable_func() at fail.
>
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
This looks sensible to me.
Reviewed-by: Ju
Hi All,
On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas
<jav...@osg.samsung.com> wrote:
> It's better to have the device name prefixed in the error message.
>
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
This looks right to me.
Revie
Hi Javier,
On Wed, Jun 1, 2016 at 11:51 PM, Javier Martinez Canillas
<jav...@osg.samsung.com> wrote:
> Hello Julian,
>
> Thanks a lot for your feedback and reviews.
>
> On 06/01/2016 12:20 AM, Julian Calaby wrote:
>> Hi All,
>>
>> On Sat, May 28, 2016 at 12:
Hi All,
On Fri, May 27, 2016 at 9:25 PM, Eduardo Abinader <eabina...@ocedo.com> wrote:
> Just small adjustment.
>
> Signed-off-by: Eduardo Abinader <eduardo.abina...@riverbed.com>
This looks right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
>
ted patch.
>
> Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
Looks right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
> ---
> net/wireless/ap.c | 1 -
> net/wireless/chan.c| 3 ---
> net/wireless/core.h| 2 --
>
ement
Multiple assignments:
> - multiple assignments should be avoided
ether_addr_copy:
> - prefer ether_addr_copy over memcpy
Spelling:
> - correct spelling - 'implementation'
NULL comparisons:
> - comparison to NULL could be written as !foo
kcalloc vs kzalloc:
> - prefer kcalloc over
kas <auri...@google.com>
Other than that, it looks good to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
One final note, any patch you send to linux-wireless gets entered into
patchwork, so there's no need to keep asking for a review, people are
busy and will get to i
nd the whole patch-set or just patch 3/3 in
> this one as a separate set?
Re-send the entire set, make sure you mark it as v2, include a
changelog in the cover letter or below the "---" in the patches
themselves, and don't forget to include the reviewed-bys for any
unchanged patches.
Th
'*/' on a separate line
>
> Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
The change and logic behind it are sound, so it gets my:
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
however I'm concerned that this file is a deliberate exception to the
after declarations
>
> Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
Looks sensible to me
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
Julian Calaby
> ---
> net/wireless/nl80211.c | 22 ++
> 1 file changed, 10
right to me, but doesn't ether_addr_copy() have alignment
requirements? Could someone more familiar with that review these
changes to ensure they're met?
Thanks,
Julian Calaby
> ---
> net/wireless/nl80211.c | 9 -
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/net/wi
ail.com>
Looks right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
Julian Calaby
> ---
> net/wireless/nl80211.c | 23 +++
> 1 file changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/net/wireless/nl80211.c b/net/wirel
>
Looks right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
Julian Calaby
> ---
> net/wireless/nl80211.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 945405d.
1 - 100 of 296 matches
Mail list logo
