Re: [PATCH] net: rfkill: gpio: Fix clock status

device with clock resource. Regards, Loic On 17/09/2014 17:11, John W. Linville wrote: On Tue, Sep 16, 2014 at 02:53:58PM +0200, Loic Poulain wrote: Clock is disabled when the device is blocked. So, clock_enabled is the logical negation of blocked. Signed-off-by: Loic Poulain loic.poul

[PATCH 4/5] net: rfkill: gpio: Add OBDA8723 ACPI ID

Add OBDA8723 (rtl8723) ACPI id. rtl8723 bluetooth chip has the following interface: HOST ---UART--- CONTROLLER HOST --- WAKE--- CONTROLLER (gpio res 0) HOST ---ENABLE-- CONTROLLER (gpio res 1) HOST ---WAKE CONTROLLER (gpio res 2) Signed-off-by: Loic Poulain loic.poul...@intel.com --- net

[PATCH 3/5] net: rfkill: gpio: Implement host wake up support

Some GPIO based rfkill devices can wake their host up from suspend by toggling an input (from the host perspective) GPIO. This patch adds a generic support for that feature by registering a threaded interrupt routine and thus setting the corresponding GPIO as a wake up source. Signed-off-by: Loic

[PATCH 2/5] net: rfkill: gpio: Implement PM hooks

GPIO based rfkill devices should also be put to sleep mode when the system enters suspend. This patch introduces a wake gpio. Signed-off-by: Loic Poulain loic.poul...@intel.com --- net/rfkill/rfkill-gpio.c | 48 1 file changed, 48 insertions

[PATCH 5/5] net: rfkill: gpio: Add BCM47521 ACPI ID

Add BCM47521 (GPS) to the ACPI table. BCM47521 supports host wake. HOST ---UART--- CONTROLLER HOST -- WAKE CONTROLLER (gpio res 0) HOST ---ENABLE-- CONTROLLER (gpio res 1) Signed-off-by: Loic Poulain loic.poul...@intel.com --- net/rfkill/rfkill-gpio.c | 9 + 1 file changed, 9

Re: [PATCH 1/5] net: rfkill: gpio: Configurable GPIO idx

Hi Johannes, acpi_device_id driver_data field is defined as a kernel_ulong_t in mod_devicetable.h. Regards, Loic On 08/10/2014 10:53, Johannes Berg wrote: On Wed, 2014-10-08 at 10:34 +0200, Loic Poulain wrote: + { BCM2E1A, (kernel_ulong_t)acpi_default_bluetooth }, Shouldn't

Re: [PATCH 3/5] net: rfkill: gpio: Implement host wake up support

parameter with ACPI? Regards, Loic On 08/10/2014 13:38, Heikki Krogerus wrote: On Wed, Oct 08, 2014 at 10:34:38AM +0200, Loic Poulain wrote: Some GPIO based rfkill devices can wake their host up from suspend by toggling an input (from the host perspective) GPIO. This patch adds a generic support

Re: [PATCH 3/5] net: rfkill: gpio: Implement host wake up support

Thanks Heikki, I'll rework these patches accordingly. Regards, Loic On 09/10/2014 09:38, Heikki Krogerus wrote: On Wed, Oct 08, 2014 at 04:09:50PM +0200, Loic Poulain wrote: Thanks, it sounds good to use a label instead of index. However: - DSD is only compatible with BIOS ACPI 5.1

[PATCH] wcn36xx: Disable 5GHz for wcn3620

wcn3620 can only operate on 2.4GHz band due to RF limitation. If wcn36xx digital block is associated with an external IRIS RF module, retrieve the id and disable 5GHz band in case of wcn3620 id. Signed-off-by: Loic Poulain <loic.poul...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/

[PATCH] wcn36xx: Add hardware scan offload support

connection with hidden APs. It also fixes scan issues with band-steering AP which are not 'visible' with passive scan (due to hidden ssid in beacons). Let's keep the 'legacy' scanning method in case scan-offload is not supported. Signed-off-by: Loic Poulain <loic.poul...@linaro.org> --- drive

[PATCH] wcn36xx: Fix dynamic power saving

enabling PS mode in a static way, this make the device unusable when power save is enabled since device is forced to PS regardless RX/TX traffic. Signed-off-by: Loic Poulain <loic.poul...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c | 23 --- 1 file changed, 12 inse

[PATCH v2] wcn36xx: Fix dynamic power saving

enabling PS mode in a static way, this make the device unusable when power save is enabled since device is forced to PS regardless RX/TX traffic. Acked-by: Bjorn Andersson <bjorn.anders...@linaro.org> Signed-off-by: Loic Poulain <loic.poul...@linaro.org> --- v2: remove error msg on unbalanc

Re: [PATCH] wcn36xx: Fix dynamic power saving

Hi Bjorn, On 9 December 2017 at 01:45, Bjorn Andersson wrote: >> } >> } >> >> + if (changed & IEEE80211_CONF_CHANGE_PS) { >> + list_for_each_entry(tmp, >vif_list, list) { >> + vif = wcn36xx_priv_to_vif(tmp); >> +

Re: [PATCH] wcn36xx: Add hardware scan offload support

Hi Bjorn, On 9 December 2017 at 01:34, Bjorn Andersson wrote: > >> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c >> b/drivers/net/wireless/ath/wcn36xx/smd.c > [..] >> +static int wcn36xx_smd_hw_scan_ind(struct wcn36xx *wcn, void *buf, size_t >> len) >> +{ >> +

Re: [PATCH v2] wcn36xx: Fix dynamic power saving

Hi Ramon, On 11 December 2017 at 16:41, Bjorn Andersson <bjorn.anders...@linaro.org> wrote: > On Mon 11 Dec 07:34 PST 2017, Ramon Fried wrote: > >> On Mon, Dec 11, 2017 at 10:52:22AM +0200, Loic Poulain wrote: >> > Since driver does not report hardware dynamic power

[PATCH 1/3] wcn36xx: Fix WEP104 encryption type

Signed-off-by: Loic Poulain <loic.poul...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index aeb5e6e..4648a78 100644 --- a/drive

[PATCH 3/3] wcn36xx: Fix WEP encryption

In case of WEP encryption, driver has to configure shared key for associated station(s). Note that sta pointer is NULL in case of non pairwise key, causing NULL pointer dereference with existing code (sta_priv->is_data_encrypted). Fix this by using associated sta list instead. Signed-off-by: L

[PATCH 2/3] wcn36xx: Track associated stations

Add list of associated stations(STA, AP, peer...) per vif. Signed-off-by: Loic Poulain <loic.poul...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 5 + drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/drivers/net/wirele

[PATCH v2 1/3] wcn36xx: Fix WEP104 encryption type

This is an obvious copy & paste bug. Signed-off-by: Loic Poulain --- v2: non-empty commit message. drivers/net/wireless/ath/wcn36xx/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/ma

[PATCH v2 3/3] wcn36xx: Fix WEP encryption

WEP support as client, WEP AP is non-functional. Signed-off-by: Loic Poulain --- v2: Commit reword, clarify Client/AP WEP status drivers/net/wireless/ath/wcn36xx/main.c | 19 +++ drivers/net/wireless/ath/wcn36xx/smd.c | 20 ++-- 2 files changed, 25 insertions(+),

[PATCH v2 2/3] wcn36xx: Track associated stations

Add list of associated stations(STA, AP, peer...) per vif. Signed-off-by: Loic Poulain --- v2: no change drivers/net/wireless/ath/wcn36xx/main.c| 5 + drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/wcn36xx

[PATCH] wcn36xx: Fix warning due to duplicate scan_completed notification

been completed. Signed-off-by: Loic Poulain <loic.poul...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c | 9 +++-- drivers/net/wireless/ath/wcn36xx/smd.c | 2 ++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drive

Re: [PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time

Hi Colin, Bjorn, On 26 December 2017 at 21:13, Bjorn Andersson wrote: > On Tue 19 Dec 09:04 PST 2017, Colin King wrote: > >> From: Colin Ian King >> >> msg_body.min_ch_time is being assigned twice; remove the redundant >> first assignment.

[PATCH] wlcore: Set rx_status boottime_ns field on rx

BSS_LAST_SEEN_BOOTTIME parameter). Signed-off-by: Loic Poulain --- drivers/net/wireless/ti/wlcore/rx.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ti/wlcore/rx.c b/drivers/net/wireless/ti/wlcore/rx.c index 0f15696..078a494 100644 --- a/drivers

[PATCH] wcn36xx: Remove useless skb spinlock

Each DXE control block is associated to a specific channel. The channel lock is always taken before accessing a control block. There is no need to have an extra (useless) spinlock for the control block skb. Signed-off-by: Loic Poulain <loic.poul...@linaro.org> --- drivers/net/wirele

[PATCH] wcn36xx: Add missing fall through comment in smd.c

This prevents GCC warning. Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Loic Poulain <loic.poul...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/smd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/

Re: [PATCH 1/1 RFC] wcn36xx: fix buffer commit logic on TX path

Hi Daniel, > /* Move the head of the ring to the next empty descriptor */ > -ch->head_blk_ctl = ctl->next; > +ch->head_blk_ctl = ctl_skb->next; > + > + /* Commit all previous writes and set descriptors to VALID */ > + wmb(); Is this first memory barrier really

Re: [PATCH] wcn36xx: pass correct BSS index when deleting BSS keys

Hi Daniel, > @@ -564,10 +565,13 @@ static int wcn36xx_set_key(struct ieee80211_hw *hw, > enum set_key_cmd cmd, > break; > case DISABLE_KEY: > if (!(IEEE80211_KEY_FLAG_PAIRWISE & key_conf->flags)) { > + if (vif_priv->bss_index != >

Re: [PATCH 1/1 RFC] wcn36xx: fix buffer commit logic on TX path

On 11 April 2018 at 15:37, Daniel Mack <dan...@zonque.org> wrote: > Hi Loic, > > On Wednesday, April 11, 2018 03:30 PM, Loic Poulain wrote: >>> /* Move the head of the ring to the next empty descriptor */ >>> -ch->head_blk_ctl = ctl->next;

Re: [PATCH v2] wcn36xx: Disable 5GHz for wcn3610

Hi Ramon, On 29 March 2018 at 09:32, Ramon Fried wrote: >> Should we document qcom,wcn3610 just like wcn3620 is: >> >> Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.txt: >>"qcom,wcn3620", > IMHO the mentioned bindings is related to the