Re: [PATCH] mac80211_hwsim: Allow wmediumd to attach to radios created in its netns

2016-06-15 Thread Martin Willi
> > >  printk(KERN_INFO "mac80211_hwsim: wmediumd released netlink" > >         " socket, switching to perfect channel medium\n"); > I wonder if we can do something better about them? Or perhaps if we > should remove them, so other namespaces won't mess up the kernel log This is in fact not

[PATCH] mac80211_hwsim: Add missing check for HWSIM_ATTR_SIGNAL

2016-05-13 Thread Martin Willi
registration from user namespaces. Fixes: 7882513bacb1 ("mac80211_hwsimdriver support userspace frame tx/rx") Signed-off-by: Martin Willi <mar...@strongswan.org> --- drivers/net/wireless/mac80211_hwsim.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/mac

Re: [PATCH v2 0/2] wireless: Allow wiphy/hwsim management from user namespaces

2016-05-13 Thread Martin Willi
Hi Johannes, > So I think you should change the "wmediumd_portid" variable to live > in struct hwsim_net and then allow HWSIM_CMD_REGISTER to be done > inside the net namespace. > > With that, and making the other few wmediumd related operations > namespace aware, we would be able to run

[PATCH] mac80211_hwsim: Allow wmediumd to attach to radios created in its netns

2016-05-14 Thread Martin Willi
, even if they have been moved to other network namespaces. The wmediumd Netlink portid is tracked per net namespace. Additionally, the portid is stored on all radios created in that net namespace to simplify the portid lookup in the data path. Signed-off-by: Martin Willi <mar...@strongswan.

[PATCH 1/2] nl80211: Allow privileged operations from user namespaces

2016-05-03 Thread Martin Willi
ch implies a namespace aware lookup of the device. The only exception is NL80211_CMD_SET_WIPHY, which explicitly uses a namespace aware lookup. Signed-off-by: Martin Willi <mar...@strongswan.org> --- net/wireless/nl80211.c | 150 - 1 file change

[PATCH 2/2] mac80211_hwsim: Allow managing radios from non-initial namespaces

2016-05-03 Thread Martin Willi
the same netgroup can communicate even if not in the same namespace; This allows a controlling namespace to create radios and move them to other namespaces for communication. Signed-off-by: Martin Willi <mar...@strongswan.org> --- drivers/net/wireless/mac80211_hwsim.

[PATCH 0/2] wireless: Allow wiphy/hwsim management from user namespaces

2016-05-03 Thread Martin Willi
such namespaces. Together, with these patches an unprivileged test environment can create user/network namespaces and set up abitrary simulated wireless networks. Martin Willi (2): nl80211: Allow privileged operations from user namespaces mac80211_hwsim: Allow managing radios from non-initial

Re: [PATCH 2/2] mac80211_hwsim: Allow managing radios from non-initial namespaces

2016-05-03 Thread Martin Willi
> > This allows a controlling namespace to create radios and move them > > to other namespaces for communication. > Neat. > > I'm curious what the use case is? We use a test environment for integration and regression testing, which allows us to run our networked applications in a simulated

Re: [PATCH 2/2] mac80211_hwsim: Allow managing radios from non-initial namespaces

2016-05-04 Thread Martin Willi
  > > +static __net_init int hwsim_init_net(struct net *net) > > +{ > > + struct mac80211_hwsim_data *data; > > + bool exists = true; > > + int netgroup = 0; > > + > > + spin_lock_bh(_radio_lock); > > + while (exists) { > > + exists = false; > > +

Re: [PATCH 2/2] mac80211_hwsim: Allow managing radios from non-initial namespaces

2016-05-09 Thread Martin Willi
> > Moving the radio back to the creators namespace would be the most > > consistent behavior, so I'll check how difficult such a reverse > > lookup is. We then would delete the radio only if it is in the > > creators namespace, or if the creators namespace is gone. Does that > > make sense? >

[PATCH v2 0/2] wireless: Allow wiphy/hwsim management from user namespaces

2016-05-09 Thread Martin Willi
, add accessors. * On namespace exit, do not destroy hwsim radios originally created in the initial network namespace. Martin Willi (2): nl80211: Allow privileged operations from user namespaces mac80211_hwsim: Allow managing radios from non-initial namespaces drivers/net/wireless

[PATCH v2 1/2] nl80211: Allow privileged operations from user namespaces

2016-05-09 Thread Martin Willi
ch implies a namespace aware lookup of the device. The only exception is NL80211_CMD_SET_WIPHY, which explicitly uses a namespace aware phy lookup. Signed-off-by: Martin Willi <mar...@strongswan.org> --- net/wireless/nl80211.c | 150 - 1 file change

[PATCH v2 2/2] mac80211_hwsim: Allow managing radios from non-initial namespaces

2016-05-09 Thread Martin Willi
. This keeps the previous behavior by returning them to the init namespace, but prevents unprivileged users from creating radios in the initial namespace. Signed-off-by: Martin Willi <mar...@strongswan.org> --- drivers/net/wireless/mac80211_hwsim.c | 97 +-- 1 file c

ath10k SWBA overrun / tx credit starvation

2018-07-30 Thread Martin Willi
Hi, We are experiencing some issues when running ath10k in AP mode. Unfortunately, I didn't manage to reproduce the issue in the lab, but in the field we see it roughly once a day on one out of fifty devices. The symptoms are the logged "SWBA overruns" followed by a kernel WARNING when removing

Re: ath10k SWBA overrun / tx credit starvation

2018-08-07 Thread Martin Willi
> > [...], which implies that at least some of them have been addressed > > with 10.2/10.2.4. > > Out of curiosity, how soon could you hit it with -ct firmware? We > often see these around once per day in some of our test cases, rarely > more often than that. I have no hard numbers, as I have

Re: ath10k SWBA overrun / tx credit starvation

2018-08-06 Thread Martin Willi
more testing with this approach before considering to upstream it. Regards Martin --- >From fd9e90d0294450c093d243ee4f1eb1e07b1cd73a Mon Sep 17 00:00:00 2001 From: Martin Willi Date: Fri, 3 Aug 2018 14:23:30 +0200 Subject: [PATCH] ath10k: Schedule hardware restart if WMI command times out

[PATCH] nl80211: announce radios/interfaces when switching namespaces

2018-10-27 Thread Martin Willi
and their interfaces. Add netlink announcements through nl80211 when switching namespaces, so userspace can rely on these events to discover radios properly. Signed-off-by: Martin Willi --- net/wireless/core.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/net/wireless/core.c b/net

[PATCH] mac80211_hwsim: do not omit multicast announce of first added radio

2018-09-25 Thread Martin Willi
on these events. Signed-off-by: Martin Willi --- drivers/net/wireless/mac80211_hwsim.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index 70229a839c84..aa8058264d5b 100644 --- a/drivers/net