iwlwifi: mvm: BACKPORT_WANT_DEV_COREDUMP?

2014-10-31 Thread Paul Bolle
/30/578 I proposed a patch that emits a warning in cases like this.) Did you perhaps meant to select WANT_DEV_COREDUMP? Or is the Kconfig symbol BACKPORT_WANT_DEV_COREDUMP queued somewhere? Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body

Re: iwlwifi: mvm: BACKPORT_WANT_DEV_COREDUMP?

2014-10-31 Thread Paul Bolle
On Fri, 2014-10-31 at 09:45 +0100, Johannes Berg wrote: On Fri, 2014-10-31 at 09:40 +0100, Paul Bolle wrote: Your commit aadede6e9f4c (iwlwifi: mvm: port to devcoredump framework) landed in today's linux-next (next-20141031). It adds a select statement for BACKPORT_WANT_DEV_COREDUMP

Re: iwlwifi: mvm: BACKPORT_WANT_DEV_COREDUMP?

2014-10-31 Thread Paul Bolle
On Fri, 2014-10-31 at 10:08 +0100, Johannes Berg wrote: On Fri, 2014-10-31 at 10:06 +0100, Paul Bolle wrote: Perhaps you could also look into somehow guarding the call of dev_coredumpm(), that this commit added, with checks for CONFIG_DEV_COREDUMP. See, I had a quick look at all

Re: [PATCH RFC] ipw2200: select CFG80211_WEXT

2014-12-23 Thread Paul Bolle
On Tue, 2014-12-23 at 08:52 +0200, Kalle Valo wrote: Paul Bolle pebo...@tiscali.nl writes: Commit 24a0aa212ee2 (cfg80211: make WEXT compatibility unselectable) made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing

Re: [PATCH] Revert ipw2200: select CFG80211_WEXT

2015-01-03 Thread Paul Bolle
mention anything like that, so probably I'm just confused. Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] Revert ipw2200: select CFG80211_WEXT

2015-01-03 Thread Paul Bolle
This reverts commit 60220f41775e634258efd1b54c6fa81ce706. The raison d'être of commit 60220f41 (ipw2200: select CFG80211_WEXT) was reverted in commit 2d36e008739e (Revert cfg80211: make WEXT compatibility unselectable). So revert this commit too. Signed-off-by: Paul Bolle pebo

Re: [PATCH] Revert ipw2200: select CFG80211_WEXT

2015-01-05 Thread Paul Bolle
On Mon, 2015-01-05 at 11:14 +0100, Arend van Spriel wrote: On 01/03/15 23:28, Paul Bolle wrote: Side note: am I correct in thinking that there's some successor to CFG80211_WEXT and that the ipw2200 driver could, at least in theory, be ported to that successor? (ipw2200 hardware appears

Re: [PATCH] Revert ipw2200: select CFG80211_WEXT

2015-01-05 Thread Paul Bolle
of what's provided under WIRELESS_EXT). Did I get that right? Thanks, Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/3] NFC: nxp-nci_i2c: Add I2C support to NXP NCI driver

2015-03-11 Thread Paul Bolle
details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, see http://www.gnu.org/licenses/. + */ This states the license is GPL v2. +MODULE_LICENSE(GPL); So you probably want MODULE_LICENSE(GPL v2); here. Paul Bolle

Re: [PATCH v2 2/3] NFC: nxp-nci: Add support for NXP NCI chips

2015-03-11 Thread Paul Bolle
details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, see http://www.gnu.org/licenses/. + */ This states the license is GPL v2. +MODULE_LICENSE(GPL); So you probably want MODULE_LICENSE(GPL v2); here. Paul Bolle

Re: [PATCH] drivers/nfc: remove obsolete setting of DEBUG

2015-04-29 Thread Paul Bolle
..c9ec7869dbd2 100644 --- a/drivers/nfc/nxp-nci/Makefile +++ b/drivers/nfc/nxp-nci/Makefile @@ -7,5 +7,3 @@ nxp-nci_i2c-objs = i2c.o obj-$(CONFIG_NFC_NXP_NCI) += nxp-nci.o obj-$(CONFIG_NFC_NXP_NCI_I2C) += nxp-nci_i2c.o - -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG Thanks, Paul Bolle -- To unsubscribe

Re: [PATCH] net/wireless: CFG80211_WEXT_EXPORT requires wireless extensions

2015-04-11 Thread Paul Bolle
work: a select of a Kconfig symbol will trigger the select statements of that Kconfig symbol. Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC Chip

2015-07-30 Thread Paul Bolle
. And, according to include/linux/module.h, that ident states the license is GPL v2 or later. So I think either the comments or the idents need to change. Thanks, Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-11 Thread Paul Bolle
ents[0].integer.value != 0) { > > - IWL_ERR(trans, "Unsupported splx structure\n"); > > + IWL_WARN(trans, "Unsupported splx structure, not limiting WiFi > > power\n"); > >   return 0; > >   } > > If this is really bothering you, I guess I could apply this patch for > now.  But as I said, this is not solving the actual problem. Bikeshedding: I think IWL_INFO() is more appropriate, as info doesn't imply one needs to act on this message, while warn does imply that action is needed. Thanks, Paul Bolle

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-12 Thread Paul Bolle
01 is increased until it reaches RP20. (The machine has 20 PCI devices according to lspci. I have no clue how to match that RPxx number to the 20 devices showing up in lspci, sorry.) Paul Bolle

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-12 Thread Paul Bolle
nt:     Detected Intel(R) Dual Band Wireless AC 8260, REV=0x208 > In any case, I will rework this code, so I'd prefer if we skip this > patch entirely. Feel free to prod me for testing whatever you come up with. Paul Bolle

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Paul Bolle
Luca, On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > Could you please give this a spin? I have tested it with some handmade > ACPI tables in QEMU and it seems to work fine now. Tested-by: Paul Bolle <pebo...@tiscali.nl> Not that this test was worth a lot: it builds cle

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Paul Bolle
100 lines or so, that apparently are generated directly after modprobing iwlwifi. After these 100 lines there's a ten second gap (I guess it took me ten seconds to actually use the wifi). I assume you don't care about that part of the debug messages. Have fun! Paul Bolle <7>[ 767.691342]

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Paul Bolle
benefits for the users of these laptops? In other words: should I bother somehow contacting Dell and point them to this discussion in order to have them fix this? Paul Bolle

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-12 Thread Paul Bolle
Chris' version came preinstalled with something else? Thanks, Paul Bolle

Re: [PATCH 2/2] net: wireless: fix to uses struct

2016-12-21 Thread Paul Bolle
net/wireless/reg.o' failed make: *** [net/wireless/reg.o] Error 2 Didn't Thomas Gleixner suggest that you do a basic C course just yesterday? Paul Bolle

Re: [PATCH 2/2] net: wireless: fix to uses struct

2016-12-21 Thread Paul Bolle
On Thu, 2016-12-22 at 01:50 +0300, Ozgur Karatas wrote: > I don't have a problem with C programming I'm sorry, but you do need to learn C, at a basic level, first. Paul Bolle