Re: dmesg output for iwlegacy

2014-09-25 Thread Stanislaw Gruszka
On Mon, Sep 22, 2014 at 01:02:54AM +0100, Plinio Moreno wrote: I have a Debian Wheezy (Kernel 3.2), pae 3.2 is very old version, check if issue is not fixed already on updated kernel. Stanislaw -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message

Re: [rt2x00-users] [PATCH] wireless: Remove unnessary write over of register 11 in rt2800lib.c

2014-09-28 Thread Stanislaw Gruszka
On Sat, Sep 27, 2014 at 05:11:41PM -0400, Nicholas Krause wrote: This removes the unnecessary overwrite of register 11 in the function, rt2800_config_channel as we are already writing a correct value to the register with rt2800_rfcsr_write(rt2x00dev,11.rfcsr). What make you sure that overwrite

Re: [rt2x00-users] [PATCH] wireless: Remove unnessary write over of register 11 in rt2800lib.c

2014-09-28 Thread Stanislaw Gruszka
On Sun, Sep 28, 2014 at 12:05:30PM +0400, Denis Kirjanov wrote: Or someone with the hardware has to test and check that... ... on all possible combinations of channel, bandwidth, signal strength, modulation type, ... Stanislaw -- To unsubscribe from this list: send the line unsubscribe

[PATCH] MAINTAINERS: change rt2x00 maintainer

2014-09-28 Thread Stanislaw Gruszka
After short chat with Ivo, we decided that I'll take maintenance of rt2x00 driver. Thanks for Ivo's great work in the past! Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [rt2x00-users] [PATCH] MAINTAINERS: change rt2x00 maintainer

2014-09-29 Thread Stanislaw Gruszka
On Sun, Sep 28, 2014 at 02:30:13PM +0200, Peter Stuge wrote: Stanislaw Gruszka wrote: After short chat with Ivo, we decided that I'll take maintenance of rt2x00 driver. Thanks for Ivo's great work in the past! Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com I would have been

[PATCH 1/2] iw: update nl80211.h

2014-09-30 Thread Stanislaw Gruszka
Sync nl80211.h with wireless-testing tree and add NL80211_ATTR_PS_TIMEOUT attribute needed for further ps changes. Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- nl80211.h | 123 +- 1 file changed, 121 insertions(+), 2

[PATCH] cfg80211: allow to configure dynamic PS timeout

2014-09-30 Thread Stanislaw Gruszka
Dynamic power save timeout value is suppose to be configurable via wext, but due to iwconfig bug is not possible to set it using that tool. Allow to configure PS timeout via nl80211 - add NL80211_ATTR_PS_TIMEOUT attribute which become timeout stated in ms. Signed-off-by: Stanislaw Gruszka sgrus

Re: [PATCH] rt2x00: rt2x00queue: avoid using more headroom then driver requested

2014-10-01 Thread Stanislaw Gruszka
On Tue, Sep 30, 2014 at 11:45:57PM -0400, Mark Asselstine wrote: 'struct ieee80211_hw' contains 'extra_tx_headroom' which it defines as headroom to reserve in each transmit skb for use by the driver. This value is properly setup during rt2x00lib_probe_hw() to account for all the rt2x00lib's

[PATCH v2] cfg80211: allow to configure dynamic PS timeout

2014-10-01 Thread Stanislaw Gruszka
Dynamic power save timeout value is suppose to be configurable via wext, but due to iwconfig bug is not possible to set using that tool. Allow to configure PS timeout via nl80211 - add NL80211_ATTR_PS_TIMEOUT attribute which become timeout stated in ms. Signed-off-by: Stanislaw Gruszka sgrus

Re: [PATCH] rt2x00: rt2x00queue: avoid using more headroom then driver requested

2014-10-05 Thread Stanislaw Gruszka
On Sat, Oct 04, 2014 at 07:38:25PM -0400, Mark Asselstine wrote: The only possibility to skb_under_panic I can see, is that we retransmit frame and try to align it many times, but alignment should not be needed once we aligned frame. Hence I'm not sure how those skb_under_panics can

Re: [PATCH] rt2x00: rt2x00queue: avoid using more headroom then driver requested

2014-10-05 Thread Stanislaw Gruszka
On Sun, Oct 05, 2014 at 03:13:12PM +0200, Stanislaw Gruszka wrote: On Sat, Oct 04, 2014 at 07:38:25PM -0400, Mark Asselstine wrote: The only possibility to skb_under_panic I can see, is that we retransmit frame and try to align it many times, but alignment should not be needed once we

Re: [PATCH v2] cfg80211: allow to configure dynamic PS timeout

2014-10-07 Thread Stanislaw Gruszka
On Mon, Oct 06, 2014 at 05:00:40PM +0200, Johannes Berg wrote: On Wed, 2014-10-01 at 11:27 +0200, Stanislaw Gruszka wrote: Dynamic power save timeout value is suppose to be configurable via wext, but due to iwconfig bug is not possible to set using that tool. That's interesting, what's

Re: [rt2x00-users] MediaTek Inc. MT7601U Wireless Adapter

2014-10-08 Thread Stanislaw Gruszka
On Tue, Oct 07, 2014 at 05:12:47PM +0200, poma wrote: BTW, pán Gruszka, when will these devices be supported as a part of the upstream Linux kernel? I'm not an oracle :-) Larry declared to work on some mt76xx chip support, I'm cc him. I can also work on new chips for rt2x00, but wanted to

[PATCH] rt2x00: tune multi-registers I/O timeout

2014-10-08 Thread Stanislaw Gruszka
-by: Stanislaw Gruszka sgrus...@redhat.com --- drivers/net/wireless/rt2x00/rt2500usb.c | 10 - drivers/net/wireless/rt2x00/rt2x00usb.c | 4 ++-- drivers/net/wireless/rt2x00/rt2x00usb.h | 39 ++--- 3 files changed, 17 insertions(+), 36 deletions(-) diff --git a/drivers

Re: [PATCH] rt2x00: rt2x00queue: avoid using more headroom then driver requested

2014-10-08 Thread Stanislaw Gruszka
On Wed, Oct 08, 2014 at 07:46:33AM -0400, Mark Asselstine wrote: If rt2x00 does not remove the alignment from the frame before giving it back to mac80211 and the same frame comes into rt2x00 again it should be correctly aligned and no additional header space is required. So this should be

Re: rt2x00: two candidates for -stable

2014-10-11 Thread Stanislaw Gruszka
Hi Xose On Sat, Oct 11, 2014 at 12:09:11AM +0200, Xose Vazquez Perez wrote: I think these two should be included in -stable : ac0372abf8524a7572a9cdaac6495eb2eba20457 support Ralink 5362 It's new chip support actually i.e. more like new feature, however I'm ok to post it -stable. I assume this

Re: 3.18-rc0: iwlegacy failed after a while

2014-10-24 Thread Stanislaw Gruszka
On Thu, Oct 23, 2014 at 01:02:37PM +, Grumbach, Emmanuel wrote: [Changed subject] This is really iwlegacy and not iwlwifi. Hi! Full dmesg is in the attachment, I guess the troubles started with: iwl3945 :03:00.0: Queue 4 stuck for 2004 ms. iwl3945 :03:00.0: On

Re: 3.18-rc0: iwlegacy failed after a while

2014-10-26 Thread Stanislaw Gruszka
On Sat, Oct 25, 2014 at 01:42:46PM +0200, Pavel Machek wrote: Since 3.17 we have only 2 minor iwlegacy changes on current linus tree. If this is a regression it's probably caused by different subsystem changes, most likely by PCI changes. If this is not regression, such errors could be

Re: [PATCH] wireless: rt2x00: add new rt2800usb device

2014-10-29 Thread Stanislaw Gruszka
On Tue, Oct 28, 2014 at 04:42:41PM +0100, Cyril Brulebois wrote: 0x1b75 0xa200 AirLive WN-200USB wireless 11b/g/n dongle References: https://bugs.debian.org/766802 Reported-by: Martin Mokrejs mmokr...@fold.natur.cuni.cz Was this patch tested by reporter? I would rather see

Re: [PATCH] wireless: rt2x00: add new rt2800usb device

2014-10-29 Thread Stanislaw Gruszka
On Wed, Oct 29, 2014 at 12:12:24PM +0100, Cyril Brulebois wrote: Stanislaw Gruszka sgrus...@redhat.com (2014-10-29): On Tue, Oct 28, 2014 at 04:42:41PM +0100, Cyril Brulebois wrote: 0x1b75 0xa200 AirLive WN-200USB wireless 11b/g/n dongle References: https://bugs.debian.org/766802

Re: [PATCH -stable] rt2x00: support Ralink 5362.

2014-10-31 Thread Stanislaw Gruszka
On Fri, Oct 31, 2014 at 10:47:12AM +0100, Jiri Slaby wrote: On 10/30/2014, 12:18 PM, Xose Vazquez Perez wrote: From: Canek Peláez Valdés ca...@ciencias.unam.mx Hi, what is this, please? No commit message, no upstream SHA, we cannot take the two as they stand... This is: commit

Re: [PATCH -stable] wireless: rt2x00: add new rt2800usb devices

2014-10-31 Thread Stanislaw Gruszka
On Fri, Oct 31, 2014 at 10:47:38AM +0100, Jiri Slaby wrote: On 10/30/2014, 12:18 PM, Xose Vazquez Perez wrote: 0x0b05 0x17e8 RT5372 USB 2.0 bgn 2x2 ASUS USB-N14 0x0411 0x0253 RT5572 USB 2.0 abgn 2x2 BUFFALO WLP-U2-300D 0x0df6 0x0078 RT Sitecom N300 (the same as previous) This is:

Re: 3.18-rc0: iwlegacy failed after a while

2014-11-02 Thread Stanislaw Gruszka
On Tue, Oct 28, 2014 at 11:20:15PM +0100, Pavel Machek wrote: It can be checked by iw dev wlan0 get power_save . So it seems I have power save on. I guess someone enabled it for me :-). root@duo:~# iwconfig wlan0 wlan0 IEEE 802.11abg ESSID:off/any Mode:Managed Access

Re: [rt2x00-users] Ralink RT3070(rt2800usb) - The Tortoise and the Hare

2014-11-02 Thread Stanislaw Gruszka
On Sun, Nov 02, 2014 at 06:59:15AM +0100, poma wrote: Higher values, are they even possible via rt2800usb.ko Co.? Yes. ieee80211 phy0: rt2x00_set_rt: Info - RT chipset 3070, rev 0201 detected ieee80211 phy0: rt2x00_set_rf: Info - RF chipset 0005 detected On the same RT and RF chipsets with

Re: [PATCH] rt2x00: do not align payload on modern H/W

2014-11-11 Thread Stanislaw Gruszka
On Sun, Nov 02, 2014 at 01:38:47PM +0100, Stanislaw Gruszka wrote: RT2800 and newer hardware require padding between header and payload if header length is not multiple of 4. For historical reasons we also align payload to to 4 bytes boundary, but such alignment is not needed on modern H/W

Can fb4e156886ce6e8309e912d8b370d192330d19d3 be reverted ?

2014-11-13 Thread Stanislaw Gruszka
I've updated wireless code on RHEL and get complain that now cfg80211 and rfkill modules are loaded on machines that do not have wireless hardware. Modules are auto-loaded because NetworkManager send nl80211 messages to check if there are wireless devices in the system. Hence my question, can we

[PATCH] cfg80211: remove net-pf-16-proto-16-family-nl80211 module alias

2014-11-13 Thread Stanislaw Gruszka
...@holtmann.org Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- net/wireless/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/wireless/core.c b/net/wireless/core.c index a4d2792..badcabe 100644 --- a/net/wireless/core.c +++ b/net/wireless/core.c @@ -34,7 +34,6 @@ MODULE_AUTHOR

Re: [PATCH] cfg80211: remove net-pf-16-proto-16-family-nl80211 module alias

2014-11-13 Thread Stanislaw Gruszka
hardware cfg80211 module will be loaded anyway. Cc: Marcel Holtmann mar...@holtmann.org Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- net/wireless/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/wireless/core.c b/net/wireless/core.c index a4d2792..badcabe

Re: [PATCH] cfg80211: remove net-pf-16-proto-16-family-nl80211 module alias

2014-11-14 Thread Stanislaw Gruszka
with wireless hardware cfg80211 module will be loaded anyway. Cc: Marcel Holtmann mar...@holtmann.org Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- net/wireless/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/wireless/core.c b/net/wireless/core.c index a4d2792

Re: Can fb4e156886ce6e8309e912d8b370d192330d19d3 be reverted ?

2014-11-14 Thread Stanislaw Gruszka
On Fri, Nov 14, 2014 at 03:57:40PM +0900, Marcel Holtmann wrote: Hi Luca, I've updated wireless code on RHEL and get complain that now cfg80211 and rfkill modules are loaded on machines that do not have wireless hardware. Modules are auto-loaded because NetworkManager send nl80211

Re: Can fb4e156886ce6e8309e912d8b370d192330d19d3 be reverted ?

2014-11-14 Thread Stanislaw Gruszka
On Fri, Nov 14, 2014 at 04:02:33PM +0900, Marcel Holtmann wrote: Hi Dan, I've updated wireless code on RHEL and get complain that now cfg80211 and rfkill modules are loaded on machines that do not have wireless hardware. Modules are auto-loaded because NetworkManager send nl80211

Re: [rt2x00-users] [PATCH] rt2800: fix RT5592 TX power settings regression

2014-11-25 Thread Stanislaw Gruszka
On Fri, Nov 21, 2014 at 10:39:39AM +0100, Ronald Wahl wrote: For me the patch will work but there is a change for RT3290 and RT5390. On both chipsets BBP 1 was not written before but with this patch it is going to be written now and the value depends on the return of

[PATCH] rt2800: calculate tx power temperature compensation on selected chips

2014-11-25 Thread Stanislaw Gruszka
compensation calculation. Reported-and-tested-by: Ronald Wahl ronald.w...@raritan.com Debugged-by: Ronald Wahl ronald.w...@raritan.com Cc: Mike Romberg mike-romb...@comcast.net Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- drivers/net/wireless/rt2x00/rt2800lib.c | 45

[PATCH 1/4] rt2x00: use timeout in rt2x00usb_vendor_request

2014-11-26 Thread Stanislaw Gruszka
Use provided timeout value in rt2x00usb_vendor_request() instead of iterating REGISTER_BUSY_COUNT times. Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- drivers/net/wireless/rt2x00/rt2x00usb.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH 3/4] rt2x00: change REGISTER_TIMEOUT

2014-11-26 Thread Stanislaw Gruszka
Waiting 500ms for register access is too long, decrease this value to 100ms. Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- drivers/net/wireless/rt2x00/rt2x00usb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/rt2x00/rt2x00usb.h b/drivers/net

[PATCH 4/4] Revert rt2x00: Endless loop on hub port power down

2014-11-26 Thread Stanislaw Gruszka
2ad69ac597619 solves is kinda artificial. Cc: Richard Genoud richard.gen...@gmail.com Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- drivers/net/wireless/rt2x00/rt2x00usb.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/wireless/rt2x00/rt2x00usb.c b/drivers/net/wireless

[PATCH 2/4] rt2x00: change REGISTER_BUSY_COUNT for USB

2014-11-26 Thread Stanislaw Gruszka
Because of delays on USB we do not have to iterate so many times on USB hardware when waiting for H/W register become valid. Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- drivers/net/wireless/rt2x00/rt2500usb.c | 8 drivers/net/wireless/rt2x00/rt2x00.h| 5 - drivers

Re: [PATCH 4/4] Revert rt2x00: Endless loop on hub port power down

2014-12-02 Thread Stanislaw Gruszka
On Tue, Dec 02, 2014 at 12:17:57PM +0100, Richard Genoud wrote: It tested this serie but unfortunately, reverting this still caused an infinite loop. (cf https://lkml.org/lkml/2014/4/3/492 to reproduce) It is possible to disable internal hub? It fails here, but perhaps I do not have compiled

Re: Ralink 6570 / Mediatek MT7601STA (was Re: Addition of a wifi kernel module to the linux source tree)

2014-12-04 Thread Stanislaw Gruszka
On Thu, Dec 04, 2014 at 03:52:52PM +1100, Julian Calaby wrote: On Thu, Dec 4, 2014 at 3:39 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Dec 04, 2014 at 07:07:58AM +0530, Parth Sane wrote: Hi, I'd say I'm midway through with c programming(part of my computer

Re: Ralink 6570 / Mediatek MT7601STA (was Re: Addition of a wifi kernel module to the linux source tree)

2014-12-04 Thread Stanislaw Gruszka
On Thu, Dec 04, 2014 at 09:49:53AM +0100, Oleksij Rempel wrote: So far i know, Felix is working on abgn+ac (MT7662 and MT7612) devices. MT7601STA is (a)bgn. Are there similar regs? All Mediatek/Ralink devices I know have the same MAC registers, but different BBP and RF registers. In mt7601

Re: iw wlan0 set txpower ...does not work using rt2x00 drivers

2015-02-09 Thread Stanislaw Gruszka
On Fri, Jan 23, 2015 at 10:36:39AM +1100, Sourav wrote: Hi All, I am using rt2x00 drivers for RT3072 chipset...for changing tx power, I am issuing iw wlan0 set txpower fixed value.The command succeeds(no error from command line). However the driver is not setting the value of the

Re: Ralink RT5390/RT5370 no longer works on more recent kernels

2015-02-09 Thread Stanislaw Gruszka
On Sun, Feb 08, 2015 at 08:06:28PM -0600, Larry Finger wrote: On 02/07/2015 10:54 AM, Simon Raffeiner (SCC) wrote: The second thing to verify is that your configuration contains the line CONFIG_RT2800USB_RT53XX=y. This parameter is marked as depending on EXPERIMENTAL, and I'm not sure that

Re: [PATCH] net: wireless: rt2x00: use helper to check capability/requirement

2015-01-04 Thread Stanislaw Gruszka
On Fri, Dec 26, 2014 at 04:19:18PM +0800, Fred Chou wrote: From: Fred Chou fred.chou...@gmail.com Use rt2x00_has_cap_flag macro to check rt2x00dev-cap_flags. Signed-off-by: Fred Chou fred.chou...@gmail.com Acked-by: Stanislaw Gruszka sgrus...@redhat.com -- To unsubscribe from this list

Re: [1/3] rt2x00usb: initialize the read value in case of failure

2015-03-18 Thread Stanislaw Gruszka
On Mon, Mar 16, 2015 at 05:41:00PM +0100, Sebastian Andrzej Siewior wrote: * Kalle Valo | 2015-03-16 16:06:52 [+]: Thanks, 3 patches applied to wireless-drivers-next.git: Thanks. Do you guys have any kind of further documentation? Where did There is doc describing MAC registers, it was

Re: [1/3] rt2x00usb: initialize the read value in case of failure

2015-03-18 Thread Stanislaw Gruszka
On Tue, Mar 17, 2015 at 09:34:14AM +0100, Sebastian Andrzej Siewior wrote: I have no idea what AutoRun mode is (it seems that the stick already has a firmware and is happy with it) and I have no clue why the firmware decides to lie about it. I looked at the vendor driver I found at github

Re: [PATCH] rt2x00: use rt2x00queue_flush_queues() instead of implementing the same action

2015-03-08 Thread Stanislaw Gruszka
On Sat, Mar 07, 2015 at 08:45:50PM +02iee80211_ops00, Giedrius Statkevičius wrote: Use rt2x00queue_flush_queues() in rt2x00mac_flush() instead of reimplementing the same actions the second time. Also, now it flushes the rx queue aswell which it didn't before and that makes it completely do

Re: [PATCH] iwl4965: Enable checking of format strings

2015-04-28 Thread Stanislaw Gruszka
On Tue, Apr 28, 2015 at 07:19:02PM +0300, Kalle Valo wrote: Rasmus Villemoes li...@rasmusvillemoes.dk writes: Since these fmt_* variables are just const char*, and not const char[], gcc (and smatch) doesn't to type checking of the arguments to the printf functions. Since the linker knows

[PATCH] rt2800: fix assigning same WCID for different stations

2015-06-10 Thread Stanislaw Gruszka
On some hardware reading WCID entries table results getting 0xff numbers, no matter of value written there before. This cause assigning the same WCID for different stations and makes not possible to connect to more than one station. Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com

[PATCH] rt2x00, MAINTAINERS: remove rt2x00.serialmonkey.com list and web page

2015-06-10 Thread Stanislaw Gruszka
rt2x00.serialmonkey.com will be shutdown. Since traffic on rt2x00 mailing list is very low, we can use only linux-wireless list for any rt2x00 related topics. Thanks for Luis Correia, Ivo van Doorn and Mark Wallis for maintaining rt2x00 servers for years! Signed-off-by: Stanislaw Gruszka sgrus

Re: [PATCH] rt2800: fix assigning same WCID for different stations

2015-06-11 Thread Stanislaw Gruszka
On Wed, Jun 10, 2015 at 04:20:37PM +0200, Stanislaw Gruszka wrote: On some hardware reading WCID entries table results getting 0xff numbers, no matter of value written there before. This cause assigning the same WCID for different stations and makes not possible to connect to more than one

[PATCH v2] rt2800: fix assigning same WCID for different stations

2015-06-11 Thread Stanislaw Gruszka
On some hardware reading WCID entries table results getting 0xff numbers, no matter of value written there before. This cause assigning the same WCID for different stations and makes not possible to connect to more than one station. Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- v1 - v2

[PATCH] mac80211: docs: fix cannot parse enum error

2015-05-25 Thread Stanislaw Gruszka
Patch fixes documentation generation error: Error(./include/net/mac80211.h:331): Cannot parse enum! Error(./include/net/mac80211.h:369): Cannot parse enum! Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- include/net/mac80211.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions

Re: [PATCH] rt2x00: adjust EEPROM_SIZE for rt2500usb

2015-08-12 Thread Stanislaw Gruszka
and EEPROM_CALIBRATE_OFFSET. Change the EEPROM_SIZE to 0x6e in order to retrieve all the fields. Tested with a rt2570 device. Signed-off-by: Adrien Schildknecht adrien+...@schischi.me Acked-by: Stanislaw Gruszka sgrus...@redhat.com -- To unsubscribe from this list: send the line unsubscribe

[PATCH] rt2800usb: add usb ID 1b75:3070 for Airlive WT-2000USB

2015-08-31 Thread Stanislaw Gruszka
Brand: Airlive (Ovislink Corp.) Name: Turbo-G USB Adaptor Model: WT-2000USB USB ID: 1b75:3070 Reported-and-tested-by: Michael Coates <michli...@hotmail.com> Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/rt2x00/rt2800usb.c |1 + 1 files changed,

Re: rt2x00: Firmware loading vs. udev rules

2015-10-02 Thread Stanislaw Gruszka
Hi On Tue, Sep 29, 2015 at 06:38:19PM +0200, Pascal Huerst wrote: > on rt2x00 devices, firmware gets loaded in: > > int rt2x00lib_start(struct rt2x00_dev *rt2x00dev) > > which is called, when we start the interface by: > > ifconfig wlan0 up > > I need to lower tx power of the device and

Re: [patch] iwlegacy: cleanup end of il_send_add_sta()

2015-12-04 Thread Stanislaw Gruszka
.carpen...@oracle.com> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] iwlegacy: mark il_adjust_beacon_interval as noinline

2015-12-10 Thread Stanislaw Gruszka
his in the only file > that shows the behavior, by marking the il_adjust_beacon_interval > function as noinline, which convinces gcc to use the unoptimized > do_div() all the time. I don't think this is good way to "fix" the issue, but also have nothing against to this pa

Re: [PATCH 1/3] net-iwlegacy: Refactoring for il_eeprom_init()

2016-01-04 Thread Stanislaw Gruszka
fr...@users.sourceforge.net> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] iwlegacy: 4965-mac: constify il_sensitivity_ranges structure

2016-01-04 Thread Stanislaw Gruszka
On Wed, Dec 30, 2015 at 12:20:49PM +0100, Julia Lawall wrote: > The il_sensitivity_ranges is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Acked-by: Stanislaw Gruszka <sgrus...@redhat

Re: [patch] rt2x00: type bug in _rt2500usb_register_read()

2015-11-26 Thread Stanislaw Gruszka
x%.8x\n", u32); > > We end up copying uninitialized data to the user which is bogus and an > information leak. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> > --- > Not tested. Perhaps we should just rem

Problems with mwifiex_pcie firmware activation

2016-06-14 Thread Stanislaw Gruszka
I have two systems with this device: 03:00.0 Ethernet controller [0200]: Marvell Technology Group Ltd. 88W8897 [AVASTAR] 802.11ac Wireless [11ab:2b38] Flags: bus master, fast devsel, latency 0, IRQ 92 Memory at 9070 (64-bit, prefetchable) [size=1M] Memory at 9060

Re: Problems with mwifiex_pcie firmware activation

2016-06-15 Thread Stanislaw Gruszka
On Tue, Jun 14, 2016 at 05:12:50PM +0300, Kalle Valo wrote: > Stanislaw Gruszka <sgrus...@redhat.com> writes: > > > Hence looks like forcing firmware upload somehow changed device, now it > > is capable to initialize. On my second system device is on pristine state

Re: Problems with mwifiex_pcie firmware activation

2016-06-16 Thread Stanislaw Gruszka
Hi On Wed, Jun 15, 2016 at 01:47:53PM +, Amitkumar Karwar wrote: > Could you please share complete dmesg log for failure and successful cases? Dmesg from failure case is in attachment. I loose access to system where device initalize, I'll provide missed dmesg when I get back the access. >

Re: Problems with mwifiex_pcie firmware activation

2016-06-23 Thread Stanislaw Gruszka
On Thu, Jun 16, 2016 at 01:53:15PM +0200, Stanislaw Gruszka wrote: > On Wed, Jun 15, 2016 at 01:47:53PM +, Amitkumar Karwar wrote: > > Could you please share complete dmesg log for failure and successful cases? > > Dmesg from failure case is in attachment. I loose access to

Re: New firmware for RT2870

2016-03-10 Thread Stanislaw Gruszka
On Wed, Mar 09, 2016 at 02:22:45PM -0600, Larry Finger wrote: > In https://bugzilla.kernel.org/show_bug.cgi?id=114151, the OP reports > improved stability and performance for an RT5370 using a newer firmware that > came with the driver CD. The logs show this to be version 0.36, whereas the >

Re: [PATCH MOREWORK 17/19] iwl4965: Fix a memory leak in error handling code of __il4965_up

2016-03-19 Thread Stanislaw Gruszka
On Fri, Mar 18, 2016 at 10:12:34PM +1100, Julian Calaby wrote: > I don't think you're right. Looking closely at the code, > il->num_stations gets incremented in il_prep_station() which is called > unconditionally from il4965_alloc_bcast_station(). > > So I think this and the following patch are

Re: [PATCH v5] rt2x00usb: Use usb anchor to manage URB

2016-03-19 Thread Stanislaw Gruszka
On Sat, Mar 19, 2016 at 09:21:52AM +0100, Vishal Thanki wrote: > On Sat, Mar 19, 2016 at 9:06 AM, Stanislaw Gruszka <sgrus...@redhat.com> > wrote: > > On Fri, Mar 18, 2016 at 05:29:51PM +0100, Vishal Thanki wrote: > >> > >> @@ -1001,6 +1002,9 @@ struct rt2x

Re: [PATCH v5] rt2x00usb: Use usb anchor to manage URB

2016-03-19 Thread Stanislaw Gruszka
On Fri, Mar 18, 2016 at 05:29:51PM +0100, Vishal Thanki wrote: > > @@ -1001,6 +1002,9 @@ struct rt2x00_dev { > > /* Extra TX headroom required for alignment purposes. */ > unsigned int extra_tx_headroom; > + > + struct usb_anchor *anchor; > + void

Re: [PATCH MOREWORK 18/19] iwl4965: Fix more memory leaks in __il4965_up()

2016-03-19 Thread Stanislaw Gruszka
On Fri, Mar 18, 2016 at 01:29:11PM +1100, Julian Calaby wrote: > In some of the non-success return paths, the memory allocated by > iwl4965_sta_alloc_lq() in iwl4965_alloc_bcast_station() is not freed. > > In particular: > - if the card isn't ready after il4965_prepare_card_hw() > - if the card

Re: [PATCH MOREWORK 17/19] iwl4965: Fix a memory leak in error handling code of __il4965_up

2016-03-19 Thread Stanislaw Gruszka
l_dealloc_bcast_stations in the error handling code of > __il4965_up to fix this problem. > > This patch has been tested in real device, and it actually fixes the bug. Could the call trace from the bug be provided ? > Signed-off-by: Jia-Ju Bai <baijiaju1...@163.com> > Ack

Re: [PATCH v2] rt2x00usb: Use usb anchor to manage URB

2016-03-19 Thread Stanislaw Gruszka
On Thu, Mar 17, 2016 at 12:55:59PM +0100, Vishal Thanki wrote: > @@ -840,6 +857,8 @@ void rt2x00usb_disconnect(struct usb_interface *usb_intf) > struct ieee80211_hw *hw = usb_get_intfdata(usb_intf); > struct rt2x00_dev *rt2x00dev = hw->priv; > > +

Re: [PATCH] rt2x00usb: Use usb anchors to manage URB

2016-03-19 Thread Stanislaw Gruszka
On Thu, Mar 17, 2016 at 10:53:18AM +0100, Vishal Thanki wrote: > > usb_anchor structure should be embedded in rt2x00_dev structure, > > otherwise you can kill urb's from other rt2x00 devices, when > > disconnecting another one. > > > > rt2x00_dev structure does not contain any bus specific data

Re: [PATCH v6] rt2x00usb: Use usb anchor to manage URB

2016-03-21 Thread Stanislaw Gruszka
B disconnect. > Managing the URBs with anchor will make sure that all > the URBs are handled gracefully before device gets > disconnected. > > Signed-off-by: Vishal Thanki <vishaltha...@gmail.com> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> -- To unsubscribe from this

Re: [PATCH CONTROVERSIAL 19/19] iwlegacy: Rename label in il_eeprom_init()

2016-03-20 Thread Stanislaw Gruszka
On Fri, Mar 18, 2016 at 01:29:39PM +1100, Julian Calaby wrote: > From: Markus Elfring > > Rename a jump label according to the current Linux coding style convention. > > Signed-off-by: Markus Elfring > [Rewrote commit title] >

Re: [PATCH MOREWORK 18/19] iwl4965: Fix more memory leaks in __il4965_up()

2016-03-21 Thread Stanislaw Gruszka
s truly correct - however > it looks right and I stand by my analysis. > > Could someone else please review this? Looks ok. Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] rt2x00usb: Use usb anchor to manage URB

2016-03-20 Thread Stanislaw Gruszka
On Fri, Mar 18, 2016 at 09:30:36AM +0100, Vishal Thanki wrote: > @@ -734,6 +744,8 @@ void rt2x00usb_uninitialize(struct rt2x00_dev *rt2x00dev) > { > struct data_queue *queue; > > + usb_kill_anchored_urbs(rt2x00dev->anchor); As already pointed in different email this is not good place

Re: [PATCH] rt2x00usb: Use usb anchors to manage URB

2016-03-19 Thread Stanislaw Gruszka
Hi On Wed, Mar 16, 2016 at 06:28:51PM +0100, Vishal Thanki wrote: > +struct rt2x00usb_anchors { > + struct usb_anchor async_urb; > + struct usb_anchor tx_submitted; > + struct usb_anchor rx_submitted; > +}; I don't think we need 3 different usb_anchor's, one should be enough. >

Re: [PATCH v2] rt2x00usb: Use usb anchor to manage URB

2016-03-19 Thread Stanislaw Gruszka
On Thu, Mar 17, 2016 at 04:26:22PM +0100, Vishal Thanki wrote: > On Thu, Mar 17, 2016 at 03:56:43PM +0100, Stanislaw Gruszka wrote: > > On Thu, Mar 17, 2016 at 12:55:59PM +0100, Vishal Thanki wrote: > > > @@ -840,6 +857,8 @@ void rt2x00usb_disconnect(struct usb_interfac

Re: rt2x00queue: rt2800usb: NULL pointer crash while during USB disconnect

2016-03-07 Thread Stanislaw Gruszka
Hi, On Tue, Mar 01, 2016 at 11:36:13AM +0100, Vishal Thanki wrote: > I observed a NULL pointer access crash during my testing on a custom AM33xx > based board with RT5572 USB wifi module. The kernel log is attached with > the mail. With initial debugging, I think that the USB disconnect > event

Re: [PATCH] rt2x00: add new rt2800usb device Buffalo WLI-UC-G450

2016-03-07 Thread Stanislaw Gruszka
On Tue, Feb 23, 2016 at 11:09:22PM +0800, Anthony Wong wrote: > Add USB ID 0411:01fd for Buffalo WLI-UC-G450 wireless adapter, > RT chipset 3593 > > Signed-off-by: Anthony Wong <anthony.w...@ubuntu.com> > Cc: sta...@vger.kernel.org Acked-by: Stanislaw Gruszka

Re: [PATCH] iwlegacy: avoid warning about missing braces

2016-05-19 Thread Stanislaw Gruszka
> This adds a set of curly braces to avoid the warning. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to major

Re: [PATCH] rt2800usb: enable MFP if hw crypt is disabled

2016-04-20 Thread Stanislaw Gruszka
On Wed, Apr 20, 2016 at 02:59:32PM +0800, Chun-Yeow Yeoh wrote: > If rt2800usb is loaded with nohwcrypt=1, mac80211 takes > care of the crypto with software encryption/decryption > and thus, MFP can be used. > > Tested for secured mesh using ath9k_htc and ath9k. > > Signed-off-by: Chun-Yeow Yeoh

Re: [PATCH v2] rt2800lib: enable MFP if hw crypt is disabled

2016-04-21 Thread Stanislaw Gruszka
ff-by: Chun-Yeow Yeoh <yeohchuny...@gmail.com> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Problems with mwifiex_pcie firmware activation

2016-08-11 Thread Stanislaw Gruszka
Hi On Thu, Aug 11, 2016 at 10:21:58AM +, Amitkumar Karwar wrote: > > -Original Message- > > From: Stanislaw Gruszka [mailto:sgrus...@redhat.com] > > Sent: Thursday, August 11, 2016 2:31 PM > > To: Amitkumar Karwar > > Cc: Nishant Sarmukadam; linux-wirele

Re: [PATCH] rt2x00usb: Fix error return code

2016-08-11 Thread Stanislaw Gruszka
0usb: Use usb anchor to manage URB") > > Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to m

Re: Problems with mwifiex_pcie firmware activation

2016-08-12 Thread Stanislaw Gruszka
On Fri, Aug 12, 2016 at 07:17:38AM +, Amitkumar Karwar wrote: > The problem looks strange. The patch just splits mwifiex_check_fw_status() > and increases poll count. It should not have any side-effects. > Our code used to check winner status before this patch also. Ok, I misread the patch.

Re: Problems with mwifiex_pcie firmware activation

2016-08-11 Thread Stanislaw Gruszka
On Thu, Jun 23, 2016 at 02:09:52PM +0200, Stanislaw Gruszka wrote: > On Thu, Jun 16, 2016 at 01:53:15PM +0200, Stanislaw Gruszka wrote: > > On Wed, Jun 15, 2016 at 01:47:53PM +, Amitkumar Karwar wrote: > > > Could you please share complete dmesg log for failure and succe

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

2016-07-14 Thread Stanislaw Gruszka
On Mon, Jul 11, 2016 at 06:27:30PM +, Grumbach, Emmanuel wrote: > I guess that works, but it seems wrong to me. Usually, registration > should happen only upon INIT, and yes, at that time the firmware is not > ready to provide the information yet. > > > > As can be seen in the current code

Re: [RFC] ath10k: silence firmware file probing warnings

2016-07-21 Thread Stanislaw Gruszka
On Tue, Jul 19, 2016 at 03:00:37PM +0200, Michal Kazior wrote: > Firmware files are versioned to prevent older > driver instances to load unsupported firmware > blobs. This is reflected with a fallback logic > which attempts to load several firmware files. > > This however produced a lot of

Re: [RFC] ath10k: silence firmware file probing warnings

2016-07-21 Thread Stanislaw Gruszka
On Thu, Jul 21, 2016 at 10:36:42AM +0300, Emmanuel Grumbach wrote: > On Thu, Jul 21, 2016 at 10:09 AM, Stanislaw Gruszka <sgrus...@redhat.com> > wrote: > > On Tue, Jul 19, 2016 at 03:00:37PM +0200, Michal Kazior wrote: > >> Firmware files are versioned to prevent

Re: [RFC] ath10k: silence firmware file probing warnings

2016-07-21 Thread Stanislaw Gruszka
(cc: firmware and brcmfmac maintainers) On Thu, Jul 21, 2016 at 06:23:11AM -0400, Prarit Bhargava wrote: > > > On 07/21/2016 04:05 AM, Stanislaw Gruszka wrote: > > On Thu, Jul 21, 2016 at 10:36:42AM +0300, Emmanuel Grumbach wrote: > >> On Thu, Jul 21, 2016 at 10:09 AM,

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

2016-07-15 Thread Stanislaw Gruszka
On Thu, Jul 14, 2016 at 09:44:22AM +, Grumbach, Emmanuel wrote: > > If I understad correctly this error happen 100% of the time, not only during > > init. Hence seems there is an issue here, i.e. cur_ucode is not marked > > correctly as IWL_UCODE_REGULAR or iwl_mvm_get_temp() fail 100% of the

Re: [RFC] ath10k: silence firmware file probing warnings

2016-07-22 Thread Stanislaw Gruszka
On Fri, Jul 22, 2016 at 10:38:24AM +0200, Arend Van Spriel wrote: > + Luis > > On 21-7-2016 13:51, Stanislaw Gruszka wrote: > > (cc: firmware and brcmfmac maintainers) > > > > On Thu, Jul 21, 2016 at 06:23:11AM -0400, Prarit Bhargava wrote: > >> > &g

[PATCH v4] rt2x00: avoid introducing a USB dependency in the rt2x00lib module

2017-02-02 Thread Stanislaw Gruszka
a more suitable place. Cc: Vishal Thanki <vishaltha...@gmail.com> Reported-by: Felix Fietkau <n...@nbd.name> Fixes: 8b4c0009313f ("rt2x00usb: Use usb anchor to manage URB") Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- v1 -> v2 do not break shutdown

Re: [PATCH v3] rt2x00: avoid introducing a USB dependency in the

2017-02-02 Thread Stanislaw Gruszka
On Wed, Feb 01, 2017 at 05:33:38PM +0100, Felix Fietkau wrote: > > v1 -> v2 do not break shutdown sequence > > v2 -> v3 update patch to current kernel version > What happened to the subject? It ends mid-sentence. I somehow truncated it during rework, will post fixed one. Thanks Stanislaw

Re: Intel Pro 4965 wireless

2017-01-31 Thread Stanislaw Gruszka
On Tue, Jan 31, 2017 at 09:36:28AM +0200, Luca Coelho wrote: > On Mon, 2017-01-30 at 21:04 -0500, Mel Stimmel wrote: > > I have a problem that recently arose with my Thinkpad model T61 > > running Ubuntu 16.04 with the Intel Pro 4965 installed. > > This system was working just fine

[PATCH v3] rt2x00: avoid introducing a USB dependency in the

2017-01-31 Thread Stanislaw Gruszka
a more suitable place. Cc: Vishal Thanki <vishaltha...@gmail.com> Reported-by: Felix Fietkau <n...@nbd.name> Fixes: 8b4c0009313f ("rt2x00usb: Use usb anchor to manage URB") Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- v1 -> v2 do not break shutdown

Re: [PATCH v4 3/3] mt76: add driver code for MT76x2e

2017-02-06 Thread Stanislaw Gruszka
fixed, it could be done by incremental patches after apply this one to the tree. Reviewed-by: Stanislaw Gruszka <sgrus...@redhat.com> > +enum dma_msg_port { > + WLAN_PORT, > + CPU_RX_PORT, > + CPU_TX_PORT, > + HOST_PORT, > + VIRTUAL_CPU_RX_PORT, >

Re: [PATCH v4 3/3] mt76: add driver code for MT76x2e

2017-02-06 Thread Stanislaw Gruszka
On Mon, Feb 06, 2017 at 12:52:56PM +0100, Felix Fietkau wrote: > >> +void mt76x2_set_tx_ackto(struct mt76x2_dev *dev) > >> +{ > >> + u8 ackto, sifs, slottime = dev->slottime; > >> + > >> + slottime += 3 * dev->coverage_class; > >> + > >> + sifs = mt76_get_field(dev, MT_XIFS_TIME_CFG, > >> +

Re: [PATCH v5 3/3] mt76: add driver code for MT76x2e

2017-02-08 Thread Stanislaw Gruszka
On Tue, Feb 07, 2017 at 09:20:35PM +0100, Felix Fietkau wrote: > This is a 2x2 PCIe 802.11ac chipset by MediaTek > > Signed-off-by: Felix Fietkau <n...@nbd.name> > Signed-off-by: Lorenzo Bianconi <lorenzo.biancon...@gmail.com> Reviewed-by: Stanislaw Gruszka <sgrus...@redhat.com>

  1   2   3   4   5   6   7   8   >