Re: [PATCH v3 19/20] firmware: add request_firmware_cache() to help with cache on reboot

2018-03-21 Thread Greg KH
On Tue, Mar 20, 2018 at 06:24:09PM +, Luis R. Rodriguez wrote: > On Tue, Mar 20, 2018 at 06:38:01PM +0100, Greg KH wrote: > > On Tue, Mar 20, 2018 at 05:34:09PM +, Luis R. Rodriguez wrote: > > > On Tue, Mar 20, 2018 at 09:30:55AM +0100, Greg KH wrote: > > > > On Sat, Mar 10, 2018 at

Re: [PATCH v3 19/20] firmware: add request_firmware_cache() to help with cache on reboot

2018-03-20 Thread Luis R. Rodriguez
On Tue, Mar 20, 2018 at 02:54:44PM -0400, Konstantin Ryabitsev wrote: > On 03/20/18 14:24, Luis R. Rodriguez wrote: > > *Iff* this seems sensible, this would only mean kernel.org would have to > > start > > accepting git notes long term, for those who optionally want to push them or > > fetch

Re: [PATCH v3 19/20] firmware: add request_firmware_cache() to help with cache on reboot

2018-03-20 Thread Konstantin Ryabitsev
On 03/20/18 14:24, Luis R. Rodriguez wrote: > *Iff* this seems sensible, this would only mean kernel.org would have to start > accepting git notes long term, for those who optionally want to push them or > fetch them. We don't disallow them. You just need to make sure you're fetching and pushing

Re: [PATCH v3 19/20] firmware: add request_firmware_cache() to help with cache on reboot

2018-03-20 Thread Luis R. Rodriguez
On Tue, Mar 20, 2018 at 06:38:01PM +0100, Greg KH wrote: > On Tue, Mar 20, 2018 at 05:34:09PM +, Luis R. Rodriguez wrote: > > On Tue, Mar 20, 2018 at 09:30:55AM +0100, Greg KH wrote: > > > On Sat, Mar 10, 2018 at 06:15:00AM -0800, Luis R. Rodriguez wrote: > > > >

Re: [PATCH v3 19/20] firmware: add request_firmware_cache() to help with cache on reboot

2018-03-20 Thread Greg KH
On Tue, Mar 20, 2018 at 05:34:09PM +, Luis R. Rodriguez wrote: > On Tue, Mar 20, 2018 at 09:30:55AM +0100, Greg KH wrote: > > On Sat, Mar 10, 2018 at 06:15:00AM -0800, Luis R. Rodriguez wrote: > > > +EXPORT_SYMBOL_GPL(request_firmware_cache); > > > > I know you are just following the existing

Re: [PATCH v3 19/20] firmware: add request_firmware_cache() to help with cache on reboot

2018-03-20 Thread Luis R. Rodriguez
On Tue, Mar 20, 2018 at 09:30:55AM +0100, Greg KH wrote: > On Sat, Mar 10, 2018 at 06:15:00AM -0800, Luis R. Rodriguez wrote: > > +EXPORT_SYMBOL_GPL(request_firmware_cache); > > I know you are just following the existing naming scheme, but please > let's not continue the problem here. Can you

Re: [PATCH v3 19/20] firmware: add request_firmware_cache() to help with cache on reboot

2018-03-20 Thread Greg KH
On Sat, Mar 10, 2018 at 06:15:00AM -0800, Luis R. Rodriguez wrote: > Some devices have an optimization in place to enable the firmware to > be retaineed during a system reboot, so after reboot the device can skip > requesting and loading the firmware. This can save up to 1s in load > time. The

[PATCH v3 19/20] firmware: add request_firmware_cache() to help with cache on reboot

2018-03-10 Thread Luis R. Rodriguez
Some devices have an optimization in place to enable the firmware to be retaineed during a system reboot, so after reboot the device can skip requesting and loading the firmware. This can save up to 1s in load time. The mt7601u 802.11 device happens to be such a device. When these devices retain