RE: [PATCH 01/13] ath10k: platform driver for WCN3990 SNOC WLAN module
Hi. > -Original Message- > From: govi...@codeaurora.org [mailto:govi...@codeaurora.org] > Sent: Friday, March 23, 2018 8:55 PM > To: Kalle Valo > Cc: Yamada, Masahiro/山田 真弘 ; > linux-wireless@vger.kernel.org; ath...@lists.infradead.org > Subject: Re: [PATCH 01/13] ath10k: platform driver for WCN3990 SNOC WLAN > module > > On 2018-03-10 14:41, Kalle Valo wrote: > > writes: > > > >>> >> Kbuild bot found an odd problem with this patch: > >>> >> > >>> >> include/linux/dynamic_debug.h:77:14: error: 'KBUILD_MODNAME' > >>> >> undeclared (first use in this function); did you mean > >>> 'KBUILD_BASENAME'? > >>> >> > >>> >> Full report: > >>> >> > >>> >> > >>> > http://lists.infradead.org/pipermail/ath10k/2018-February/010907.html > >>> >> > >>> >> Any ideas? Is this is some unrelated issue or what? This patch is > not > >>> >> even touching hif.h or ce.c. > >>> > > >>> > I didn't encountered this issue as in my defconfig only > >>> > CONFIG_ATH10K_SNOC was defined. This problem is coming when we define > >>> > CONFIG_ATH10K_SNOC and CONFIG_ATH10K_PCI simultaneously in defconfig > >>> > and this is known issue when multiple modules share objects(in this > >>> > case ce.o). I saw similar reported problem and found > >>> > https://patchwork.kernel.org/patch/10060825/. > >>> > > >>> > After picking the below change issue is not seen. > >>> > >>> Let's ask the kbuild maintainer. Masahiro, any chances of getting > >>> this > >>> patch applied anytime soon: > >>> > >>> kbuild: define KBUILD_MODNAME even if multiple modules share objects > >>> > >>> https://patchwork.kernel.org/patch/10060825/ > >>> > >>> In ath10k we would need it as otherwise we are not able to link ce.o > >>> both to ath10k_pci.ko and ath10k_snoc.ko. What do you think? > >>> > >>> Full discussion and the ath10k patch here: > >>> > >>> https://patchwork.kernel.org/patch/10220657/ > >>> > >> > >> I plan to submit v2, but even if the undefined KBUILD_MODNAME is > >> fixed, > >> I expect another problem from this patch. > >> > >> If both CONFIG_ATH10K_PCI and CONFIG_ATH10_SNOC are 'y' > >> two instances of ce.o would be linked into vmliux, > >> then causes multiple definition error. > > > > Oh, I didn't realise this. Thanks for pointing it out. Govind is > > looking > > at other ways to fix this. > > https://patchwork.kernel.org/patch/10298659/ is raised to address this > problem. > > CE layer is shared between pci and snoc target and results > in duplicate object inclusion if both modules are compiled > together statically and undefined KBUILD_MODNAME if > compiled as module. If you rebase your development on v4.17-rc1, this statement is no longer true. > Fix this by building ce layer in ath10k core module by > adding ce object inclusion with ATH10K_CE boolean CONFIG. Today, the solution landed in Linus' tree. [1] Solution for missing KBUILD_MODNAME definition commit aeacb019b61c4ea7689085574bd03d2c0810f119 Author: Masahiro Yamada Date: Mon Mar 19 18:01:24 2018 +0900 kbuild: define KBUILD_MODNAME even if multiple modules share objects [2] Solution for multiple definition error when both are built-in commit f98fe47ce51dee6d97dd91bbeccdde23f043c754 Author: Masahiro Yamada Date: Mon Mar 19 20:26:08 2018 +0900 kbuild: link $(real-obj-y) instead of $(obj-y) into built-in.a [3] Examples for Makefile cleanups commit f605005a50fc1443a14b4e8c9c1727881f8f96ae Author: Masahiro Yamada Date: Mon Mar 19 20:26:10 2018 +0900 net: liquidio: clean up Makefile for simpler composite object handling commit dc35da16a2e23db04822f0129cd5b28b7b0e72b4 Author: Masahiro Yamada Date: Mon Mar 19 20:26:09 2018 +0900 lib: zstd: clean up Makefile for simpler composite object handling
Re: [PATCH 01/13] ath10k: platform driver for WCN3990 SNOC WLAN module
On 2018-03-10 14:41, Kalle Valo wrote: writes: >> Kbuild bot found an odd problem with this patch: >> >> include/linux/dynamic_debug.h:77:14: error: 'KBUILD_MODNAME' >> undeclared (first use in this function); did you mean 'KBUILD_BASENAME'? >> >> Full report: >> >> http://lists.infradead.org/pipermail/ath10k/2018-February/010907.html >> >> Any ideas? Is this is some unrelated issue or what? This patch is not >> even touching hif.h or ce.c. > > I didn't encountered this issue as in my defconfig only > CONFIG_ATH10K_SNOC was defined. This problem is coming when we define > CONFIG_ATH10K_SNOC and CONFIG_ATH10K_PCI simultaneously in defconfig > and this is known issue when multiple modules share objects(in this > case ce.o). I saw similar reported problem and found > https://patchwork.kernel.org/patch/10060825/. > > After picking the below change issue is not seen. Let's ask the kbuild maintainer. Masahiro, any chances of getting this patch applied anytime soon: kbuild: define KBUILD_MODNAME even if multiple modules share objects https://patchwork.kernel.org/patch/10060825/ In ath10k we would need it as otherwise we are not able to link ce.o both to ath10k_pci.ko and ath10k_snoc.ko. What do you think? Full discussion and the ath10k patch here: https://patchwork.kernel.org/patch/10220657/ I plan to submit v2, but even if the undefined KBUILD_MODNAME is fixed, I expect another problem from this patch. If both CONFIG_ATH10K_PCI and CONFIG_ATH10_SNOC are 'y' two instances of ce.o would be linked into vmliux, then causes multiple definition error. Oh, I didn't realise this. Thanks for pointing it out. Govind is looking at other ways to fix this. https://patchwork.kernel.org/patch/10298659/ is raised to address this problem. Thanks, Govind
Re: [PATCH 01/13] ath10k: platform driver for WCN3990 SNOC WLAN module
writes: >> >> Kbuild bot found an odd problem with this patch: >> >> >> >> include/linux/dynamic_debug.h:77:14: error: 'KBUILD_MODNAME' >> >> undeclared (first use in this function); did you mean >> 'KBUILD_BASENAME'? >> >> >> >> Full report: >> >> >> >> >> http://lists.infradead.org/pipermail/ath10k/2018-February/010907.html >> >> >> >> Any ideas? Is this is some unrelated issue or what? This patch is not >> >> even touching hif.h or ce.c. >> > >> > I didn't encountered this issue as in my defconfig only >> > CONFIG_ATH10K_SNOC was defined. This problem is coming when we define >> > CONFIG_ATH10K_SNOC and CONFIG_ATH10K_PCI simultaneously in defconfig >> > and this is known issue when multiple modules share objects(in this >> > case ce.o). I saw similar reported problem and found >> > https://patchwork.kernel.org/patch/10060825/. >> > >> > After picking the below change issue is not seen. >> >> Let's ask the kbuild maintainer. Masahiro, any chances of getting this >> patch applied anytime soon: >> >> kbuild: define KBUILD_MODNAME even if multiple modules share objects >> >> https://patchwork.kernel.org/patch/10060825/ >> >> In ath10k we would need it as otherwise we are not able to link ce.o >> both to ath10k_pci.ko and ath10k_snoc.ko. What do you think? >> >> Full discussion and the ath10k patch here: >> >> https://patchwork.kernel.org/patch/10220657/ >> > > I plan to submit v2, but even if the undefined KBUILD_MODNAME is fixed, > I expect another problem from this patch. > > If both CONFIG_ATH10K_PCI and CONFIG_ATH10_SNOC are 'y' > two instances of ce.o would be linked into vmliux, > then causes multiple definition error. Oh, I didn't realise this. Thanks for pointing it out. Govind is looking at other ways to fix this. -- Kalle Valo
RE: [PATCH 01/13] ath10k: platform driver for WCN3990 SNOC WLAN module
> -Original Message- > From: Kalle Valo [mailto:kv...@codeaurora.org] > Sent: Tuesday, March 06, 2018 9:41 PM > To: Govind Singh ; Yamada, Masahiro/山田 真弘 > > Cc: linux-wireless@vger.kernel.org; ath...@lists.infradead.org > Subject: Re: [PATCH 01/13] ath10k: platform driver for WCN3990 SNOC WLAN > module > > (Fixed Govind's top posting and adding Masahiro) > > >>> WCN3990 is integrated 802.11ac chipset with SNOC bus interface. Add > >>> snoc layer driver registration and associated ops. > >>> > >>> WCN3990 support is not yet complete as cold-boot handshake is done > >>> using qmi(Qualcomm-MSM-Interface) and qmi client support will be added > >>> once qmi framework is available. > >>> > >>> Signed-off-by: Govind Singh > >> > >> Kbuild bot found an odd problem with this patch: > >> > >> include/linux/dynamic_debug.h:77:14: error: 'KBUILD_MODNAME' > >> undeclared (first use in this function); did you mean > 'KBUILD_BASENAME'? > >> > >> Full report: > >> > >> > http://lists.infradead.org/pipermail/ath10k/2018-February/010907.html > >> > >> Any ideas? Is this is some unrelated issue or what? This patch is not > >> even touching hif.h or ce.c. > > > > I didn't encountered this issue as in my defconfig only > > CONFIG_ATH10K_SNOC was defined. This problem is coming when we define > > CONFIG_ATH10K_SNOC and CONFIG_ATH10K_PCI simultaneously in defconfig > > and this is known issue when multiple modules share objects(in this > > case ce.o). I saw similar reported problem and found > > https://patchwork.kernel.org/patch/10060825/. > > > > After picking the below change issue is not seen. > > Let's ask the kbuild maintainer. Masahiro, any chances of getting this > patch applied anytime soon: > > kbuild: define KBUILD_MODNAME even if multiple modules share objects > > https://patchwork.kernel.org/patch/10060825/ > > In ath10k we would need it as otherwise we are not able to link ce.o > both to ath10k_pci.ko and ath10k_snoc.ko. What do you think? > > Full discussion and the ath10k patch here: > > https://patchwork.kernel.org/patch/10220657/ > I plan to submit v2, but even if the undefined KBUILD_MODNAME is fixed, I expect another problem from this patch. If both CONFIG_ATH10K_PCI and CONFIG_ATH10_SNOC are 'y' two instances of ce.o would be linked into vmliux, then causes multiple definition error.
Re: [PATCH 01/13] ath10k: platform driver for WCN3990 SNOC WLAN module
(Fixed Govind's top posting and adding Masahiro) >>> WCN3990 is integrated 802.11ac chipset with SNOC bus interface. Add >>> snoc layer driver registration and associated ops. >>> >>> WCN3990 support is not yet complete as cold-boot handshake is done >>> using qmi(Qualcomm-MSM-Interface) and qmi client support will be added >>> once qmi framework is available. >>> >>> Signed-off-by: Govind Singh >> >> Kbuild bot found an odd problem with this patch: >> >> include/linux/dynamic_debug.h:77:14: error: 'KBUILD_MODNAME' >> undeclared (first use in this function); did you mean 'KBUILD_BASENAME'? >> >> Full report: >> >> http://lists.infradead.org/pipermail/ath10k/2018-February/010907.html >> >> Any ideas? Is this is some unrelated issue or what? This patch is not >> even touching hif.h or ce.c. > > I didn't encountered this issue as in my defconfig only > CONFIG_ATH10K_SNOC was defined. This problem is coming when we define > CONFIG_ATH10K_SNOC and CONFIG_ATH10K_PCI simultaneously in defconfig > and this is known issue when multiple modules share objects(in this > case ce.o). I saw similar reported problem and found > https://patchwork.kernel.org/patch/10060825/. > > After picking the below change issue is not seen. Let's ask the kbuild maintainer. Masahiro, any chances of getting this patch applied anytime soon: kbuild: define KBUILD_MODNAME even if multiple modules share objects https://patchwork.kernel.org/patch/10060825/ In ath10k we would need it as otherwise we are not able to link ce.o both to ath10k_pci.ko and ath10k_snoc.ko. What do you think? Full discussion and the ath10k patch here: https://patchwork.kernel.org/patch/10220657/ -- Kalle Valo
RE: [PATCH 01/13] ath10k: platform driver for WCN3990 SNOC WLAN module
Hi Kalle, I didn't encountered this issue as in my defconfig only CONFIG_ATH10K_SNOC was defined. This problem is coming when we define CONFIG_ATH10K_SNOC and CONFIG_ATH10K_PCI simultaneously in defconfig and this is known issue when multiple modules share objects(in this case ce.o). I saw similar reported problem and found https://patchwork.kernel.org/patch/10060825/. After picking the below change issue is not seen. BR, Govind -Original Message- From: ath10k [mailto:ath10k-boun...@lists.infradead.org] On Behalf Of Kalle Valo Sent: Thursday, March 1, 2018 3:37 PM To: Govind Singh Cc: linux-wireless@vger.kernel.org; ath...@lists.infradead.org Subject: Re: [PATCH 01/13] ath10k: platform driver for WCN3990 SNOC WLAN module Govind Singh writes: > WCN3990 is integrated 802.11ac chipset with SNOC bus interface. Add > snoc layer driver registration and associated ops. > > WCN3990 support is not yet complete as cold-boot handshake is done > using qmi(Qualcomm-MSM-Interface) and qmi client support will be added > once qmi framework is available. > > Signed-off-by: Govind Singh Kbuild bot found an odd problem with this patch: include/linux/dynamic_debug.h:77:14: error: 'KBUILD_MODNAME' undeclared (first use in this function); did you mean 'KBUILD_BASENAME'? Full report: http://lists.infradead.org/pipermail/ath10k/2018-February/010907.html Any ideas? Is this is some unrelated issue or what? This patch is not even touching hif.h or ce.c. -- Kalle Valo ___ ath10k mailing list ath...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH 01/13] ath10k: platform driver for WCN3990 SNOC WLAN module
Govind Singh writes: > WCN3990 is integrated 802.11ac chipset with SNOC > bus interface. Add snoc layer driver registration > and associated ops. > > WCN3990 support is not yet complete as cold-boot > handshake is done using qmi(Qualcomm-MSM-Interface) > and qmi client support will be added once qmi framework > is available. > > Signed-off-by: Govind Singh Kbuild bot found an odd problem with this patch: include/linux/dynamic_debug.h:77:14: error: 'KBUILD_MODNAME' undeclared (first use in this function); did you mean 'KBUILD_BASENAME'? Full report: http://lists.infradead.org/pipermail/ath10k/2018-February/010907.html Any ideas? Is this is some unrelated issue or what? This patch is not even touching hif.h or ce.c. -- Kalle Valo
