Re: [PATCH] Revert "rtlwifi: rtl818x: constify local structures"
On Mon, 10 Oct 2016, Larry Finger wrote: > On 10/10/2016 11:56 AM, Johannes Berg wrote: > > On Mon, 2016-10-10 at 10:25 -0500, Larry Finger wrote: > > > This reverts commit d86e64768859fca82c78e52877ceeba04e25d27a. > > > > > > For drivers rtl8188ee, rtl8192ce, rtl8192ee, rtl8723ae, and > > > rtl8821ae, > > > the Coccinelle script missed the fact that the code changes the > > > firmware > > > name. When that happens, the kernel issues a BUG splat because > > > it is unable to overwrite the old name. > > > > Hmm. That seems somewhat problematic, for example if you have multiple > > devices that use the same driver but need different firmware? > > > > Not that I really know what's going on, but changing static variables > > based on runtime seems like it could cause issues in such cases. > > I think the situation is OK, but I have created a patch that converts all the > firmware names into local strings in the routines that initiate firmware > loading. That way the affected structs can be constified without problem. Great, thanks :) julia > > @Kalle: Please drop the patch with this subject. > > Thanks, > > Larry >
Re: [PATCH] Revert "rtlwifi: rtl818x: constify local structures"
On 10/10/2016 11:56 AM, Johannes Berg wrote: On Mon, 2016-10-10 at 10:25 -0500, Larry Finger wrote: This reverts commit d86e64768859fca82c78e52877ceeba04e25d27a. For drivers rtl8188ee, rtl8192ce, rtl8192ee, rtl8723ae, and rtl8821ae, the Coccinelle script missed the fact that the code changes the firmware name. When that happens, the kernel issues a BUG splat because it is unable to overwrite the old name. Hmm. That seems somewhat problematic, for example if you have multiple devices that use the same driver but need different firmware? Not that I really know what's going on, but changing static variables based on runtime seems like it could cause issues in such cases. I think the situation is OK, but I have created a patch that converts all the firmware names into local strings in the routines that initiate firmware loading. That way the affected structs can be constified without problem. @Kalle: Please drop the patch with this subject. Thanks, Larry
Re: [PATCH] Revert "rtlwifi: rtl818x: constify local structures"
On Mon, 2016-10-10 at 10:25 -0500, Larry Finger wrote: > This reverts commit d86e64768859fca82c78e52877ceeba04e25d27a. > > For drivers rtl8188ee, rtl8192ce, rtl8192ee, rtl8723ae, and > rtl8821ae, > the Coccinelle script missed the fact that the code changes the > firmware > name. When that happens, the kernel issues a BUG splat because > it is unable to overwrite the old name. Hmm. That seems somewhat problematic, for example if you have multiple devices that use the same driver but need different firmware? Not that I really know what's going on, but changing static variables based on runtime seems like it could cause issues in such cases. johannes
