Re: [PATCH] ath10k: fix recent bandwidth conversion bug

2018-03-11 Thread Rafał Miłecki
On 11 March 2018 at 08:12, Kalle Valo wrote: > Rafał Miłecki writes: > >> On 14 December 2017 at 14:21, Kalle Valo wrote: >>> Christian Lamparter writes: >>> On Monday, November 20, 2017 11:57:21 AM CET

Re: [PATCH] ath10k: fix recent bandwidth conversion bug

2018-03-10 Thread Kalle Valo
Rafał Miłecki writes: > On 14 December 2017 at 14:21, Kalle Valo wrote: >> Christian Lamparter writes: >> >>> On Monday, November 20, 2017 11:57:21 AM CET Kalle Valo wrote: Christian Lamparter writes:

Re: [PATCH] ath10k: fix recent bandwidth conversion bug

2018-03-01 Thread Rafał Miłecki
On 14 December 2017 at 14:21, Kalle Valo wrote: > Christian Lamparter writes: > >> On Monday, November 20, 2017 11:57:21 AM CET Kalle Valo wrote: >>> Christian Lamparter writes: >>> >>> > On Wednesday, November 1, 2017 9:37:53 PM

Re: [PATCH] ath10k: fix recent bandwidth conversion bug

2017-12-14 Thread Kalle Valo
Christian Lamparter writes: > On Monday, November 20, 2017 11:57:21 AM CET Kalle Valo wrote: >> Christian Lamparter writes: >> >> > On Wednesday, November 1, 2017 9:37:53 PM CET Sebastian Gottschall wrote: >> >> a additional array bounds check would be

Re: [PATCH] ath10k: fix recent bandwidth conversion bug

2017-11-20 Thread Christian Lamparter
On Monday, November 20, 2017 11:57:21 AM CET Kalle Valo wrote: > Christian Lamparter writes: > > > On Wednesday, November 1, 2017 9:37:53 PM CET Sebastian Gottschall wrote: > >> a additional array bounds check would be good > > > > Ah, about that: > > > > the bw variable in

Re: [PATCH] ath10k: fix recent bandwidth conversion bug

2017-11-13 Thread Johannes Berg
On Thu, 2017-11-02 at 22:08 +0100, Sebastian Gottschall wrote: > i know. saw that later too. code should be safe It would be good if you could adhere to our mailing list customs and start quoting properly, instead of just top-posting. Thanks, johannes

Re: [PATCH] ath10k: fix recent bandwidth conversion bug

2017-11-02 Thread Sebastian Gottschall
i know. saw that later too. code should be safe Am 02.11.2017 um 20:34 schrieb Christian Lamparter: On Wednesday, November 1, 2017 9:37:53 PM CET Sebastian Gottschall wrote: a additional array bounds check would be good Ah, about that: the bw variable in ath10k_htt_rx_h_rates() is extracted

Re: [PATCH] ath10k: fix recent bandwidth conversion bug

2017-11-02 Thread Christian Lamparter
On Wednesday, November 1, 2017 9:37:53 PM CET Sebastian Gottschall wrote: > a additional array bounds check would be good Ah, about that: the bw variable in ath10k_htt_rx_h_rates() is extracted from info2 in the following way [0]: | bw = info2 & 3; the txrate.bw variable in

Re: [PATCH] ath10k: fix recent bandwidth conversion bug

2017-11-01 Thread Sebastian Gottschall
a additional array bounds check would be good Am 01.11.2017 um 21:01 schrieb Christian Lamparter: The commit "cfg80211: make RATE_INFO_BW_20 the default" changed the index of RATE_INFO_BW_20, but the updates to ath10k missed the special bandwidth calculation case in

Re: [PATCH] ath10k: fix recent bandwidth conversion bug

2017-11-01 Thread Sebastian Gottschall
true. good finding. Am 01.11.2017 um 21:01 schrieb Christian Lamparter: The commit "cfg80211: make RATE_INFO_BW_20 the default" changed the index of RATE_INFO_BW_20, but the updates to ath10k missed the special bandwidth calculation case in ath10k_update_per_peer_tx_stats(). Fixes: