Re: [PATCH] cfg80211: Add HT and VHT information in start_ap

2016-10-13 Thread Johannes Berg
On Tue, 2016-10-04 at 16:15 +, Malinen, Jouni wrote: >  > And even if the driver were to simply copy the IEs with the BSS > membership selectors, this would only work with stations that > implement this part correctly, i.e., the AP would not necessarily > have any means for rejecting the associ

Re: [PATCH] cfg80211: Add HT and VHT information in start_ap

2016-10-04 Thread Malinen, Jouni
On Tue, Oct 04, 2016 at 03:25:51PM +0200, Johannes Berg wrote: > > ath6kl: > > Use cfg80211_get_chandef_type(&info->chandef) != NL80211_CHAN_NO_HT > > to determine whether HT is enabled. No VHT support. HT-required case > > not covered. No parsing of HT/VHT IEs used. > > Hmm. Wouldn't the supporte

Re: [PATCH] cfg80211: Add HT and VHT information in start_ap

2016-10-04 Thread Johannes Berg
> The main goal of this was to see if we can reduce actual driver > implementation size and maybe even more so to prepare for 802.11ax > changes (i.e., see what we are doing currently for configuring HT/VHT > in a way that could be done better). Fair enough. > Looking at the current in-tree driv

Re: [PATCH] cfg80211: Add HT and VHT information in start_ap

2016-10-03 Thread Malinen, Jouni
On Mon, Sep 12, 2016 at 12:09:42PM +0200, Johannes Berg wrote: > I have no major objections to this. However, a few things: > > 1) are you planning to add support for this into a kernel driver at >    all, anyway? > 2) are you planning to have a driver upstream that contains the now >    necessary

Re: [PATCH] cfg80211: Add HT and VHT information in start_ap

2016-09-12 Thread Johannes Berg
So I haven't seen a response from you guys: I have no major objections to this. However, a few things: 1) are you planning to add support for this into a kernel driver at    all, anyway? 2) are you planning to have a driver upstream that contains the now    necessary parsing? Depending on the an

Re: [PATCH] cfg80211: Add HT and VHT information in start_ap

2016-08-26 Thread Johannes Berg
On Tue, 2016-08-16 at 12:34 +, Malinen, Jouni wrote: >  > > So if you get HT_VHT_NOT_INDICATED in the driver, don't you *still* > > have to parse the IEs? > > Well.. Yes, I guess one would need to do that for some time until > relevant user space is expected to have been updated to support the

Re: [PATCH] cfg80211: Add HT and VHT information in start_ap

2016-08-16 Thread Malinen, Jouni
On Tue, Aug 16, 2016 at 08:52:47AM +0200, Johannes Berg wrote: > On Mon, 2016-08-15 at 21:07 +0300, Jouni Malinen wrote: > > From: Peng Xu > > Add HT and VHT information in struct cfg80211_ap_settings when > > starting ap so that driver does not need to parse IE to obtain > > the information. > >

Re: [PATCH] cfg80211: Add HT and VHT information in start_ap

2016-08-15 Thread Johannes Berg
On Mon, 2016-08-15 at 21:07 +0300, Jouni Malinen wrote: > From: Peng Xu > > Add HT and VHT information in struct cfg80211_ap_settings when > starting ap so that driver does not need to parse IE to obtain > the information. > +enum ht_vht_support { > + HT_VHT_DISABLED, > + HT_VHT_ENABLED,