Re: [PATCH 2/4] staging: wilc1000: modified wilc_spi_read_int() by using GENMASK macro

2018-02-22 Thread Claudiu Beznea
On 22.02.2018 11:23, Claudiu Beznea wrote: > Hi Dan, Sorry, I intended to be address this to Ajay, > > On 22.02.2018 09:37, Dan Carpenter wrote: >> On Wed, Feb 21, 2018 at 09:42:10PM +0530, Ajay Singh wrote: >>> Use existing macro GENMASK to get the bitmask value. Moved the code to >>> get the b

Re: [PATCH 2/4] staging: wilc1000: modified wilc_spi_read_int() by using GENMASK macro

2018-02-22 Thread Claudiu Beznea
Hi Dan, On 22.02.2018 09:37, Dan Carpenter wrote: > On Wed, Feb 21, 2018 at 09:42:10PM +0530, Ajay Singh wrote: >> Use existing macro GENMASK to get the bitmask value. Moved the code to >> get the bitmask value outside the loop, as its only required one time. >> >> Signed-off-by: Ajay Singh >> --

Re: [PATCH 2/4] staging: wilc1000: modified wilc_spi_read_int() by using GENMASK macro

2018-02-21 Thread Dan Carpenter
On Wed, Feb 21, 2018 at 09:42:10PM +0530, Ajay Singh wrote: > Use existing macro GENMASK to get the bitmask value. Moved the code to > get the bitmask value outside the loop, as its only required one time. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_spi.c | 3 +-- > 1 fil