Hi Sebastian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on v4.16-rc2 next-20180223]
[cannot apply to ath6kl/ath-next]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/s-gottschall-dd-wrt-com/ath10k-add-LED-and-GPIO-controlling-support-for-various-chipsets/20180221-134523
base:   
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git 
master
config: i386-randconfig-b0-02231423 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/net//wireless/ath/ath10k/core.c: In function 'ath10k_attach_led':
>> drivers/net//wireless/ath/ath10k/core.c:2331:3: error: implicit declaration 
>> of function 'ath10k_add_led' [-Werror=implicit-function-declaration]
      ath10k_add_led(ar, &ar->gpio->wifi_led);
      ^
   cc1: some warnings being treated as errors

vim +/ath10k_add_led +2331 drivers/net//wireless/ath/ath10k/core.c

  2322  
  2323  static void ath10k_attach_led(struct ath10k *ar)
  2324  {
  2325          if (!ar->gpio_attached) {
  2326                  ar->gpio->wifi_led.active_low = 1;
  2327                  ar->gpio->wifi_led.gpio = ar->hw_params.led_pin;
  2328                  ar->gpio->wifi_led.name = ar->gpio->label;
  2329                  ar->gpio->wifi_led.default_state = 
LEDS_GPIO_DEFSTATE_KEEP;
  2330                  
> 2331                  ath10k_add_led(ar, &ar->gpio->wifi_led);
  2332          }
  2333          ath10k_reset_led_pin(ar); /* initially we need to configure the 
led pin to output */
  2334  }
  2335  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to