Re: [v5 1/8] rsi: add rx control block to handle rx packets in USB

[Amitkumar Karwar]

On Thu, Feb 1, 2018 at 12:00 PM, Kalle Valo  wrote:
> Amitkumar Karwar  writes:
>
>> From: Prameela Rani Garnepudi 
>>
>> Rx bluetooth endpoint shall be added in further patches. Rx control
>> block is introduced here to handle Rx packets properly. Separate
>> function is written to initialize the RX control blocks.
>>
>> Signed-off-by: Prameela Rani Garnepudi 
>> Signed-off-by: Siva Rebbagondla 
>> Signed-off-by: Amitkumar Karwar 
>
> [...]
>
>> +static int rsi_usb_init_rx(struct rsi_hw *adapter)
>> +{
>> + struct rsi_91x_usbdev *dev = (struct rsi_91x_usbdev *)adapter->rsi_dev;
>> + struct rx_usb_ctrl_block *rx_cb;
>> + u8 idx;
>> +
>> + for (idx = 0; idx < MAX_RX_URBS; idx++) {
>> + rx_cb = >rx_cb[idx];
>> +
>> + rx_cb->rx_buffer = kzalloc(RSI_USB_BUF_SIZE * 2,
>> +GFP_KERNEL | GFP_DMA);
>
> Do you really need GFP_DMA? From the documentation:
>
>  "GFP_DMA exists for historical reasons and should be avoided where
>   possible."

Thanks for review. I will get rid of this flag,

Regards,
Amitkumar

Re: [v5 1/8] rsi: add rx control block to handle rx packets in USB

[Kalle Valo]

Amitkumar Karwar  writes:

> From: Prameela Rani Garnepudi 
>
> Rx bluetooth endpoint shall be added in further patches. Rx control
> block is introduced here to handle Rx packets properly. Separate
> function is written to initialize the RX control blocks.
>
> Signed-off-by: Prameela Rani Garnepudi 
> Signed-off-by: Siva Rebbagondla 
> Signed-off-by: Amitkumar Karwar 

[...]

> +static int rsi_usb_init_rx(struct rsi_hw *adapter)
> +{
> + struct rsi_91x_usbdev *dev = (struct rsi_91x_usbdev *)adapter->rsi_dev;
> + struct rx_usb_ctrl_block *rx_cb;
> + u8 idx;
> +
> + for (idx = 0; idx < MAX_RX_URBS; idx++) {
> + rx_cb = >rx_cb[idx];
> +
> + rx_cb->rx_buffer = kzalloc(RSI_USB_BUF_SIZE * 2,
> +GFP_KERNEL | GFP_DMA);

Do you really need GFP_DMA? From the documentation:

 "GFP_DMA exists for historical reasons and should be avoided where
  possible."

-- 
Kalle Valo