Re: [linux-yocto] [PATCH 19/94] drivers/tty: AXM5516 emulation bringup - amba-pl011.c

2013-11-09 Thread Bruce Ashfield

On 11/7/2013, 8:12 PM, Paul Butler wrote:

Signed-off-by: Paul Butler paul.but...@windriver.com
---
  drivers/tty/serial/amba-pl011.c | 5 +
  1 file changed, 5 insertions(+)

diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
index b69356c..abe91eb 100644
--- a/drivers/tty/serial/amba-pl011.c
+++ b/drivers/tty/serial/amba-pl011.c
@@ -1667,8 +1667,13 @@ pl011_set_termios(struct uart_port *port, struct 
ktermios *termios,
quot -= 2;
}
/* Set baud rate */
+#if 0


? Why is the #if 0 code being kept. Drop it completely or give it a
Kconfig value .. or anything, but don't leave it dead in the tree.

Bruce


writew(quot  0x3f, port-membase + UART011_FBRD);
writew(quot  6, port-membase + UART011_IBRD);
+#else
+   writew(0x5, port-membase + UART011_FBRD);
+   writew(0x1, port-membase + UART011_IBRD);
+#endif

/*
 * --v--v--v--v-



___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto


[linux-yocto] [PATCH 19/94] drivers/tty: AXM5516 emulation bringup - amba-pl011.c

2013-11-07 Thread Paul Butler
Signed-off-by: Paul Butler paul.but...@windriver.com
---
 drivers/tty/serial/amba-pl011.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
index b69356c..abe91eb 100644
--- a/drivers/tty/serial/amba-pl011.c
+++ b/drivers/tty/serial/amba-pl011.c
@@ -1667,8 +1667,13 @@ pl011_set_termios(struct uart_port *port, struct 
ktermios *termios,
quot -= 2;
}
/* Set baud rate */
+#if 0
writew(quot  0x3f, port-membase + UART011_FBRD);
writew(quot  6, port-membase + UART011_IBRD);
+#else
+   writew(0x5, port-membase + UART011_FBRD);
+   writew(0x1, port-membase + UART011_IBRD);
+#endif
 
/*
 * --v--v--v--v-
-- 
1.8.3.4

___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto