From: Joe Perches j...@perches.com
commit 2235ad1c3ac545bd8fc2c026be5be16d98b9a891 upstream
Add openvswitch: prefix to OVS_NLERR output
to match the other OVS_NLERR output of datapath.c
Signed-off-by: Joe Perches j...@perches.com
Signed-off-by: Jesse Gross je...@nicira.com
Signed-off-by: He
From: Daniele Di Proietto daniele.di.proie...@gmail.com
commit 7085130bab2f9c5b8d61bff73b01dc8195d0f974 upstream
In few functions, const formal parameters are assigned or cast to
non-const.
These changes suppress warnings if compiled with -Wcast-qual.
Signed-off-by: Daniele Di Proietto
From: Daniele Di Proietto daniele.di.proie...@gmail.com
commit d0b4da137508db3d38998eae7f62c0f9699ee08c upstream
This change, firstly, avoids declaring the formal parameter const,
since it is treated as non const. (to avoid -Wcast-qual)
Secondly, it cast the pointer from void* to u8*, since it
From: Daniele Di Proietto daniele.di.proie...@gmail.com
commit cc23ebf3bb4348fb022c0d25494307459bb2e539 upstream
This is necessary, since u64 is not unsigned long long
in all architectures: u64 could be also uint64_t.
Signed-off-by: Daniele Di Proietto daniele.di.proie...@gmail.com
From: Daniele Di Proietto daniele.di.proie...@gmail.com
commit 07dc0602c5976cfc36ccffe5c6d73234f204d585 upstream
This function must cast a const value to a non const value.
By adding an uintptr_t cast the warning is suppressed.
To avoid the cast (proper solution) several function signatures
must
From: Joe Perches j...@perches.com
commit 8c63ff09bddf944ab0033fea97aacfadfffa76de upstream
It's slightly smaller/faster for some architectures.
Signed-off-by: Joe Perches j...@perches.com
Signed-off-by: Jesse Gross je...@nicira.com
Signed-off-by: He Zhe zhe...@windriver.com
---
From: Joe Perches j...@perches.com
commit 1815a8831fb04c60d73627816cb0b596266e9bee upstream
Each use of pr_level_once has a per-site flag.
Some of the OVS_NLERR messages look as if seeing them
multiple times could be useful, so use net_ratelimit()
instead of pr_info_once.
Signed-off-by: Joe
From: Jarno Rajahalme jrajaha...@nicira.com
commit 23dabf88abb48a866fdb19ee08ebcf1ddd9b1840 upstream
The 5-tuple optimization becomes unnecessary with a later per-NUMA
node stats patch. Remove it first to make the changes easier to
grasp.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
From: Jarno Rajahalme jrajaha...@nicira.com
commit 63e7959c4b9bd6f791061c460a22d9ee32ae2240 upstream
Keep kernel flow stats for each NUMA node rather than each (logical)
CPU. This avoids using the per-CPU allocator and removes most of the
kernel-side OVS locking overhead otherwise on the top of
From: Jarno Rajahalme jrajaha...@nicira.com
commit 88d73f6c411ac2f057829b93b3cf202ee551f6cb upstream
We already extract the TCP flags for the key, might as well use that
for stats.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
Acked-by: Pravin B Shelar pshe...@nicira.com
Signed-off-by:
From: Monam Agarwal monamagarwal...@gmail.com
commit 944df8ae84d88f5e8eb027990dad2cfa4fbe4be5 upstream
This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)
The rcu_assign_pointer() ensures that the initialization of a structure
is carried out before storing a pointer
From: Jarno Rajahalme jrajaha...@nicira.com
commit 6093ae9abac18871afd0bbc5cf093dff53112fcb upstream
Move most memory allocations away from the ovs_mutex critical
sections. vport allocations still happen while the lock is taken, as
changing that would require major refactoring. Also, vports are
From: Jarno Rajahalme jrajaha...@nicira.com
commit fb5d1e9e127ad1542e5db20cd8620a1509baef69 upstream
Use netlink_has_listeners() and NLM_F_ECHO flag to determine if a
reply is needed or not for OVS_FLOW_CMD_NEW, OVS_FLOW_CMD_SET, or
OVS_FLOW_CMD_DEL. Currently, OVS userspace does not request a
From: Jarno Rajahalme jrajaha...@nicira.com
commit 56c19868e115fcf8d62d843e1b9616bb9837d0db upstream
Masks are inserted when flows are inserted to the table, so it is
logical to correspondingly remove masks when flows are removed from
the table, in ovs_flow_table_remove().
This allows
From: Jarno Rajahalme jrajaha...@nicira.com
commit bb6f9a708d4067713afae2e9eb2637f6b4c01ecb upstream
Remove unnecessary locking from functions that are always called with
appropriate locking.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
Signed-off-by: Thomas Graf tg...@redhat.com
From: Jarno Rajahalme jrajaha...@nicira.com
commit be52c9e96a6657d117bb0ec6e11438fb246af5c7 upstream
Flow SET can accept an empty set of actions, with the intended
semantics of leaving existing actions unmodified. This seems to have
been brokin after OVS 1.7, as we have assigned the flow's
From: Jarno Rajahalme jrajaha...@nicira.com
commit 1139e241ec436b9e9610c7a33ac5c6657f87fda1 upstream
Minimize padding in sw_flow_key and move 'tp' top the main struct.
These changes simplify code when accessing the transport port numbers
and the tcp flags, and makes the sw_flow_key 8 bytes
From: Jarno Rajahalme jrajaha...@nicira.com
commit eb07265904d6ee95497aba0f3cbd2ae6d9c39a97 upstream
Incorrect struct name was confusing, even though otherwise
inconsequental.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
Signed-off-by: Pravin B Shelar pshe...@nicira.com
Signed-off-by:
From: Ben Pfaff b...@nicira.com
commit ad55200734c65a3ec5d0c39d6ea904008baea536 upstream
Flow statistics need to take into account the TCP flags from the packet
currently being processed (in 'key'), not the TCP flags matched by the
flow found in the kernel flow table (in 'flow').
This bug made
From: Jarno Rajahalme jrajaha...@nicira.com
commit 0e9796b4af9ef490e203158cb738a5a4986eb75c upstream
Reduce and clarify locking requirements for ovs_flow_cmd_alloc_info(),
ovs_flow_cmd_fill_info() and ovs_flow_cmd_build_info().
A datapath pointer is available only when holding a lock. Change
From: Jarno Rajahalme jrajaha...@nicira.com
commit 37bdc87ba00dadd0156db77ba48224d042202435 upstream
Following patch will be easier to reason about with separate
ovs_flow_cmd_new() and ovs_flow_cmd_set() functions.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
Signed-off-by: Pravin B
From: Andy Zhou az...@nicira.com
commit fe984c08e20f0fc2b4666bf8eeeb02605568387b upstream
When sample action returns with an error, the skb has already been
freed. This patch fix a bug to make sure we don't free it again.
This bug introduced by commit ccb1352e76cff05 (net: Add Open vSwitch
From: Pravin B Shelar pshe...@nicira.com
commit 0c200ef94c9492205e18a18c25650cf27939889c upstream
Following patch get rid of struct genl_family_and_ops which is
redundant due to changes to struct genl_family.
Signed-off-by: Kyle Mestery mest...@noironetworks.com
Acked-by: Kyle Mestery
From: Jarno Rajahalme jrajaha...@nicira.com
commit 893f139b9a6c00c097b9082a90f3041cfb3a0d20 upstream
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
Signed-off-by: Pravin B Shelar pshe...@nicira.com
Signed-off-by: He Zhe zhe...@windriver.com
---
net/openvswitch/datapath.c | 192
From: Jarno Rajahalme jrajaha...@nicira.com
commit 86ec8dbae27e5fa2b5d54f10f77286d9ef55732a upstream
For ovs_flow_stats_get() using ovsl_dereference() was wrong, since
flow dumps call this with RCU read lock.
ovs_flow_stats_clear() is always called with ovs_mutex, so can use
ovsl_dereference().
From: Jarno Rajahalme jrajaha...@nicira.com
commit aed067783e505bf66dcafa8647d08619eb5b1c55 upstream
ovs_flow_cmd_del() now allocates reply (if needed) after the flow has
already been removed from the flow table. If the reply allocation
fails, a netlink error is signaled with netlink_set_err(),
From: Wei Zhang asuka@163.com
commit e0bb8c44ed5cfcc56b571758ed966ee48779024c upstream
When use gre vport, openvswitch register a gre_cisco_protocol but
does not supply a err_handler with it. The gre_cisco_err() in
net/ipv4/gre_demux.c expect err_handler be provided with the
From: Alex Wang al...@nicira.com
commit 4a46b24e147dfa9b858026da02cad0bdd4e149d2 upstream
Due to the race condition in userspace, there is chance that two
overlapping megaflows could be installed in datapath. And this
causes userspace unable to delete the less inclusive megaflow flow
even after
From: Al Viro v...@zeniv.linux.org.uk
commit 09aaacf02a3e88870ed5cad038a5bc822c947904 upstream
Signed-off-by: Al Viro v...@zeniv.linux.org.uk
Signed-off-by: He Zhe zhe...@windriver.com
---
drivers/vhost/net.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
From: Nicholas Bellinger n...@linux-iscsi.org
commit b1935f687bb93b207ef690f7debc0e9921fc484f upstream
This patch updates tcm_vhost_make_nexus() to pre-allocate per descriptor
tcm_vhost_cmd-tvc_prot_sgl[] used to expose protection SGLs from within
virtio-scsi guest memory to vhost-scsi.
Cc:
From: Nicholas Bellinger n...@linux-iscsi.org
commit 5a01d08217e39f3d36d3ca160361c7b019ff1598 upstream
Move the overflow check for sgl_count TCM_VHOST_PREALLOC_SGLS into
vhost_scsi_map_iov_to_sgl() so that it's based on the total number
of SGLs for all IOVs, instead of single IOVs.
Also,
From: Michael S. Tsirkin m...@redhat.com
commit ea16c51433510f7f758382dec5b933fc0797f244 upstream
Refactor code to make sure features are only accessed
under VQ mutex. This makes everything simpler, no need
for RCU here anymore.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by:
From: Nicholas Bellinger n...@linux-iscsi.org
commit 95e7c4341b8e28dae5204378087c1e2a115abc82 upstream
This patch updates vhost_scsi_handle_vq() to check for the existance
of virtio_scsi_cmd_req_pi comparing vq-iov[0].iov_len in order to
calculate seperate data + protection SGLs from data_num.
From: Michael S. Tsirkin m...@redhat.com
commit 47283bef7ed356629467d1fac61687756e48f254 upstream
commit 2ae76693b8bcabf370b981cd00c36cd41d33fabc
vhost: replace rcu with mutex
replaced rcu sync for memory accesses with VQ mutex locl/unlock.
This is correct since all accesses are under VQ
From: Michael S. Tsirkin m...@redhat.com
commit 23cc5a991c7a9fb7e6d6550e65cee4f4173111c5 upstream
Michael Mueller provided a patch to reduce the size of
vhost-net structure as some allocations could fail under
memory pressure/fragmentation. We are still left with
high order allocations though.
From: Michael S. Tsirkin m...@redhat.com
commit 98f9ca0a3faa99b7388578d55eccecf272be4038 upstream
All memory accesses are done under some VQ mutex.
So lock/unlock all VQs is a faster equivalent of synchronize_rcu()
for memory access changes.
Some guests cause a lot of these changes, so it's
From: Nicholas Bellinger n...@linux-iscsi.org
commit e31885dd901e80d5bd528c1cbedde07ebbf051b2 upstream
This patch adds vhost_scsi_map_iov_to_prot() to perform the mapping of
T10 data integrity memory between virtio iov + struct scatterlist using
get_user_pages_fast() following existing code.
As
From: Nicholas Bellinger n...@linux-iscsi.org
commit 9f977ef7b671f6169eca78bf40f230fe84b7c7e5 upstream
This patch updates vhost_scsi_get_tag() to accept the combined
expected data transfer length + T10 PI bytes as the value passed
into target_submit_cmd().
This is required now that target-core
38 matches
Mail list logo
