Re: [Linux-zigbee-devel] [PATCH net-next 01/15] 6lowpan: lowpan_is_iid_16_bit_compressable() does not detect compressable address correctly

2012-10-22 Thread David Miller
From: Tony Cheneau Date: Tue, 23 Oct 2012 00:09:43 -0400 > The current test is not RFC6282 compliant. The same issue has been found > out and fixed in Contiki. This patch is basicaly a port of their fix. > > Signed-off-by: Tony Cheneau It's really demoralizing to sit down to read a large 15 en

[Linux-zigbee-devel] [PATCH net-next 15/15] mac802154: re-introduce MAC primitives required to send/receive packets

2012-10-22 Thread Tony Cheneau
- mlme_assoc_req() and mlme_assoc_resp() are just place holder for the moment (they prevent the two corresponding function pointers in the mac802154_mlme_wpan structure to be left uninitialized) - mac802514_dev_get_bsn() and mac802514_dev_get_dsn() MAC primitives were present in the Linux-Zig

[Linux-zigbee-devel] [PATCH net-next 14/15] mac802154: remove unnecessary spinlocks

2012-10-22 Thread Tony Cheneau
These spinlock protects an int variable, that is always accessible in an atomic fashion. Signed-off-by: Tony Cheneau --- net/mac802154/mib.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/net/mac802154/mib.c b/net/mac802154/mib.c index f47781a..2339f8d 100

[Linux-zigbee-devel] [PATCH net-next 13/15] mac802154: make mem alloc ATOMIC to prevent "scheduling while atomic" crashes

2012-10-22 Thread Tony Cheneau
These crashes occur mainly with the serial driver (not yet in the tree). Signed-off-by: Tony Cheneau --- net/mac802154/wpan.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/mac802154/wpan.c b/net/mac802154/wpan.c index d6aea7f..49ba8df 100644 --- a/net/mac802154/wp

[Linux-zigbee-devel] [PATCH net-next 12/15] 6lowpan: make memory allocation atomic during 6lowpan header creation

2012-10-22 Thread Tony Cheneau
This is prevent various crashes when using the serial driver (not yet in the tree). Signed-off-by: Tony Cheneau --- net/ieee802154/6lowpan.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 9c7ac2e..70ff171 100644

[Linux-zigbee-devel] [PATCH net-next 11/15] 6lowpan: modify udp compression/uncompression to match the standard

2012-10-22 Thread Tony Cheneau
The previous code would just compress the UDP header and send the compressed UDP header along with the uncompressed one. Signed-off-by: Tony Cheneau --- net/ieee802154/6lowpan.c | 36 +--- 1 files changed, 33 insertions(+), 3 deletions(-) diff --git a/net/ieee8

[Linux-zigbee-devel] [PATCH net-next 10/15] 6lowpan: use the PANID provided by the device instead of a static value

2012-10-22 Thread Tony Cheneau
Signed-off-by: Tony Cheneau --- net/ieee802154/6lowpan.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index f8fcdae..9711038 100644 --- a/net/ieee802154/6lowpan.c +++ b/net/ieee802154/6lowpan.c @@ -584,10 +584,1

[Linux-zigbee-devel] [PATCH net-next 08/15] 6lowpan: obtain IEEE802.15.4 sequence number from the MAC layer

2012-10-22 Thread Tony Cheneau
This patch sets the sequence number in the frame format. Without this fix, the sequence number is always set to 0. This makes trafic analysis very hard. Signed-off-by: Tony Cheneau --- net/ieee802154/6lowpan.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/net/ie

[Linux-zigbee-devel] [PATCH net-next 09/15] 6lowpan: add a new parameter in sysfs to turn on/off ACK request at MAC layer

2012-10-22 Thread Tony Cheneau
Signed-off-by: Tony Cheneau --- net/ieee802154/6lowpan.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 24b83fa..f8fcdae 100644 --- a/net/ieee802154/6lowpan.c +++ b/net/ieee802154/6lowpan.c @@ -62,6 +62,8

[Linux-zigbee-devel] [PATCH net-next 06/15] 6lowpan: fix first fragment (FRAG1) handling

2012-10-22 Thread Tony Cheneau
The first fragment, FRAG1, must contain some payload according to the specs. However, as it is currently written, the first fragment will remain empty and only contain the 6lowpan headers. This patch also extract the transport layer information from the first fragment. This information is later on

[Linux-zigbee-devel] [PATCH net-next 07/15] 6lowpan: store fragment tag values per device instead of net stack wide

2012-10-22 Thread Tony Cheneau
Signed-off-by: Tony Cheneau --- net/ieee802154/6lowpan.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 38cecaf..eb8003b 100644 --- a/net/ieee802154/6lowpan.c +++ b/net/ieee802154/6lowpan.c @@ -104,6 +104

[Linux-zigbee-devel] [PATCH net-next 04/15] mac802154: turn on ACK when enabled by the upper layers

2012-10-22 Thread Tony Cheneau
Signed-off-by: Tony Cheneau --- net/mac802154/wpan.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/mac802154/wpan.c b/net/mac802154/wpan.c index f30f6d4..d6aea7f 100644 --- a/net/mac802154/wpan.c +++ b/net/mac802154/wpan.c @@ -149,6 +149,8 @@ static int mac802154_

[Linux-zigbee-devel] [PATCH net-next 05/15] 6lowpan: use short IEEE 802.15.4 addresses for broadcast destination

2012-10-22 Thread Tony Cheneau
It is intended that the IEEE 802.15.4 standard uses the 0x short address (2 bytes) for message broadcasting. Signed-off-by: Tony Cheneau --- net/ieee802154/6lowpan.c | 21 + 1 files changed, 13 insertions(+), 8 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/i

[Linux-zigbee-devel] [PATCH net-next 02/15] 6lowpan: next header is not properly set upon decompression of a UDP header.

2012-10-22 Thread Tony Cheneau
This causes a drop of the UDP packet. Signed-off-by: Tony Cheneau --- net/ieee802154/6lowpan.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 6d42c17..b53a71a4 100644 --- a/net/ieee802154/6lowpan.c +++ b/net/

[Linux-zigbee-devel] [PATCH net-next 03/15] 6lowpan: always enable link-layer acknowledgments

2012-10-22 Thread Tony Cheneau
This feature is especially important when using fragmentation, because the reassembly mechanism can not recover from the loss of a fragment. Note that some hardware ignore this flag and not will not transmit any acknowledgments if this is set. Signed-off-by: Tony Cheneau --- net/ieee802154/6low

[Linux-zigbee-devel] [PATCH net-next 01/15] 6lowpan: lowpan_is_iid_16_bit_compressable() does not detect compressable address correctly

2012-10-22 Thread Tony Cheneau
The current test is not RFC6282 compliant. The same issue has been found out and fixed in Contiki. This patch is basicaly a port of their fix. Signed-off-by: Tony Cheneau --- net/ieee802154/6lowpan.h | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/net/ieee80

[Linux-zigbee-devel] [PATCH net-next 00/15] 6lowpan: Some more bug fixes

2012-10-22 Thread Tony Cheneau
Hello, This patch serie fixes a few bugs within the 6lowpan modules and prepares the integration of the serial driver that will be submitted in a subsequent patch serie. It should apply cleanly on the latest net-next. Regards, Tony Cheneau Tony Cheneau (15): 6lowpan: lowpan_is_iid_16_