[Linux-zigbee-devel] [PATCH v2] mac802154: Keep track of the channel when changed

2013-04-05 Thread Alan Ott
Two sections checked whether the current channel != the new channel without ever setting the current channel variables. 1. net/mac802154/tx.c: Prevent set_channel() from getting called every time a packet is sent. 2. net/mac802154/mib.c: Lock (pib_lock) accesses to current_channel and current_pag

Re: [Linux-zigbee-devel] [PATCH] mac802154: Keep track of the channel when changed

2013-04-05 Thread Alan Ott
On 04/05/2013 05:05 PM, Werner Almesberger wrote: > Alan Ott wrote: >> Prevent set_channel() from getting called every time a packet is sent. This >> looks like it was an oversight. > at86rf230.c and derivatives avoid this problem by setting > phy->current_* in the *_channel function. > > But I'd a

Re: [Linux-zigbee-devel] [PATCH] mac802154: Keep track of the channel when changed

2013-04-05 Thread Werner Almesberger
Alan Ott wrote: > Prevent set_channel() from getting called every time a packet is sent. This > looks like it was an oversight. at86rf230.c and derivatives avoid this problem by setting phy->current_* in the *_channel function. But I'd agree that it's nicer to do this in one place, not in every d

[Linux-zigbee-devel] [PATCH] mrf24j40: Enable link-layer acknowledgement and retry

2013-04-05 Thread Alan Ott
On the MRF24J40, link-layer acknowledgment request and retry must be turned on explicitly for each packet. Turn this on in the hardware based on the FC_ACK_REQ bit being set in the packet. Also, now that failure to receive an ACK will cause the hardware to report failure of transmission, change t

[Linux-zigbee-devel] [PATCH] mac802154: Keep track of the channel when changed

2013-04-05 Thread Alan Ott
Prevent set_channel() from getting called every time a packet is sent. This looks like it was an oversight. Signed-off-by: Alan Ott --- net/mac802154/tx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/mac802154/tx.c b/net/mac802154/tx.c index 3fd3e07..6d16473 100644 --- a/net/mac802

[Linux-zigbee-devel] Fix to transmit RFC 4944 compilant fraglets from 6lowpan.c

2013-04-05 Thread Ralph Droms (rdroms)
Patch for outbound fraglets is attached. Seems to interoperate with Contiki and Wireshark correctly reassembles the original datagram; tested with "ping6 -s 200". - Ralph 0001-ieee802154-6lowpan.c-Fix-fraglet-generation-code-so-.patch Description: 0001-ieee802154-6lowpan.c-Fix-fraglet-gen

Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-04-05 Thread Tony Cheneau
Hi Jon, From the last talk I had with Michael Richardson on his implementation, it was not functional. It can send some of the RPL messages, but no code logic is present to interpret them, etc. Regards, Tony Le 2013-04-05 18:50, jonsm...@gmail.com a écrit : > There is another Linux RPL implem

Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-04-05 Thread jonsm...@gmail.com
There is another Linux RPL implementation here. https://github.com/mcr/unstrung How does these relate to each other? On Fri, Apr 5, 2013 at 12:30 PM, Ralph Droms (rdroms) wrote: > Tony - I inadvertently missed one problem in the previous patch set. Please > use the attached [PATCH 3/3] instead

Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-04-05 Thread Ralph Droms (rdroms)
Tony - I inadvertently missed one problem in the previous patch set. Please use the attached [PATCH 3/3] instead of the one I sent previously. - Ralph On Apr 5, 2013, at 10:29 AM 4/5/13, Tony Cheneau wrote: > Hi Ralph, > > I'll test it over the course of the week-end or at the beginning o

Re: [Linux-zigbee-devel] [PATCH 2/2] at86rf230: change irq handling to prevent lockups with edge type irq

2013-04-05 Thread Sascha Herrmann
>I wrote: >> To achieve perfection, at86rf230_probe could try all four >> possible trigger modes, pick one the platform supports, and >> set TRX_CTRL_1.IRQ_POLARITY accordingly. > >Thinking of it, probing by trying request_irq has an unpleasant ring >to it. Perhaps a better way would be to leave

Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-04-05 Thread Tony Cheneau
Hi Ralph, I'll test it over the course of the week-end or at the beginning of the next week. Thanks. Regards, Tony Le 2013-04-05 14:33, Ralph Droms (rdroms) a écrit : > Attached are the patches for fixing link-local address decompression. > Comments welcome... > > - Ralph

Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-04-05 Thread Tony Cheneau
Hi, >> I'd be very interested if you had any thoughts on retrieving the >> link >> quality metrics. My understanding is that Contiki uses it for its >> Objective Function (both OF0 and ETX). > > Yes, RPL uses link-layer information (ETX). It uses it for both, OF0 > and MRHOF > (latter unfortunat

Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-04-05 Thread Ralph Droms (rdroms)
Attached are the patches for fixing link-local address decompression. Comments welcome... - Ralph 6lowpan-patches.tgz Description: 6lowpan-patches.tgz -- Minimize network downtime and maximize team effectiveness. Re

Re: [Linux-zigbee-devel] [PATCH 2/2] at86rf230: change irq handling to prevent lockups with edge type irq

2013-04-05 Thread Werner Almesberger
I wrote: > To achieve perfection, at86rf230_probe could try all four > possible trigger modes, pick one the platform supports, and > set TRX_CTRL_1.IRQ_POLARITY accordingly. Thinking of it, probing by trying request_irq has an unpleasant ring to it. Perhaps a better way would be to leave this deci

Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-04-05 Thread Markus Becker
> Hi Markus, > > I'd be very interested if you had any thoughts on retrieving the link > quality metrics. My understanding is that Contiki uses it for its > Objective Function (both OF0 and ETX). Yes, RPL uses link-layer information (ETX). It uses it for both, OF0 and MRHOF (latter unfortunately