Re: [Linux-zigbee-devel] [PATCH 0/2 v3] changed irq handling for at86rf230

2013-04-15 Thread David Miller
From: Werner Almesberger Date: Tue, 16 Apr 2013 00:16:58 -0300 > David Miller wrote: >> "Acked-by: Werner ..." is most useful to me. > > Hmm, since I don't have any official role (maintainer or such) > with respect to that driver or the WPAN stack, I think this would > fit better: > > Reviewed-

Re: [Linux-zigbee-devel] [PATCH 0/2 v3] changed irq handling for at86rf230

2013-04-15 Thread Werner Almesberger
David Miller wrote: > "Acked-by: Werner ..." is most useful to me. Hmm, since I don't have any official role (maintainer or such) with respect to that driver or the WPAN stack, I think this would fit better: Reviewed-by: Werner Almesberger Tested-by: Werner Almesberger Do you need Sascha to re

Re: [Linux-zigbee-devel] [PATCH 0/2 v3] changed irq handling for at86rf230

2013-04-15 Thread David Miller
From: Werner Almesberger Date: Mon, 15 Apr 2013 22:44:19 -0300 > David Miller wrote: >> I'd like to see some reviews of this patch series, thanks. > > Sascha and I discussed the functional aspects of his changes a > while ago and I'm satisfied with the way he has done things now. > I also believ

Re: [Linux-zigbee-devel] [PATCH 0/2 v3] changed irq handling for at86rf230

2013-04-15 Thread Werner Almesberger
David Miller wrote: > I'd like to see some reviews of this patch series, thanks. Sascha and I discussed the functional aspects of his changes a while ago and I'm satisfied with the way he has done things now. I also believe his approach to be technically sound. Furthermore, I merged his changes i

Re: [Linux-zigbee-devel] [PATCH 0/2 v3] changed irq handling for at86rf230

2013-04-15 Thread David Miller
From: Sascha Herrmann Date: Mon, 15 Apr 2013 10:33:27 +0200 > Changes to last version: Reordered local variable declarations. > > The first patch add the option to configure the irq type of the > plattform and the device. The second patch changes the irq handling > when edge type interrupts are

[Linux-zigbee-devel] [PATCH 1/2 v3] at86rf230: add irq type configuration option

2013-04-15 Thread Sascha Herrmann
Add option to at86rf230 platform data to configure the type of the interrupt used by the driver. The irq polarity of the device will be configured accordingly. Signed-off-by: Sascha Herrmann --- drivers/net/ieee802154/at86rf230.c | 47 include/linux/spi/at8

[Linux-zigbee-devel] [PATCH 2/2 v3] at86rf230: change irq handling to prevent lockups with edge type irq

2013-04-15 Thread Sascha Herrmann
Implemented separate irq handling for edge and level type interrupt configuration. For edge type interrupts calls to disable_irq_nosync() and enable_irq() are removed. The at86rf230 resets the irq line only after the irq status register is read. Disabling the irq can lock the driver in situations w

[Linux-zigbee-devel] [PATCH 0/2 v3] changed irq handling for at86rf230

2013-04-15 Thread Sascha Herrmann
Changes to last version: Reordered local variable declarations. The first patch add the option to configure the irq type of the plattform and the device. The second patch changes the irq handling when edge type interrupts are configured. Without irq configuration of the irq type, the driver will