Re: [Linux-zigbee-devel] [PATCH v5] net: mac802154: comparision issue of type cast, finding by EXTRA_CFLAGS=-W

2013-05-01 Thread Chen Gang
On 2013年04月30日 00:29, David Miller wrote: > From: Chen Gang > Date: Thu, 25 Apr 2013 18:49:55 +0800 > >> >> Change MAC802154_CHAN_NONE from ~(u8)0 to 0xff, or the comparison in >> mac802154_wpan_xmit() for ``chan == MAC802154_CHAN_NONE'' will not >> succeed. >> >> This bug can be boiled down to `

[Linux-zigbee-devel] [PATCH v3 2/2] izattach: enable custom baudrate

2013-05-01 Thread Tony Cheneau
Add a "baudrate" parameter on the CLI that enables the user to choose from different baudrates. If no parameter is passed, the baudrate is set to 115200 (retaining the previous behavior). Signed-off-by: Tony Cheneau --- src/serial.c | 105 +++--

[Linux-zigbee-devel] [PATCH v3 0/2] Enable izattach to change the baudrate

2013-05-01 Thread Tony Cheneau
This is a small patch for the izattach (part of the linux-zigbee userspace tools). It enables the user to select the baudrate when communicating with their IEEE 802.15.4 serial device. This is the 3rd version of these patches. Here is the list of changes since the previous version: - add "usage" t

[Linux-zigbee-devel] [PATCH v3 1/2] izattach: remove extra whitespace

2013-05-01 Thread Tony Cheneau
Signed-off-by: Tony Cheneau --- src/serial.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/serial.c b/src/serial.c index 252f3d9..ab76aea 100644 --- a/src/serial.c +++ b/src/serial.c @@ -76,8 +76,8 @@ int main(int argc, char **argv) { tbuf.c_lflag &= ~(ICANO

Re: [Linux-zigbee-devel] [PATCH v2 2/2] izattach: enable custom baudrate

2013-05-01 Thread Tony Cheneau
Hi Alex, Thanks your for your comments. They make plenty of sense. I'll update the patches accordingly. However, I won't change the return values: there might be some scripts that depends on these return values (or it could be that using various return values here makes debugging easier). Regards

Re: [Linux-zigbee-devel] [RFC] at86rf230: add support for platform-specific reset function

2013-05-01 Thread Alexander Aring
Hi Werner, maybe it is better to preserve the current design of platform_data handling on. Look at at86rf230_fill_data function, which copy the platform_data settings to the lp struct. So we should the function pointer to the at86rf230_local, too. Later we should use lp->reset instead of getting

Re: [Linux-zigbee-devel] [RFC] at86rf230: add support for platform-specific reset function

2013-05-01 Thread Sascha Herrmann
Hi Werner, looks ok to me. I applied it to my kernel and things are still working as expected with the default reset handling. Sascha > The AT86RF231-based ATBEN board does not connect the /RST line and > uses power cycling to reset the transceiver. For this, I added a > platform-specific reset