Re: [Linux-zigbee-devel] [PATCHv3 net-next 0/6] 6lowpan: address uncompression fixes

2013-08-16 Thread Alexander Aring
Hi, On Fri, Aug 16, 2013 at 09:59:53PM +0200, Alexander Aring wrote: > The current implementation to uncompress addresses in a 6lowpan header > is completely broken. > > This patch series fixes the parsing of addresses in a 6lowpan header. > It contains a major rewrite of the uncompress address f

[Linux-zigbee-devel] [PATCH net-next 5/6] 6lowpan: lowpan_uncompress_addr with address_mode

2013-08-16 Thread Alexander Aring
This patch drops the pre and postcount calculation from the lowpan_uncompress_addr function.We use instead a switch/case over address_mode value. The original implementation has several bugs in this function and it was hard to decrypt how it works. To make it maintainable and fix these bugs this pa

[Linux-zigbee-devel] [PATCH net-next 1/6] 6lowpan: init ipv6hdr buffer to zero

2013-08-16 Thread Alexander Aring
This patch simplify the handling to set fields inside of struct ipv6hdr to zero. Instead of setting some memory regions with memset to zero we initialize the whole ipv6hdr to zero. This is a simplification for parsing the 6lowpan header for the upcomming patches. Signed-off-by: Alexander Aring R

[Linux-zigbee-devel] [PATCH net-next 6/6] 6lowpan: handle context based source address

2013-08-16 Thread Alexander Aring
Handle context based address when an unspecified address is given. For other context based address we print a warning and drop the packet because we don't support it right now. Signed-off-by: Alexander Aring Reviewed-by: Werner Almesberger --- net/ieee802154/6lowpan.c | 49 +

[Linux-zigbee-devel] [PATCH net-next 2/6] 6lowpan: Fix fragmentation with link-local compressed addresses

2013-08-16 Thread Alexander Aring
From: David Hauweele When a new 6lowpan fragment is received, a skbuff is allocated for the reassembled packet. However when a 6lowpan packet compresses link-local addresses based on link-layer addresses, the processing function relies on the skb mac control block to find the related link-layer a

[Linux-zigbee-devel] [PATCHv3 net-next 0/6] 6lowpan: address uncompression fixes

2013-08-16 Thread Alexander Aring
The current implementation to uncompress addresses in a 6lowpan header is completely broken. This patch series fixes the parsing of addresses in a 6lowpan header. It contains a major rewrite of the uncompress address function to parse the address in a correct way. Tested with the ravenusbstick(co

[Linux-zigbee-devel] [PATCH net-next 3/6] 6lowpan: introduce lowpan_fetch_skb function

2013-08-16 Thread Alexander Aring
This patch adds a helper function to parse the ipv6 header to a 6lowpan header in stream. This function checks first if we can pull data with a specific length from a skb. If this seems to be okay, we copy skb data to a destination pointer and run skb_pull. Signed-off-by: Alexander Aring Reviewe

[Linux-zigbee-devel] [PATCH net-next 4/6] 6lowpan: add function to uncompress multicast addr

2013-08-16 Thread Alexander Aring
Add function to uncompress multicast address. This function split the uncompress function for a multicast address in a seperate function. To uncompress a multicast address is different than a other non-multicasts addresses according to rfc6282. Signed-off-by: Alexander Aring Reviewed-by: Werner