Hi Martin,
On Mon, Sep 15, 2014 at 03:09:54PM +0100, Martin Townsend wrote:
> Currently there are a number of error paths in the lowpan_rcv function that
> free the skb before returning, the patch simplifies the receive path by
> ensuring that the skb is only freed from this function.
>
> Passing
Currently there are a number of error paths in the lowpan_rcv function that
free the skb before returning, the patch simplifies the receive path by
ensuring that the skb is only freed from this function.
Passing the skb from 6lowpan up to the higher layers is not a
function of IPHC. By moving it
This series aims to fix incorrect return values in lowpan_rcv
To achieve this it also refactors the receive path to
1) free skb only from lowpan_rcv and not functions that it calls
2) move skb delivery from IPHC
I have only compile tested the changes for bluetooth as I don't have any HW
availa
Currently there are a number of error paths in the lowpan_rcv function that
free the skb before returning, the patch simplifies the receive path by
ensuring that the skb is only freed from this function.
Passing the skb from 6lowpan up to the higher layers is not a
function of IPHC. By moving it
This series aims to fix incorrect return values in lowpan_rcv
To achieve this it also refactors the receive path to
1) free skb only from lowpan_rcv and not functions that it calls
2) move skb delivery from IPHC
I have only compile tested the changes for bluetooth as I don't have any HW
availa
On Mon, Sep 15, 2014 at 12:08:35PM +0100, Martin Townsend wrote:
> Hi Alex,
>
...
> > Also here that's too broken here. In lowpan_give_skb_to_devices we have
> > mixed errno and NET_RX_SUCCESS for the return variable, we need to
> > clean this up. Maybe just return the NET_RX_SUCCESS|NET_RX_DROP
Hi Alex,
Thanks for the review, I have one question below, when answered I'll respin a
v3 patch.
On 15/09/14 11:13, Alexander Aring wrote:
> Hi Martin,
>
> something is wrong with you mail client. I received the cover letter
> twice one has some wrong reply-to id. Please check this.
I did use gi
On Mon, Sep 15, 2014 at 12:13:31PM +0200, Alexander Aring wrote:
...
>
> > if (ret == 1) {
> > - ret = process_data(skb, &hdr);
> > - if (ret == NET_RX_DROP)
> > + ret = process_data(&skb, &hdr);
> >
Hi Martin,
something is wrong with you mail client. I received the cover letter
twice one has some wrong reply-to id. Please check this.
Do you use git send-email? How, maybe we can help you there.
On Fri, Sep 12, 2014 at 10:34:40AM +0100, Martin Townsend wrote:
> Currently there are a number of