Re: [Linux-zigbee-devel] [PATCH 02/14] 6lowpan: fix magic number

2013-07-24 Thread Alexander Aring
Hi Werner, On Wed, Jul 24, 2013 at 10:17:51AM -0300, Werner Almesberger wrote: > Alexander Aring wrote: > > - memcpy(&(sa.hwaddr), saddr, 8); > > + memcpy(&(sa.hwaddr), saddr, IEEE802154_ADDR_LEN); > > Nice. While we're at it, we don't need parentheses around sa.hwaddr. > Tha

Re: [Linux-zigbee-devel] [PATCH 02/14] 6lowpan: fix magic number

2013-07-24 Thread Werner Almesberger
Alexander Aring wrote: > - memcpy(&(sa.hwaddr), saddr, 8); > + memcpy(&(sa.hwaddr), saddr, IEEE802154_ADDR_LEN); Nice. While we're at it, we don't need parentheses around sa.hwaddr. - Werner -- Se

[Linux-zigbee-devel] [PATCH 02/14] 6lowpan: fix magic number

2013-07-24 Thread Alexander Aring
Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 1ec14ef..90b9b90 100644 --- a/net/ieee802154/6lowpan.c +++ b/net/ieee802154/6lowpan.c @@ -589,7 +589,7 @@ stati