Re: [Linux-zigbee-devel] [PATCH net-next 07/12] 6lowpan: cleanup lowpan netdev setup

2013-10-24 Thread Werner Almesberger
Alexander Aring wrote: > ok, I remove this patch from current series. It's not necessary to add > this now. It's a minor detail, you don't have to pull the patch for it. Just though I'd mention it. - Werner -- October We

Re: [Linux-zigbee-devel] [PATCH net-next 07/12] 6lowpan: cleanup lowpan netdev setup

2013-10-24 Thread Alexander Aring
Hi Werner, On Thu, Oct 24, 2013 at 09:50:44AM -0300, Werner Almesberger wrote: > Alexander Aring wrote: > > - dev->needed_tailroom= 2; /* FCS */ > > + dev->needed_tailroom= IEEE802154_MFR_SIZE; > > Looking at include/net/ieee802154.h > > /* MAC footer size */ > #define IEEE802154

Re: [Linux-zigbee-devel] [PATCH net-next 07/12] 6lowpan: cleanup lowpan netdev setup

2013-10-24 Thread Werner Almesberger
Alexander Aring wrote: > - dev->needed_tailroom= 2; /* FCS */ > + dev->needed_tailroom= IEEE802154_MFR_SIZE; Looking at include/net/ieee802154.h /* MAC footer size */ #define IEEE802154_MFR_SIZE 2 /* 2 octets */ we "lose" the information that MFR is the FCS. You may want

[Linux-zigbee-devel] [PATCH net-next 07/12] 6lowpan: cleanup lowpan netdev setup

2013-10-22 Thread Alexander Aring
This patch replaces a redundant open-coded calculation with the already defined MAC802154_FRAME_HARD_HEADER_LEN. Also replace a magic number with the already defined IEEE802154_MFR_SIZE. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 d