Re: [Linux-zigbee-devel] [PATCH net-next 4/6] 6lowpan: fix fragmentation

2014-05-14 Thread Phoebe Buckheister
On Wed, 14 May 2014 17:56:57 +0200 Alexander Aring wrote: > > + > > + frag = alloc_skb(real_dev->hard_header_len + > > +real_dev->needed_tailroom + size, > > +GFP_ATOMIC); > > Why not keep netdev_alloc_skb for the real_dev? > > But then we need to use d

Re: [Linux-zigbee-devel] [PATCH net-next 4/6] 6lowpan: fix fragmentation

2014-05-14 Thread Alexander Aring
Hi Phoebe, that's a nice solution for the DSN increment on fragmentation. This stands long time on my ToDo list and you did a very nice solution. Thanks. :-) On Wed, May 14, 2014 at 05:43:09PM +0200, Phoebe Buckheister wrote: > Currently, 6lowpan creates one 802.15.4 MAC header for the original

[Linux-zigbee-devel] [PATCH net-next 4/6] 6lowpan: fix fragmentation

2014-05-14 Thread Phoebe Buckheister
Currently, 6lowpan creates one 802.15.4 MAC header for the original packet the device was given by upper layers and reuses this header for all fragments, if fragmentation is required. This also reuses frame sequence numbers, which must not happen. 6lowpan also has issues with fragmentation in the p