Re: [Linux-zigbee-devel] [PATCH v4 bluetooth] Fix lowpan_rcv

2014-10-02 Thread Martin Townsend
Hi Jukka, Very bizarre that the patch causes a locking issue in the Tx path. Is it a side effect from not cloning the skb before calling process_data. I couldn't see why a clone was being made so maybe I'm missing something here. - Martin. On 02/10/14 14:55, Jukka Rissanen wrote: > Hi Mart

Re: [Linux-zigbee-devel] [PATCH v4 bluetooth] Fix lowpan_rcv

2014-10-02 Thread Jukka Rissanen
Hi Martin, On to, 2014-10-02 at 13:16 +0100, Martin Townsend wrote: > Hi Jukka, > > Thanks for investigating this. > > If you set the dev in your receive function does the oops go away, BTW this > is where the pkt_type is set to PACKET_HOST, for us this was causing > problems, I don't know i

Re: [Linux-zigbee-devel] [PATCH v4 bluetooth] Fix lowpan_rcv

2014-10-02 Thread Martin Townsend
Hi Jukka, Thanks for investigating this. If you set the dev in your receive function does the oops go away, BTW this is where the pkt_type is set to PACKET_HOST, for us this was causing problems, I don't know if this is the same for you guys. Here's the code: local_skb->protocol

Re: [Linux-zigbee-devel] [PATCH v4 bluetooth] Fix lowpan_rcv

2014-10-02 Thread Jukka Rissanen
Hi Martin, On ke, 2014-10-01 at 16:24 +0100, Martin Townsend wrote: > Hi Jukka, > > I spotted one thing in recv_pkt when skb_copy_expand fails it should goto > drop but this is not what you are seeing. This also exists in 6lowpan_rtnl.c > so I will fix this in both for the next patch. > > I w

Re: [Linux-zigbee-devel] [PATCH v4 bluetooth] Fix lowpan_rcv

2014-10-01 Thread Martin Townsend
Hi Jukka, I spotted one thing in recv_pkt when skb_copy_expand fails it should goto drop but this is not what you are seeing. This also exists in 6lowpan_rtnl.c so I will fix this in both for the next patch. I would be interested to know if the 802.15.4 wireless guys are seeing this to narrow

Re: [Linux-zigbee-devel] [PATCH v4 bluetooth] Fix lowpan_rcv

2014-10-01 Thread Jukka Rissanen
Hi Martin, just in case add me to cc: next time so I do not miss these 6lowpan patches. On ke, 2014-10-01 at 13:10 +0100, Martin Townsend wrote: > This series aims to fix incorrect return values in lowpan_rcv > To achieve this it also refactors the receive path to > 1) free skb only from lowpan

[Linux-zigbee-devel] [PATCH v4 bluetooth] Fix lowpan_rcv

2014-10-01 Thread Martin Townsend
This series aims to fix incorrect return values in lowpan_rcv To achieve this it also refactors the receive path to 1) free skb only from lowpan_rcv and not functions that it calls 2) move skb delivery from IPHC I have only compile tested the changes for bluetooth as I don't have any HW availa

[Linux-zigbee-devel] [PATCH v4 bluetooth] Fix lowpan_rcv

2014-09-16 Thread Martin Townsend
This series aims to fix incorrect return values in lowpan_rcv To achieve this it also refactors the receive path to 1) free skb only from lowpan_rcv and not functions that it calls 2) move skb delivery from IPHC I have only compile tested the changes for bluetooth as I don't have any HW availa