Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-04-04 Thread Tony Cheneau
Hi Robert, Thanks for your comment, I knew someone would raise that point. Allow me clarify things a little (in no particular order): - I wanted an implementation of RPL that could run on Linux that that I could turn a Linux box into a 6LoWPAN border router. There was no such implementation, so

Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-04-04 Thread Markus Becker
Hi, some time ago I started porting Contiki's RPL implementation to Linux. Because of the same Contiki/linux-154 interop issues mentioned below, I stopped progressing further. The current state of it is, that it compiles with some most likely necessary stuff commented out. The repository is at

Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-04-04 Thread Ralph Droms (rdroms)
I've seen several mentions of Contiki-Linux interoperability issues. I have some preliminary fixes for address compression and fragletting, which seem to work OK when tested against a couple of (fairly old) Contiki builds. Would anyone be interesting in testing these fixes if I publish a few p

Re: [Linux-zigbee-devel] [RFC PATCH] ieee802154/nl-mac.c: make some MLME operations optional

2013-04-04 Thread Alan Ott
On 03/31/2013 12:18 PM, Werner Almesberger wrote: > This makes documented use of "struct ieee802154_mlme_ops" follow current > use, in which some operations are regularly left out, making them NULL. > Since the calls do not check for NULL, any attempted use causes an oops. > > This patch makes the

Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-04-04 Thread Tony Cheneau
Hi Ralph, I would *definitely* test your patches if you were to release them. Regards, Tony Le 2013-04-04 17:19, Ralph Droms (rdroms) a écrit : > I've seen several mentions of Contiki-Linux interoperability issues. > I have some preliminary fixes for address compression and > fragletting, > whi

Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-04-04 Thread Ralph Droms (rdroms)
OK. I'll try to get them out later today. - Ralph On Apr 4, 2013, at 11:38 AM 4/4/13, Tony Cheneau wrote: > Hi Ralph, > > I would *definitely* test your patches if you were to release them. > > Regards, > Tony > > Le 2013-04-04 17:19, Ralph Droms (rdroms) a écrit : >> I've seen several men

Re: [Linux-zigbee-devel] Announcing the first public release of SimpleRPL

2013-04-04 Thread Tony Cheneau
Hi Markus, I'd be very interested if you had any thoughts on retrieving the link quality metrics. My understanding is that Contiki uses it for its Objective Function (both OF0 and ETX). In my SimpleRPL, I don't retrieve anything for now, because I haven't figured out a proper way to pass it to

Re: [Linux-zigbee-devel] [RFC PATCH] ieee802154/nl-mac.c: make some MLME operations optional

2013-04-04 Thread Werner Almesberger
Alan Ott wrote: > Maybe make it clear that this fixes a current oops in the kernel. Maybe > some text like the following: Thanks ! I'll clarify the wording and send it to netdev. - Werner -- Minimize network downtime and

[Linux-zigbee-devel] [PATCH net-next 0/2] ieee802154_mlme_ops oops removal and cleanup

2013-04-04 Thread Werner Almesberger
This fixes a kernel oops we get when some linux-zigbee user space tools try to invoke unimplemented operations. The second of the two patches checks whether the respective functions are present and returne EOPNOTSUPP if they aren't. It also updates the documentation. The first one removes the unu

[Linux-zigbee-devel] [PATCH net-next 1/2] IEEE 802.15.4: remove get_bsn from "struct ieee802154_mlme_ops"

2013-04-04 Thread Werner Almesberger
It served no purpose: we never call it from anywhere in the stack and the only driver that did implement it (fakehard) merely provided a dummy value. There is also considerable doubt whether it would make sense to even attempt beacon processing at this level in the Linux kernel. Signed-off-by: We

[Linux-zigbee-devel] [PATCH net-next 2/2] ieee802154/nl-mac.c: make some MLME operations optional

2013-04-04 Thread Werner Almesberger
Check for NULL before calling the following operations from "struct ieee802154_mlme_ops": assoc_req, assoc_resp, disassoc_req, start_req, and scan_req. This fixes a current oops where those functions are called but not implemented. It also updates the documentation to clarify that they are now opt

[Linux-zigbee-devel] [PATCH 0/2] changed irq handling and some cleanup for at86rf230

2013-04-04 Thread Sascha Herrmann
The first patch contains some cleanup for the at86rf230 driver. The second patch changes the irq handling of the driver to avoid a lockup caused by the irq handling of the driver. Sascha Herrmann (2): at86rf230: remove unnecessary / dead code at86rf230: change irq handling to prevent lockups w

[Linux-zigbee-devel] [PATCH 1/2] at86rf230: remove unnecessary / dead code

2013-04-04 Thread Sascha Herrmann
In at86rf230_probe() lp was first set to dev->priv and a few lines later dev->priv was set to lp again, without changing lp in between. The call to ieee802154_unregister_device() before err_irq: was unreachable. Signed-off-by: Sascha Herrmann --- drivers/net/ieee802154/at86rf230.c |2 -- 1 f

[Linux-zigbee-devel] [PATCH 2/2] at86rf230: change irq handling to prevent lockups with edge type irq

2013-04-04 Thread Sascha Herrmann
Hard code the interrupt type of the at86rf230 to rising edge type and remove the calls to disable_irq_nosync() and enable_irq() from the isr and the irqwork function. The at86rf230 resets the irq line only after the irq status register is read. Disabling the irq can lock the driver in situations wh

Re: [Linux-zigbee-devel] [PATCH 2/2] at86rf230: change irq handling to prevent lockups with edge type irq

2013-04-04 Thread Werner Almesberger
Sascha Herrmann wrote: > - rc = request_irq(spi->irq, at86rf230_isr, IRQF_SHARED, > + rc = request_irq(spi->irq, at86rf230_isr, > + IRQF_SHARED | IRQF_TRIGGER_RISING, To clarify the purpose of your patch, I think it's only needed for platforms that don't support level-