Hi,
On Mon, Oct 14, 2013 at 09:07:03PM -0300, Werner Almesberger wrote:
> Alexander Aring wrote:
> > This patch drops the directly memcpy on skb and uses the right skb
> > memcpy functions. Also remove an unnecessary check if plen is non zero.
>
> The memcpys actually looked a little easier :-) B
On Mon, Oct 14, 2013 at 09:11:12PM -0300, Werner Almesberger wrote:
> Alexander Aring wrote:
> > Since we drop the skb copies, we don't need this function.
>
> ... and you get rid of a potential (?) compiler warning:
>
no it's still used.
It's not a static inline function so maybe we save a func
Alexander Aring wrote:
> I will notice the point that:
>
> skb_copy_from_linear_data_offset(skb, offset + mlen,
> skb_put(frag, plen), plen);
>
> is change to:
Yes, I saw this. When I first spotted it, I was hopeful that you may
simply have changed the *_fro
Alexander Aring wrote:
> no it's still used.
> It's not a static inline function so maybe we save a function call.
I mean that, after 03/17, "stat" wasn't used anywhere in
lowpan_skb_deliver, which should produce a warning. Thinking of
it, you should delete "stat" already in 03/17.
- Werner
On Tue, Oct 15, 2013 at 06:49:00AM -0300, Werner Almesberger wrote:
> Alexander Aring wrote:
> > no it's still used.
> > It's not a static inline function so maybe we save a function call.
>
> I mean that, after 03/17, "stat" wasn't used anywhere in
ah okay, maybe I just recompile on each patch in
