On Tue, 25 Feb 2014 22:38:29 -0700
Jean Sacren wrote:
> The commit 8fad346f366a7 ("eee802154: add basic support for RF212 to
> at86rf230 driver") introduced the new function is_rf212() with some
> minor issues in declaration:
>
> 1) Fix the function type by changing it to bool as the function
>
Hi,
this patch series reimplementation the fragmentation handling of 6lowpan
accroding to rfc4944 [1].
The first big note is, that the current fragmentation behaviour isn't rfc
complaint. The main issue is a wrong datagram_size value which needs to be:
datagram_size = ipv6_payload + ipv6 header +
This patch fix the fragmentation on sending side according to rfc4944.
Also add improvement to use the full payload of a PDU which calculate
the nearest divided to 8 payload length for the fragmentation datagram
size attribute.
The main issue is that the datagram size of fragmentation header use
Signed-off-by: Alexander Aring
---
net/ieee802154/6lowpan.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
index 872c8f9..6b7d17f 100644
--- a/net/ieee802154/6lowpan.c
+++ b/net/ieee802154/6lowpan.c
@@ -68,7 +68,7 @@ st
This patch adds a 6lowpan fragmentation struct into cb of skb which
is necessary to hold fragmentation information.
Signed-off-by: Alexander Aring
---
include/net/ieee802154_netdev.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/net/ieee802154_netdev.h b/include/net/ieee8021
Signed-off-by: Alexander Aring
---
net/ieee802154/6lowpan.h | 116 +++
1 file changed, 116 insertions(+)
diff --git a/net/ieee802154/6lowpan.h b/net/ieee802154/6lowpan.h
index 2b835db..b6ae0bc 100644
--- a/net/ieee802154/6lowpan.h
+++ b/net/ieee802154/
This patch drops the current way of 6lowpan fragmentation on receiving
side and replace it with a implementation which use the inet_frag api.
The old fragmentation handling has some race conditions and isn't
rfc4944 compatible. Also adding support to match fragments on
destination and source addres
Detected with:
./scripts/checkpatch.pl --strict -f net/ieee802154/6lowpan_rtnl.c
Signed-off-by: Alexander Aring
---
net/ieee802154/6lowpan_rtnl.c | 27 +--
1 file changed, 9 insertions(+), 18 deletions(-)
diff --git a/net/ieee802154/6lowpan_rtnl.c b/net/ieee802154/6lowp
We have a 6lowpan.c file and 6lowpan.ko file. To avoid confusing we
should move 6lowpan.c to 6lowpan_rtnl.c. Then we can support multiple
source files for 6lowpan module.
Signed-off-by: Alexander Aring
---
net/ieee802154/{6lowpan.c => 6lowpan_rtnl.c} | 0
net/ieee802154/Makefile
This patch adds necessary ieee802154 6lowpan namespace to provide the
inet_frag information. This is a initial support for handling 6lowpan
fragmentation with the inet_frag api.
Signed-off-by: Alexander Aring
---
include/net/net_namespace.h| 4
include/net/netns/ieee802154_6low
Hi David,
thanks for your reply.
On Wed, Feb 26, 2014 at 04:10:05PM +, David Laight wrote:
> From: Alexander Aring
> > Signed-off-by: Alexander Aring
> > ---
> > net/ieee802154/6lowpan.h | 116
> > +++
> > 1 file changed, 116 insertions(+)
> >
>
On Wed, 2014-02-26 at 17:05 +0100, Alexander Aring wrote:
> Detected with:
>
> ./scripts/checkpatch.pl --strict -f net/ieee802154/6lowpan_rtnl.c
Hello Alexander.
Can I suggest to you (and to David) that the
multiline comment style:
/*
* comment
*/
is fine and doesn't need correcting here at
On Wed, 2014-02-26 at 16:10 +, David Laight wrote:
> From: Alexander Aring
[]
> > diff --git a/net/ieee802154/6lowpan.h b/net/ieee802154/6lowpan.h
[]
> > +static inline u8 lowpan_addr_mode_size(const u8 addr_mode)
> > +{
> > + switch (addr_mode) {
> > + case LOWPAN_IPHC_ADDR_00:
> > +
On Wed, Feb 26, 2014 at 10:24:45AM -0800, Joe Perches wrote:
> On Wed, 2014-02-26 at 16:10 +, David Laight wrote:
> > From: Alexander Aring
> []
> > > diff --git a/net/ieee802154/6lowpan.h b/net/ieee802154/6lowpan.h
> []
> > > +static inline u8 lowpan_addr_mode_size(const u8 addr_mode)
> > > +{
On Wed, 2014-02-26 at 19:32 +0100, Alexander Aring wrote:
> On Wed, Feb 26, 2014 at 10:24:45AM -0800, Joe Perches wrote:
[]
> > Perhaps the compiler would inline the assignment
> > anyway if addr_mode is __builtin_constant_p
[]
> I am not sure what I should do now, change or not change? :-)
Whatev
From: David Laight
Date: Wed, 26 Feb 2014 16:10:05 +
> From: Alexander Aring
>> Signed-off-by: Alexander Aring
>> ---
>> net/ieee802154/6lowpan.h | 116
>> +++
>> 1 file changed, 116 insertions(+)
>>
>> diff --git a/net/ieee802154/6lowpan.h b/ne
From: Joe Perches
Date: Wed, 26 Feb 2014 09:24:56 -0800
> On Wed, 2014-02-26 at 17:05 +0100, Alexander Aring wrote:
>> Detected with:
>>
>> ./scripts/checkpatch.pl --strict -f net/ieee802154/6lowpan_rtnl.c
>
> Hello Alexander.
>
> Can I suggest to you (and to David) that the
> multiline commen
From: Jean Sacren
Date: Tue, 25 Feb 2014 22:38:29 -0700
> The commit 8fad346f366a7 ("eee802154: add basic support for RF212 to
> at86rf230 driver") introduced the new function is_rf212() with some
> minor issues in declaration:
>
> 1) Fix the function type by changing it to bool as the function
18 matches
Mail list logo
