While transmit over a at86rf231 device and unloading the module I got:
[ 29.643073] WARNING: CPU: 0 PID: 3 at kernel/workqueue.c:1335
__queue_work+0xb4/0x224()
[ 29.651457] Modules linked in: at86rf230(-) autofs4
[ 29.656612] CPU: 0 PID: 3 Comm: ksoftirqd/0 Tainted: GW
3.14.0-rc
This patch puts a buffer on the stack instead of heap. There is no need
to hold the buffer on the heap.
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/ne
This patch replace request_irq with devm_request_irq. With
devm_request_irq we don't need to care about freeing the irq.
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ieee802154/at
Signed-off-by: Alexander Aring
Reported-by: Varka Bhadram
---
drivers/net/ieee802154/at86rf230.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/net/ieee802154/at86rf230.c
index 6658e58..f7715c3 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++
This patch removes the pr_* functions and replace it with the dev_*
print functions.
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/net/ieee802154/at8
Currently the at86rf230 have one spinlock for two variables is_tx and
is_busy. The current one spinlock are for these variables which are
undependency. This patch splits the spinlock in tx_lock and busy_lock.
These spinlocks have some different contexts, the busy_lock is used in a
interrupt context
This patch resets the irq line before we are requesting the irq. This
avoids old interrupts.
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/net/ieee802
This patch replace the gpio_request functions with devm_gpio_request_one
functions. Then we don't need to take care about freeing gpios.
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 53 +-
1 file changed, 12 insertions(+), 41 deletio
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/net/ieee802154/at86rf230.c
index bc9dd10..125da90 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drive
We don't need to set these values at request_irq. The interrupt line is
already configured to same value like irq_get_trigger_type returned.
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/iee
This patch adds devicetree bindings for the at86rf230 IEEE 802.15.4 SPI
device driver.
Signed-off-by: Alexander Aring
---
.../bindings/net/ieee802154/at86rf230.txt | 23 ++
1 file changed, 23 insertions(+)
create mode 100644
Documentation/devicetree/bindings/net/ie
This patch removes the platform data for the irq_type. We use instead
the irq_get_trigger_type function to get these flags which should
already configured by the interrupt controller.
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 28
include
This patch adds a at86rf230_device_id table to offers various module
aliases.
Signed-off-by: Alexander Aring
Reported-by: Varka Bhadram
---
drivers/net/ieee802154/at86rf230.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/net/ieee80
Hi,
second try after I fixed the at86rf230 unloading bug in net.
I will send this series in the next 24h to net-next, please review.
- Alex
Alexander Aring (15):
at86rf230: use dev_* print functions
at86rf230: use irq_get_trigger_type
at86rf230: remove irq_type in request_irq
at86rf230:
Signed-off-by: Alexander Aring
Reported-by: Varka Bhadram
---
drivers/net/ieee802154/at86rf230.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/net/ieee802154/at86rf230.c
index f7715c3..6afce6e 100644
--- a/drivers/net/ieee802154
This is already handled by the of_match_ptr macro.
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/net/ieee802154/at86rf230.c
index 694facb..bc9dd10 100644
--- a/drivers/net/i
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/net/ieee802154/at86rf230.c
index 39cdc09..3679183 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at8
17 matches
Mail list logo