On Thu, 2014-04-17 at 18:22 -0700, Luis R. Rodriguez wrote:
> +#if IS_ENABLED(CONFIG_IEEE802154_6LOWPAN)
> [...]
> +#else
> +static inline struct netns_ieee802154_lowpan *
> +net_ieee802154_lowpan(struct net *net)
> +{
> + return NULL;
> +}
> +#endif
Why would that be needed? If nobody compil
We don't need to set these values at request_irq. The interrupt line is
already configured to same value like irq_get_trigger_type returned.
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/iee
This patch replace the gpio_request functions with devm_gpio_request_one
functions. Then we don't need to take care about freeing gpios.
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 53 +-
1 file changed, 12 insertions(+), 41 deletio
This patch resets the irq line before we are requesting the irq. This
avoids pending interrupts before requesting.
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ieee802154/at86rf230.c
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/net/ieee802154/at86rf230.c
index 46d992a..41c3384 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/n
This patch puts a buffer on the stack instead of heap. There is no need
to hold the buffer on the heap.
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/ne
This patch removes a unnecessary state read. The status value is never
evaluate after reading the state.
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/net/ieee802154/at86r
This is already handled by the of_match_ptr macro.
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/net/ieee802154/at86rf230.c
index cf376c4..b324bb3 100644
--- a/drivers/net/i
This patch adds a at86rf230_device_id table to offers various module
aliases.
Signed-off-by: Alexander Aring
Reported-by: Varka Bhadram
---
drivers/net/ieee802154/at86rf230.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/net/ieee80
This patch adds devicetree bindings for the at86rf230 IEEE 802.15.4 SPI
device driver.
Signed-off-by: Alexander Aring
---
.../bindings/net/ieee802154/at86rf230.txt | 23 ++
1 file changed, 23 insertions(+)
create mode 100644
Documentation/devicetree/bindings/net/ie
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/net/ieee802154/at86rf230.c
index b324bb3..960444b 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drive
The function is small enough, we don't need a extra function for this.
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/net/ieee802154/at86rf230.c
index 6e
Hi,
this is the first patch series to cleanup the at86rf230 driver. Later I want
to implement regmap and a asynchron spi handling for transmit and receiving
frames.
If all seems fine I will send these patches to net-next tomorrow.
- Alex
Alexander Aring (15):
at86rf230: use irq_get_trigger_ty
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/net/ieee802154/at86rf230.c
index d1fca56..5079036 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at8
This patch replace request_irq with devm_request_irq. With
devm_request_irq we don't need to care about freeing the irq.
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ieee802154/at
Signed-off-by: Alexander Aring
Reported-by: Varka Bhadram
---
drivers/net/ieee802154/at86rf230.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ieee802154/at86rf230.c
b/drivers/net/ieee802154/at86rf230.c
index d52700f..46d992a 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++
This patch removes the platform data for the irq_type. We use instead
the irq_get_trigger_type function to get these flags which should
already configured by the interrupt controller.
Signed-off-by: Alexander Aring
---
drivers/net/ieee802154/at86rf230.c | 28
include
From: "Luis R. Rodriguez"
Johannes noted this is not needed, all of the fragment
accessors don't need CONFIG_NET_NS. This goes test compiled with
CONFIG_BT_6LOWPAN=y and a disabled CONFIG_NET_NS.
CC: Alexander Smirnov
Cc: Dmitry Eremin-Solenikov
Cc: linux-zigbee-devel@lists.sourceforge.net
Cc:
On Tue, Apr 22, 2014 at 11:45 AM, Johannes Berg
wrote:
> On Tue, 2014-04-22 at 19:58 +0200, Luis R. Rodriguez wrote:
>
>> > > > +#if IS_ENABLED(CONFIG_IEEE802154_6LOWPAN)
>> > > > [...]
>> > > > +#else
>> > > > +static inline struct netns_ieee802154_lowpan *
>> > > > +net_ieee802154_lowpan(struct
On Tue, Apr 22, 2014 at 11:49 AM, Alexander Aring wrote:
> On Tue, Apr 22, 2014 at 08:45:15PM +0200, Johannes Berg wrote:
>> On Tue, 2014-04-22 at 19:58 +0200, Luis R. Rodriguez wrote:
>>
>> > > > > +#if IS_ENABLED(CONFIG_IEEE802154_6LOWPAN)
>> > > > > [...]
>> > > > > +#else
>> > > > > +static in
On Tue, April 22, 2014 8:55 pm, Alexander Aring wrote:
> This patch puts a buffer on the stack instead of heap. There is no need
> to hold the buffer on the heap.
I put that there because I was told that heap memory is DMA safe, while
stack memory need not be. If you intend to change that back to
On Tue, Apr 22, 2014 at 10:13:40PM +0200, Phoebe Buckheister wrote:
> On Tue, April 22, 2014 8:55 pm, Alexander Aring wrote:
> > This patch puts a buffer on the stack instead of heap. There is no need
> > to hold the buffer on the heap.
>
> I put that there because I was told that heap memory is D
22 matches
Mail list logo
