Re: [Linux-zigbee-devel] [PATCH net-next] ieee802154: use helper function to get rid of redundancy

2014-06-01 Thread Alexander Aring
Hi Jean, the at86rf230 driver supports several at86rf2xx chips. You split the at86rf212_set_channel which is at86rf212 specific in two function which are named at86rf230_foo. Sorry, but I think we should not do this. One reason is that the code is much easier to read when we have one channel_set

Re: [Linux-zigbee-devel] [PATCH net-next] ieee802154: use helper function to get rid of redundancy

2014-06-01 Thread Alexander Aring
Hi, On Sun, Jun 01, 2014 at 08:23:17AM -0600, Jean Sacren wrote: > From: Alexander Aring > Date: Sun, 01 Jun 2014 09:26:57 +0200 > > Hi Alex, > > Thank you very much for the feedback. > > > the at86rf230 driver supports several at86rf2xx chips. You split the > > at86rf212_set_channel which is

Re: [Linux-zigbee-devel] [PATCH net-next] ieee802154: use helper function to get rid of redundancy

2014-06-01 Thread Alexander Aring
On Sun, Jun 01, 2014 at 09:35:47AM -0600, Jean Sacren wrote: > From: Alexander Aring > Date: Sun, 01 Jun 2014 16:35:53 +0200 > > > > Hi, > > > > On Sun, Jun 01, 2014 at 08:23:17AM -0600, Jean Sacren wrote: > > > From: Alexander Aring > > > Date: Sun, 01 Jun 2014 09:26:57 +0200 > > > > > > Hi Al