Re: [Linux-zigbee-devel] [PATCH 0/2] linux-wpan-next: lowpan_rcv - skb is freed within function and fix return values.

2014-07-30 Thread Martin Townsend
Hi Alex, Any thoughts on this patch series? My next patch series depends on this one :) - Martin. On 17/07/14 15:33, Martin Townsend wrote: > Currently it is up to the functions below lowpan_rcv to free the skb on error > conditions. This patch now removes all the UAPI error codes and pro

Re: [Linux-zigbee-devel] [PATCH 0/2] linux-wpan-next: lowpan_rcv - skb is freed within function and fix return values.

2014-07-30 Thread Alexander Aring
Hi Martin, On Wed, Jul 30, 2014 at 02:38:02PM +0100, Martin Townsend wrote: > Hi Alex, > > Any thoughts on this patch series? My next patch series depends on this one > :) > I don't get any patches for this. Maybe the patch size hits some limits for this mailinglist and filter the mail. Did yo

Re: [Linux-zigbee-devel] [PATCH 0/2] linux-wpan-next: lowpan_rcv - skb is freed within function and fix return values.

2014-07-30 Thread Martin Townsend
Hi Alex, I didn't get any failed response, I'll try and send again. - Martin. On 30/07/14 15:46, Alexander Aring wrote: > Hi Martin, > > On Wed, Jul 30, 2014 at 02:38:02PM +0100, Martin Townsend wrote: >> Hi Alex, >> >> Any thoughts on this patch series? My next patch series depends on this one

Re: [Linux-zigbee-devel] [PATCH 0/2] linux-wpan-next: lowpan_rcv - skb is freed within function and fix return values.

2014-07-30 Thread Alexander Aring
On Wed, Jul 30, 2014 at 03:48:51PM +0100, Martin Townsend wrote: > Hi Alex, > > I didn't get any failed response, I'll try and send again. > mh, okay. > - Martin. > > On 30/07/14 15:46, Alexander Aring wrote: > > Hi Martin, > > > > On Wed, Jul 30, 2014 at 02:38:02PM +0100, Martin Townsend wrot

[Linux-zigbee-devel] [PATCH 0/2] linux-wpan-next: lowpan_rcv - skb is freed within function and fix return values.

2014-07-30 Thread Martin Townsend
Currently it is up to the functions below lowpan_rcv to free the skb on error conditions. This patch now removes all the UAPI error codes and process data now returns -1 if there is a problem. In this scenario lowpan_rcv will free the skb and return NET_RX_DROP. This also fixes the

[Linux-zigbee-devel] [PATCH 2/2] Change lowpan_rcv so skb is freed within function and fix return values.

2014-07-30 Thread Martin Townsend
Currently it is up to the functions below lowpan_rcv to free the skb on error conditions. This patch now removes all the UAPI error codes and process data now returns -1 if there is a problem. In this scenario lowpan_rcv will free the skb and return NET_RX_DROP. This also fixes the problem where

[Linux-zigbee-devel] [PATCH 1/2] Remove dev parameter from skb_delivery_cb in 6lowpan.

2014-07-30 Thread Martin Townsend
This parameter is never used by any functions that are passed to lowpan_process_data which uses this callback. Signed-off-by: Martin Townsend --- include/net/6lowpan.h | 2 +- net/6lowpan/iphc.c| 2 +- net/bluetooth/6lowpan.c | 4 ++-- net/ieee802154/6lowpan_rtnl.c | 5

Re: [Linux-zigbee-devel] [PATCH 0/2] linux-wpan-next: lowpan_rcv - skb is freed within function and fix return values.

2014-07-30 Thread Marcel Holtmann
Hi Martin, > Currently it is up to the functions below lowpan_rcv to free the skb on error >conditions. This patch now removes all the UAPI error codes and process > data >now returns -1 if there is a problem. In this scenario lowpan_rcv will > free >the skb and return NET_RX_DROP.

Re: [Linux-zigbee-devel] [PATCH 0/2] linux-wpan-next: lowpan_rcv - skb is freed within function and fix return values.

2014-07-30 Thread Alexander Aring
Hi Marcel, On Wed, Jul 30, 2014 at 10:42:09AM -0700, Marcel Holtmann wrote: > Hi Martin, > > > Currently it is up to the functions below lowpan_rcv to free the skb on > > error > >conditions. This patch now removes all the UAPI error codes and process > > data > >now returns -1 if ther

Re: [Linux-zigbee-devel] [PATCH 0/2] linux-wpan-next: lowpan_rcv - skb is freed within function and fix return values.

2014-07-30 Thread Marcel Holtmann
Hi Alex, >>> Currently it is up to the functions below lowpan_rcv to free the skb on >>> error >>> conditions. This patch now removes all the UAPI error codes and process >>> data >>> now returns -1 if there is a problem. In this scenario lowpan_rcv will >>> free >>> the skb and return

Re: [Linux-zigbee-devel] [PATCH 1/2] Remove dev parameter from skb_delivery_cb in 6lowpan.

2014-07-30 Thread Alexander Aring
Hi Martin, this patch looks good, simple rebase it on bluetooth-next. You could do: git remote add bluetooth-next git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git git checkout bluetooth-next/master then git cherry-pick $COMMIT_ID to get the necessary commits from oth

Re: [Linux-zigbee-devel] [PATCH 2/2] Change lowpan_rcv so skb is freed within function and fix return values.

2014-07-30 Thread Alexander Aring
Hi Martin, I agree about the issue, we talked a lot time before about this. But I would not complete remove the errno numbers. The basic issue is that that mixed function can return errno or NET_RX_DROP/NET_RX_SUCCESS and we need to decide if we use NET_RX_DROP/NET_RX_SUCCESS only or using errno'

Re: [Linux-zigbee-devel] [PATCH 2/2] Change lowpan_rcv so skb is freed within function and fix return values.

2014-07-30 Thread Alexander Aring
On Thu, Jul 31, 2014 at 07:54:27AM +0200, Alexander Aring wrote: ... > > > > raw_dump_inline(NULL, > > @@ -179,10 +179,10 @@ static int skb_deliver(struct sk_buff *skb, struct > > ipv6hdr *hdr, > > > > new = skb_copy_expand(skb, sizeof(struct ipv6hdr), > > skb