Re: Device Tree updates for xilinx.

2007-12-16 Thread David Gibson
On Thu, Dec 13, 2007 at 03:41:16PM -0800, Stephen Neuendorffer wrote: These patches synchronize all the in-kernel drivers to use the compatible names generated by the UBoot BSP generator. (at git://git.xilinx.com/gen-mhs-devtree.git) The patches to make this work are coming shortly:

Re: [PATCH 1/3] [libata] pata_platform: make probe and remove functions device type neutral

2007-12-16 Thread Paul Mundt
On Fri, Dec 14, 2007 at 09:24:29PM +0300, Anton Vorontsov wrote: Split pata_platform_{probe,remove} into two pieces: 1. pata_platform_{probe,remove} -- platform_device-dependant bits; 2. __ptata_platform_{probe,remove} -- device type neutral bits. This is done to not duplicate code for the

Re: Device Tree updates for xilinx.

2007-12-16 Thread Josh Boyer
On Sun, 16 Dec 2007 18:04:04 +1100 David Gibson [EMAIL PROTECTED] wrote: cpus { #address-cells = 1; #cpus = 1; #size-cells = 0; PowerPC,[EMAIL PROTECTED] { I'm trying to encourage people to move to naming cpu nodes simply [EMAIL

Re: [PATCH] [POWERPC] 4xx: Add aliases node to 4xx dts files

2007-12-16 Thread Josh Boyer
On Sun, 16 Dec 2007 17:19:59 +1100 David Gibson [EMAIL PROTECTED] wrote: On Sat, Dec 15, 2007 at 08:55:16AM +0100, Stefan Roese wrote: Signed-off-by: Stefan Roese [EMAIL PROTECTED] Acked-by: David Gibson [EMAIL PROTECTED] Applied to my candidates tree. Though I'd really like dtc to be

Re: [MPC5200] problem running FEC and ATA

2007-12-16 Thread Robert Schwebel
On Sun, Dec 16, 2007 at 03:24:34PM +0200, Arnon Kaufman wrote: does any one succeed running a functional FEC and ATA (pata) running together? Yes, we do, on the phyCORE-MPC5200B-tiny; you can check our patches here: http://www.pengutronix.de/oselas/bsp/phytec/download/phyCORE-MPC5200B-tiny/

Re: [PATCH 2/3] mpc82xx: Embedded Planet EP8248E support

2007-12-16 Thread Scott Wood
On Sun, Dec 16, 2007 at 05:30:20PM +1100, David Gibson wrote: This mdio-under-bcsr arrangement is a bit strange. Can you explain what's going on here? It's pretty much what it looks like; MDIO is connected to a couple pins that are controlled by some bits in the BCSR. -Scott

Re: [MPC5200] problem running FEC and ATA

2007-12-16 Thread Arnon Kaufman
Robert Schwebel wrote: On Sun, Dec 16, 2007 at 03:24:34PM +0200, Arnon Kaufman wrote: does any one succeed running a functional FEC and ATA (pata) running together? Yes, we do, on the phyCORE-MPC5200B-tiny; you can check our patches here:

Re: [MPC5200] problem running FEC and ATA

2007-12-16 Thread Robert Schwebel
On Sun, Dec 16, 2007 at 07:28:40PM +0200, Arnon Kaufman wrote: Robert Schwebel wrote: On Sun, Dec 16, 2007 at 03:24:34PM +0200, Arnon Kaufman wrote: does any one succeed running a functional FEC and ATA (pata) running together? Yes, we do, on the phyCORE-MPC5200B-tiny; you can check our

[PATCH 1/2] [RESEND] ps3: vuart: fix error path locking

2007-12-16 Thread Daniel Walker
This stray down would cause a permanent sleep which doesn't seem correct. The other uses of this semaphore appear fairly mutex like it's even initialized with init_MUTEX() .. So here a patch for removing this one down(). Signed-off-by: Geoff Levand [EMAIL PROTECTED] Signed-off-by: Daniel Walker

Re: [PATCH] [POWERPC] 4xx: Add aliases node to 4xx dts files

2007-12-16 Thread Josh Boyer
On Sun, 16 Dec 2007 19:10:02 +0100 Segher Boessenkool [EMAIL PROTECTED] wrote: Applied to my candidates tree. Though I'd really like dtc to be merged so that we can figure out what the in-kernel version will support. Hopefully some version that stores path strings in the properties in

Re: [PATCH] [POWERPC] 4xx: Add aliases node to 4xx dts files

2007-12-16 Thread David Gibson
On Sun, Dec 16, 2007 at 08:58:58AM -0600, Josh Boyer wrote: On Sun, 16 Dec 2007 17:19:59 +1100 David Gibson [EMAIL PROTECTED] wrote: On Sat, Dec 15, 2007 at 08:55:16AM +0100, Stefan Roese wrote: Signed-off-by: Stefan Roese [EMAIL PROTECTED] Acked-by: David Gibson [EMAIL PROTECTED]

Re: [PATCH] [POWERPC] 4xx: Add aliases node to 4xx dts files

2007-12-16 Thread David Gibson
On Sun, Dec 16, 2007 at 07:10:02PM +0100, Segher Boessenkool wrote: Applied to my candidates tree. Though I'd really like dtc to be merged so that we can figure out what the in-kernel version will support. Hopefully some version that stores path strings in the properties in /aliases, and

Re: [PATCH] [POWERPC] 4xx: Add aliases node to 4xx dts files

2007-12-16 Thread Segher Boessenkool
Hopefully some version that stores path strings in the properties in /aliases, and not phandles. Or does that current version of DTC do that correctly already, and just has an inconvenient source syntax? I don't think anyone's actually gone and generated phandles in /aliases, although it

Re: [PATCH] [POWERPC] 4xx: Add aliases node to 4xx dts files

2007-12-16 Thread David Gibson
On Sun, Dec 16, 2007 at 11:44:50PM +0100, Segher Boessenkool wrote: Hopefully some version that stores path strings in the properties in /aliases, and not phandles. Or does that current version of DTC do that correctly already, and just has an inconvenient source syntax? I don't think

[PATCH] Fix sleep on powerbook 3400

2007-12-16 Thread Paul Mackerras
Sleep on the powerbook 3400 has been broken since the change that made powerbook_sleep_3400 call pmac_suspend_devices(), which disables interrupts. There are a couple of loops in powerbook_sleep_3400 that depend on interrupts being enabled, and in fact it has to have interrupts enabled at the

Re: [PATCH 1/2] wrapper: rename offset in offset_devp().

2007-12-16 Thread David Gibson
On Tue, Dec 11, 2007 at 03:23:04PM -0600, Scott Wood wrote: fdt_wrapper_create_node passes a variable called offset to offset_devp(), which uses said parameter to initialize a local variable called offset. Due to one of the odder aspects of the C language, the result is an undefined

Re: [PATCH 1/2] wrapper: rename offset in offset_devp().

2007-12-16 Thread David Gibson
On Wed, Dec 12, 2007 at 03:45:28PM +1100, Stephen Rothwell wrote: On Tue, 11 Dec 2007 15:23:04 -0600 Scott Wood [EMAIL PROTECTED] wrote: #define offset_devp(off) \ ({ \ - int offset = (off); \ - check_err(offset) ? NULL : (void *)(offset+1); \ +

Re: [PATCH v2 1/3] 8xx: Analogue Micro Adder875 board support.

2007-12-16 Thread David Gibson
On Wed, Dec 12, 2007 at 04:54:27PM -0600, Scott Wood wrote: Signed-off-by: Scott Wood [EMAIL PROTECTED] [snip] diff --git a/arch/powerpc/boot/dts/adder875-redboot.dts b/arch/powerpc/boot/dts/adder875-redboot.dts new file mode 100644 index 000..4d28220 --- /dev/null +++

Re: [PATCH v2 2/3] mpc82xx: Embedded Planet EP8248E support

2007-12-16 Thread David Gibson
On Wed, Dec 12, 2007 at 04:54:29PM -0600, Scott Wood wrote: This board is also resold by Freescale under the names QUICCStart MPC8248 Evaluation System and CWH-PPC-8248N-VE. [snip] + localbus { Should be [EMAIL PROTECTED] + compatible = fsl,ep8248e-localbus, +

Re: [PATCH 7/7] [POWERPC] Xilinx: Update booting-without-of.

2007-12-16 Thread David Gibson
On Thu, Dec 13, 2007 at 03:43:33PM -0800, Stephen Neuendorffer wrote: This now better describes what the UBoot device tree generator actually does. In particular: 1) Nodes have a label derived from the device name, and a node name derived from the device type. 2) Usage of compound nodes

Re: [PATCH 7/7] [POWERPC] Xilinx: Update booting-without-of.

2007-12-16 Thread Grant Likely
On 12/16/07, David Gibson [EMAIL PROTECTED] wrote: On Thu, Dec 13, 2007 at 03:43:33PM -0800, Stephen Neuendorffer wrote: This now better describes what the UBoot device tree generator actually does. In particular: 1) Nodes have a label derived from the device name, and a node name

RE: [PATCH 7/7] [POWERPC] Xilinx: Update booting-without-of.

2007-12-16 Thread Stephen Neuendorffer
Compound devices that actually have their own shared registers should do something different. Likely they'll need some sort of data synchronization anyway. It seems that by far the common case here is to going to be to just have aggregation, and I don't see any reason that can't be handled

RE: Device Tree updates for xilinx.

2007-12-16 Thread Stephen Neuendorffer
Since there don't seem to be any examples of this in the tree: do you have a format preference? For the rest of the compatible lists, I'm using something like: xlnx,ipname-version. So for the microblaze, I'd prefer something like: xlnx,microblaze-6.00.b For the powerpc, either ibm,ppc405 or

Re: [PATCH] [POWERPC][RFC] MPC8360E-RDK: Device tree and board file

2007-12-16 Thread David Gibson
On Sat, Dec 15, 2007 at 07:23:31PM +0300, Anton Vorontsov wrote: On Tue, Dec 11, 2007 at 12:42:18PM -0600, Kumar Gala wrote: [snip] + [EMAIL PROTECTED] { + #address-cells = 1; + #size-cells = 1; + device_type = soc; + ranges = 0 0xe000

Re: Device Tree updates for xilinx.

2007-12-16 Thread David Gibson
On Sun, Dec 16, 2007 at 08:58:18PM -0800, Stephen Neuendorffer wrote: Since there don't seem to be any examples of this in the tree: do you have a format preference? For the rest of the compatible lists, I'm using something like: xlnx,ipname-version. So for the microblaze, I'd prefer

Re: [DTC][PATCH] Fix cross-compile building

2007-12-16 Thread David Gibson
On Thu, Dec 13, 2007 at 11:57:48PM -0600, Kumar Gala wrote: On Dec 7, 2007, at 6:36 PM, David Gibson wrote: On Fri, Dec 07, 2007 at 12:28:20PM -0600, Kumar Gala wrote: From: Stuart Hughes [EMAIL PROTECTED] This patch allows you to build the DTC source without making the tests

dtc: Don't build tests as part of all

2007-12-16 Thread David Gibson
Currently make all for dtc will build (but not run) the testcase binaries. This is a problem for cross compiles, because building the tests will attempt to run the dumptrees utility on the host system, which won't work if it's cross-compiled of course. Although it would be possible to separately

Re: [PATCH 2/3] arch/ : Platform changes for UCC TDM driver for MPC8323ERDB.Also includes related QE changes.

2007-12-16 Thread Poonam Aggrwal
Thanx Tabi for your comments. Sorry I was on leave for the last week, so could not reply in time. Shall make the changes you suggested and repost the patch. Regards Poonam On 12/11/07, Timur Tabi [EMAIL PROTECTED] wrote: Poonam_Aggrwal-b10812 wrote: + qe =

Re: [PATCH 2/2] wrapper: Treat NULL as root node in devp_offset; add devp_offset_find().

2007-12-16 Thread David Gibson
On Tue, Dec 11, 2007 at 03:23:05PM -0600, Scott Wood wrote: Many operations, as currently used in the wrapper, assume they can pass NULL and have it be treated as the root node. However, libfdt-wrapper converts NULL to -1, which is only appropriate when searching for nodes, and will cause an

RE: [PATCH 2/3] arch/ : Platform changes for UCC TDM driver for MPC8323ERDB.Also includes related QE changes.

2007-12-16 Thread Aggrwal Poonam
Thanks Stephen for your comments. I have gone through them. Shall incorporate them and repost the patch. Sorry for late reply as I was on leave for the last week. With Regards Poonam -Original Message- From: Stephen Rothwell [mailto:[EMAIL PROTECTED] Sent: Tuesday, December 11,

RE: Device Tree updates for xilinx.

2007-12-16 Thread Stephen Neuendorffer
Thanks, I've updated the generator to reflect this. Steve -Original Message- From: David Gibson [mailto:[EMAIL PROTECTED] Sent: Sun 12/16/2007 9:21 PM To: Stephen Neuendorffer Cc: linuxppc-dev@ozlabs.org; Michal Simek; git Subject: Re: Device Tree updates for xilinx. On Sun, Dec 16,

[PATCH] Implement pci_set_dma_mask() in terms of the dma_ops

2007-12-16 Thread Michael Ellerman
Powerpc currently doesn't implement pci_set_dma_mask(), which means drivers calling it will get the generic version in drivers/pci/pci.c. The Powerpc dma mapping ops include a dma_set_mask() hook, which luckily is not implemented by anyone - so there is no bug in the fact that the hook is