Re: State of the MPC5200 PSC AC97 driver

2008-04-11 Thread Robert Schwebel
Hi Matt, On Thu, Apr 10, 2008 at 04:25:20PM +0100, Matt Sealey wrote: I have a copy of the driver I hacked to work with the new PSC framework but it doesn't work anymore - I have no idea why. Mail me privately if you want it, I have no time to make patches or look for a good reason for the

Re: [PATCH 1/5] phylib: don't create a phydev for ID-less PHYs.

2008-04-11 Thread Joakim Tjernlund
On Thu, 2008-04-10 at 13:51 -0400, Paul Gortmaker wrote: I've tested on 8360, 8540 and 8641D and in all cases, the PHY ID returned for bus addr 0x1f is all zeros, and not all 0xf. This means we've been allocating a phydev for this ghost. In addition to marking 0x0 as an invalid PHY ID, I've

Re: State of the MPC5200 PSC AC97 driver

2008-04-11 Thread Sylvain Munaut
Last year you have posted a MPC5200 PSC AC97 driver patch [PATCH 9/9] sound: Add support for Freescale MPC5200 AC97 interface. with the following comment: Not quite a clean driver, but it get things done (well, mostly). Only included to be able to test functionalityi/usage of the

Re: State of the MPC5200 PSC AC97 driver

2008-04-11 Thread Sven Luther
On Fri, Apr 11, 2008 at 08:51:00AM +0200, Robert Schwebel wrote: Hi Matt, On Thu, Apr 10, 2008 at 04:25:20PM +0100, Matt Sealey wrote: I have a copy of the driver I hacked to work with the new PSC framework but it doesn't work anymore - I have no idea why. Mail me privately if you want

Re: [PATCH 1/5] phylib: don't create a phydev for ID-less PHYs.

2008-04-11 Thread Stefan Roese
On Friday 11 April 2008, Joakim Tjernlund wrote: On Thu, 2008-04-10 at 13:51 -0400, Paul Gortmaker wrote: In addition to marking 0x0 as an invalid PHY ID, I've also changed the existing somewhat useless printk to actually list the bus IDs where it found a PHY so we get a basic bus

Re: State of the MPC5200 PSC AC97 driver

2008-04-11 Thread Marian Balakowicz
All, Thanks for the input and comments. I am also having a look at the I2S driver. There were attempts some time ago and I found few pieces of code floating on net but couldn't find anything cleaned up. Did anyone tried to put the results of those attempts together? Cheers, m.

Re: [PATCH 1/5] phylib: don't create a phydev for ID-less PHYs.

2008-04-11 Thread Joakim Tjernlund
On Fri, 2008-04-11 at 10:06 +0200, Stefan Roese wrote: On Friday 11 April 2008, Joakim Tjernlund wrote: On Thu, 2008-04-10 at 13:51 -0400, Paul Gortmaker wrote: In addition to marking 0x0 as an invalid PHY ID, I've also changed the existing somewhat useless printk to actually list the

Re: patches for 2.6.26

2008-04-11 Thread Anton Vorontsov
Hello Kumar, On Thu, Apr 10, 2008 at 09:21:34AM -0500, Kumar Gala wrote: Guy's if you have work you want in 2.6.26 related to Freescale PPC's let me know. Ideally you can provide links to the patches in http://patchwork.ozlabs.org/linuxppc/ Please take a look at these: [POWERPC]

[PATCH] fs_enet: Don't call NAPI functions when NAPI is not used.

2008-04-11 Thread Laurent Pinchart
fs_enet_close() calls napi_disable() unconditionally. This patch skips the call when use_napi isn't set. Signed-off-by: Laurent Pinchart [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

[PATCH 0/2] Notorious OF GPIO API support

2008-04-11 Thread Anton Vorontsov
Hello Paul, Please consider applying these patches for the 2.6.26. Pretty much of new drivers depend on this support, including some of my patches and patches from Jochen Friedrich and Laurent Pinchart. My plan is to submit MPC83xx/MPC85xx specific parts to Kumar after these two applied. Then

[PATCH 2/2] [POWERPC] Implement support for the GPIO LIB API

2008-04-11 Thread Anton Vorontsov
This patch implements support for the GPIO LIB API. Two calls unimplemented though: irq_to_gpio and gpio_to_irq. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- Documentation/powerpc/booting-without-of.txt | 52 arch/powerpc/Kconfig |5

[PATCH 1/2] OF helpers for the GPIO API

2008-04-11 Thread Anton Vorontsov
This patch implements various helpers to support OF bindings for the GPIO LIB API. Previously this was PowerPC specific, but it seems this code isn't arch-dependent anyhow, so let's place it into of/. SPARC will not see this addition yet, real hardware seem to not use GPIOs at all. But this

zImage.embedded

2008-04-11 Thread Guillaume Dargaud
Hello all, I'm not sure what kind of error this is. I'm trying to generate a kernel image suitable for network boot and it seems to fail at the very end (wrong target ?) $ make ARCH=ppc CROSS_COMPILE=powerpc-linux-uclibc- znetboot powerpc-linux-uclibc-objcopy -O elf32-powerpc

Re: State of the MPC5200 PSC AC97 driver

2008-04-11 Thread Grant Likely
On Fri, Apr 11, 2008 at 3:23 AM, Marian Balakowicz [EMAIL PROTECTED] wrote: All, Thanks for the input and comments. I am also having a look at the I2S driver. There were attempts some time ago and I found few pieces of code floating on net but couldn't find anything cleaned up. Did

Re: [PATCH 1/5] phylib: don't create a phydev for ID-less PHYs.

2008-04-11 Thread Grant Likely
On Fri, Apr 11, 2008 at 4:47 AM, Joakim Tjernlund [EMAIL PROTECTED] wrote: On Fri, 2008-04-11 at 10:06 +0200, Stefan Roese wrote: On Friday 11 April 2008, Joakim Tjernlund wrote: PHY ID 0x0 isn't an invalid id, I got a Broadcom PHY that has PHY ID=0. Maybe I am misunderstanding

Re: zImage.embedded

2008-04-11 Thread Grant Likely
On Fri, Apr 11, 2008 at 7:43 AM, Guillaume Dargaud [EMAIL PROTECTED] wrote: Hello all, I'm not sure what kind of error this is. I'm trying to generate a kernel image suitable for network boot and it seems to fail at the very end (wrong target ?) $ make ARCH=ppc

[PATCH0/7] OF support for i2c bus drivers

2008-04-11 Thread Jochen Friedrich
This series of patches implements the framework needed by of_platform_driver i2c bus drivers. i2c-mpc is then converted to an of_platform_driver and i2c-cpm is added as new driver. This is based on earlier work by Jon Smirl and Jean Delvare. [PATCH1/7] i2c: Add support for device alias names

Re: [PATCH 1/8] [POWERPC] fsl_elbc_nand: factor out localbus defines

2008-04-11 Thread Kumar Gala
On Mar 11, 2008, at 12:23 PM, Anton Vorontsov wrote: This is needed to support other localbus peripherals, such as NAND on FSL UPM. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- Would be great if someone from the MTD community will ack this patch to go through powerpc trees. Thanks,

[PATCH1/7] i2c: Add support for device alias names

2008-04-11 Thread Jochen Friedrich
Based on earlier work by Jon Smirl and Jean Delvare. This patch allows new-style i2c chip drivers to have alias names using the official kernel aliasing system and MODULE_DEVICE_TABLE(). At this point, the old i2c driver binding scheme (driver_name/type) is still supported. Signed-off-by: Jochen

[PATCH2/7] i2c: Convert all new-style drivers to use module aliasing

2008-04-11 Thread Jochen Friedrich
Based on earlier work by Jon Smirl and Jean Delvare. Update all the new-style i2c drivers to use standard module aliasing instead of the old driver_name/type driver matching scheme. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] Cc: Jean Delvare [EMAIL PROTECTED] Cc: Jon Smirl [EMAIL

[PATCH3/7] i2c: OF helpers for the i2c API

2008-04-11 Thread Jochen Friedrich
This patch implements various helpers to support OF bindings for the i2c API. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- drivers/of/Kconfig |6 +++ drivers/of/Makefile|1 + drivers/of/i2c.c | 115

Re: [PATCH 2/8] [POWERPC] fsl_lbc: implement few routines to manage FSL UPMs

2008-04-11 Thread Kumar Gala
On Mar 11, 2008, at 12:24 PM, Anton Vorontsov wrote: These will be used by the FSL UPM NAND driver. can this be a bit more descriptive. What exactly are these functions trying to accomplish. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- arch/powerpc/Kconfig |5 ++

[PATCH4/7] i2c: Convert PowerPC MPC i2c to of_platform_driver from platform_driver

2008-04-11 Thread Jochen Friedrich
Based on earlier work by Jon Smirl. Changed common name from powerpc_ to of_ per Olof's suggestion. Convert MPC i2c driver from a platform_driver to a of_platform_driver. Add the ability to dynamically load i2c drivers based on device tree names. Routine names were changed from fsl_ to mpc_ to

[PATCH5/7] i2c: Kill the old driver matching scheme

2008-04-11 Thread Jochen Friedrich
Based on earlier work by Jon Smirl and Jean Delvare. Remove the old driver_name/type scheme for i2c driver matching. Only the standard aliasing model will be used from now on. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] Cc: Jean Delvare [EMAIL PROTECTED] Cc: Jon Smirl [EMAIL PROTECTED] ---

[PATCH6/7] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-04-11 Thread Jochen Friedrich
This driver uses the port of 2.4 code from Vitaly Bordug [EMAIL PROTECTED] and the actual algorithm used by the i2c driver of the DBox code on cvs.tuxboc.org from Felix Domke ([EMAIL PROTECTED]) and Gillem ([EMAIL PROTECTED]) converted to an of_platform_driver. Tested on CPM1 (MPC823 on dbox2

[PATCH7/7] [POWERPC] Add i2c pins to dts and board setup

2008-04-11 Thread Jochen Friedrich
Initialize I2C pins on boards with CPM1/CPM2 controllers. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc8272ads.dts | 10 ++ arch/powerpc/boot/dts/mpc866ads.dts | 10 ++ arch/powerpc/boot/dts/mpc885ads.dts | 10

Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup

2008-04-11 Thread Kumar Gala
On Mar 11, 2008, at 12:10 PM, Anton Vorontsov wrote: - get rid of `model = UCC' in the ucc nodes It isn't used anywhere, so remove it. If we'll ever need something like this, we'll use compatible property instead. - replace cell-index and device-id properties by fsl,ucc. Drivers are modified

Re: [PATCH 2/2] [POWERPC] Implement support for the GPIO LIB API

2008-04-11 Thread Grant Likely
On Fri, Apr 11, 2008 at 7:06 AM, Anton Vorontsov [EMAIL PROTECTED] wrote: This patch implements support for the GPIO LIB API. Two calls unimplemented though: irq_to_gpio and gpio_to_irq. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] I like it Acked-by: Grant Likely [EMAIL PROTECTED]

Re: [PATCH 1/2] ibm_newemac: PowerPC 440GX EMAC PHY clock workaround

2008-04-11 Thread Josh Boyer
On Fri, 28 Mar 2008 22:18:25 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Valentine Barshak wrote: The PowerPC 440GX Taishan board fails to reset EMAC3 (reset timeout error) if there's no link. Because of that it fails to find PHY chip. The older ibm_emac driver had a workaround for that:

Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup

2008-04-11 Thread Timur Tabi
Kumar Gala wrote: I'd prefer we use cell-index and not introduce fsl,ucc. Yeah, me too. cell-index is the right property for the UCC number. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

Re: [PATCH 1/2] OF helpers for the GPIO API

2008-04-11 Thread Grant Likely
On Fri, Apr 11, 2008 at 7:06 AM, Anton Vorontsov [EMAIL PROTECTED] wrote: This patch implements various helpers to support OF bindings for the GPIO LIB API. Previously this was PowerPC specific, but it seems this code isn't arch-dependent anyhow, so let's place it into of/. SPARC will

Re: [PATCH] CPM: Always use new binding.

2008-04-11 Thread Scott Wood
On Thu, Apr 10, 2008 at 06:44:24PM -0500, Kumar Gala wrote: On Apr 10, 2008, at 3:45 PM, Scott Wood wrote: The kconfig entry can go away once arch/ppc and references to the config in drivers are removed. just to be clear. arch/powerpc will always just use the new binding and arch/ppc

Re: State of the MPC5200 PSC AC97 driver

2008-04-11 Thread Marian Balakowicz
Grant Likely wrote: On Fri, Apr 11, 2008 at 3:23 AM, Marian Balakowicz [EMAIL PROTECTED] wrote: All, Thanks for the input and comments. I am also having a look at the I2S driver. There were attempts some time ago and I found few pieces of code floating on net but couldn't find

Re: [PATCH7/7] [POWERPC] Add i2c pins to dts and board setup

2008-04-11 Thread Scott Wood
Jochen Friedrich wrote: diff --git a/arch/powerpc/boot/dts/mpc8272ads.dts b/arch/powerpc/boot/dts/mpc8272ads.dts index 7285ca1..7273996 100644 --- a/arch/powerpc/boot/dts/mpc8272ads.dts +++ b/arch/powerpc/boot/dts/mpc8272ads.dts @@ -215,6 +215,16 @@

Flash on LocalBus @ MPC8343

2008-04-11 Thread Andre Schwarz
Hi all, I've been trying hard to make the mtd-partitions available via device tree on my MPC8343 local bus. No success so far ... Everything works fine on my MPC5200B based system - flash layout definition is quite simple To me it looks like there's a problem regarding the local bus

Re: Flash on LocalBus @ MPC8343

2008-04-11 Thread Laurent Pinchart
On Friday 11 April 2008 17:13, Andre Schwarz wrote: Hi all, I've been trying hard to make the mtd-partitions available via device tree on my MPC8343 local bus. No success so far ... Everything works fine on my MPC5200B based system - flash layout definition is quite simple To

Re: [PATCH v2.6.26] gianfar: Determine TBIPA value dynamically

2008-04-11 Thread Scott Wood
On Thu, Apr 10, 2008 at 06:34:31PM -0500, Andy Fleming wrote: + /* + * This is mildly evil, but so is our hardware for doing this. + * Also, we have to cast back to struct gfar_mii because of + * definition weirdness done in gianfar.h. + */ + enet_regs =

Re: Flash on LocalBus @ MPC8343

2008-04-11 Thread Scott Wood
On Fri, Apr 11, 2008 at 05:13:47PM +0200, Andre Schwarz wrote: To me it looks like there's a problem regarding the local bus in general. Am I missing a compatible or anything else ? reg or ranges ? Do you have an of_bus_ids[] entry that covers the localbus? -Scott

Re: [PATCH v2.6.26] gianfar: Determine TBIPA value dynamically

2008-04-11 Thread Paul Gortmaker
In message: [PATCH v2.6.26] gianfar: Determine TBIPA value dynamically on 10/04/2008 Andy Fleming wrote: TBIPA needs to be set to a value (on connected MDIO buses) that doesn't conflict with PHYs on the bus. By hardcoding it to 0x1f, we were preventing boards with PHYs at 0x1f from working

Re: zImage.embedded

2008-04-11 Thread Guillaume Dargaud
is the file zImage.elf my proper network image ? What bootloader is on your board? zImage.elf *might* be the proper image. If you're using u-boot, then you want to build a uImage instead. I... ahem... what would you recommand for a ML405 ? Builroot gives to options of U-Boot or Yaboot.

Re: [PATCH] CPM: Always use new binding.

2008-04-11 Thread Kumar Gala
On Apr 11, 2008, at 9:46 AM, Scott Wood wrote: On Thu, Apr 10, 2008 at 06:44:24PM -0500, Kumar Gala wrote: On Apr 10, 2008, at 3:45 PM, Scott Wood wrote: The kconfig entry can go away once arch/ppc and references to the config in drivers are removed. just to be clear. arch/powerpc will

Re: zImage.embedded

2008-04-11 Thread Grant Likely
On Fri, Apr 11, 2008 at 9:51 AM, Guillaume Dargaud [EMAIL PROTECTED] wrote: is the file zImage.elf my proper network image ? What bootloader is on your board? zImage.elf *might* be the proper image. If you're using u-boot, then you want to build a uImage instead. I...

Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup

2008-04-11 Thread Anton Vorontsov
On Fri, Apr 11, 2008 at 09:13:36AM -0500, Kumar Gala wrote: On Mar 11, 2008, at 12:10 PM, Anton Vorontsov wrote: - get rid of `model = UCC' in the ucc nodes It isn't used anywhere, so remove it. If we'll ever need something like this, we'll use compatible property instead. - replace

Re: [PATCH 2/8] [POWERPC] fsl_lbc: implement few routines to manage FSL UPMs

2008-04-11 Thread Scott Wood
Anton Vorontsov wrote: On Fri, Apr 11, 2008 at 09:09:57AM -0500, Kumar Gala wrote: On Mar 11, 2008, at 12:24 PM, Anton Vorontsov wrote: These will be used by the FSL UPM NAND driver. can this be a bit more descriptive. What exactly are these functions trying to accomplish. Yeah, sorry

Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup

2008-04-11 Thread Timur Tabi
Anton Vorontsov wrote: On Fri, Apr 11, 2008 at 09:13:36AM -0500, Kumar Gala wrote: On Mar 11, 2008, at 12:10 PM, Anton Vorontsov wrote: - get rid of `model = UCC' in the ucc nodes It isn't used anywhere, so remove it. If we'll ever need something like this, we'll use compatible property

[PATCH] 86xx: mark functions static, other minor cleanups

2008-04-11 Thread Paul Gortmaker
Cleanups as suggested by Stephen Rothwell and Dale Farnsworth, which incudes: mark a bunch of functions static; add vendor prefix to the compat node check for uniqueness, add in missing of_node_put(), delete unused DBG macros. Signed-off-by: Paul Gortmaker [EMAIL PROTECTED] ---

Re: [PATCH 2/8] [POWERPC] fsl_lbc: implement few routines to manage FSL UPMs

2008-04-11 Thread Anton Vorontsov
On Fri, Apr 11, 2008 at 11:18:30AM -0500, Scott Wood wrote: Anton Vorontsov wrote: On Fri, Apr 11, 2008 at 09:09:57AM -0500, Kumar Gala wrote: On Mar 11, 2008, at 12:24 PM, Anton Vorontsov wrote: These will be used by the FSL UPM NAND driver. can this be a bit more descriptive. What exactly

Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup

2008-04-11 Thread Anton Vorontsov
On Fri, Apr 11, 2008 at 11:48:37AM -0500, Timur Tabi wrote: Anton Vorontsov wrote: On Fri, Apr 11, 2008 at 09:13:36AM -0500, Kumar Gala wrote: On Mar 11, 2008, at 12:10 PM, Anton Vorontsov wrote: - get rid of `model = UCC' in the ucc nodes It isn't used anywhere, so remove it. If we'll

Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup

2008-04-11 Thread Timur Tabi
Anton Vorontsov wrote: Do we want the first UCC to have a cell-index of 1? Maybe we should fix this off-by-one error once and for all, and number all UCCs from 0? Isn't documentation numbers UCC from 1? Yes. Then I believe we should stick with it for device tree, since off by one is

Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup

2008-04-11 Thread Timur Tabi
Anton Vorontsov wrote: From: Anton Vorontsov [EMAIL PROTECTED] Subject: [POWERPC] UCC nodes cleanup - get rid of `model = UCC' in the ucc nodes It isn't used anywhere, so remove it. If we'll ever need something like this, we'll use compatible property instead. - replace last

Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup

2008-04-11 Thread Anton Vorontsov
On Fri, Apr 11, 2008 at 09:06:57PM +0400, Anton Vorontsov wrote: On Fri, Apr 11, 2008 at 11:48:37AM -0500, Timur Tabi wrote: Anton Vorontsov wrote: On Fri, Apr 11, 2008 at 09:13:36AM -0500, Kumar Gala wrote: On Mar 11, 2008, at 12:10 PM, Anton Vorontsov wrote: - get rid of `model =

Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup

2008-04-11 Thread Timur Tabi
Anton Vorontsov wrote: Or maybe I'm thinking here in terms of fsl,ucc... and cell-index is indeed should be -1... don't know. Please decide. ;-) Well, that's what I was thinking. cell-index is zero-based, so UCC1 should have cell-index = 0. Of course, this means all the code needs to change,

Re: [PATCH] 86xx: mark functions static, other minor cleanups

2008-04-11 Thread Scott Wood
On Fri, Apr 11, 2008 at 12:59:46PM -0400, Paul Gortmaker wrote: diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts b/arch/powerpc/boot/dts/mpc8641_hpcn.dts index 79385bc..d5c2da4 100644 --- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts +++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts @@ -13,7 +13,7

Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup

2008-04-11 Thread Anton Vorontsov
On Fri, Apr 11, 2008 at 12:12:30PM -0500, Timur Tabi wrote: Anton Vorontsov wrote: Or maybe I'm thinking here in terms of fsl,ucc... and cell-index is indeed should be -1... don't know. Please decide. ;-) Well, that's what I was thinking. cell-index is zero-based, so UCC1 should have

Re: [PATCH3/7] i2c: OF helpers for the i2c API

2008-04-11 Thread David Miller
From: Jochen Friedrich [EMAIL PROTECTED] Date: Fri, 11 Apr 2008 16:09:17 +0200 + +config OF_I2C + def_bool y + depends on OF PPC_OF I2C + help + OpenFirmware I2C accessors I wouldn't mind trying to use this infrastructure on sparc64, and I don't see any powerpc specific

Re: [PATCH] 86xx: mark functions static, other minor cleanups

2008-04-11 Thread Segher Boessenkool
add vendor prefix to the compat node check for uniqueness, - compatible = mpc86xx; + compatible = wrs,sbc8641; Either use the ticker thing (uppercase, WIND,), or, if you prefer a lowercase name without that little extra namespace protection, please use something more

Re: [PATCH] 86xx: mark functions static, other minor cleanups

2008-04-11 Thread Paul Gortmaker
In message: Re: [PATCH] 86xx: mark functions static, other minor cleanups on 11/04/2008 Scott Wood wrote: model = MPC8641HPCN; - compatible = mpc86xx; + compatible = fsl,mpc86xx; #address-cells = 1; #size-cells = 1; If we're changing the compatible, change it to

[PATCH] [v6] Add idle wait support for 44x platforms

2008-04-11 Thread Jerone Young
2 files changed, 68 insertions(+), 1 deletion(-) arch/powerpc/platforms/44x/Makefile |2 - arch/powerpc/platforms/44x/idle.c | 67 +++ Updates: Shrink code even more from comments made on the list This patch adds the ability for the CPU to go into wait

Re: [PATCH v2.6.26] gianfar: Determine TBIPA value dynamically

2008-04-11 Thread Andy Fleming
On Apr 11, 2008, at 10:31, Scott Wood wrote: On Thu, Apr 10, 2008 at 06:34:31PM -0500, Andy Fleming wrote: + /* +* This is mildly evil, but so is our hardware for doing this. +* Also, we have to cast back to struct gfar_mii because of +* definition weirdness

Re: [PATCH v2.6.26] gianfar: Determine TBIPA value dynamically

2008-04-11 Thread Scott Wood
Andy Fleming wrote: I tried. Technically, we can. But the issue is that struct gfar *enet_regs-gfar_mii_regs is declared: u8 gfar_mii_regs[24]; I could not find any sequence of castings that made the warning go away about casting that to a struct gfar_mii __iomem *. And that includes

Re: [PATCH] 86xx: mark functions static, other minor cleanups

2008-04-11 Thread Segher Boessenkool
Updated as per above, and with tickerized prefixes for sbc8641. Care to try once more? It's only tickerized if it's in all uppercase. + compatible = wind,sbc8641; Segher ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

[PATCHv2 3/7] i2c: OF helpers for the i2c API

2008-04-11 Thread Jochen Friedrich
This patch implements various helpers to support OF bindings for the i2c API. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- drivers/of/Kconfig |6 +++ drivers/of/Makefile|1 + drivers/of/i2c.c | 115

Re: [PATCH3/7] i2c: OF helpers for the i2c API

2008-04-11 Thread Jochen Friedrich
David Miller schrieb: I wouldn't mind trying to use this infrastructure on sparc64, and I don't see any powerpc specific interfaces being invoked, so if you could remove the PPC_OF requirement I'd appreciate it. I've resenf the patch without the dependency on PPC_OF. Thanks for the comment.

[PATCHv2 7/7] [POWERPC] Add i2c pins to dts and board setup

2008-04-11 Thread Jochen Friedrich
Initialize I2C pins on boards with CPM1/CPM2 controllers. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc8272ads.dts | 10 ++ arch/powerpc/boot/dts/mpc866ads.dts | 10 ++ arch/powerpc/boot/dts/mpc885ads.dts | 10

Re: [PATCHv2 3/7] i2c: OF helpers for the i2c API

2008-04-11 Thread David Miller
From: Jochen Friedrich [EMAIL PROTECTED] Date: Fri, 11 Apr 2008 21:22:35 +0200 This patch implements various helpers to support OF bindings for the i2c API. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] Acked-by: David S. Miller [EMAIL PROTECTED]

Re: Flash on LocalBus @ MPC8343

2008-04-11 Thread André Schwarz
Scott, thanks for your help ... but Scott Wood wrote: On Fri, Apr 11, 2008 at 05:13:47PM +0200, Andre Schwarz wrote: To me it looks like there's a problem regarding the local bus in general. Am I missing a compatible or anything else ? reg or ranges ? Do you have an of_bus_ids[]

Re: Flash on LocalBus @ MPC8343

2008-04-11 Thread Scott Wood
André Schwarz wrote: Scott, thanks for your help ... but Scott Wood wrote: On Fri, Apr 11, 2008 at 05:13:47PM +0200, Andre Schwarz wrote: To me it looks like there's a problem regarding the local bus in general. Am I missing a compatible or anything else ? reg or ranges ? Do you

[PATCH v3] E500 Make steal_context SMP-safe.

2008-04-11 Thread Randy Vinson
When steal_context is used on SMP systems, it can steal a context in use by one of the other processors leading to random page faults, hung processors and general badness. This patch adds context tracking as suggested by BenH. Signed-off-by: Randy Vinson [EMAIL PROTECTED] ---

Re: [PATCH 1/2] Driver for Freescale 8610 and 5121 DIU

2008-04-11 Thread Jiri Slaby
ping. Seeing this in -mm yet. Are those comments all wrong? Are you working on it? On 03/12/2008 11:20 PM, Jiri Slaby wrote: On 03/12/2008 10:43 PM, York Sun wrote: +static int fsl_diu_open(struct fb_info *info, int user) +{ +struct mfb_info *mfbi = info-par; +int res = 0; + +

[PATCH] pseries: phyp dump: Variable size reserve space.

2008-04-11 Thread Manish Ahuja
Reposting patch with following changes: 1. Changed phyp_dump_reserve_bootvar to just reserve_bootvar. 2. Changed 0x0001fff to 0x0fffUL. Paulus, If you think this is okay can you send this upstream ? Many thanks, Manish A small proposed change in the amount of reserve space we

Re: [PATCHv2 3/7] i2c: OF helpers for the i2c API

2008-04-11 Thread Stephen Rothwell
On Fri, 11 Apr 2008 21:22:35 +0200 Jochen Friedrich [EMAIL PROTECTED] wrote: This patch implements various helpers to support OF bindings for the i2c API. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] Acked-by: Stephen Rothwell [EMAIL PROTECTED] -- Cheers, Stephen Rothwell

Re: [PATCH 1/2] Driver for Freescale 8610 and 5121 DIU

2008-04-11 Thread Andrew Morton
On Fri, 11 Apr 2008 23:45:35 +0200 Jiri Slaby [EMAIL PROTECTED] wrote: On 03/12/2008 11:20 PM, Jiri Slaby wrote: On 03/12/2008 10:43 PM, York Sun wrote: +static int fsl_diu_open(struct fb_info *info, int user) +{ +struct mfb_info *mfbi = info-par; +int res = 0; + +

[LMB][2/2] Restructure allocation loops to avoid unsigned underflow

2008-04-11 Thread Paul Mackerras
There is a potential bug in __lmb_alloc_base where we subtract `size' from the base address of a reserved region without checking whether the subtraction could wrap around and produce a very large unsigned value. In fact it probably isn't possible to hit the bug in practice since it would only

Re: [PATCH 2/8] [POWERPC] fsl_lbc: implement few routines to manage FSL UPMs

2008-04-11 Thread Paul Mackerras
Anton Vorontsov writes: Ok. Updated patch follows. Thanks! - - - - From: Anton Vorontsov [EMAIL PROTECTED] Subject: [POWERPC] fsl_lbc: implement few UPM routines Just a hint: your patches are less likely to get overlooked if you change the subject of your email to describe the new patch

[LMB][1/2] Fix some whitespace and other formatting issues, use pr_debug

2008-04-11 Thread Paul Mackerras
This makes no semantic changes. It fixes the whitespace and formatting a bit, gets rid of a local DBG macro and uses the equivalent pr_debug instead, and restructures one while loop that had a function call and assignment in the condition to be a bit more readable. Some comments about functions

Re: [PATCH] fs_enet: Don't call NAPI functions when NAPI is not used.

2008-04-11 Thread Jeff Garzik
Laurent Pinchart wrote: fs_enet_close() calls napi_disable() unconditionally. This patch skips the call when use_napi isn't set. Signed-off-by: Laurent Pinchart [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git