Re: [RFC] 4xx hardware watchpoint support

2008-05-22 Thread Roland McGrath
I would think there would be a different REQUEST value to mean set a hardware breakpoint. Roland McGrath (cc'd) might be able to tell us what other architectures do. Other architectures don't give a good model to follow. (If anything, they just trivally virtualize their own idiosyncratic

Re: [PATCH] Add port multiplier (PMP) support in sata_fsl driver

2008-05-22 Thread Tejun Heo
Kumar Gala wrote: From: Ashish Kalra [EMAIL PROTECTED] PMP support for sata_fsl driver. Signed-off-by: Ashish Kalra [EMAIL PROTECTED] --- Jeff, The following commit (4c9bf4e799ce06a7378f1196587084802a414c03): libata: replace tf_read with qc_fill_rtf for non-SFF drivers Heh.. I tried not to

Re: [PATCH 1/1] ehea: Fix use after free on reboot

2008-05-22 Thread Jeff Garzik
Brian King wrote: Fixes the following use after free oops: ehea: Reboot: freeing all eHEA resources Unable to handle kernel paging request for data at address 0x6b6b6b6b6b6b6c5b Faulting instruction address: 0xd0354488 cpu 0x0: Vector: 300 (Data Access) at [c0002ec6f310] pc:

Re: [PATCH 4/6] drivers/net/fs_enet: remove null pointer dereference

2008-05-22 Thread Jeff Garzik
Julia Lawall wrote: From: Julia Lawall [EMAIL PROTECTED] The following code appears in the function fs_init_instance in the file drivers/net/fs_enet/fs_enet-main.c. if (fep-ops == NULL) { printk(KERN_ERR DRV_MODULE_NAME : %s No matching ops found

SD-MMC over SPI on PSC6

2008-05-22 Thread Fabio Tosetto
Hello, I have an embedded system with an on-board processor powerpc MPC5200B and Linux kernel 2.6.22, I must turn over to MMC SPI on the PSC6. The MMC over SPI is connected to MPC5200b, here's how: MPC5200B |

Re: [PATCH 3/4] [MMC] mmc_spi: add polling support for the card detectline

2008-05-22 Thread Anton Vorontsov
On Mon, May 19, 2008 at 11:02:13AM +0800, Chen Gong wrote: -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Anton Vorontsov Sent: 2008?5?17? 0:51 To: Kumar Gala; David Brownell; Pierre Ossman Cc: linuxppc-dev@ozlabs.org; [EMAIL

RE: [PATCH 3/4] [MMC] mmc_spi: add polling support for the carddetectline

2008-05-22 Thread Chen Gong
-Original Message- From: Anton Vorontsov [mailto:[EMAIL PROTECTED] Sent: 2008?5?22? 20:39 To: Chen Gong Cc: Kumar Gala; David Brownell; Pierre Ossman; linuxppc-dev@ozlabs.org; [EMAIL PROTECTED]; [EMAIL PROTECTED]; Tabi Timur Subject: Re: [PATCH 3/4] [MMC] mmc_spi: add

Re: [PATCH 2/2] USB: isp1760: Support board-specific hardware configurations

2008-05-22 Thread Olof Johansson
On Wed, May 21, 2008 at 04:28:51PM -0500, Nate Case wrote: This adds support for hardware configurations that don't match the chip default register settings (e.g., 16-bit data bus, DACK and DREQ pulled down instead of up, analog overcurrent mode). These settings are passed in via the OF

RE: 1 GB lowmem

2008-05-22 Thread Rune Torgersen
Kumar Gala wrote: On May 21, 2008, at 4:24 PM, Rune Torgersen wrote: Kumar Gala wrote: On May 21, 2008, at 3:55 PM, Rune Torgersen wrote: Argh... Found it. Had to set CONFIG_TASK_SIZE to 0x8000. Now it works in both vaniulla an d RT kernel. We should really add some sanity check on

FW: 1 GB lowmem

2008-05-22 Thread Rune Torgersen
Kumar Gala wrote: On May 21, 2008, at 4:24 PM, Rune Torgersen wrote: Kumar Gala wrote: On May 21, 2008, at 3:55 PM, Rune Torgersen wrote: Argh... Found it. Had to set CONFIG_TASK_SIZE to 0x8000. Now it works in both vaniulla an d RT kernel. We should really add some sanity check on

Re: [PATCH] [POWERPC] Improve (in|out)_beXX() asm code

2008-05-22 Thread Benjamin Herrenschmidt
On Tue, 2008-05-20 at 15:53 -0700, David Miller wrote: From: Scott Wood [EMAIL PROTECTED] Date: Tue, 20 May 2008 17:43:58 -0500 David Miller wrote: The __volatile__ in the asm construct disallows movement of the inline asm relative to statements surrounding it. The only reason

Re: MPC5200b MMC over SPI into PSC6

2008-05-22 Thread Fabri
Doesn't look like you are passing a kernel parameters line. The kernel probably is booting, but doesn't know where to output the console. Try adding console=ttyPSC0,115200. Hi Grant, I've tried to add that with this commands = bootargs debug console=ttyPSC0,115200 root=/dev/ram = saveenv

RE: 1 GB lowmem

2008-05-22 Thread Rune Torgersen
Kumar Gala wrote: something like that would be good. is there really anything PPC32 specific about it? Apparently. The Kconfig option is only available for arch/powerpc and arch/ppc, and the only place in the whole codetree where CONFIG_TASK_SIZE is used is that particular spot in

Re: Badness seen on 2.6.26-rc2 with lockdep enabled

2008-05-22 Thread Benjamin Herrenschmidt
On Wed, 2008-05-14 at 18:15 +0530, Balbir Singh wrote: I see the following error on my power box at boot up. Could be RTAS playing with interrupt enabling without proper lockdep notifications. I'll have a look when I'm back. RTAS: event: 14, Type: Platform Error, Severity: 2 [

Re: [PATCH] edac: mpc85xx - Fix building as a module

2008-05-22 Thread Dave Jiang
Acked-by: Dave Jiang [EMAIL PROTECTED] Kumar Gala wrote: including of asm/mpc85xx.h causes build problems since it doesn't exist. Also removed warning: drivers/edac/mpc85xx_edac.c:45: warning: 'mpc85xx_ctl_name' defined but not used Signed-off-by: Kumar Gala [EMAIL PROTECTED] --- This is a

section mismatch warnings in current git head for powerpc

2008-05-22 Thread Chris Friesen
I got the following warnings when building current git head for powerpc 64bit: LD net/ipv4/built-in.o LD drivers/scsi/built-in.o LD net/built-in.o LD drivers/built-in.o LD vmlinux.o MODPOST vmlinux.o WARNING: vmlinux.o(.text+0x73bc): Section mismatch in

Re: section mismatch warnings in current git head for powerpc

2008-05-22 Thread Bart Van Assche
On Thu, May 22, 2008 at 7:22 PM, Chris Friesen [EMAIL PROTECTED] wrote: I got the following warnings when building current git head for powerpc 64bit: Something that should be fixed, but not something to worry about. Similar warnings appear when building the kernel for x86_64. See also

Re: [PATCH] Sam440ep support

2008-05-22 Thread Giuseppe Coviello
Il giorno mar, 20/05/2008 alle 08.34 -0500, Josh Boyer ha scritto: On Tue, 20 May 2008 07:50:28 -0500 Josh Boyer [EMAIL PROTECTED] wrote: On Mon, 19 May 2008 17:20:47 +0200 Giuseppe Coviello [EMAIL PROTECTED] wrote: + [EMAIL PROTECTED] { +

Re: [PATCH 1/2] USB: isp1760: Assign resource fields before adding hcd

2008-05-22 Thread Sebastian Siewior
* Nate Case | 2008-05-21 16:28:20 [-0500]: This fixes the bogus io mem 0x message printed during driver init due to hcd-rsrc_start being assigned after the call to usb_add_hcd(). Signed-off-by: Nate Case [EMAIL PROTECTED] I saw this and was wondering why it was correct in other places

Re: [PATCH 3/4] [MMC] mmc_spi: add polling support for the card detect line

2008-05-22 Thread Anton Vorontsov
On Wed, May 21, 2008 at 09:28:31PM +0200, Pierre Ossman wrote: On Wed, 21 May 2008 22:47:13 +0400 Anton Vorontsov [EMAIL PROTECTED] wrote: Calling get_cd() for every request smells like overhead, especially given that that get_cd() could ask for GPIO status via relatively slow bus (like

[PATCH 1/3] mmc: add support for card-detection polling

2008-05-22 Thread Anton Vorontsov
Some hosts (and boards that use mmc_spi) do not use interrupts on the CD line, so they can't trigger mmc_detect_change. We want to poll the card and see if there was a change. 1 second poll interval seems resonable. This patch also implements .get_cd() host operation, that could be used by the

[PATCH 3/3] mmc: change .get_ro() callback semantics

2008-05-22 Thread Anton Vorontsov
get_ro() callback must return values = 0 for its logical state, and negative errno values in case of error. If particular host instance doesn't support RO/WP switch, it should return -ENOSYS. This patch changes some hosts in two ways: 1. Now functions should be smart to not return negative

[PATCH 2/3] mmc_spi: add support for card-detection polling

2008-05-22 Thread Anton Vorontsov
If platform_data lacks init() callback (solely used to request card-detect interrupt), we mark the host as MMC_CAP_NEEDS_POLL. get_cd() host operation provided to optimize polling. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- drivers/mmc/host/mmc_spi.c | 18 --

Re: [PATCH 2/2] USB: isp1760: Support board-specific hardware configurations

2008-05-22 Thread Sebastian Siewior
* Nate Case | 2008-05-21 16:28:51 [-0500]: This adds support for hardware configurations that don't match the chip default register settings (e.g., 16-bit data bus, DACK and DREQ pulled down instead of up, analog overcurrent mode). Nice patch. A few comments inline. These settings are passed in

[PATCH] ftrace: powerpc clean ups

2008-05-22 Thread Steven Rostedt
This patch cleans up the ftrace code in PowerPC based on the comments from Michael Ellerman. Signed-off-by: Steven Rostedt [EMAIL PROTECTED] --- -0700 |binary arch/powerpc/kernel/entry_32.S | 11 ++- arch/powerpc/kernel/ftrace.c|8 +++-

[PATCH] [POWERPC] Fix return value check logic

2008-05-22 Thread Emil Medve
debugfs_create_file() return a non-NULL (non-zero) value in case of success This fixes this non-critical boot-time debuging error message: [1.316386] calling irq_debugfs_init+0x0/0x50 [1.316399] initcall irq_debugfs_init+0x0/0x50 returned -12 after 0 msecs [1.316411] initcall

adding external interrupt support for MPC8313e bsp

2008-05-22 Thread Suvidh Kankariya
Hi, I have mpc8313e local bus connected to a external UART. and the interrupt is connected to EXT_INT2. I am able to communicate to UART if I disable IRQ i.e IRQ = 0 in port structure. I am not able to understand how to tell kernel to use external IRQ -2. Should I put the external interrupts

Re: JFFS2 FS not writeable

2008-05-22 Thread Scott Wood
Ron Madrid wrote: I'm trying to make new directories, create files, save changes to files, etc. and when I reboot my changes are not being saved. I'm sorry if this is vague, but I haven't run into this problem before in previous kernels. I'm using 2.6.25 and my configuration is very similar to

Re: JFFS2 FS not writeable

2008-05-22 Thread Sean MacLennan
On Thu, 22 May 2008 13:36:32 -0700 (PDT) Ron Madrid [EMAIL PROTECTED] wrote: I'm trying to make new directories, create files, save changes to files, etc. and when I reboot my changes are not being saved. I'm sorry if this is vague, but I haven't run into this problem before in previous

Re: adding external interrupt support for MPC8313e bsp

2008-05-22 Thread Scott Wood
Suvidh Kankariya wrote: I have mpc8313e local bus connected to a external UART. and the interrupt is connected to EXT_INT2. I am able to communicate to UART if I disable IRQ i.e IRQ = 0 in port structure. I am not able to understand how to tell kernel to use external IRQ -2. Should I put the

[PATCH] generic rtc and nvram: Push the BKL down

2008-05-22 Thread Alan Cox
Switch the ioctl handlers to unlocked_ioctl and push lock_kernel into the driver instead. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff --git a/drivers/char/generic_nvram.c b/drivers/char/generic_nvram.c index 2398e86..8886e51 100644 --- a/drivers/char/generic_nvram.c +++

[PATCH] [POWERPC] Add the PC speaker only when requested so

2008-05-22 Thread Emil Medve
This will cause this minor boot-time debugging error message to go away: [1.316451] calling add_pcspkr+0x0/0x84 [1.316478] initcall add_pcspkr+0x0/0x84 returned -19 after 0 msecs Signed-off-by: Emil Medve [EMAIL PROTECTED] --- scripts/checkpatch.pl

Re: [PATCH] [POWERPC] Improve (in|out)_beXX() asm code

2008-05-22 Thread Trent Piepho
On Fri, 23 May 2008, Benjamin Herrenschmidt wrote: On Tue, 2008-05-20 at 15:53 -0700, David Miller wrote: From: Scott Wood [EMAIL PROTECTED] Date: Tue, 20 May 2008 17:43:58 -0500 David Miller wrote: The __volatile__ in the asm construct disallows movement of the inline asm relative to

Re: [PATCH] [POWERPC] Add the PC speaker only when requested so

2008-05-22 Thread Grant Likely
On Thu, May 22, 2008 at 4:40 PM, Emil Medve [EMAIL PROTECTED] wrote: This will cause this minor boot-time debugging error message to go away: [1.316451] calling add_pcspkr+0x0/0x84 [1.316478] initcall add_pcspkr+0x0/0x84 returned -19 after 0 msecs What situation are you hitting this

Re: section mismatch warnings in current git head for powerpc

2008-05-22 Thread Michael Ellerman
On Thu, 2008-05-22 at 11:22 -0600, Chris Friesen wrote: I got the following warnings when building current git head for powerpc 64bit: LD net/ipv4/built-in.o LD drivers/scsi/built-in.o LD net/built-in.o LD drivers/built-in.o LD vmlinux.o

Re: [PATCH] [POWERPC] Fix return value check logic

2008-05-22 Thread Michael Ellerman
On Thu, 2008-05-22 at 14:49 -0500, Emil Medve wrote: debugfs_create_file() return a non-NULL (non-zero) value in case of success This fixes this non-critical boot-time debuging error message: [1.316386] calling irq_debugfs_init+0x0/0x50 [1.316399] initcall

[PATCH] [POWERPC] iSeries: remove unused mail address

2008-05-22 Thread Stephen Rothwell
I don't use my IBM email address normally and people can find me in CREDITS. Signed-off-by: Stephen Rothwell [EMAIL PROTECTED] --- drivers/block/viodasd.c |2 +- drivers/cdrom/viocd.c |2 +- drivers/char/viocons.c |2 +- drivers/char/viotape.c |2 +- 4 files changed, 4

Re: [patch 1/2] powerpc: rmb fix

2008-05-22 Thread Paul Mackerras
Nick Piggin writes: More than one device driver does raw/relaxed io accessors and expects the *mb functions to order them. Can you point us at an example? I don't think the semantics of the raw accessors are particularly well defined (it's not even defined what endianness the data comes back

RE: [PATCH v2] [POWERPC] mpic: deal with bogus NIRQ in FeatureReporting Register

2008-05-22 Thread Jin Zhengxiong
Hi, Kumar, So I should change the MSI hwirq num according to this change, The patches will be send after this changes updated to your tree. How about applying the MSI driver firstly? Jason -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] g] On Behalf Of

Re: [PATCH 2/2] USB: isp1760: Support board-specific hardware configurations

2008-05-22 Thread Nathaniel Case
On Thu, 2008-05-22 at 17:35 +0200, Sebastian Siewior wrote: If you don't mind, I would prefer having ISP1760_FLAG_BUS_WIDTH_32 and or conditionally HW_DATA_BUS_32BIT. It doesn't matter much to me -- I just reasoned that a 32-bit bus width was the norm since it's the hardware default and so

Re: [PATCH v2] [POWERPC] mpic: deal with bogus NIRQ in FeatureReporting Register

2008-05-22 Thread Kumar Gala
On May 22, 2008, at 9:15 PM, Jin Zhengxiong wrote: Hi, Kumar, So I should change the MSI hwirq num according to this change, The patches will be send after this changes updated to your tree. How about applying the MSI driver firstly? I've asked Paul to pick up this patch for

Re: [PATCH] [POWERPC] Add the PC speaker only when requested so

2008-05-22 Thread Kumar Gala
On May 22, 2008, at 6:27 PM, Grant Likely wrote: On Thu, May 22, 2008 at 4:40 PM, Emil Medve [EMAIL PROTECTED] wrote: This will cause this minor boot-time debugging error message to go away: [1.316451] calling add_pcspkr+0x0/0x84 [1.316478] initcall add_pcspkr+0x0/0x84 returned

Re: [PATCH 3/4] spi: Add OF binding support for SPI busses

2008-05-22 Thread David Brownell
On Wednesday 21 May 2008, Anton Vorontsov wrote: +++ b/drivers/spi/spi_of.c I think better placement for this is drivers/of, no? Yes please. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: SD-MMC over SPI on PSC6

2008-05-22 Thread David Brownell
On Thursday 22 May 2008, Fabio Tosetto wrote: * MMC host test driver Unwise unless you really want to trash every MMC or SD card you insert ... You might consider not crossposting to such a large proportion of the free world, by the way. ___

Re: [spi-devel-general] [PATCH 3/4] spi: Add OF binding support for SPI busses

2008-05-22 Thread David Brownell
On Wednesday 21 May 2008, Grant Likely wrote: spi-controller {        #address-cells = 2;        #size-cells = 0;       [EMAIL PROTECTED],f000 { reg = 0 f000 ; } // CS 0, SPI address f000       [EMAIL PROTECTED],f000 { reg = 1 f000 ; } // CS 1, SPI address f000       [EMAIL

[PATCH 1/1] Merge Axon MSI trigger debugging

2008-05-22 Thread Michael Ellerman
This patch adds some debugging code to the Axon MSI driver. It creates a file per MSIC in /sys/kernel/debug/powerpc, which allows the user to trigger a fake MSI interrupt by writing to the file. This can be used to test some of the MSI generation path. In particular that the MSIC recognises a

[PATCH] Remove unnecessary cast in arch_deref_entry_point()

2008-05-22 Thread Michael Ellerman
func_descr_t-entry is already an unsigned long. Mea culpa. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- arch/powerpc/kernel/kprobes.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/kernel/kprobes.c b/arch/powerpc/kernel/kprobes.c index

Re: [patch 1/2] powerpc: rmb fix

2008-05-22 Thread Nick Piggin
On Fri, May 23, 2008 at 12:14:41PM +1000, Paul Mackerras wrote: Nick Piggin writes: More than one device driver does raw/relaxed io accessors and expects the *mb functions to order them. Can you point us at an example? Uh, I might be getting confused because the semantics are completely

Re: [PATCH] [POWERPC] Add the PC speaker only when requested so

2008-05-22 Thread Grant Likely
On Thu, May 22, 2008 at 9:34 PM, Kumar Gala [EMAIL PROTECTED] wrote: On May 22, 2008, at 6:27 PM, Grant Likely wrote: On Thu, May 22, 2008 at 4:40 PM, Emil Medve [EMAIL PROTECTED] wrote: This will cause this minor boot-time debugging error message to go away: [1.316451] calling

Re: [patch 1/2] powerpc: rmb fix

2008-05-22 Thread Paul Mackerras
Nick Piggin writes: There don't seem to actually be read*_relaxed calls that also use rmb in the same file (although there is no reason why they might not appear). But I must be thinking of are the raw_read accessors. They aren't ordered on powerpc, and a few drivers appear to hope rmb() will

[PATCH] [POWERPC] viotape: use unlocked_ioctl

2008-05-22 Thread Stephen Rothwell
This pushes the BKL down into the driver. Based on a patch by Alan Cox. We need to do it this way for now as the inode parameter of viotap_ioctl is used internally as a flag. We should do a further cleanup patch. Cc: Alan Cox [EMAIL PROTECTED] Signed-off-by: Stephen Rothwell [EMAIL PROTECTED]

Re: [patch 1/2] powerpc: rmb fix

2008-05-22 Thread Nick Piggin
On Fri, May 23, 2008 at 02:53:21PM +1000, Paul Mackerras wrote: Nick Piggin writes: There don't seem to actually be read*_relaxed calls that also use rmb in the same file (although there is no reason why they might not appear). But I must be thinking of are the raw_read accessors. They