Re: [RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-04-06 Thread Benjamin Herrenschmidt
On Wed, 2010-04-07 at 10:27 +0530, Vaidyanathan Srinivasan wrote: > > Check the result. Also that's not a nice way to do that, you should look > > for /cpus by path I reckon. > > I will check the return code, but why do you feel getting the node by > path is better? Is there any race, or we may

Re: [RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-04-06 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt [2010-04-07 12:04:49]: > On Wed, 2010-03-03 at 23:48 +0530, Vaidyanathan Srinivasan wrote: > > Hi, > > > diff --git a/arch/powerpc/kernel/setup-common.c > > b/arch/powerpc/kernel/setup-common.c > > index 03dd6a2..fbd93e3 100644 > > --- a/arch/powerpc/kernel/setup-common

Re: powermac/low_i2c.c: three minor problems

2010-04-06 Thread Benjamin Herrenschmidt
On Sat, 2010-02-06 at 12:13 +, d binderman wrote: > > Hello there, > > I just ran the sourceforge tool cppcheck over the source code of the > new Linux kernel 2.6.33-rc6 Hi ! All your patches have various problems with the actual patch format. Patches should be submitted so that they apply

Re: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver

2010-04-06 Thread David Miller
From: Eric Dumazet Date: Mon, 05 Apr 2010 23:29:53 +0200 > So, I ask, cant you use netdev_alloc_skb_ip_align() in this driver ? Thanks to everyone for getting this patch into shape. I applied version 4 of the patch to net-next-2.6, thanks! ___ Linuxpp

Re: [RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-04-06 Thread Benjamin Herrenschmidt
On Wed, 2010-03-03 at 23:48 +0530, Vaidyanathan Srinivasan wrote: > Hi, > diff --git a/arch/powerpc/kernel/setup-common.c > b/arch/powerpc/kernel/setup-common.c > index 03dd6a2..fbd93e3 100644 > --- a/arch/powerpc/kernel/setup-common.c > +++ b/arch/powerpc/kernel/setup-common.c > @@ -359,6 +359,8

[PATCH] powerpc/pseries: Flush lazy kernel mappings after unplug operations

2010-04-06 Thread Benjamin Herrenschmidt
This ensures that the translations for unmapped IO mappings or unmapped memory are properly removed from the MMU hash table before such an unplug. Without this, the hypervisor refuses the unplug operations due to those resources still being mapped by the partition. Signed-off-by: Benjamin Herrensc

Re: ppc4xx emac support of phy-less devices patch + dts example

2010-04-06 Thread Benjamin Herrenschmidt
On Fri, 2010-02-19 at 13:32 +0100, staale.aakerm...@kongsberg.com wrote: > Hi, Hi ! Sorry for the delay, I've been busy with other things and your message slipped a bit through the cracks. > I'm currently working on a custom embedded card with ppc405ex > installed. > > On this card, EMAC1 is

[PATCH] [V4] Add non-Virtex5 support for LL TEMAC driver

2010-04-06 Thread John Linn
This patch adds support for using the LL TEMAC Ethernet driver on non-Virtex 5 platforms by adding support for accessing the Soft DMA registers as if they were memory mapped instead of solely through the DCR's (available on the Virtex 5). The patch also updates the driver so that it runs on the Mi

[PATCH v3 3/6] RapidIO: Add Port-Write handling for EM

2010-04-06 Thread Alexandre Bounine
From: Alexandre Bounine Add RapidIO Port-Write message handling in the context of Error Management Extensions Specification Rev.1.3. Signed-off-by: Alexandre Bounine Tested-by: Thomas Moll Cc: Matt Porter --- arch/powerpc/sysdev/fsl_rio.c |2 drivers/rapidio/rio-scan.c| 1

[PATCH v3 1/6] RapidIO: Add IDT CPS/TSI switches

2010-04-06 Thread Alexandre Bounine
From: Alexandre Bounine Extentions to RapidIO switch support: 1. modify switch route operation declarations to allow using single switch-specific file for family of switches that share the same route table operations. 2. add standard route table operations for switches that that support

[PATCH v3 2/6] RapidIO: Add switch locking during discovery

2010-04-06 Thread Alexandre Bounine
From: Alexandre Bounine Add switch access locking during RapidIO discovery. Access lock is required when reading switch routing table contents due to indexed mechanism of RT addressing. Signed-off-by: Alexandre Bounine Tested-by: Thomas Moll Cc: Matt Porter --- rio-scan.c | 164 ++

[PATCH v3 4/6] RapidIO, powerpc/85xx: Add Port-Write message handler for SRIO port

2010-04-06 Thread Alexandre Bounine
From: Alexandre Bounine Add RapidIO Port-Write message handler for Freescale SoCs with RapidIO port. Signed-off-by: Alexandre Bounine Tested-by: Thomas Moll Cc: Matt Porter --- fsl_rio.c | 263 +- 1 files changed, 260 insertions(

[PATCH v3 6/6] RapidIO: Add enabling SRIO port RX and TX

2010-04-06 Thread Alexandre Bounine
From: Thomas Moll Add the functionality to enable Input receiver and Output transmitter of every port, to allow non-maintenance traffic. Signed-off-by: Thomas Moll Cc: Matt Porter --- drivers/rapidio/Kconfig| 11 ++ drivers/rapidio/rio-scan.c | 79 +++

[PATCH v3 5/6] RapidIO, powerpc/85xx: Add MChk handler for SRIO port

2010-04-06 Thread Alexandre Bounine
From: Alexandre Bounine Add Machine Check exception handling into RapidIO port driver for Freescale SoCs (MPC85xx). Signed-off-by: Alexandre Bounine Tested-by: Thomas Moll Cc: Matt Porter --- fsl_rio.c | 74 ++ 1 files changed,

RE: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver

2010-04-06 Thread John Linn
> -Original Message- > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Tuesday, April 06, 2010 2:24 PM > To: grant.lik...@secretlab.ca > Cc: John Linn; net...@vger.kernel.org; linuxppc-...@ozlabs.org; > jwbo...@linux.vnet.ibm.com; > john.willi...@petalogix.com; michal.si...@peta

Re: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver

2010-04-06 Thread Eric Dumazet
Le mardi 06 avril 2010 à 12:53 -0600, Grant Likely a écrit : > Hold on BUFFER_ALIGN is being used to align the DMA buffer on a > cache line boundary. I don't think netdev_alloc_skb() makes any > guarantees about how the start of the IP header lines up against cache > line boundaries. The amo

RE: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver

2010-04-06 Thread John Linn
> -Original Message- > From: Steven J. Magnani [mailto:st...@digidescorp.com] > Sent: Tuesday, April 06, 2010 2:04 PM > To: grant.lik...@secretlab.ca > Cc: John Linn; Eric Dumazet; net...@vger.kernel.org; linuxppc-...@ozlabs.org; > jwbo...@linux.vnet.ibm.com; john.willi...@petalogix.com; mi

RE: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver

2010-04-06 Thread John Linn
> -Original Message- > From: glik...@secretlab.ca [mailto:glik...@secretlab.ca] On Behalf Of Grant > Likely > Sent: Tuesday, April 06, 2010 12:54 PM > To: John Linn > Cc: Eric Dumazet; net...@vger.kernel.org; linuxppc-...@ozlabs.org; > jwbo...@linux.vnet.ibm.com; > john.willi...@petalogix

Re: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver

2010-04-06 Thread Steven J. Magnani
On Tue, 2010-04-06 at 12:53 -0600, Grant Likely wrote: > Hold on BUFFER_ALIGN is being used to align the DMA buffer on a > cache line boundary. I don't think netdev_alloc_skb() makes any > guarantees about how the start of the IP header lines up against cache > line boundaries. The amount of

Re: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver

2010-04-06 Thread Grant Likely
On Tue, Apr 6, 2010 at 11:11 AM, John Linn wrote: >> -Original Message- >> From: Eric Dumazet [mailto:eric.duma...@gmail.com] >> Sent: Tuesday, April 06, 2010 11:01 AM >> To: John Linn >> Cc: net...@vger.kernel.org; linuxppc-...@ozlabs.org; >> grant.lik...@secretlab.ca; >> jwbo...@linux.v

Re: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver

2010-04-06 Thread Grant Likely
On Mon, Apr 5, 2010 at 3:33 PM, John Linn wrote: > From: Eric Dumazet [mailto:eric.duma...@gmail.com] >> > +/* Align the IP data in the packet on word boundaries as MicroBlaze >> > + * needs it. >> > + */ >> > + >> >  #define XTE_ALIGN       32 >> > -#define BUFFER_ALIGN(adr) ((XTE_ALIGN - ((u32)

RE: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver

2010-04-06 Thread Eric Dumazet
> > Yes I see how it's used, but it only allows you to reserve 2 bytes in the skb > with no options. Really ? This would be a bug ! __alloc_skb() uses kmalloc(), this gives you the guarantee you want, or maybe comment you wrote is not what is _really_ necessary ? /* Align the IP data in

RE: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver

2010-04-06 Thread John Linn
> -Original Message- > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Tuesday, April 06, 2010 11:01 AM > To: John Linn > Cc: net...@vger.kernel.org; linuxppc-...@ozlabs.org; > grant.lik...@secretlab.ca; > jwbo...@linux.vnet.ibm.com; john.willi...@petalogix.com; > michal.si...@

RE: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver

2010-04-06 Thread Eric Dumazet
Le mardi 06 avril 2010 à 10:12 -0600, John Linn a écrit : > > -Original Message- > > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > > Sent: Monday, April 05, 2010 3:30 PM > > To: John Linn > > Cc: net...@vger.kernel.org; linuxppc-...@ozlabs.org; > > grant.lik...@secretlab.ca; > > jwb

RE: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver

2010-04-06 Thread John Linn
> -Original Message- > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Monday, April 05, 2010 3:30 PM > To: John Linn > Cc: net...@vger.kernel.org; linuxppc-...@ozlabs.org; > grant.lik...@secretlab.ca; > jwbo...@linux.vnet.ibm.com; john.willi...@petalogix.com; > michal.si...@pe

Re: [PATCH] 460EX on-chip SATA driver < resubmission : 02>

2010-04-06 Thread Jeff Garzik
On 04/06/2010 07:41 AM, Rupjyoti Sarmah wrote: General comment: remove "inline" and let the compiler select those functions that need it. +struct sata_dwc_host_priv { + + void __iomem *scr_addr_sstatus; + u32 sata_dwc_sactive_issued; + u32 sata_dwc_sactive_queued; +

RE: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver

2010-04-06 Thread Steven J. Magnani
On Mon, 2010-04-05 at 15:33 -0600, John Linn wrote: > > > +/* Align the IP data in the packet on word boundaries as MicroBlaze > > > + * needs it. > > > + */ > > > + > > > #define XTE_ALIGN 32 > > > -#define BUFFER_ALIGN(adr) ((XTE_ALIGN - ((u32) adr)) % XTE_ALIGN) > > > +#define BUFFER_ALIG

Re: [PATCH 4/7] hvc_console: Fix race between hvc_close and hvc_remove

2010-04-06 Thread Alan Cox
> I don't claim to understand the tty layer, but it seems like hvc_open and > hvc_close should be balanced in their kref reference counting. They should yes. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/l

Re: [PATCH 4/7] hvc_console: Fix race between hvc_close and hvc_remove

2010-04-06 Thread Sachin Sant
Anton Blanchard wrote: The patch below changes things to call tty_kref_put once for every hvc_close call, and with that my machine boots fine. Signed-off-by: Anton Blanchard --- Works for me. Thanks Anton. Regards -Sachin diff --git a/drivers/char/hvc_console.c b/drivers/char/hvc_console

Re: [PATCH 4/7] hvc_console: Fix race between hvc_close and hvc_remove

2010-04-06 Thread Amit Shah
On (Tue) Apr 06 2010 [21:42:38], Anton Blanchard wrote: > > Hi, > > > > Looking at the commit e74d098c66543d0731de62eb747ccd5b636a6f4c, > > > i see that for every tty_kref_get() there is a corresponding > > > tty_kref_put() except maybe for the one in the following patch snippet > > > > > >

Re: [PATCH 4/7] hvc_console: Fix race between hvc_close and hvc_remove

2010-04-06 Thread Anton Blanchard
Hi, > > Looking at the commit e74d098c66543d0731de62eb747ccd5b636a6f4c, > > i see that for every tty_kref_get() there is a corresponding > > tty_kref_put() except maybe for the one in the following patch snippet > > > >spin_lock_irqsave(&hp->lock, flags); > >/* Check and then incr

Re: Continual reading from the PowerPc time base register is not stable

2010-04-06 Thread Csdncannon
Hi guys In fact my problem is gettimeofday cannot return right value sometimes, and this will bring instability to our system software. You can find a law from the log that there is a 17592 seconds' shift every time error occurs. 2010/3/26 Csdncannon > Yes, the missing 64-bit conversion