Re: pci_request_regions() failure

2010-09-08 Thread Ravi Gupta
Hi Tiejun, Thanks for the reply. Your PCI device should be one virtual device so I think the above should be as we understood. You know 0x ~ 0x3 should not be allowed to reserved. Can you explain a little more that what do you mean by Your PCI device should be one virtual

[PATCH RFCv2 0/5] CARMA Board Support

2010-09-08 Thread Ira W. Snyder
Hello everyone, This is the second posting of these drivers, taking into account comments from the RFCv1 post. Thanks to all that contributed. The changes: - change comments to kerneldoc format - Kconfig improvements - use the videobuf_dma_sg API in the programmer - updates for Freescale

[PATCH 1/5] fsldma: fix missing header include

2010-09-08 Thread Ira W. Snyder
The slab.h header is required to use the kmalloc() family of functions. Due to recent kernel changes, this header must be directly included by code that calls into the memory allocator. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu --- arch/powerpc/include/asm/fsldma.h |1 + 1 files

[PATCH 2/5] fsldma: move DMA_SLAVE support functions to the driver

2010-09-08 Thread Ira W. Snyder
The DMA_SLAVE support functions all existed as static inlines in the driver specific header arch/powerpc/include/asm/fsldma.h. Move the body of the functions to the driver itself, and EXPORT_SYMBOL_GPL() them. At the same time, add the missing linux/list.h header. Signed-off-by: Ira W. Snyder

[PATCH 5/5] fpga: add CARMA DATA-FPGA Programmer support

2010-09-08 Thread Ira W. Snyder
This adds support for programming the data processing FPGAs on the OVRO CARMA board. These FPGAs have a special programming sequence that requires that we program the Freescale DMA engine, which is only available inside the kernel. Signed-off-by: Ira W. Snyder i...@ovro.caltech.edu ---

RE: [PATCH] APM821xx: Add support for new SoC APM821xx

2010-09-08 Thread Tirumala Marri
CPU portion uses SoC name. Hm, you're right. Confusing. Still, the cpu setup functions would make more sense to have the core name in, not the SoC name. Especially since multiple SoC families might use the same core, etc. [Marri] I agree. Probably we need another node which identifies SoC

Re: [PATCH] arch/powerpc/platforms/52xx/efika.c: Add of_node_put to avoid memory leak

2010-09-08 Thread Grant Likely
On Sat, Sep 04, 2010 at 09:13:17AM +0200, Julia Lawall wrote: This function is implemented as though the function of_get_next_child does not increment the reference count of its result, but actually it does. Thus the patch adds of_node_put in error handling code and drops a call to

Re: [PATCH v2] powerpc/5200: tighten up ac97 reset timing

2010-09-08 Thread Grant Likely
On Fri, Sep 03, 2010 at 01:27:38PM -0400, Eric Millbrandt wrote: Tighten up time timing around the gpio reset functionality. Add a 200ns delay before remuxing the pins back to ac97 to comply with the ac97 spec. Signed-off-by: Eric Millbrandt emillbra...@dekaresearch.com --- Scope shots

Re: [PATCH 7/7] arch/powerpc/platforms/cell: Add of_node_put to avoid memory leak

2010-09-08 Thread Grant Likely
On Sun, Aug 29, 2010 at 11:52:46AM +0200, Julia Lawall wrote: Add calls to of_node_put in the error handling code following calls to of_find_node_by_path and of_find_node_by_phandle. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@

Re: [PATCH 6/7] arch/powerpc/platforms/maple/setup.c: Add of_node_put to avoid memory leak

2010-09-08 Thread Grant Likely
On Sun, Aug 29, 2010 at 11:52:45AM +0200, Julia Lawall wrote: Add a call to of_node_put in the error handling code following a call to of_find_node_by_path. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ local idexpression x;

Re: [PATCH 4/7] arch/powerpc/platforms/powermac/pfunc_core.c: Add of_node_put to avoid memory leak

2010-09-08 Thread Grant Likely
[cc'ing linuxppc-dev] On Sun, Aug 29, 2010 at 11:52:43AM +0200, Julia Lawall wrote: Add a call to of_node_put in the error handling code following a call to of_find_node_by_phandle. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@

Re: [PATCH 1/4] drivers/serial/ucc_uart.c: Add of_node_put to avoid memory leak

2010-09-08 Thread Grant Likely
On Tue, Aug 31, 2010 at 05:48:55PM +0200, Julia Lawall wrote: Add a call to of_node_put in the error handling code following a call to of_find_compatible_node or of_find_node_by_type. This patch also substantially reorganizes the error handling code in the function, to that it is possible

Re: [PATCH 4/4] arch/powerpc/platforms/chrp/nvram.c: Add of_node_put to avoid memory leak

2010-09-08 Thread Grant Likely
On Tue, Aug 31, 2010 at 05:48:58PM +0200, Julia Lawall wrote: Add a call to of_node_put in the error handling code following a call to of_find_node_by_type. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ local idexpression x;

[PATCH][v2] mpc8308_p1m: support for MPC8308 P1M board

2010-09-08 Thread Ilya Yanok
This patch adds support for MPC8308 P1M board. Supported devices: DUART Dual Ethernet NOR flash Both I2C controllers USB in peripheral mode PCI Express Signed-off-by: Ilya Yanok ya...@emcraft.com --- Scott's comments addressed. arch/powerpc/boot/dts/mpc8308_p1m.dts | 332

Re: [PATCH 0/8] sdhci: Move real work out of an atomic context

2010-09-08 Thread Anton Vorontsov
On Wed, Sep 08, 2010 at 10:37:41PM +0100, Chris Ball wrote: Hi Andrew, On Tue, Sep 07, 2010 at 03:38:13PM -0700, Andrew Morton wrote: I noticed no throughput drop neither with PIO transfers nor with DMA (tested on MPC8569E CPU), while latencies should be greatly improved. This

Re: [PATCH][v2] mpc8308_p1m: support for MPC8308 P1M board

2010-09-08 Thread Scott Wood
On Wed, 8 Sep 2010 23:54:46 +0200 Ilya Yanok ya...@emcraft.com wrote: + c...@2,0 { + compatible = cpld; + reg = 0x2 0x0 0x8; + interrupts = 48 0x8; + interrups-parent = ipic; + }; Sorry,

Re: [PATCH 0/8] sdhci: Move real work out of an atomic context

2010-09-08 Thread Anton Vorontsov
On Wed, Sep 08, 2010 at 11:05:48PM +0100, Chris Ball wrote: Hi Anton, On Thu, Sep 09, 2010 at 01:57:50AM +0400, Anton Vorontsov wrote: Thanks! Would be also great if you could point out which patch causes most of the performance drop (if any)? Albert, if you could find time, can

[no subject]

2010-09-08 Thread Tirumala Marri
Is anyone working on Linus suggestion to combine the defconfigs under 44x or 4xx ? Thanks, Marri ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Combining defconfigs for 44x based boards

2010-09-08 Thread Tirumala Marri
Is anyone working on Linus suggestion to combine the defconfigs under 44x or 4xx ? Thanks, Marri ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 0/8] sdhci: Move real work out of an atomic context

2010-09-08 Thread Chris Ball
Hi Andrew, On Tue, Sep 07, 2010 at 03:38:13PM -0700, Andrew Morton wrote: I noticed no throughput drop neither with PIO transfers nor with DMA (tested on MPC8569E CPU), while latencies should be greatly improved. This patchset isn't causing any problems yet, but may do so in the future

Re: [PATCH 0/8] sdhci: Move real work out of an atomic context

2010-09-08 Thread Chris Ball
Hi Anton, On Thu, Sep 09, 2010 at 01:57:50AM +0400, Anton Vorontsov wrote: Thanks! Would be also great if you could point out which patch causes most of the performance drop (if any)? Albert, if you could find time, can you also bisect the patchset? I wouldn't want to buy Nintendo WII

Combining defconfigs for 44x based boards

2010-09-08 Thread Tirumala Marri
Is anyone working on combining defconfigs for 44x or 4xx devices ? Regards, Marri ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

CONFIG_PROVE_LOCKING broken on 83xx (and all of powerpc?)

2010-09-08 Thread Ira W. Snyder
Hello everyone, I'm running Linux on a Freescale MPC8349EA board (PowerPC 6xx processor). When I enable the CONFIG_PROVE_LOCKING option, the kernel fails to boot. If I toggle that option (and ONLY that option) off, the kernel boots normally. The lockup happens very, very early during boot. Much

[PATCH][v3] mpc8308_p1m: support for MPC8308 P1M board

2010-09-08 Thread Ilya Yanok
This patch adds support for MPC8308 P1M board. Supported devices: DUART Dual Ethernet NOR flash Both I2C controllers USB in peripheral mode PCI Express Signed-off-by: Ilya Yanok ya...@emcraft.com --- Changed 'compatible' entry for 'cpld' node to denx,mpc8308_p1m-cpld

Re: Combining defconfigs for 44x based boards

2010-09-08 Thread Josh Boyer
On Wed, Sep 08, 2010 at 03:40:37PM -0700, Tirumala Marri wrote: Is anyone working on Linus suggestion to combine the defconfigs under 44x or 4xx ? Linus made a suggestion to that effect? If so, I missed it. Have a pointer? josh ___ Linuxppc-dev

Re: Combining defconfigs for 44x based boards

2010-09-08 Thread Olof Johansson
On Wed, Sep 08, 2010 at 03:40:37PM -0700, Tirumala Marri wrote: Is anyone working on Linus suggestion to combine the defconfigs under 44x or 4xx ? Do you mean ppc44x_defconfig? Already there. -Olof ___ Linuxppc-dev mailing list

Re: CONFIG_PROVE_LOCKING broken on 83xx (and all of powerpc?)

2010-09-08 Thread Benjamin Herrenschmidt
On Wed, 2010-09-08 at 16:21 -0700, Ira W. Snyder wrote: I am happy to provide more information if it will help. I'm not especially good at working the debugger. I can't get it to stop at machine_init() and let me step through the code. I tried this feature when it first became

Re: Combining defconfigs for 44x based boards

2010-09-08 Thread Stephen Rothwell
Hi Marri, On Wed, 8 Sep 2010 15:39:29 -0700 Tirumala Marri tma...@apm.com wrote: Is anyone working on Linus suggestion to combine the defconfigs under 44x or 4xx ? Are arch/powerpc/configs/ppc44x_defconfig and ppc40x_defconfig what you want? Or do you mean the Kconfig based versions? --

RE: Combining defconfigs for 44x based boards

2010-09-08 Thread Tirumala Marri
Linus made a suggestion to that effect? If so, I missed it. Have a pointer? There was discussion going on in arm-kernel mailing list. And I see some patches being submitted for ARM based boards. I think we can also combine some of the defconfigs under arch/powerpc/configs/44x/ directory.

RE: Combining defconfigs for 44x based boards

2010-09-08 Thread Tirumala Marri
On Wed, Sep 08, 2010 at 03:40:37PM -0700, Tirumala Marri wrote: Is anyone working on Linus suggestion to combine the defconfigs under 44x or 4xx ? Do you mean ppc44x_defconfig? Already there. No it is not there yet. I should have said Linus suggestion about defconfigs in ARM mailing list.

RE: Combining defconfigs for 44x based boards

2010-09-08 Thread Tirumala Marri
Linus made a suggestion to that effect? If so, I missed it. Have a pointer? I am thinking that we can combine arches, Canyonlands, glacier, redwood and eiger can be combined as ppc46x_defconfig. here is the defconfig example --- # # Automatically generated make config: don't edit

Re: Combining defconfigs for 44x based boards

2010-09-08 Thread Olof Johansson
On Wed, Sep 08, 2010 at 07:11:11PM -0700, Tirumala Marri wrote: On Wed, Sep 08, 2010 at 03:40:37PM -0700, Tirumala Marri wrote: Is anyone working on Linus suggestion to combine the defconfigs under 44x or 4xx ? Do you mean ppc44x_defconfig? Already there. No it is not there yet. I

Re: [PATCH 0/8] sdhci: Move real work out of an atomic context

2010-09-08 Thread Chris Ball
Hi, On Wed, Sep 08, 2010 at 10:37:41PM +0100, Chris Ball wrote: Hi Andrew, On Tue, Sep 07, 2010 at 03:38:13PM -0700, Andrew Morton wrote: I noticed no throughput drop neither with PIO transfers nor with DMA (tested on MPC8569E CPU), while latencies should be greatly improved.

Re: CONFIG_PROVE_LOCKING broken on 83xx (and all of powerpc?)

2010-09-08 Thread Ira W. Snyder
On Thu, Sep 09, 2010 at 11:02:36AM +1000, Benjamin Herrenschmidt wrote: On Wed, 2010-09-08 at 16:21 -0700, Ira W. Snyder wrote: I am happy to provide more information if it will help. I'm not especially good at working the debugger. I can't get it to stop at machine_init() and let

Re: CONFIG_PROVE_LOCKING broken on 83xx (and all of powerpc?)

2010-09-08 Thread Benjamin Herrenschmidt
On Wed, 2010-09-08 at 19:52 -0700, Ira W. Snyder wrote: I will attempt to get the debugger to stop at start_kernel. I'm having trouble driving the JTAG debugger (a BDI2000). I have used Denx's guide [1] in the past, but the section on debugging the kernel itself is now missing. [1]