[PATCH 4/4] sound/aoa/fabrics/layout.c: remove unneeded kfree

2011-08-20 Thread Julia Lawall
From: Julia Lawall ju...@diku.dk The label outnodev is only used when kzalloc has not yet taken place or has failed, so there is no need for the call for kfree under this label. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) //

[PATCH 2/2] sound/soc/fsl/mpc8610_hpcd.c: add missing of_node_put

2011-08-20 Thread Julia Lawall
From: Julia Lawall ju...@diku.dk The first change is to add an of_node_put, since codec_np has previously been allocated. The rest of the patch reorganizes the error handling code so the only code executed is that which is needed. A simplified version of the semantic match that finds this

[PATCH] sound/soc/fsl/fsl_dma.c: add missing of_node_put

2011-08-20 Thread Julia Lawall
From: Julia Lawall ju...@diku.dk of_parse_phandle increments the reference count of np, so this should be decremented before trying the next possibility. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression e,e1,e2; @@ *e =

Re: [PATCH 4/4] sound/aoa/fabrics/layout.c: remove unneeded kfree

2011-08-20 Thread Takashi Iwai
At Sat, 20 Aug 2011 08:12:41 +0200, Julia Lawall wrote: From: Julia Lawall ju...@diku.dk The label outnodev is only used when kzalloc has not yet taken place or has failed, so there is no need for the call for kfree under this label. A simplified version of the semantic match that finds

Re: kvm PCI assignment VFIO ramblings

2011-08-20 Thread Alex Williamson
We had an extremely productive VFIO BoF on Monday. Here's my attempt to capture the plan that I think we agreed to: We need to address both the description and enforcement of device groups. Groups are formed any time the iommu does not have resolution between a set of devices. On x86, this