Thanks for your review.
-Original Message-
From: Wood Scott-B07421
Sent: 2013年10月29日 星期二 11:26
To: Tang Yuantian-B29983
Cc: Wood Scott-B07421; Mark Rutland; devicet...@vger.kernel.org;
linuxppc-dev@lists.ozlabs.org; Li Yang-Leo-R58472
Subject: Re: [PATCH v5] powerpc/mpc85xx: Update
-Original Message-
From: Chen Guangyu-B42378
Sent: Tuesday, October 29, 2013 12:02 PM
To: Xiubo Li-B47053
Cc: Mark Brown; Guo Shawn-R65073; ti...@tabi.org; lgirdw...@gmail.com;
Jin Zhengxiong-R64188; rob.herr...@calxeda.com; pawel.m...@arm.com;
mark.rutl...@arm.com;
On Mon, Oct 28, 2013 at 10:58:58PM +0200, Victor Kaplansky wrote:
Oleg Nesterov o...@redhat.com wrote on 10/28/2013 10:17:35 PM:
mb(); // : do we really need it? I think yes.
Oh, it is hard to argue with feelings. Also, it is easy to be on
conservative side and put the
On Tue, Oct 29, 2013 at 11:21:31AM +0100, Peter Zijlstra wrote:
On Mon, Oct 28, 2013 at 10:58:58PM +0200, Victor Kaplansky wrote:
Oleg Nesterov o...@redhat.com wrote on 10/28/2013 10:17:35 PM:
mb(); // : do we really need it? I think yes.
Oh, it is hard to argue with
On Tue, Oct 29, 2013 at 11:30:57AM +0100, Peter Zijlstra wrote:
@@ -154,9 +175,11 @@ int perf_output_begin(struct perf_output
* Userspace could choose to issue a mb() before updating the
* tail pointer. So that all reads will be completed before the
This patch series consolidates the backend cpuidle driver for pSeries
and powernv platforms with minimal code duplication.
Current existing backend driver for pseries has been moved to drivers/cpuidle
and has been extended to accommodate powernv idle power mgmt states.
As seen in V1 of this
This patch replaces the cpuidle driver and devices initialisation
calls with a single generic cpuidle_register() call
and also includes minor refactoring of the code around it.
Signed-off-by: Deepthi Dharwar deep...@linux.vnet.ibm.com
---
drivers/cpuidle/cpuidle-ibm-power.c | 80
Move the file from arch specific pseries/processor_idle.c
to drivers/cpuidle/cpuidle-ibm-power.c
Make the relevant Makefile and Kconfig changes.
This will enable having a common backend cpuidle driver
for POWER platform going forward.
Signed-off-by: Deepthi Dharwar deep...@linux.vnet.ibm.com
---
Currently pseries_idle cpuidle backend driver cannot be
built as a module due to dependencies. Therefore the driver has
to be built in. The dependency is around update_snooze_delay() defined
in cpuidle driver and called from kernel/sysfs.c.
This patch is removes all the module related code.
This patch removes the usage of MAX_IDLE_STATE macro
and dead code around it. The number of states
are determined at run time based on the cpuidle
state table selected on a given platform
Signed-off-by: Deepthi Dharwar deep...@linux.vnet.ibm.com
---
drivers/cpuidle/cpuidle-ibm-power.c | 26
This patch includes cleanup and refactoring of the
existing code to make the driver POWER generic.
* Re-naming the functions from pseries to generic power.
* Re-naming the backend driver from pseries_idle to
ibm-power-idle.
Signed-off-by: Deepthi Dharwar deep...@linux.vnet.ibm.com
---
The following patch extends the current power backend
idle driver to the powernv platform.
Signed-off-by: Deepthi Dharwar deep...@linux.vnet.ibm.com
---
drivers/cpuidle/cpuidle-ibm-power.c | 39 ---
1 file changed, 36 insertions(+), 3 deletions(-)
diff --git
This patch enables idle cpu on the powernv platform to hook on to the cpuidle
framework, if available, else call on to default idle platform
code.
Signed-off-by: Deepthi Dharwar deep...@linux.vnet.ibm.com
---
arch/powerpc/platforms/powernv/setup.c | 13 -
1 file changed, 12
This patch enables Tx-related SIER_FLAGS only when direction is PLAYBACK
and does same thing for CAPTURE. Also, after TRIGGER_STOP/PAUSE, it will
disable SIER_xFLAGS for symmetric.
[ Passed compile-test with mpc85xx_defconfig ]
Signed-off-by: Nicolin Chen b42...@freescale.com
---
In Aperture type of IOMMU (like FSL PAMU), VFIO-iommu system need to know
the MSI region to map its window in h/w. This patch just defines the
required weak functions only and will be used by followup patches.
Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com
---
drivers/pci/msi.c |
So by now we have defined all the interfaces for getting the msi region,
this patch expose the interface to linux subsystem. These will be used by
vfio subsystem for setting up iommu for MSI interrupt of direct assignment
devices.
Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com
---
This patch adds the interface to get the msi region information from arch
specific code. The machine spicific code is not yet defined.
Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com
---
arch/powerpc/include/asm/machdep.h |8
arch/powerpc/kernel/msi.c | 18
The FSL MSI will provide the interface to get:
- Number of MSI regions (which is number of MSI banks for powerpc)
- Get the region address range: Physical page which have the
address/addresses used for generating MSI interrupt
and size of the page.
These are required to create IOMMU
PAMU (FSL IOMMU) has a concept of primary window and subwindows.
Primary window corresponds to the complete guest iova address space
(including MSI space), with respect to IOMMU_API this is termed as
geometry. IOVA Base of subwindow is determined from the number of
subwindows (configurable using
From: Bharat Bhushan bharat.bhus...@freescale.com
PAMU (FSL IOMMU) has a concept of primary window and subwindows.
Primary window corresponds to the complete guest iova address space
(including MSI space), with respect to IOMMU_API this is termed as
geometry. IOVA Base of subwindow is determined
Nicolin Chen wrote:
This patch enables Tx-related SIER_FLAGS only when direction is PLAYBACK
and does same thing for CAPTURE. Also, after TRIGGER_STOP/PAUSE, it will
disable SIER_xFLAGS for symmetric.
I'm okay with this patch in principle, but why bother? The sysfs entry
is going to display
On Tue, Oct 29, 2013 at 06:59:44AM -0500, Timur Tabi wrote:
Nicolin Chen wrote:
This patch enables Tx-related SIER_FLAGS only when direction is PLAYBACK
and does same thing for CAPTURE. Also, after TRIGGER_STOP/PAUSE, it will
disable SIER_xFLAGS for symmetric.
I'm okay with this patch in
Nicolin Chen wrote:
Well, actually I just wanted to clear T/RDMAE to disable DMA request,
but it seems to be much easier to do it like this based on current
code and disabling unused interrupts should be better right?:)
It's not better if it complicates the code and has no real impact. The
On Tue, Oct 29, 2013 at 07:18:21AM -0500, Timur Tabi wrote:
Nicolin Chen wrote:
Well, actually I just wanted to clear T/RDMAE to disable DMA request,
but it seems to be much easier to do it like this based on current
code and disabling unused interrupts should be better right?:)
It's not
Changelog
v1:
* SSI can reduce hardware overrun/underrun possibility when using dual
* fifo mode. To support this mode, we need to first update sdma sciprt
* list, and then enable dual fifo BIT in SSI driver, and last update DT
* bindings of i.MX series.
*
* ! This series of patches has a
There's a script for SSI missing in current sdma script list. Thus add it.
This script would allow SSI use its dual fifo mode to transimit/receive
data without occasional hardware underrun/overrun.
This patch also fixed a counting error for total number of scripts.
Signed-off-by: Nicolin Chen
By enabling dual fifo mode, it would allow SSI enter a better performance
to transimit/receive data without occasional hardware underrun/overrun.
[ Passed compile-test with mpc85xx_defconfig ]
Signed-off-by: Nicolin Chen b42...@freescale.com
---
sound/soc/fsl/fsl_ssi.c | 24
Use dual-fifo sdma scripts instead of shared scripts for ssi on i.MX series.
Signed-off-by: Nicolin Chen b42...@freescale.com
---
arch/arm/boot/dts/imx51.dtsi | 4 ++--
arch/arm/boot/dts/imx53.dtsi | 4 ++--
arch/arm/boot/dts/imx6qdl.dtsi | 12 ++--
arch/arm/boot/dts/imx6sl.dtsi |
Nicolin Chen wrote:
The DMA request might be remaining high if not disabling it.
Might? Are you just guessing?
This would
cause SDMA re-check this request, while it has no BD existing. For the
other interrupts, if you don't like it, I can drop it. Just modification
to the driver might not
Nicolin Chen wrote:
By enabling dual fifo mode, it would allow SSI enter a better performance
to transimit/receive data without occasional hardware underrun/overrun.
Have you measured any real performance gain with this patch? I
considered adding dual-FIFO support when I originally wrote
Without dual fifo support, handware underrun would occasionally occur and then
two audio channels would physically swap. This could be easily reproduced in
low bus frequency situation, while it would be better if we enable dual fifo.
Sent by Android device.
Timur Tabi ti...@tabi.org wrote:
I mean there is a possibility.
I'm sorry if my patch is kinda annoying and it really bother you, sir. I also
want to make things better.
If you really don't like it, we can drop it. It's all your call.
And thank you for reviewing.
Sent by Android device.
Timur Tabi ti...@tabi.org wrote:
Chen Guangyu-B42378 wrote:
Without dual fifo support, handware underrun would occasionally
occur and then two audio channels would physically swap. This could
be easily reproduced in low bus frequency situation, while it would
be better if we enable dual fifo.
Ok.
ACK.
Thank you, sir. And sorry for taking your time.
Sent by Android device.
Timur Tabi ti...@tabi.org wrote:
Chen Guangyu-B42378 wrote:
Without dual fifo support, handware underrun would occasionally
occur and then two audio channels would physically swap. This could
be easily reproduced in
Chen Guangyu-B42378 wrote:
I mean there is a possibility.
I'm sorry if my patch is kinda annoying and it really bother you, sir. I also
want to make things better.
It does not bother me. I'm glad people are working on my driver. I
just want to make sure that my driver does not get
As you wish, sir.
Sent by Android device.
Timur Tabi ti...@tabi.org wrote:
Chen Guangyu-B42378 wrote:
I mean there is a possibility.
I'm sorry if my patch is kinda annoying and it really bother you, sir. I
also want to make things better.
It does not bother me. I'm glad people are
On Tue, Oct 29, 2013 at 09:00:52AM +0530, Preeti U Murthy wrote:
Oh nice, that gets rid of the multiple atomics, and it nicely splits
this nohz logic into per topology groups -- now if only we could split
the rest too :-)
I am sorry, I don't get you here. By the 'rest', do you refer to
On Tue, Oct 29, 2013 at 08:33:15PM +0800, Nicolin Chen wrote:
There's a script for SSI missing in current sdma script list. Thus add it.
This script would allow SSI use its dual fifo mode to transimit/receive
data without occasional hardware underrun/overrun.
This patch also fixed a counting
Nope , same situation, can't find whats wrong :(
--
View this message in context:
http://linuxppc.10917.n7.nabble.com/Re-PCIE-device-errors-after-linux-kernel-upgrade-tp74563p77605.html
Sent from the linuxppc-dev mailing list archive at Nabble.com.
On Oct 29, 2013, at 7:33 AM, Nicolin Chen wrote:
There's a script for SSI missing in current sdma script list. Thus add it.
This script would allow SSI use its dual fifo mode to transimit/receive
data without occasional hardware underrun/overrun.
This patch also fixed a counting error for
On 10/29, Peter Zijlstra wrote:
On Tue, Oct 29, 2013 at 11:30:57AM +0100, Peter Zijlstra wrote:
@@ -154,9 +175,11 @@ int perf_output_begin(struct perf_output
* Userspace could choose to issue a mb() before updating the
* tail pointer. So that all reads will be
Peter Zijlstra pet...@infradead.org wrote:
On Tue, Oct 29, 2013 at 11:21:31AM +0100, Peter Zijlstra wrote:
On Mon, Oct 28, 2013 at 10:58:58PM +0200, Victor Kaplansky wrote:
Oleg Nesterov o...@redhat.com wrote on 10/28/2013 10:17:35 PM:
mb(); // : do we really need
On Mon, 2013-10-28 at 04:26 -0700, Christian Kujau wrote:
Hi,
for quite some time the following is printed (twice) after doing
make oldconfig:
[...]
scripts/kconfig/conf --oldconfig Kconfig
warning: (ADB_PMU_LED_IDE) selects LEDS_TRIGGER_IDE_DISK which has unmet
direct dependencies
On Fri, 2013-10-18 at 14:40 -0500, Tom Musta wrote:
This patch modifies the endian chicken switch in the single step
emulation code (emulate_step()). The old (big endian) code bailed
early if a load or store instruction was to be emulated in little
endian mode.
The new code modifies the
Need include the related header file, or can not pass compiling with
allmodconfig.
The related error (with allmodconfig):
CC arch/powerpc/platforms/powernv/rng.o
arch/powerpc/platforms/powernv/rng.c: In function ‘rng_init_per_cpu’:
arch/powerpc/platforms/powernv/rng.c:64:2: error:
Changes from V1:https://lkml.org/lkml/2013/10/21/248
1. Swapped the order of PATCH1 and PATCH2 in V1 so as to not mess with the
nr_busy_cpus parameter computation during asymmetric balancing, while fixing
it.
2. nohz_busy_cpus parameter is to be updated and queried at only one level of
the sched
nr_busy_cpus parameter is used by nohz_kick_needed() to find out the number
of busy cpus in a sched domain which has SD_SHARE_PKG_RESOURCES flag set.
Therefore instead of updating nr_busy_cpus at every level of sched domain,
since it is irrelevant, we can update this parameter only at the parent
The changelog has missed mentioning the introduction of sd_asym per_cpu sched
domain.
Apologies for this. The patch with the changelog including mention of sd_asym is
pasted below.
Regards
Preeti U Murthy
---
sched: Remove un-necessary iteration over sched domains to update
On Wed, 30 Oct 2013 at 10:13, Benjamin Herrenschmidt wrote:
You probably want to do that to the ADB_PMU_LED_IDE entry not the
ADB_PMU_LED one which doesn't have a dependency and isn't the one
selecting LEDS_TRIGGER_IDE_DISK :-)
Right you are, sorry for the mixup. Let me try again:
Hi Sascha,
On Tue, Oct 29, 2013 at 02:51:43PM +0100, Sascha Hauer wrote:
Look at drivers/dma/imx-sdma.c:
/**
* struct sdma_firmware_header - Layout of the firmware image
*
* @magic SDMA
* @version_major increased whenever layout of struct
* sdma_script_start_addrs
Hi Alex,
Looks like this patch is not picked by anyone, Are you going to pick this patch?
My vfio/iommu patches have dependency on this patch (this is already tested by
me).
Thanks
-Bharat
-Original Message-
From: Linuxppc-dev [mailto:linuxppc-dev-
51 matches
Mail list logo
