Re: [PATCH v8 1/4] perf, kvm/{x86, s390}: Remove dependency on uapi/kvm_perf.h

2015-09-30 Thread Hemant Kumar
On 09/28/2015 08:51 PM, David Ahern wrote: On 9/28/15 9:16 AM, Scott Wood wrote: On Mon, 2015-09-28 at 08:31 -0600, David Ahern wrote: On 9/28/15 7:00 AM, Alexander Yarygin wrote: diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c index fc1cffb..ef25fcf 100644 ---

Re: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks

2015-09-30 Thread Jiri Olsa
On Wed, Sep 30, 2015 at 11:28:36AM -0700, Sukadev Bhattiprolu wrote: > From e29a7236122c4d807ec9ebc721b5d7d75c8d Mon Sep 17 00:00:00 2001 > From: Sukadev Bhattiprolu > Date: Thu, 24 Sep 2015 17:53:49 -0400 > Subject: [PATCH v2] perf: Fix build break on powerpc due

Re: [PATCH v8 1/4] perf, kvm/{x86, s390}: Remove dependency on uapi/kvm_perf.h

2015-09-30 Thread Hemant Kumar
Hi, Thanks for the review. On 09/28/2015 06:30 PM, Alexander Yarygin wrote: Hemant Kumar writes: Its better to remove the dependency on uapi/kvm_perf.h to allow dynamic discovery of kvm events (if its needed). To do this, some extern variables have been introduced

[PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks

2015-09-30 Thread Sukadev Bhattiprolu
From e29a7236122c4d807ec9ebc721b5d7d75c8d Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Thu, 24 Sep 2015 17:53:49 -0400 Subject: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks perf_regs.c does not get built on Powerpc as

Re: [PATCH v11 1/6] genalloc:support memory-allocation with bytes-alignment to genalloc

2015-09-30 Thread Laura Abbott
On 09/28/2015 07:09 PM, Zhao Qiang wrote: Bytes alignment is required to manage some special RAM, so add gen_pool_first_fit_align to genalloc, meanwhile add gen_pool_alloc_data to pass data to gen_pool_first_fit_align(modify gen_pool_alloc as a wrapper) Signed-off-by: Zhao Qiang

Re: [PATCH v11 2/6] genalloc:support allocating specific region

2015-09-30 Thread Laura Abbott
On 09/28/2015 07:09 PM, Zhao Qiang wrote: Add new algo for genalloc, it reserve a specific region of memory matching the size requirement (no alignment constraint) Signed-off-by: Zhao Qiang Reviewed-by: Laura Abbott

Re: [PATCH RFC 0/5] powerpc:numa Add serial nid support

2015-09-30 Thread Raghavendra K T
On 09/30/2015 01:16 AM, Denis Kirjanov wrote: On 9/29/15, Raghavendra K T wrote: On 09/28/2015 10:34 PM, Nishanth Aravamudan wrote: On 28.09.2015 [13:44:42 +0300], Denis Kirjanov wrote: On 9/27/15, Raghavendra K T wrote:

Re: [PATCH v4 30/32] cxlflash: Fix to avoid corrupting adapter fops

2015-09-30 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 3/3] cxl: fix leak of ctx->mapping when releasing kernel API contexts

2015-09-30 Thread Ian Munsie
Good catch! Acked-by: Ian Munsie ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 2/3] cxl: fix leak of ctx->irq_bitmap when releasing context via kernel API

2015-09-30 Thread Ian Munsie
Acked-by: Ian Munsie ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH V2 19/31] powerpc/mm: Convert 4k hash insert to C

2015-09-30 Thread Benjamin Herrenschmidt
On Wed, 2015-09-30 at 17:37 +0530, Anshuman Khandual wrote: > > + if (unlikely(old_pte & _PAGE_BUSY)) > > + return 0; > > + /* If PTE permissions don't match, take page fault */ > > We are already in page fault interrupt path, will it be better > if we

Re: [PATCH v3 1/3] powerpc/512x: add LocalPlus Bus FIFO device driver

2015-09-30 Thread Alexander Popov
Hello Timur, thanks again for your review. On 25.09.2015 04:01, Timur Tabi wrote: > Alexander Popov wrote: >> + >> +for (i = 0; i < lpbfifo.cs_n; i++) { >> +phys_addr_t cs_start; >> +phys_addr_t cs_end; >> + >> +cs_start = lpbfifo.cs_ranges[i].addr; >> +cs_end

Re: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks

2015-09-30 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 30, 2015 at 09:09:09PM +0200, Jiri Olsa escreveu: > On Wed, Sep 30, 2015 at 11:28:36AM -0700, Sukadev Bhattiprolu wrote: > > From e29a7236122c4d807ec9ebc721b5d7d75c8d Mon Sep 17 00:00:00 2001 > > From: Sukadev Bhattiprolu > > Date: Thu, 24 Sep 2015

Re: [1/5] powerpc/perf: Drop the branch sample when 'from' cannot be fetched

2015-09-30 Thread Anshuman Khandual
On 07/28/2015 08:38 AM, Anshuman Khandual wrote: > On 07/27/2015 09:49 AM, Michael Ellerman wrote: >> > On Tue, 2015-30-06 at 08:20:27 UTC, Anshuman Khandual wrote: >>> >> BHRB (Branch History Rolling Buffer) is a rolling buffer. Hence we >>> >> might end up in a situation where we have read one

Re: [1/5] powerpc/perf: Drop the branch sample when 'from' cannot be fetched

2015-09-30 Thread Michael Ellerman
On Wed, 2015-09-30 at 14:33 +0530, Anshuman Khandual wrote: > On 07/28/2015 08:38 AM, Anshuman Khandual wrote: > > On 07/27/2015 09:49 AM, Michael Ellerman wrote: > >> > On Tue, 2015-30-06 at 08:20:27 UTC, Anshuman Khandual wrote: > >>> >> BHRB (Branch History Rolling Buffer) is a rolling buffer.

[PATCH v5 11/22] tty/hvc: xen: Use xen page definition

2015-09-30 Thread Julien Grall
The console ring is always based on the page granularity of Xen. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: David Vrabel

Regarding DSISR value of 0xa410

2015-09-30 Thread Anshuman Khandual
Hey Ben/Michael, Why does 0xa410 value of DSISR called weird here ? What does this signify ? Just wondering if we can replace it with a meaningful macro instead. arch/powerpc/kernel/exceptions-64s.S /* * Hash table stuff */ .align 7 do_hash_page: std r3,_DAR(r1)

Re: [PATCH V2 19/31] powerpc/mm: Convert 4k hash insert to C

2015-09-30 Thread Anshuman Khandual
On 09/30/2015 07:57 AM, Aneesh Kumar K.V wrote: > Signed-off-by: Aneesh Kumar K.V > --- > arch/powerpc/mm/Makefile| 3 + > arch/powerpc/mm/hash64_64k.c| 202 + > arch/powerpc/mm/hash_low_64.S | 380 >

[GIT PULL 00/16] perf/core improvements and fixes

2015-09-30 Thread Arnaldo Carvalho de Melo
Hi Ingo, Please consider pulling, - Arnaldo The following changes since commit 9c17dbc6eb73bdd8a6aaea1baefd37ff78d86148: Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-09-29 09:43:46 +0200) are available in the git

Re: [PATCH v4 25/32] cxlflash: Fix to prevent EEH recovery failure

2015-09-30 Thread Daniel Axtens
"Matthew R. Ochs" writes: >>> The process_sense() routine can perform a read capacity which >>> can take some time to complete. If an EEH occurs while waiting >>> on the read capacity, the EEH handler is unable to obtain the >>> context's mutex in order to put the

Re: [PATCH v4 27/32] cxlflash: Fix to prevent stale AFU RRQ

2015-09-30 Thread Daniel Axtens
>>> Following an adapter reset, the AFU RRQ that resides in host memory >>> holds stale data. This can lead to a condition where the RRQ interrupt >>> handler tries to process stale entries and/or endlessly loops due to an >>> out of sync generation bit. >>> >>> To fix, the AFU RRQ in host

[PATCH 05/16] perf tools: Fix build break on powerpc due to sample_reg_masks

2015-09-30 Thread Arnaldo Carvalho de Melo
From: Sukadev Bhattiprolu The perf_regs.c file does not get built on Powerpc as CONFIG_PERF_REGS is false. So the weak definition for 'sample_regs_masks' doesn't get picked up. Adding perf_regs.o to util/Build unconditionally, exposes a redefinition error for

Re: [PATCH] powerpc/iommu: use iommu_num_pages() to calculate the number of iommu page

2015-09-30 Thread Wei Yang
Hmm... some comments on this one? like it or not? On Sat, Sep 19, 2015 at 09:04:27PM +0800, Wei Yang wrote: >On PowerPC, currently we support different value of PAGE_SIZE and different >value of IOMMU Page Size. > >In case the PAGE_SIZE is 4K and the IOMMU Page Size is 16M, and driver >asked for

Re: [PATCH v4 17/32] cxlflash: Remove dual port online dependency

2015-09-30 Thread Daniel Axtens
(resending to the list this time, apologies!) >> I'm not sure I fully understand the flow of this function, but it looks >> like you set rc=0 regardless of how things actually go: is this ever >> going to print a return value other than zero? > > Correct, this function behaves more like a void

Re: [v2,5/5] powerpc/pseries: re-use code from of_helpers module

2015-09-30 Thread Michael Ellerman
On Wed, 2015-09-30 at 19:19 +0300, Andy Shevchenko wrote: > On Fri, 2015-08-14 at 21:51 +1000, Michael Ellerman wrote: > > On Tue, 2015-11-08 at 11:23:09 UTC, Andy Shevchenko wrote: > > > int dlpar_attach_node(struct device_node *dn) > > > { > > > int rc; > > > > > > - dn->parent =

[PATCH] powerpc: Fix checkstop in native_hpte_clear() with lockdep

2015-09-30 Thread Cyril Bur
native_hpte_clear() is called in real mode from two places: - Early in boot during htab initialisation if firmware assisted dump is active. - Late in the kexec path. In both contexts there is no need to disable interrupts are they are already disabled. Furthermore, locking around the tlbie() is

Re: [PATCH] powerpc/iommu: use iommu_num_pages() to calculate the number of iommu page

2015-09-30 Thread Michael Ellerman
On Thu, 2015-10-01 at 07:50 +0800, Wei Yang wrote: > Hmm... some comments on this one? like it or not? It sounds like it's fixing a bug, but you don't really say. Have you seen this fail in the wild? Which commit introduced the breakage? cheers ___

Re: [PATCH 2/3] cxl: fix leak of ctx->irq_bitmap when releasing context via kernel API

2015-09-30 Thread Matthew R. Ochs
Reviewed-by: Matthew R. Ochs ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 3/3] cxl: fix leak of ctx->mapping when releasing kernel API contexts

2015-09-30 Thread Matthew R. Ochs
Reviewed-by: Matthew R. Ochs ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/3] cxl: fix leak of IRQ names in cxl_free_afu_irqs()

2015-09-30 Thread Matthew R. Ochs
Reviewed-by: Matthew R. Ochs ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [v2,5/5] powerpc/pseries: re-use code from of_helpers module

2015-09-30 Thread Andy Shevchenko
On Fri, 2015-08-14 at 21:51 +1000, Michael Ellerman wrote: > On Tue, 2015-11-08 at 11:23:09 UTC, Andy Shevchenko wrote: > > The derive_parent() has similar semantics to what we have in newly > > introduced > > of_helpers module. The replacement reduces code base and propagates > > the actual > >

Re: [PATCH] powerpc/configs: Re-enable CONFIG_SCSI_DH

2015-09-30 Thread Christoph Hellwig
On Tue, Sep 29, 2015 at 08:35:08PM +1000, Michael Ellerman wrote: > Commit 086b91d052eb ("scsi_dh: integrate into the core SCSI code") > changed CONFIG_SCSI_DH from tristate to bool. > > Our defconfigs have CONFIG_SCSI_DH=m, which the kconfig machinery warns > us is invalid, but instead of

Re: [PATCH V2 26/31] powerpc/mm: Remove the dependency on pte bit position in asm code

2015-09-30 Thread Anshuman Khandual
On 09/30/2015 07:57 AM, Aneesh Kumar K.V wrote: > We should not expect pte bit position in asm code. Simply > by moving part of that to C I guess this does not depend on the new code changes and can simply be part of the preparatory patches at the beginning.