Re: [net-next v5 0/8] dpaa_eth: Add the Freescale DPAA Ethernet driver

2015-12-04 Thread Timur Tabi
On Thu, Dec 3, 2015 at 6:08 AM, <> wrote: > From: Madalin Bucur > > This patch series adds the Ethernet driver for the Freescale > QorIQ Data Path Acceleration Architecture (DPAA). Please fix your git-send-email configuration, so that your emails are formatted properly. This is the From: header

[PATCH v2] powerpc/e6500: add locking to hugetlb

2015-12-04 Thread Scott Wood
e6500 has threads but does not have TLB write conditional. Thus, the hugetlb code needs to take the same lock that the normal TLB miss handlers take, to ensure that the tlbsx and tlbwe are atomic. Signed-off-by: Scott Wood --- v2: Fix trailing whitespace arch/powerpc/mm/hugetlbpage-book3e.c |

[PATCH] powerpc/e6500: add locking to hugetlb

2015-12-04 Thread Scott Wood
e6500 has threads but does not have TLB write conditional. Thus, the hugetlb code needs to take the same lock that the normal TLB miss handlers take, to ensure that the tlbsx and tlbwe are atomic. Signed-off-by: Scott Wood --- arch/powerpc/mm/hugetlbpage-book3e.c | 46 ++

Re: [net-next v5 2/8] dpaa_eth: add support for DPAA Ethernet

2015-12-04 Thread David Miller
From: Joe Perches Date: Fri, 04 Dec 2015 12:00:35 -0800 > On Fri, 2015-12-04 at 14:55 -0500, David Miller wrote: >> From: Madalin Bucur >> Date: Thu, 3 Dec 2015 15:49:43 +0200 >> >> > @@ -0,0 +1,22 @@ >> > +menuconfig FSL_DPAA_ETH >> > + tristate "DPAA Ethernet" >> > + depends on FSL_SO

Re: [net-next v5 2/8] dpaa_eth: add support for DPAA Ethernet

2015-12-04 Thread Joe Perches
On Fri, 2015-12-04 at 14:55 -0500, David Miller wrote: > From: Madalin Bucur > Date: Thu, 3 Dec 2015 15:49:43 +0200 > > > @@ -0,0 +1,22 @@ > > +menuconfig FSL_DPAA_ETH > > + tristate "DPAA Ethernet" > > + depends on FSL_SOC && FSL_BMAN && FSL_QMAN && FSL_FMAN > > + select PHYLIB > > +

Re: [net-next v5 2/8] dpaa_eth: add support for DPAA Ethernet

2015-12-04 Thread David Miller
From: Madalin Bucur Date: Thu, 3 Dec 2015 15:49:43 +0200 > @@ -0,0 +1,22 @@ > +menuconfig FSL_DPAA_ETH > + tristate "DPAA Ethernet" > + depends on FSL_SOC && FSL_BMAN && FSL_QMAN && FSL_FMAN > + select PHYLIB > + select FSL_FMAN_MAC I do not see the FSL_FMAN_MAC Kconfig symbol de

Re: [PATCH v3 1/6] powerpc/mm: any thread in one core can be the first to setup TLB1

2015-12-04 Thread Scott Wood
On Fri, 2015-12-04 at 11:04 +0300, Denis Kirjanov wrote: > On 12/3/15, Scott Wood wrote: > > On Wed, 2015-12-02 at 15:12 +0300, Denis Kirjanov wrote: > > > On 11/20/15, Chenhui Zhao wrote: > > > > On e6500, in the case of cpu hotplug, either thread in one core > > > > may be the first thread init

Re: more POLL... fun

2015-12-04 Thread Arnd Bergmann
On Friday 04 December 2015 17:30:31 Al Viro wrote: > On Fri, Dec 04, 2015 at 06:13:54PM +0100, Arnd Bergmann wrote: > > > Yes, I think that would be best. Do you want me to send that patch, or do > > you prefer to do it yourself? In theory that patch should also go into > > stable > > kernels, bu

Re: more POLL... fun

2015-12-04 Thread Al Viro
On Fri, Dec 04, 2015 at 06:13:54PM +0100, Arnd Bergmann wrote: > Yes, I think that would be best. Do you want me to send that patch, or do > you prefer to do it yourself? In theory that patch should also go into stable > kernels, but I suspect nobody who still owns a machine that is able to run >

Re: more POLL... fun

2015-12-04 Thread Arnd Bergmann
On Friday 04 December 2015 15:21:33 Al Viro wrote: > On Fri, Dec 04, 2015 at 10:16:50AM +0100, Arnd Bergmann wrote: > > > I don't remember why we put in fasync support, but I have checked the libspe > > implementation and found that it doesn't use it (not a big surprise there). > > It always uses

Re: [PATCH v2 3/5] printk/nmi: Try hard to print Oops message in NMI context

2015-12-04 Thread Russell King - ARM Linux
On Fri, Dec 04, 2015 at 04:27:09PM +0100, Petr Mladek wrote: > On Tue 2015-12-01 23:44:37, Russell King - ARM Linux wrote: > > On Fri, Nov 27, 2015 at 12:09:30PM +0100, Petr Mladek wrote: > > > What we can do, though, is to zap all printk locks. We already do this > > > when a printk recursion is d

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-12-04 Thread Takashi Iwai
On Fri, 04 Dec 2015 18:02:58 +0100, Jens Axboe wrote: > > On 12/04/2015 09:59 AM, Takashi Iwai wrote: > > On Wed, 25 Nov 2015 20:01:47 +0100, > > Hannes Reinecke wrote: > >> > >> On 11/25/2015 07:01 PM, Mike Snitzer wrote: > >>> On Wed, Nov 25 2015 at 4:04am -0500, > >>> Hannes Reinecke wrote: >

Re: [PATCH] of: Fix comparison of reserved memory regions

2015-12-04 Thread Mitchel Humpherys
On Wed, Nov 18 2015 at 09:46:38 PM, Michael Ellerman wrote: > In order to check for overlapping reserved memory regions, we first need > to sort the array of memory regions. This is implemented using sort(), > and a custom comparison function __rmem_cmp(). > > Unfortunatley __rmem_cmp() doesn't w

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-12-04 Thread Jens Axboe
On 12/04/2015 09:59 AM, Takashi Iwai wrote: On Wed, 25 Nov 2015 20:01:47 +0100, Hannes Reinecke wrote: On 11/25/2015 07:01 PM, Mike Snitzer wrote: On Wed, Nov 25 2015 at 4:04am -0500, Hannes Reinecke wrote: On 11/20/2015 04:28 PM, Ewan Milne wrote: On Fri, 2015-11-20 at 15:55 +0100, Hanne

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-12-04 Thread Takashi Iwai
On Wed, 25 Nov 2015 20:01:47 +0100, Hannes Reinecke wrote: > > On 11/25/2015 07:01 PM, Mike Snitzer wrote: > > On Wed, Nov 25 2015 at 4:04am -0500, > > Hannes Reinecke wrote: > > > >> On 11/20/2015 04:28 PM, Ewan Milne wrote: > >>> On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: >

Re: [PATCH v2 1/5] printk/nmi: Generic solution for safe printk in NMI

2015-12-04 Thread Petr Mladek
On Wed 2015-12-02 00:24:49, Jiri Kosina wrote: > On Fri, 27 Nov 2015, Petr Mladek wrote: > > > MN10300 has its own implementation for entering and exiting NMI > > handlers. It does not call nmi_enter() and nmi_exit(). Please, find > > below an updated patch that adds printk_nmi_enter() and > >

Re: [PATCH v2 5/5] printk/nmi: Increase the size of the temporary buffer

2015-12-04 Thread Petr Mladek
On Wed 2015-12-02 16:20:41, David Laight wrote: > From: yalin wang > > Sent: 30 November 2015 16:42 > > > On Nov 27, 2015, at 19:09, Petr Mladek wrote: > > > > > > Testing has shown that the backtrace sometimes does not fit > > > into the 4kB temporary buffer that is used in NMI context. > > > > >

[PATCH v5 5/9] ppc64 ftrace_with_regs: spare early boot and low level

2015-12-04 Thread Torsten Duwe
Using -mprofile-kernel on early boot code not only confuses the checker but is also useless, as the infrastructure is not yet in place. Proceed like with -pg (remove it from CFLAGS), equally with time.o and ftrace itself. * arch/powerpc/kernel/Makefile: - remove -mprofile-kernel from low lev

Re: [PATCH v2 1/5] printk/nmi: Generic solution for safe printk in NMI

2015-12-04 Thread Petr Mladek
On Wed 2015-12-02 13:45:16, Michael Ellerman wrote: > On Fri, 2015-11-27 at 12:09 +0100, Petr Mladek wrote: > > > printk() takes some locks and could not be used a safe way in NMI > > context. > > > > The chance of a deadlock is real especially when printing > > stacks from all CPUs. This particu

[PATCH v5 9/9] Enable LIVEPATCH to be configured on ppc64le and add livepatch.o if it is selected.

2015-12-04 Thread Torsten Duwe
Signed-off-by: Torsten Duwe --- arch/powerpc/Kconfig | 5 + arch/powerpc/kernel/Makefile | 1 + 2 files changed, 6 insertions(+) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 89b1a2a..62a3f54 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -163,6 +163

[PATCH v5 8/9] Implement kernel live patching for ppc64le (ABIv2)

2015-12-04 Thread Torsten Duwe
* create the appropriate files+functions arch/powerpc/include/asm/livepatch.h klp_check_compiler_support, klp_arch_set_pc arch/powerpc/kernel/livepatch.c with a stub for klp_write_module_reloc This is architecture-independent work in progress. * introduce a f

[PATCH v5 7/9] ppc64 ftrace: disable profiling for some files

2015-12-04 Thread Torsten Duwe
This patch complements the "notrace" attribute for selected functions. It adds -mprofile-kernel to the cc flags to be stripped from the command line for code-patching.o and feature-fixups.o, in addition to "-pg" Signed-off-by: Torsten Duwe --- arch/powerpc/lib/Makefile | 4 ++-- 1 file changed,

[PATCH v5 6/9] ppc64 ftrace: disable profiling for some functions

2015-12-04 Thread Torsten Duwe
At least POWER7/8 have MMUs that don't completely autoload; a normal, recoverable memory fault might pass through these functions. If a dynamic tracer function causes such a fault, any of these functions being traced with -mprofile-kernel may cause an endless recursion. Signed-off-by: Torsten Duwe

[PATCH v5 4/9] ppc64 ftrace_with_regs configuration variables

2015-12-04 Thread Torsten Duwe
* Makefile: - globally use -mprofile-kernel in case it's configured and available. * arch/powerpc/Kconfig / kernel/trace/Kconfig: - declare that ppc64le HAVE_MPROFILE_KERNEL and HAVE_DYNAMIC_FTRACE_WITH_REGS, and use it. Signed-off-by: Torsten Duwe --- arch/powerpc/Kconfi

[PATCH v5 3/9] ppc use ftrace_modify_all_code default

2015-12-04 Thread Torsten Duwe
Convert ppc's arch_ftrace_update_code from its own function copy to use the generic default functionality (without stop_machine -- our instructions are properly aligned and the replacements atomic ;) With this we gain error checking and the much-needed function_trace_op handling. Signed-off-by: T

[PATCH v5 2/9] ppc64le FTRACE_WITH_REGS implementation

2015-12-04 Thread Torsten Duwe
Implement FTRACE_WITH_REGS for powerpc64, on ELF ABI v2. Initial work started by Vojtech Pavlik, used with permission. * arch/powerpc/kernel/entry_64.S: - Implement an effective ftrace_caller that works from within the kernel binary as well as from modules. * arch/powerpc/kernel/ftra

[PATCH v5 1/9] ppc64 (le): prepare for -mprofile-kernel

2015-12-04 Thread Torsten Duwe
The gcc switch -mprofile-kernel, available for ppc64 on gcc > 4.8.5, allows to call _mcount very early in the function, which low-level ASM code and code patching functions need to consider. Especially the link register and the parameter registers are still alive and not yet saved into a new stack

Re: [PATCH v2 3/5] printk/nmi: Try hard to print Oops message in NMI context

2015-12-04 Thread Petr Mladek
On Tue 2015-12-01 23:44:37, Russell King - ARM Linux wrote: > On Fri, Nov 27, 2015 at 12:09:30PM +0100, Petr Mladek wrote: > > What we can do, though, is to zap all printk locks. We already do this > > when a printk recursion is detected. This should be safe because > > the system is crashing and t

[PATCH v5 0/9] ftrace with regs + live patching for ppc64 LE (ABI v2)

2015-12-04 Thread Torsten Duwe
Changes since v4: * change comment style in entry_64.S to C89 (nobody is using assembler syntax comments there). * the bool function restore_r2 shouldn't return 2, that's a little confusing. * Test whether the compiler supports -mprofile-kernel and only then define CC_USING_MPROFI

Re: more POLL... fun

2015-12-04 Thread Al Viro
On Fri, Dec 04, 2015 at 10:16:50AM +0100, Arnd Bergmann wrote: > I don't remember why we put in fasync support, but I have checked the libspe > implementation and found that it doesn't use it (not a big surprise there). > It always uses epoll() to get notifications from spufs, and based on your >

Re: [PATCH] crypto: talitos - add new crypto modes

2015-12-04 Thread Herbert Xu
On Tue, Dec 01, 2015 at 12:44:15PM +0100, Christophe Leroy wrote: > This patch adds the following algorithms to the talitos driver: > * ecb(aes) > * ctr(aes) > * ecb(des) > * cbc(des) > * ecb(des3_ede) > > Signed-off-by: Christophe Leroy Patch applied. Thanks. -- Email: Herbert Xu Home Page:

[PATCH 3/5] powerpc: ftrace: fix the comments for ftrace_modify_code

2015-12-04 Thread Li Bin
There is no need to worry about module and __init text disappearing case, because that ftrace has a module notifier that is called when a module is being unloaded and before the text goes away and this code grabs the ftrace_lock mutex and removes the module functions from the ftrace list, such that

[PATCH 0/5] ftrace: fix ftrace misleading comments for arch using it

2015-12-04 Thread Li Bin
Fix the following similar misleading comments of ftrace for arch ia64/metag/powerpc/sh/x86: Note: Due to modules and __init, code can disappear and change, we need to protect against faulting as well as code changing. We do this by using the probe_kernel_* functions. No real locking needed, th

Re: [v9, 3/6] fsl/fman: Add FMan MAC support

2015-12-04 Thread Kenneth Klette Jonassen
> +/* PHY Control Register */ > +#define PHY_CR_PHY_RESET 0x8000 > +#define PHY_CR_SPEED0 0x2000 > +#define PHY_CR_ANE 0x1000 > +#define PHY_CR_RESET_AN0x0200 > +#define PHY_CR_FULLDUPLEX 0x0100 > +#define PHY_CR_SPEED1 0x0040 Reuse defines

[net-next v5 0/8] dpaa_eth: Add the Freescale DPAA Ethernet driver

2015-12-04 Thread linuxppc-dev-bounces+archive=mail-archive . com
From: Madalin Bucur This patch series adds the Ethernet driver for the Freescale QorIQ Data Path Acceleration Architecture (DPAA). This version includes changes following the feedback received on previous versions from Eric Dumazet, Bob Cochran, Joe Perches, Paul Bolle, Joakim Tjernlund, Scott W

[net-next v5 4/8] dpaa_eth: add driver's Tx queue selection

2015-12-04 Thread linuxppc-dev-bounces+archive=mail-archive . com
From: Madalin Bucur Allow the selection of the transmission queue based on the CPU id. The DPAA Ethernet driver defines a ndo_select_queue() callback for optimal selection of the egress FQ. That will override the XPS support for this netdevice and should provide a certain increase in performance.

[net-next v5 6/8] dpaa_eth: add ethtool statistics

2015-12-04 Thread linuxppc-dev-bounces+archive=mail-archive . com
From: Madalin Bucur Add a series of counters to be exported through ethtool: - add detailed counters for reception errors; - add detailed counters for QMan enqueue reject events; - count the number of fragmented skbs received from the stack; - count all frames received on the Tx confirmation path

[net-next v5 5/8] dpaa_eth: add ethtool functionality

2015-12-04 Thread linuxppc-dev-bounces+archive=mail-archive . com
From: Madalin Bucur Add support for basic ethtool operations. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/Makefile | 2 +- .../net/ethernet/freescale/dpaa/dpaa_eth_common.c | 2 + .../net/ethernet/freescale/dpaa/dpaa_eth_common.h | 3 + drivers/net/ethern

[net-next v5 1/8] devres: add devm_alloc_percpu()

2015-12-04 Thread linuxppc-dev-bounces+archive=mail-archive . com
From: Madalin Bucur Introduce managed counterparts for alloc_percpu() and free_percpu(). Add devm_alloc_percpu() and devm_free_percpu() into the managed interfaces list. Signed-off-by: Madalin Bucur Tested-by: Madalin-Cristian Bucur --- Documentation/driver-model/devres.txt | 4 +++ drivers/

[net-next v5 7/8] dpaa_eth: add sysfs exports

2015-12-04 Thread linuxppc-dev-bounces+archive=mail-archive . com
From: Madalin Bucur Export Frame Queue and Buffer Pool IDs through sysfs. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/Makefile | 2 +- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 + drivers/net/ethernet/freescale/dpaa/dpaa_eth.h | 3 + .../ne

[net-next v5 8/8] dpaa_eth: add trace points

2015-12-04 Thread linuxppc-dev-bounces+archive=mail-archive . com
From: Madalin Bucur Add trace points on the hot processing path. Signed-off-by: Ruxandra Ioana Radulescu --- drivers/net/ethernet/freescale/dpaa/Makefile | 1 + drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 12 ++ drivers/net/ethernet/freescale/dpaa/dpaa_eth.h | 4 + .../

[net-next v5 2/8] dpaa_eth: add support for DPAA Ethernet

2015-12-04 Thread linuxppc-dev-bounces+archive=mail-archive . com
From: Madalin Bucur This introduces the Freescale Data Path Acceleration Architecture (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan, BMan, PAMU and FMan drivers to deliver Ethernet connectivity on the Freescale DPAA QorIQ platforms. Signed-off-by: Madalin Bucur --- drivers/n

[net-next v5 3/8] dpaa_eth: add support for S/G frames

2015-12-04 Thread linuxppc-dev-bounces+archive=mail-archive . com
From: Madalin Bucur Add support for Scatter/Gather (S/G) frames. The FMan can place the frame content into multiple buffers and provide a S/G Table (SGT) into one first buffer with references to the others. Signed-off-by: Madalin Bucur --- .../net/ethernet/freescale/dpaa/dpaa_eth_common.c |

Re: [PATCH 2/3] selftests/powerpc: Add test for forking inside transaction

2015-12-04 Thread Michael Neuling
On Tue, 2015-12-01 at 16:08 +1100, Rashmica Gupta wrote: > This test does a fork syscall inside a transaction. Basic sniff test > to see > if we can enter the kernel during a transaction. Can you add this description to the top of the test case as well? Mikey > > Signed-off-by: Rashmica Gupta

Re: more POLL... fun

2015-12-04 Thread Arnd Bergmann
On Friday 04 December 2015 06:38:25 Al Viro wrote: > On cross-builds the __poll_t annotations had caught something interesting: > void spufs_mfc_callback(struct spu *spu) > { > > mask = 0; > if (free_elements & 0x) > mask |= POL

Re: [PATCH v4 8/9] Implement kernel live patching for ppc64le (ABIv2)

2015-12-04 Thread Torsten Duwe
On Thu, Dec 03, 2015 at 05:24:45PM +0100, Petr Mladek wrote: > > +++ b/arch/powerpc/include/asm/livepatch.h > > @@ -0,0 +1,45 @@ > [...] > > +#include > > +#include > > + > > +#ifdef CONFIG_LIVEPATCH > > +static inline int klp_check_compiler_support(void) > > +{ > > +#if !defined(_CALL_ELF) || _C

Re: [PATCH v4 4/9] ppc64 ftrace_with_regs configuration variables

2015-12-04 Thread Torsten Duwe
On Thu, Dec 03, 2015 at 05:20:08PM +0100, Petr Mladek wrote: > > IMHO, we should not define CC_USING_MPROFILE_KERNEL if it is not > supported by the compiler. Yes, true. > I took inspiration from the CC_USING_FENTRY handling in > linux/Makefile. The following code worked for me: > > CC_USING_MPRO

Re: [PATCH v3 1/6] powerpc/mm: any thread in one core can be the first to setup TLB1

2015-12-04 Thread Denis Kirjanov
On 12/3/15, Scott Wood wrote: > On Wed, 2015-12-02 at 15:12 +0300, Denis Kirjanov wrote: >> On 11/20/15, Chenhui Zhao wrote: >> > On e6500, in the case of cpu hotplug, either thread in one core >> > may be the first thread initilzing the TLB1. The subsequent threads >> > must not setup it again.