Re: 32-bit powerpc, aty128fb: vmap allocation for size 135168 failed

2017-08-18 Thread Meelis Roos
> Meelis Roos writes: > > > I was trying 4.13.0-rc5-00075-gac9a40905a61 on my PowerMac G4 with 1G > > RAM and after some time of sddm respawning and X trying to restart, > > dmesg is full of messages about vmap allocation failures. > > Did it just start happening? ie. did rc4 work? It goes ba

Re: [RFC v7 26/25] mm/mprotect, powerpc/mm/pkeys, x86/mm/pkeys: Add sysfs interface

2017-08-18 Thread Thiago Jung Bauermann
Ram Pai writes: > On Fri, Aug 11, 2017 at 02:34:43PM -0300, Thiago Jung Bauermann wrote: >> Expose useful information for programs using memory protection keys. >> Provide implementation for powerpc and x86. >> >> On a powerpc system with pkeys support, here is what is shown: >> >> $ head /sys

Re: [RFC v7 24/25] powerpc: Deliver SEGV signal on pkey violation

2017-08-18 Thread Ram Pai
On Fri, Aug 18, 2017 at 10:04:10AM -0700, Ram Pai wrote: > On Fri, Aug 18, 2017 at 02:48:31PM +1000, Michael Ellerman wrote: > > Ram Pai writes: > > > On Fri, Aug 11, 2017 at 08:26:30PM +1000, Michael Ellerman wrote: > > >> Thiago Jung Bauermann writes: > > >> > > >> > Ram Pai writes: > > >> >

Re: [RFC v7 24/25] powerpc: Deliver SEGV signal on pkey violation

2017-08-18 Thread Ram Pai
On Sat, Aug 19, 2017 at 07:54:20AM +1000, Benjamin Herrenschmidt wrote: > On Fri, 2017-08-18 at 10:04 -0700, Ram Pai wrote: > > Assume two threads of a task. > > > > T1: mprotect_key(foo, PAGE_SIZE, pkey=4); > > T1: set AMR to disable access for pkey 4; > > T1: key fault > > T2: set AMR to

Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc

2017-08-18 Thread Bart Van Assche
On Fri, 2017-08-18 at 16:57 -0500, Brian King wrote: > To add to my analysis above, #9 should not be there... It looks like > jiffies_at_alloc would also be getting reinitialized in this case, resulting > in > a perpetual retry, which is what I was seeing. Hello Brian, Some time ago I noticed th

Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc

2017-08-18 Thread Brian King
On 08/18/2017 04:41 PM, Bart Van Assche wrote: > On Fri, 2017-08-18 at 16:04 -0500, Brian King wrote: >> I think I have an understanding what is going on and why Bart's patch is >> causing problems for ipr. >> I can work around the boot hang in ipr, but ultimately I think we need to >> figure out

Re: [RFC v7 24/25] powerpc: Deliver SEGV signal on pkey violation

2017-08-18 Thread Benjamin Herrenschmidt
On Fri, 2017-08-18 at 10:04 -0700, Ram Pai wrote: > Assume two threads of a task. > > T1: mprotect_key(foo, PAGE_SIZE, pkey=4); > T1: set AMR to disable access for pkey 4; > T1: key fault > T2: set AMR to enable access to pkey 4; > T1: fault handler called. > This fault handler wil

Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc

2017-08-18 Thread Bart Van Assche
On Fri, 2017-08-18 at 16:04 -0500, Brian King wrote: > I think I have an understanding what is going on and why Bart's patch is > causing problems for ipr. > I can work around the boot hang in ipr, but ultimately I think we need to > figure out a fix > in scsi / block. I added some tracing and co

[PATCH] ipr: Set no_report_opcodes for RAID arrays

2017-08-18 Thread Brian King
Since ipr RAID arrays do not support the MAINTENANCE_IN / MI_REPORT_SUPPORTED_OPERATION_CODES, set no_report_opcodes to prevent it from being sent. Signed-off-by: Brian King --- Index: linux-2.6.git/drivers/scsi/ipr.c === --- linux-

Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc

2017-08-18 Thread Brian King
On 08/17/2017 10:52 AM, Bart Van Assche wrote: > On Wed, 2017-08-16 at 18:18 -0500, Brian King wrote: >> On 08/16/2017 12:21 PM, Bart Van Assche wrote: >>> On Wed, 2017-08-16 at 22:30 +0530, Abdul Haleem wrote: As of next-20170809, linux-next on powerpc boot hung with below trace message.

Re: [PATCH] tpm: vtpm: constify vio_device_id

2017-08-18 Thread Jason Gunthorpe
On Fri, Aug 18, 2017 at 09:32:46PM +1000, Michael Ellerman wrote: > >> drivers/char/tpm/tpm_ibmvtpm.c | 2 +- > > Who merges changes for this driver? I assume it's Jarkko? Yes Jason

Re: [RFC v7 24/25] powerpc: Deliver SEGV signal on pkey violation

2017-08-18 Thread Ram Pai
On Fri, Aug 18, 2017 at 02:48:31PM +1000, Michael Ellerman wrote: > Ram Pai writes: > > On Fri, Aug 11, 2017 at 08:26:30PM +1000, Michael Ellerman wrote: > >> Thiago Jung Bauermann writes: > >> > >> > Ram Pai writes: > >> > > >> >> The value of the AMR register at the time of exception > >> >>

Re: [RFC v7 25/25] powerpc: Enable pkey subsystem

2017-08-18 Thread Ram Pai
On Fri, Aug 18, 2017 at 12:26:33PM -0300, Thiago Jung Bauermann wrote: > > Michael Ellerman writes: > > > Ram Pai writes: > >> On Thu, Aug 17, 2017 at 05:30:27PM -0300, Thiago Jung Bauermann wrote: > >>> Ram Pai writes: > >>> > On Thu, Aug 10, 2017 at 06:27:34PM -0300, Thiago Jung Bauermann wr

Re: [PATCH 7/7] powerpc: use helper functions to get and set hash slots

2017-08-18 Thread Ram Pai
On Fri, Aug 18, 2017 at 10:18:31PM +1000, Michael Ellerman wrote: > Ram Pai writes: > > > replace redundant code in __hash_page_64K(), __hash_page_huge(), > > __hash_page_4K(), __hash_page_4K() and flush_hash_page() with > > helper functions pte_get_hash_gslot() and pte_set_hash_slot() > > T

Re: [PATCH kernel] PCI: Disable IOV before pcibios_sriov_disable()

2017-08-18 Thread Bjorn Helgaas
On Fri, Aug 18, 2017 at 08:05:42AM +1000, Alexey Kardashevskiy wrote: > On 11/08/17 18:19, Alexey Kardashevskiy wrote: > > From: Gavin Shan > > > > The PowerNV platform is the only user of pcibios_sriov_disable(). > > The IOV BAR could be shifted by pci_iov_update_resource(). The > > warning mess

Re: [RFC v7 25/25] powerpc: Enable pkey subsystem

2017-08-18 Thread Thiago Jung Bauermann
Michael Ellerman writes: > Ram Pai writes: >> On Thu, Aug 17, 2017 at 05:30:27PM -0300, Thiago Jung Bauermann wrote: >>> Ram Pai writes: >>> > On Thu, Aug 10, 2017 at 06:27:34PM -0300, Thiago Jung Bauermann wrote: >>> >> Ram Pai writes: >>> >> > @@ -227,6 +229,24 @@ static inline void pkey_mm

Re: [PATCH v7 1/4] powerpc/fadump: reduce memory consumption for capture kernel

2017-08-18 Thread Hari Bathini
On Friday 18 August 2017 05:27 PM, Michal Suchánek wrote: On Fri, 18 Aug 2017 16:20:53 +0530 Hari Bathini wrote: Hi Michal, Thanks for the patches. I tried testing with the patches: [0.00] fadump: Firmware-assisted dump is active. [0.00] fadump: Modifying command line to e

Re: [PATCH] powerpc: powernv: Fix build error on const discarding

2017-08-18 Thread Corentin Labbe
On Thu, Aug 17, 2017 at 10:52:11PM +1000, Michael Ellerman wrote: > Corentin Labbe writes: > > > When building a random powerpc kernel I hit this build error: > > CC arch/powerpc/platforms/powernv/opal-imc.o > > arch/powerpc/platforms/powernv/opal-imc.c: In function «  > > disable_nest_pmu

Re: [PATCH 2/2] kvm/xive: Add missing barriers and document them

2017-08-18 Thread Guilherme G. Piccoli
On 08/17/2017 11:10 PM, Benjamin Herrenschmidt wrote: > This adds missing memory barriers to order updates/tests of > the virtual CPPR and MFRR, thus fixing a lost IPI problem. > > While at it also document all barriers in this file > > This fixes a bug causing guest IPIs to occasionally get lost

Re: [1/1] selftests/powerpc: Improve tm-resched-dscr

2017-08-18 Thread Michael Ellerman
On Thu, 2017-08-17 at 01:06:47 UTC, Sam bobroff wrote: > The tm-resched-dscr self test can, in some situations, run for > several minutes before being successfully interrupted by the context > switch it needs in order to perform the test. This often seems to > occur when the test is being run in a

Re: powerpc/perf: Fix usage of nest_imc_refc

2017-08-18 Thread Michael Ellerman
On Wed, 2017-08-16 at 16:21:34 UTC, Madhavan Srinivasan wrote: > nest_imc_refc is a reference count struct, > used to track number of active perf sessions > using the nest units. > > It is preferred to access nest_imc_refc using > per-cpu pointer 'local_nest_imc_refc'. Since, > nest_imc_refc is no

Re: [2/5] powerpc: Fix missing CR before {

2017-08-18 Thread Michael Ellerman
On Wed, 2017-08-16 at 06:01:15 UTC, Benjamin Herrenschmidt wrote: > Signed-off-by: Benjamin Herrenschmidt Patches 2-5 applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/6a303833b5e3acbb4c97cc11cc6886 cheers

Re: [2/3] block/ps3vram: Check return of ps3vram_cache_init

2017-08-18 Thread Michael Ellerman
On Mon, 2017-08-07 at 20:09:20 UTC, Geoff Levand wrote: > Cc: Markus Elfring > Cc: Jim Paris > Cc: Jens Axboe > Signed-off-by: Geoff Levand Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/00e7c259e9c44f414ead5fc9bb3c45 cheers

Re: [1/3] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

2017-08-18 Thread Michael Ellerman
On Mon, 2017-08-07 at 20:09:20 UTC, Geoff Levand wrote: > From: Markus Elfring > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Link: > http://events.linuxfoundation.org/sites/events/files/slides/LCJ16

Re: powerpc: add const to bin_attribute structures

2017-08-18 Thread Michael Ellerman
On Wed, 2017-08-02 at 18:07:38 UTC, Bhumika Goyal wrote: > Declare bin_attribute structures as const as they are only passed as an > argument to the function sysfs_create_bin_file. This argument is of > type const, so declare the structure as const. > > Signed-off-by: Bhumika Goyal Applied to po

Re: [v4, 1/3] mm/hugetlb: Allow arch to override and call the weak function

2017-08-18 Thread Michael Ellerman
On Fri, 2017-07-28 at 05:01:25 UTC, "Aneesh Kumar K.V" wrote: > When running in guest mode ppc64 supports a different mechanism for hugetlb > allocation/reservation. The LPAR management application called HMC can > be used to reserve a set of hugepages and we pass the details of > reserved pages vi

Re: [05/11] powerpc/topology: Remove the unused parent_node() macro

2017-08-18 Thread Michael Ellerman
On Wed, 2017-07-26 at 13:34:30 UTC, Dou Liyang wrote: > Commit a7be6e5a7f8d ("mm: drop useless local parameters of > __register_one_node()") removes the last user of parent_node(). > > The parent_node() macro in POWERPC platform is unnecessary. > > Remove it for cleanup. > > Reported-by: Michael

Re: [1/2] powerpc: string: implement optimized memset variants

2017-08-18 Thread Michael Ellerman
On Mon, 2017-03-27 at 19:37:40 UTC, "Naveen N. Rao" wrote: > Based on Matthew Wilcox's patches for other architectures. > > Signed-off-by: Naveen N. Rao Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/694fc88ce271fd48f7939c032c1247 cheers

[GIT PULL] Please pull powerpc/linux.git powerpc-4.13-7 tag

2017-08-18 Thread Michael Ellerman
Hi Linus, Please pull another powerpc fix for 4.13: The following changes since commit 96ea91e7b6ee2c406598d859e7348b4829404eea: powerpc/watchdog: add locking around init/exit functions (2017-08-09 23:45:33 +1000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/

Re: 32-bit powerpc, aty128fb: vmap allocation for size 135168 failed

2017-08-18 Thread Meelis Roos
> > I was trying 4.13.0-rc5-00075-gac9a40905a61 on my PowerMac G4 with 1G > > RAM and after some time of sddm respawning and X trying to restart, > > dmesg is full of messages about vmap allocation failures. > > Did it just start happening? ie. did rc4 work? No, rc4 was the first one I tried af

Re: 32-bit powerpc, aty128fb: vmap allocation for size 135168 failed

2017-08-18 Thread Michael Ellerman
Meelis Roos writes: > I was trying 4.13.0-rc5-00075-gac9a40905a61 on my PowerMac G4 with 1G > RAM and after some time of sddm respawning and X trying to restart, > dmesg is full of messages about vmap allocation failures. Did it just start happening? ie. did rc4 work? cheers

Re: [PATCH 7/7] powerpc: use helper functions to get and set hash slots

2017-08-18 Thread Michael Ellerman
Ram Pai writes: > replace redundant code in __hash_page_64K(), __hash_page_huge(), > __hash_page_4K(), __hash_page_4K() and flush_hash_page() with > helper functions pte_get_hash_gslot() and pte_set_hash_slot() This seems out of order. At lease some of these are patching or even entirely re

Re: [PATCH v7 1/4] powerpc/fadump: reduce memory consumption for capture kernel

2017-08-18 Thread Michal Suchánek
On Fri, 18 Aug 2017 16:20:53 +0530 Hari Bathini wrote: > Hi Michal, > > > Thanks for the patches. I tried testing with the patches: > > [0.00] fadump: Firmware-assisted dump is active. > [0.00] fadump: Modifying command line to enforce the > additional parameters passed through

Re: [PATCH] tpm: vtpm: constify vio_device_id

2017-08-18 Thread Michael Ellerman
Jason Gunthorpe writes: > On Thu, Aug 17, 2017 at 11:04:21PM +0530, Arvind Yadav wrote: >> vio_device_id are not supposed to change at runtime. All functions >> working with vio_device_id provided by work with >> const vio_device_id. So mark the non-const structs as const. >> >> Signed-off-by:

Re: [PATCH 5/5] Use __func__ instead of function name

2017-08-18 Thread Michael Ellerman
Michal Suchánek writes: > On 2017-07-29 09:24, SZ Lin wrote: >> Fix following checkpatch.pl warning: >> WARNING: Prefer using '"%s...", __func__' to using >> the function's name, in a string >> >> Signed-off-by: SZ Lin >> --- >> drivers/char/tpm/tpm_ibmvtpm.c | 12 ++-- >> 1 file chang

Re: [PATCH v7 1/4] powerpc/fadump: reduce memory consumption for capture kernel

2017-08-18 Thread Hari Bathini
Hi Michal, Thanks for the patches. I tried testing with the patches: [0.00] fadump: Firmware-assisted dump is active. [0.00] fadump: Modifying command line to enforce the additional parameters passed through 'fadump_extra_args=' [0.00] fadump: Original command line: BO

Re: [PATCH v2 4/8] powerpc/xive: introduce xive_esb_write()

2017-08-18 Thread David Gibson
On Fri, Aug 11, 2017 at 04:23:37PM +0200, Cédric Le Goater wrote: Rationale in the commit message, maybe. > Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson > --- > arch/powerpc/sysdev/xive/common.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH v2 3/8] powerpc/xive: rename xive_poke_esb() in xive_esb_read()

2017-08-18 Thread David Gibson
On Fri, Aug 11, 2017 at 04:23:36PM +0200, Cédric Le Goater wrote: > xive_poke_esb() is performing a load/read so it is better named as > xive_esb_read() as we will need to introduce a xive_esb_write() > routine. Also use the XIVE_ESB_LOAD_EOI offset when EOI'ing LSI > interrupts. > > Signed-off-by

[PATCH 6/6] dpaa_eth: check allocation result

2017-08-18 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index ef30038..ff7f153 100644 --- a/drivers/net/ethernet/freescal

[PATCH 3/6] dpaa_eth: enable Rx hashing control

2017-08-18 Thread Madalin Bucur
Allow ethtool control of the Rx flow hashing. By default RSS is enabled, this allows to turn it off by bypassing the FMan Keygen block and sending all traffic on the default Rx frame queue. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 113

[PATCH 5/6] Documentation: networking: add RSS information

2017-08-18 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- Documentation/networking/dpaa.txt | 68 ++- 1 file changed, 67 insertions(+), 1 deletion(-) diff --git a/Documentation/networking/dpaa.txt b/Documentation/networking/dpaa.txt index 76e016d..f88194f 100644 --- a/Documentation/n

[PATCH 4/6] dpaa_eth: add NETIF_F_RXHASH

2017-08-18 Thread Madalin Bucur
Set the skb hash when then FMan Keygen hash result is available. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 19 --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.h | 1 + drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 9 ++

[PATCH 1/6] fsl/fman: enable FMan Keygen

2017-08-18 Thread Madalin Bucur
From: Iordache Florinel-R70177 Add support for the FMan Keygen with a hardcoded scheme to spread incoming traffic on a FQ range based on source and destination IPs and ports. Signed-off-by: Iordache Florinel Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/Makefile |

[PATCH 2/6] dpaa_eth: use multiple Rx frame queues

2017-08-18 Thread Madalin Bucur
Add a block of 128 Rx frame queues per port. The FMan hardware will send traffic on one of these queues based on the FMan port Parse Classify Distribute setup. The hash computed by the FMan Keygen block will select the Rx FQ. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/d

[PATCH 0/6] Add RSS to DPAA 1.x Ethernet driver

2017-08-18 Thread Madalin Bucur
This patch set introduces Receive Side Scaling for the DPAA Ethernet driver. Documentation is updated with details related to the new feature and limitations that apply. Added also a small fix. Iordache Florinel-R70177 (1): fsl/fman: enable FMan Keygen Madalin Bucur (5): dpaa_eth: use multipl

Re: [PATCH 1/6] ASoC: fsl: make snd_pcm_hardware const

2017-08-18 Thread Nicolin Chen
On Thu, Aug 17, 2017 at 03:46:07PM +0530, Bhumika Goyal wrote: > Make these const as they are only passed as the 2nd argument to the > function snd_soc_set_runtime_hwparams, which is const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal Acked-by: Nicolin Chen

Re: [PATCH 5/5] Use __func__ instead of function name

2017-08-18 Thread Michal Suchánek
On 2017-07-29 09:24, SZ Lin wrote: Fix following checkpatch.pl warning: WARNING: Prefer using '"%s...", __func__' to using the function's name, in a string Signed-off-by: SZ Lin --- drivers/char/tpm/tpm_ibmvtpm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/

Re: [PATCH v2 1/1] Split VGA default device handler out of VGA arbiter

2017-08-18 Thread Daniel Vetter
On Thu, Aug 17, 2017 at 09:30:28PM +1000, Daniel Axtens wrote: > A system without PCI legacy resources (e.g. ARM64) may find that no > default/boot VGA device has been marked, because the VGA arbiter > checks for legacy resource decoding before marking a card as default. > > Split the small bit of