Re: [PATCH v2] powerpc/64s: ISAv3 initialize MMU registers before setting partition table

On Tue, 05 Dec 2017 14:04:42 +1100 Michael Ellerman wrote: > Hi Nick, > > Sorry I didn't reply sooner. > > Nicholas Piggin writes: > > > kexec can leave MMU registers set when booting into a new kernel, PIDR > > in particular. The boot sequence does

Re: [PATCH 2/4] powerpc/64: do not trace irqs-off at interrupt return to soft-disabled context

Benjamin Herrenschmidt writes: > On Mon, 2017-12-04 at 16:09 +1100, Michael Ellerman wrote: >> Nicholas Piggin writes: >> >> > When an interrupt is returning to a soft-disabled context (which can >> > happen for non-maskable interrupts or

Re: [PATCH] cpufreq: powernv: Define methods to parse positive & negative pstates

On 30-11-17, 10:13, Shilpasri G Bhat wrote: > From: "Gautham R. Shenoy" > > Pstates are 8bit values but on POWER8 they are negative and on POWER9 > they are positive. This patch adds helper routines to differentiate > the sign to read the correct pstate value. > >

[PATCH] powerpc/perf: Fix nest-imc cpuhotplug callback failure

Call trace observed during boot: Faulting instruction address: 0xc0248340 cpu 0x0: Vector: 380 (Data Access Out of Range) at

Re: [PATCH 04/10] ASoC: fsl_ssi: Refine all comments

On Mon, Dec 04, 2017 at 10:04:57PM -0600, Timur Tabi wrote: > On 12/4/17 2:46 PM, Nicolin Chen wrote: > >This patch refines the comments by: > >1) Removing all out-of-date comments > >2) Removing all not-so-useful comments > >3) Unifying the styles of all comments > >4) Simplifying

Re: [PATCH 04/10] ASoC: fsl_ssi: Refine all comments

On 12/4/17 2:46 PM, Nicolin Chen wrote: This patch refines the comments by: 1) Removing all out-of-date comments 2) Removing all not-so-useful comments 3) Unifying the styles of all comments 4) Simplifying over-descriptive comments 5) Adding comments to improve code readablity 6) Moving all

Re: [PATCH] powerpc/xive: store server for masked interrupt in kvmppc_xive_set_xive()

On Fri, Nov 24, 2017 at 07:38:13AM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2017-11-23 at 10:06 +0100, Laurent Vivier wrote: > > This is needed to map kvmppc_xive_set_xive() behavior > > to kvmppc_xics_set_xive(). > > > > As we store the server, kvmppc_xive_get_xive() can return > > the

Re: [PATCH v2] powerpc/64s: ISAv3 initialize MMU registers before setting partition table

Hi Nick, Sorry I didn't reply sooner. Nicholas Piggin writes: > kexec can leave MMU registers set when booting into a new kernel, PIDR > in particular. The boot sequence does not zero PIDR, so it only gets > set when CPUs first switch to a userspace processes (until then

Re: [PATCH v5 0/3] Prepartion for SR-IOV PowerVM Enablement

On 05/12/17 02:08, Bryant G. Ly wrote: > > > On 12/2/17 7:45 PM, Alexey Kardashevskiy wrote: >> On 10/11/17 01:00, Bryant G. Ly wrote: >>> v1 - Initial patch >>> v2 - Addressed Bjorn's comment on creating a highly platform >>> dependent global exported symbol. >>> v3 - Based patch off

[PATCH 07/10] ASoC: fsl_ssi: Refine printk outputs

This patches unifies the error message in the "failed to " format. It also reduces the length of one line and adds spaces to an operator. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 16 1 file changed, 8 insertions(+), 8 deletions(-)

[PATCH 10/10] ASoC: fsl_ssi: Replace fsl_ssi_rxtx_reg_val with fsl_ssi_regvals

The name fsl_ssi_rxtx_reg_val is too long to read comfortably. So this patch shortens it by using an array (fsl_ssi_regvals, renamed from fsl_ssi_reg_val). To do that, it also introduces two macros (TX and RX) to replace the wrapper structure. This will also help for further cleanups. Meanwhile,

[PATCH 09/10] ASoC: fsl_ssi: Rename scr_val to scr

Simplify the variable name. This reduces one over-80-character line. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index

[PATCH 08/10] ASoC: fsl_ssi: Rename cpu_dai parameter to dai

Shortens the variable name to save space, useful for dev_err outputs. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c

[PATCH 06/10] ASoC: fsl_ssi: Refine indentations and wrappings

This patch just simply unifies the coding style. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 225 ++-- sound/soc/fsl/fsl_ssi.h | 2 +- sound/soc/fsl/fsl_ssi_dbg.c | 3 +- 3 files changed, 113

[PATCH 05/10] ASoC: fsl_ssi: Rename registers and fields macros

This patch renames CCSR_SSI_xxx to REG_SSI_xxx and SSI_xxx_yyy style. It also slightly reduces the length of them to save some space. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 374 +-- sound/soc/fsl/fsl_ssi.h

[PATCH 04/10] ASoC: fsl_ssi: Refine all comments

This patch refines the comments by: 1) Removing all out-of-date comments 2) Removing all not-so-useful comments 3) Unifying the styles of all comments 4) Simplifying over-descriptive comments 5) Adding comments to improve code readablity 6) Moving all register related comments to fsl_ssi.h 7)

[PATCH 02/10] ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi

Shorten the private data structure to save some wrapped lines. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 456 +++- 1 file changed, 220 insertions(+), 236 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c

[PATCH 03/10] ASoC: fsl_ssi: Cache pdev->dev pointer

There should be no trouble to understand dev = pdev->dev. This can save some space to have more print info or save some wrapped lines. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 64 - 1 file changed, 31

[PATCH 01/10] ASoC: fsl_ssi: Remove unused struct device

struct device is defined in system level header files any way. As long as fsl_ssi.h is included after those header files, it should be safe to remove this line. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.h | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level

==Background== The fsl_ssi driver was designed for PPC originally and then it has been updated to support different modes for i.MX Series, including SDMA, I2S Master mode, AC97 and older i.MXs with FIQ, by different contributors for different use cases in different coding styles. Additionally, in

SB600 for the Nemo board has non-zero devices on non-root bus

Darren, What do you think about Olof’s solution? Link: http://forum.hyperion-entertainment.biz/viewtopic.php?f=35=3891=43206#p43201 Thanks, Christian Sent from my iPhone > On 4. Dec 2017, at 12:40, Darren Stevens wrote: > > Hello Bjorn > > Firstly sorry for not

Re: Resend: [PATCH V5 3/4] hotplug/drc-info: Add code to search ibm,drc-info property

See below. On 11/30/2017 01:51 PM, Nathan Fontenot wrote: > > > On 11/28/2017 05:07 PM, Michael Bringmann wrote: >> rpadlpar_core.c: Provide parallel routines to search the older device- >> tree properties ("ibm,drc-indexes", "ibm,drc-names", "ibm,drc-types" >> and "ibm,drc-power-domains"), or

Re: Resend: [PATCH V5 2/4] pseries/drc-info: Search DRC properties for CPU indexes

See below. On 11/30/2017 01:28 PM, Nathan Fontenot wrote: > On 11/28/2017 05:07 PM, Michael Bringmann wrote: >> pseries/drc-info: Provide parallel routines to convert between >> drc_index and CPU numbers at runtime, using the older device-tree >> properties ("ibm,drc-indexes", "ibm,drc-names",

Re: [PATCH 2/4] powerpc/64: do not trace irqs-off at interrupt return to soft-disabled context

On Mon, 2017-12-04 at 16:09 +1100, Michael Ellerman wrote: > Nicholas Piggin writes: > > > When an interrupt is returning to a soft-disabled context (which can > > happen for non-maskable interrupts or synchronous interrupts), it goes > > through the motions of soft-disabling

Re: [PATCH v5 0/3] Prepartion for SR-IOV PowerVM Enablement

On 12/2/17 7:45 PM, Alexey Kardashevskiy wrote: > On 10/11/17 01:00, Bryant G. Ly wrote: >> v1 - Initial patch >> v2 - Addressed Bjorn's comment on creating a highly platform >> dependent global exported symbol. >> v3 - Based patch off linux-ppc/master >> v4 - Using the

Re: [PATCH v2 1/2] KVM: PPC: Book3S HV: Drop prepare_done from struct kvm_resize_hpt and cleanups

On Mon, 2017-12-04 at 09:36 -0500, Serhii Popovych wrote: > Change comparison against zero to make checkpatch.pl happy. Huh? Either I'm confused or you are incorrect here. checkpatch should or does not warn against comparisons to zero. There is a test for comparison to NULL. > diff --git

Re: [PATCH 0/4] Fix use after free in HPT resizing code and related minor improvements

David Gibson wrote: > On Wed, Nov 29, 2017 at 11:38:22AM -0500, Serhii Popovych wrote: >> It is possible to trigger use after free during HPT resize >> causing host kernel to crash. More details and analysis of >> the problem can be found in change with corresponding subject >> (KVM: PPC: Book3S

[PATCH v2 2/2] KVM: PPC: Book3S HV: Fix use after free in case of multiple resize requests

When serving multiple resize requests following could happen: CPU0CPU1 kvm_vm_ioctl_resize_hpt_prepare(1); -> schedule_work() /* system_rq might be busy:

[PATCH v2 1/2] KVM: PPC: Book3S HV: Drop prepare_done from struct kvm_resize_hpt and cleanups

Currently the kvm_resize_hpt structure has two fields relevant to the state of an ongoing resize: 'prepare_done', which indicates whether the worker thread has completed or not, and 'error' which indicates whether it was successful or not. Since the success/failure isn't known until completion,

[PATCH v2 0/2] Fix use after free in HPT resizing code and related minor improvements

It is possible to trigger use after free during HPT resize causing host kernel to crash. More details and analysis of the problem can be found in change with corresponding subject (KVM: PPC: Book3S HV: Fix use after free in case of multiple resize requests). We need some changes to prepare for

Re: [PATCH 2/4] powerpc/64: do not trace irqs-off at interrupt return to soft-disabled context

Nicholas Piggin writes: > On Mon, 04 Dec 2017 16:09:57 +1100 > Michael Ellerman wrote: > >> Nicholas Piggin writes: >> >> > When an interrupt is returning to a soft-disabled context (which can >> > happen for non-maskable interrupts

Re: [PATCH 0/4] Fix use after free in HPT resizing code and related minor improvements

David Gibson writes: > On Wed, Nov 29, 2017 at 11:38:22AM -0500, Serhii Popovych wrote: >> It is possible to trigger use after free during HPT resize >> causing host kernel to crash. More details and analysis of >> the problem can be found in change with

Re: SB600 for the Nemo board has non-zero devices on non-root bus

Hello Bjorn Firstly sorry for not being able to join in this discussion, I have been moving house and only got my X1000 set up again yesterday.. On 30/11/2017, Bjorn Helgaas wrote: > I *think* something like the patch below should make this work if you > use the "pci=pcie_scan_all" parameter.

Re: [PATCH] powerpc/40x: acadia: Fix the 'interrupt-parent' property

Hi Michael, On Mon, Dec 4, 2017 at 2:45 AM, Michael Ellerman wrote: > Will pick it up for 4.16. Just realized that there is already a fix for this in linux-next: commit 3d2d4339cc326c427638daa67e264dd455ee1899 Author: Geert Uytterhoeven Date:

Re: [PATCH] KVM: PPC: Book3S HV: check for XIVE device before executing the XICS hcalls

On 12/04/2017 02:04 AM, Paul Mackerras wrote: > On Mon, Nov 27, 2017 at 08:30:17AM +0100, Cédric Le Goater wrote: >> When QEMU is started with the option kernel_irqchip=òff, the kvm XICS >> hcalls are being used even though a kvm XICS device has not been >> created on the host, resulting quickly