RE: [bug report] fsl/qe: setup clock source for TDM mode

2018-01-31 Thread Qiang Zhao
On 2018/1/31 23:30, Dan Carpenter wrote -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: 2018年1月31日 23:30 To: Qiang Zhao Cc: linuxppc-dev@lists.ozlabs.org Subject: [bug report] fsl/qe: setup clock source for

[PATCH kernel v2] powerpc/mm: Flush radix process translations when setting MMU type

2018-01-31 Thread Alexey Kardashevskiy
Radix guests do normally invalidate process-scoped translations when a new pid is allocated but migrated guests do not invalidate these so migrated guests crash sometime, especially easy to reproduce with migration happening within first 10 seconds after the guest boot start on the same machine.

[PATCH kernel] powerpc/mm: Fix typo in comments

2018-01-31 Thread Alexey Kardashevskiy
Fixes: 912cc87a6 "powerpc/mm/radix: Add LPID based tlb flush helpers" Signed-off-by: Alexey Kardashevskiy --- arch/powerpc/mm/tlb-radix.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/mm/tlb-radix.c b/arch/powerpc/mm/tlb-radix.c

Re: [bug report] powerpc/mm/radix: Add tlbflush routines

2018-01-31 Thread Michael Ellerman
Dan Carpenter writes: > Hello Aneesh Kumar K.V, > > The patch 1a472c9dba6b: "powerpc/mm/radix: Add tlbflush routines" > from Apr 29, 2016, leads to the following static checker warning: > > arch/powerpc/mm/tlb_nohash.c:218 __local_flush_tlb_page() > warn:

Re: [PATCH] powerpc/tm: Remove struct thread_info param from tm_reclaim_thread()

2018-01-31 Thread Michael Ellerman
Cyril Bur writes: > tm_reclaim_thread() doesn't use the parameter anymore, both callers have > to bother getting it as they have no need for a struct thread_info > either. In future please tell me why the parameter is unused and when it became unused. In this case it was

Re: [bug report] powerpc/mm/radix: Add tlbflush routines

2018-01-31 Thread Aneesh Kumar K.V
On 01/31/2018 09:31 PM, Christophe LEROY wrote: Le 31/01/2018 à 16:45, Dan Carpenter a écrit : Hello Aneesh Kumar K.V, The patch 1a472c9dba6b: "powerpc/mm/radix: Add tlbflush routines" from Apr 29, 2016, leads to the following static checker warning: arch/powerpc/mm/tlb_nohash.c:218

Re: [PATCH v11 0/3] mm, x86, powerpc: Enhancements to Memory Protection Keys.

2018-01-31 Thread Michael Ellerman
Ingo Molnar writes: > * Ram Pai wrote: > >> This patch series provides arch-neutral enhancements to >> enable memory-keys on new architecutes, and the corresponding >> changes in x86 and powerpc specific code to support that. >> >> a) Provides ability to

[PATCH] powerpc/tm: Remove struct thread_info param from tm_reclaim_thread()

2018-01-31 Thread Cyril Bur
tm_reclaim_thread() doesn't use the parameter anymore, both callers have to bother getting it as they have no need for a struct thread_info either. Just remove it and adjust the callers. Signed-off-by: Cyril Bur --- arch/powerpc/kernel/process.c | 7 +++ 1 file changed,

[bug report] powerpc/perf: Add nest IMC PMU support

2018-01-31 Thread Dan Carpenter
Hello Anju T Sudhakar, The patch 885dcd709ba9: "powerpc/perf: Add nest IMC PMU support" from Jul 19, 2017, leads to the following static checker warning: arch/powerpc/perf/imc-pmu.c:1393 init_imc_pmu() warn: 'pmu_ptr' was already freed. arch/powerpc/perf/imc-pmu.c 1317 int

Re: Wifi (B43) broken on G4 PowerBooks with kernel v4.15

2018-01-31 Thread James Hogan
On Wed, Jan 31, 2018 at 10:37:30AM +0100, Gabriel Paubert wrote: > Hi, > > yesterday I recompiled the kernel on my late 2005 G4 PowerBook, and the > Wifi stopped working. After comparing the configuration is turns out > that a change to a Kconfig condition disabled SSB support which is >

[PATCH] KVM: PPC: Fix svcpu copying with preemption enabled

2018-01-31 Thread Alexander Graf
When copying between the vcpu and svcpu, we may get scheduled away onto a different host CPU which in turn means our svcpu pointer may change. That means we need to atomically copy to and from the svcpu with preemption disabled, so that all code around it always sees a coherent state.

[bug report] fsl/qe: setup clock source for TDM mode

2018-01-31 Thread Dan Carpenter
Hello Zhao Qiang, The patch bb8b2062aff3: "fsl/qe: setup clock source for TDM mode" from Jun 6, 2016, leads to the following static checker warning: drivers/soc/fsl/qe/ucc.c:629 ucc_get_tdm_sync_shift() warn: both sides of ternary the same: '30' RX_SYNC_SHIFT_BASE

Re: [bug report] powerpc/mm/radix: Add tlbflush routines

2018-01-31 Thread Christophe LEROY
Le 31/01/2018 à 16:45, Dan Carpenter a écrit : Hello Aneesh Kumar K.V, The patch 1a472c9dba6b: "powerpc/mm/radix: Add tlbflush routines" from Apr 29, 2016, leads to the following static checker warning: arch/powerpc/mm/tlb_nohash.c:218 __local_flush_tlb_page() warn: always

[bug report] powerpc/mm/radix: Add tlbflush routines

2018-01-31 Thread Dan Carpenter
Hello Aneesh Kumar K.V, The patch 1a472c9dba6b: "powerpc/mm/radix: Add tlbflush routines" from Apr 29, 2016, leads to the following static checker warning: arch/powerpc/mm/tlb_nohash.c:218 __local_flush_tlb_page() warn: always true condition '(pid != ~0) => (0-u32max != u64max)'

[PATCH] powerpc/mm/radix: Fix build error when RADIX_MMU=n

2018-01-31 Thread Michael Ellerman
The recent TLB flush rework broke the build when the Radix MMU is disabled at build time, eg: (.text+0x264): undefined reference to `.radix__tlbiel_all' We could add an empty version, but if we ever called it by accident that would indicate a bad bug, so add a stub that just WARNs if we do.

Re: [PATCH v11 3/3] mm, x86: display pkey in smaps only if arch supports pkeys

2018-01-31 Thread Michal Hocko
On Tue 30-01-18 11:44:12, Ram Pai wrote: > Currently the architecture specific code is expected to > display the protection keys in smap for a given vma. > This can lead to redundant code and possibly to divergent > formats in which the key gets displayed. > > This patch changes the

Re: [PATCH] ocxl: fix signed comparison with less than zero

2018-01-31 Thread Frederic Barrat
Le 30/01/2018 à 16:11, Colin King a écrit : From: Colin Ian King Currently the comparison of used < 0 is always false because uses is a size_t. Fix this by making used a ssize_t type. Detected by Coccinelle: drivers/misc/ocxl/file.c:320:6-10: WARNING: Unsigned

[PATCH v3 1/1] KVM: PPC: Book3S: Add MMIO emulation for VMX instructions

2018-01-31 Thread Jose Ricardo Ziviani
This patch provides the MMIO load/store vector indexed X-Form emulation. Instructions implemented: lvx: the quadword in storage addressed by the result of EA & 0x___fff0 is loaded into VRT. stvx: the contents of VRS are stored into the quadword in storage addressed by the result of

[PATCH v3 0/1] Implements MMIO emulation for lvx/stvx instructions

2018-01-31 Thread Jose Ricardo Ziviani
v3: - Added Reported-by in the commit message v2: - kvmppc_get_vsr_word_offset() moved back to its original place - EA AND ~0xF, following ISA. - fixed BE/LE cases TESTS: For testing purposes I wrote a small program that performs stvx/lvx using the program's virtual memory and using

Re: [PATCH] KVM: PPC: Book3S PR: close a race window when SVCPU pointer is hold before kvmppc_copy_from_svcpu()

2018-01-31 Thread Simon Guo
Hi Alex, On Wed, Jan 31, 2018 at 10:28:05AM +0100, Alexander Graf wrote: > > > On 31.01.18 05:23, wei.guo.si...@gmail.com wrote: > > From: Simon Guo > > > > commit 40fdd8c88c4a ("KVM: PPC: Book3S: PR: Make svcpu -> vcpu store > > preempt savvy") and commit 3d3319b45eea

Re: Wifi (B43) broken on G4 PowerBooks with kernel v4.15

2018-01-31 Thread Gabriel Paubert
On Wed, Jan 31, 2018 at 10:03:46AM +, James Hogan wrote: > On Wed, Jan 31, 2018 at 10:37:30AM +0100, Gabriel Paubert wrote: > > Hi, > > > > yesterday I recompiled the kernel on my late 2005 G4 PowerBook, and the > > Wifi stopped working. After comparing the configuration is turns out > >

Wifi (B43) broken on G4 PowerBooks with kernel v4.15

2018-01-31 Thread Gabriel Paubert
Hi, yesterday I recompiled the kernel on my late 2005 G4 PowerBook, and the Wifi stopped working. After comparing the configuration is turns out that a change to a Kconfig condition disabled SSB support which is necessary for these chips. The graph of configuration options is quite

Re: [PATCH] KVM: PPC: Book3S PR: close a race window when SVCPU pointer is hold before kvmppc_copy_from_svcpu()

2018-01-31 Thread Alexander Graf
On 31.01.18 05:23, wei.guo.si...@gmail.com wrote: > From: Simon Guo > > commit 40fdd8c88c4a ("KVM: PPC: Book3S: PR: Make svcpu -> vcpu store > preempt savvy") and commit 3d3319b45eea ("KVM: PPC: Book3S: PR: Enable > interrupts earlier") is trying to turns on preemption

Re: [PATCH] KVM: PPC: Book3S PR: close a race window when SVCPU pointer is hold before kvmppc_copy_from_svcpu()

2018-01-31 Thread Alexander Graf
On 31.01.18 05:23, wei.guo.si...@gmail.com wrote: > From: Simon Guo > > commit 40fdd8c88c4a ("KVM: PPC: Book3S: PR: Make svcpu -> vcpu store > preempt savvy") and commit 3d3319b45eea ("KVM: PPC: Book3S: PR: Enable > interrupts earlier") is trying to turns on preemption

Re: [PATCH v2 3/6] gpio: Add GPIO driver for Nintendo Wii

2018-01-31 Thread Jonathan Neuschäfer
Hi, On Sun, Jan 28, 2018 at 07:31:58PM +0200, Andy Shevchenko wrote: > On Mon, Jan 22, 2018 at 7:04 AM, Jonathan Neuschäfer > wrote: > > Style issues below. > > > +#define HW_GPIO_OWNER 0x3c > > + > > + > > +struct hlwd_gpio { > > No need extra empty line in