Re: [RFC] new SYSCALL_DEFINE/COMPAT_SYSCALL_DEFINE wrappers

2018-03-26 Thread John Paul Adrian Glaubitz
On 03/27/2018 12:40 PM, Linus Torvalds wrote: > On Mon, Mar 26, 2018 at 4:37 PM, John Paul Adrian Glaubitz > wrote: >> >> What about a tarball with a minimal Debian x32 chroot? Then you can >> install interesting packages you would like to test yourself. > > That

Re: linux-next: manual merge of the powerpc tree with the powerpc-fixes tree

2018-03-26 Thread Michael Ellerman
Stephen Rothwell writes: > Hi all, > > Today's linux-next merge of the powerpc tree got a conflict in: > > arch/powerpc/include/asm/cputable.h > arch/powerpc/kernel/dt_cpu_ftrs.c > > between commit: > > a5d4b5891c2f ("powerpc/mm: Fixup tlbie vs store ordering issue

[PATCH v3 8/8] powerpc: Disable DAWR in the base POWER9 CPU features

2018-03-26 Thread Michael Neuling
Using the DAWR on POWER9 can cause xstops, hence we need to disable it. Signed-off-by: Michael Neuling --- arch/powerpc/include/asm/cputable.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/include/asm/cputable.h

[PATCH v3 7/8] powerpc: Disable DAWR on POWER9 via CPU feature quirk

2018-03-26 Thread Michael Neuling
This disables the DAWR on all POWER9 CPUs via cpu feature quirk. Using the DAWR on POWER9 can cause xstops, hence we need to disable it. Signed-off-by: Michael Neuling --- arch/powerpc/kernel/dt_cpu_ftrs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v3 6/8] KVM: PPC: Book3S HV: Handle migration with POWER9 disabled DAWR

2018-03-26 Thread Michael Neuling
POWER9 with the DAWR disabled causes problems for partition migration. Either we have to fail the migration (since we lose the DAWR) or we silently drop the DAWR and allow the migration to pass. This patch does the latter and allows the migration to pass (at the cost of silently losing the DAWR).

[PATCH v3 5/8] KVM: PPC: Book3S HV: Return error from h_set_dabr() on POWER9

2018-03-26 Thread Michael Neuling
POWER7 compat mode guests can use h_set_dabr on POWER9. POWER9 should use the DAWR but since it's disabled there we can't. This returns H_UNSUPPORTED on a h_set_dabr() on POWER9 where the DAWR is disabled. Current Linux guests ignore this error, so they will silently not get the DAWR (sigh). The

[PATCH v3 3/8] powerpc: Update xmon to use ppc_breakpoint_available()

2018-03-26 Thread Michael Neuling
The 'bd' command will now print an error and not set the breakpoint on P9. Signed-off-by: Michael Neuling --- arch/powerpc/xmon/xmon.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index a06cf6e389..047a682c6d

[PATCH v3 2/8] powerpc: Update ptrace to use ppc_breakpoint_available()

2018-03-26 Thread Michael Neuling
This updates the ptrace code to use ppc_breakpoint_available(). We now advertise via PPC_PTRACE_GETHWDBGINFO zero breakpoints when the DAWR is missing (ie. POWER9). This results in GDB falling back to software emulation of the breakpoint (which is slow). For the features advertised by

[PATCH v3 0/8] powerpc: Disable DAWR on POWER9

2018-03-26 Thread Michael Neuling
Using the DAWR on POWER9 can cause xstops, hence we need to disable it. The current CPU_FTR for DAWR is a bit messy. Despite having CPU_FTR_DAWR, currently we assume DAWR exists in the KVM code based on CPU_FTR_ARCH_207. In other places we assume DAWR exists if CPU_FTR_DAWR is set. This attempts

[PATCH v3 4/8] KVM: PPC: Book3S HV: Return error from h_set_mode(SET_DAWR) on POWER9

2018-03-26 Thread Michael Neuling
Return H_P2 on a h_set_mode(SET_DAWR) on POWER9 where the DAWR is disabled. Current Linux guests ignore this error, so they will silently not get the DAWR (sigh). The same error code is being used by POWERVM in this case. Signed-off-by: Michael Neuling ---

[PATCH v3 1/8] powerpc: Add ppc_breakpoint_available()

2018-03-26 Thread Michael Neuling
Add ppc_breakpoint_available() to determine if a breakpoint is available currently via the DAWR or DABR. Signed-off-by: Michael Neuling --- arch/powerpc/include/asm/debug.h | 1 + arch/powerpc/kernel/process.c| 12 2 files changed, 13 insertions(+) diff

[PATCH] powerpc: Only support DYNAMIC_FTRACE not static

2018-03-26 Thread Michael Ellerman
We've had dynamic ftrace support for over 9 years since Steve first wrote it, all the distros use dynamic, and static is basically untested these days, so drop support for static ftrace. Signed-off-by: Michael Ellerman --- arch/powerpc/Kconfig | 1

Re: [PATCH v4] mm, pkey: treat pkey-0 special

2018-03-26 Thread Balbir Singh
On Tue, Mar 27, 2018 at 2:48 PM, Michael Ellerman wrote: > Ram Pai writes: > >> On Fri, Mar 16, 2018 at 10:02:22PM +1100, Balbir Singh wrote: >>> On Fri, Mar 16, 2018 at 9:33 PM, Ram Pai wrote: >>> > Applications need the ability to

Re: [PATCH] powerpc/mm: Fix thread_pkey_regs_init()

2018-03-26 Thread Balbir Singh
On Tue, Mar 27, 2018 at 1:36 PM, Ram Pai wrote: > thread_pkey_regs_init() initializes the pkey related registers > instead of initializing the fields in the task structures. Fortunately > those key related registers are re-set to zero when the task > gets scheduled on the

Re: [PATCH v9 21/24] perf tools: Add support for the SPF perf event

2018-03-26 Thread Andi Kleen
On Mon, Mar 26, 2018 at 02:44:48PM -0700, David Rientjes wrote: > On Tue, 13 Mar 2018, Laurent Dufour wrote: > > > Add support for the new speculative faults event. > > > > Signed-off-by: Laurent Dufour > > Acked-by: David Rientjes > > Aside:

Re: [PATCH v4] mm, pkey: treat pkey-0 special

2018-03-26 Thread Michael Ellerman
Ram Pai writes: > On Fri, Mar 16, 2018 at 10:02:22PM +1100, Balbir Singh wrote: >> On Fri, Mar 16, 2018 at 9:33 PM, Ram Pai wrote: >> > Applications need the ability to associate an address-range with some >> > key and latter revert to its initial

Re: [RFC] new SYSCALL_DEFINE/COMPAT_SYSCALL_DEFINE wrappers

2018-03-26 Thread Linus Torvalds
On Mon, Mar 26, 2018 at 4:37 PM, John Paul Adrian Glaubitz wrote: > > What about a tarball with a minimal Debian x32 chroot? Then you can > install interesting packages you would like to test yourself. That probably works fine. Linus

Re: [RFC] new SYSCALL_DEFINE/COMPAT_SYSCALL_DEFINE wrappers

2018-03-26 Thread John Paul Adrian Glaubitz
On 03/27/2018 10:03 AM, Linus Torvalds wrote: > Hmm. Do you have a few statically built binaries that could be tested > without installing a whole distribution? Something real and meaningful > enough that it actually exercised a few real system calls, but not > something that needs to bring in 50

[PATCH] powerpc/mm: Fix thread_pkey_regs_init()

2018-03-26 Thread Ram Pai
thread_pkey_regs_init() initializes the pkey related registers instead of initializing the fields in the task structures. Fortunately those key related registers are re-set to zero when the task gets scheduled on the cpu. However its good to fix this glaringly visible error. cc: Michael Ellermen

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Jason Gunthorpe
On Tue, Mar 27, 2018 at 10:59:40AM +1100, Benjamin Herrenschmidt wrote: > On Mon, 2018-03-26 at 16:50 -0600, Jason Gunthorpe wrote: > > On Tue, Mar 27, 2018 at 09:36:11AM +1100, Benjamin Herrenschmidt wrote: > > > On Mon, 2018-03-26 at 16:27 -0600, Jason Gunthorpe wrote: > > > > > Otherwise almost

[PATCH] powerpc: do not allow userspace to modify execute-only pkey

2018-03-26 Thread Ram Pai
When mprotect(,PROT_EXEC) is called, the kernel allocates a execute-only pkey and associates the pkey with the given address space. The permission of this key should not be modifiable from userspace. However a bug in the current implementation lets the permissions on the key modifiable from

[PATCH v2] powerpc, pkey: make protection key 0 less special

2018-03-26 Thread Ram Pai
Applications need the ability to associate an address-range with some key and latter revert to its initial default key. Pkey-0 comes close to providing this function but falls short, because the current implementation disallows applications to explicitly associate pkey-0 to the address range.

Re: [PATCH] powerpc, pkey: make protection key 0 less special

2018-03-26 Thread Ram Pai
On Mon, Mar 26, 2018 at 04:31:41PM -0700, Ram Pai wrote: > Applications need the ability to associate an address-range with some > key and latter revert to its initial default key. Pkey-0 comes close to > providing this function but falls short, because the current > implementation disallows

Re: [RFC] new SYSCALL_DEFINE/COMPAT_SYSCALL_DEFINE wrappers

2018-03-26 Thread Linus Torvalds
On Sun, Mar 25, 2018 at 8:44 PM, John Paul Adrian Glaubitz wrote: < > FWIW, we are maintaining an x32 port in Debian and there are some people > actually using it [1]. There is one build instance running on VMWare that > I am hosting [2] and around 10800 out of 12900

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Benjamin Herrenschmidt
On Mon, 2018-03-26 at 16:50 -0600, Jason Gunthorpe wrote: > On Tue, Mar 27, 2018 at 09:36:11AM +1100, Benjamin Herrenschmidt wrote: > > On Mon, 2018-03-26 at 16:27 -0600, Jason Gunthorpe wrote: > > > > Otherwise almost all drivers out there are broken which I very much > > > > doubt :-) > > > > >

[PATCH] powerpc, pkey: make protection key 0 less special

2018-03-26 Thread Ram Pai
Applications need the ability to associate an address-range with some key and latter revert to its initial default key. Pkey-0 comes close to providing this function but falls short, because the current implementation disallows applications to explicitly associate pkey-0 to the address range.

linux-next: manual merge of the powerpc tree with the powerpc-fixes tree

2018-03-26 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the powerpc tree got a conflict in: arch/powerpc/include/asm/cputable.h arch/powerpc/kernel/dt_cpu_ftrs.c between commit: a5d4b5891c2f ("powerpc/mm: Fixup tlbie vs store ordering issue on POWER9") from the powerpc-fixes tree and commits:

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Jason Gunthorpe
On Tue, Mar 27, 2018 at 09:36:11AM +1100, Benjamin Herrenschmidt wrote: > On Mon, 2018-03-26 at 16:27 -0600, Jason Gunthorpe wrote: > > > Otherwise almost all drivers out there are broken which I very much > > > doubt :-) > > > > But.. Sinan is right, you look anywhere in the driver tree and you

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Benjamin Herrenschmidt
On Tue, 2018-03-27 at 09:36 +1100, Benjamin Herrenschmidt wrote: > I don't kow, it used to be the case, at least that's what drove us to > define things the way we did. > > Maybe things changed, but if that's the case, nobody knows for sure, > and we probably want to get Linus POV on the matter.

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Benjamin Herrenschmidt
On Mon, 2018-03-26 at 16:27 -0600, Jason Gunthorpe wrote: > > Otherwise almost all drivers out there are broken which I very much > > doubt :-) > > But.. Sinan is right, you look anywhere in the driver tree and you > find stuff like this: > > drivers/net/ethernet/intel/i40e/i40e_txrx.c > >

Re: [PATCH v3 3/6] powerpc/kexec: Disable ftrace before switching to the new kernel

2018-03-26 Thread Michael Ellerman
Michael Ellerman writes: > "Naveen N. Rao" writes: >> If function_graph tracer is enabled during kexec, we see the below >> exception in the simulator: >> root@(none):/# kexec -e >> kvm: exiting hardware virtualization >>

Re: [PATCH v3 3/6] powerpc/kexec: Disable ftrace before switching to the new kernel

2018-03-26 Thread Michael Ellerman
"Naveen N. Rao" writes: > If function_graph tracer is enabled during kexec, we see the below > exception in the simulator: > root@(none):/# kexec -e > kvm: exiting hardware virtualization > kexec_core: Starting new kernel > [

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Benjamin Herrenschmidt
On Mon, 2018-03-26 at 18:08 -0400, Sinan Kaya wrote: > On 3/26/2018 6:01 PM, Benjamin Herrenschmidt wrote: > > On Mon, 2018-03-26 at 17:46 -0400, Sinan Kaya wrote: > > > On 3/26/2018 5:30 PM, Arnd Bergmann wrote: > > > > > But that was never a requirement of writel(), > > > > >

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Jason Gunthorpe
On Tue, Mar 27, 2018 at 09:01:57AM +1100, Benjamin Herrenschmidt wrote: > On Mon, 2018-03-26 at 17:46 -0400, Sinan Kaya wrote: > > On 3/26/2018 5:30 PM, Arnd Bergmann wrote: > > > > But that was never a requirement of writel(), > > > > Documentation/memory-barriers.txt gives an explicit example

Re: [PATCH 6/6] doc/devicetree: NVDIMM region documentation

2018-03-26 Thread Rob Herring
On Fri, Mar 23, 2018 at 07:12:09PM +1100, Oliver O'Halloran wrote: > Add device-tree binding documentation for the nvdimm region driver. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Oliver O'Halloran > --- > .../devicetree/bindings/nvdimm/nvdimm-region.txt | 45 >

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Sinan Kaya
On 3/26/2018 6:01 PM, Benjamin Herrenschmidt wrote: > On Mon, 2018-03-26 at 17:46 -0400, Sinan Kaya wrote: >> On 3/26/2018 5:30 PM, Arnd Bergmann wrote: But that was never a requirement of writel(), Documentation/memory-barriers.txt gives an explicit example demanding the wmb()

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Benjamin Herrenschmidt
On Mon, 2018-03-26 at 17:46 -0400, Sinan Kaya wrote: > On 3/26/2018 5:30 PM, Arnd Bergmann wrote: > > > But that was never a requirement of writel(), > > > Documentation/memory-barriers.txt gives an explicit example demanding > > > the wmb() before writel() for ordering system memory against

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Benjamin Herrenschmidt
On Mon, 2018-03-26 at 23:30 +0200, Arnd Bergmann wrote: > Most of the drivers have a unwound loop with writeq() or something to > > do it. > > But isn't the writeq() barrier much more expensive than anything you'd > do in function calls? It is for us, and will break any write combining. > > >

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Sinan Kaya
On 3/26/2018 5:30 PM, Arnd Bergmann wrote: >> But that was never a requirement of writel(), >> Documentation/memory-barriers.txt gives an explicit example demanding >> the wmb() before writel() for ordering system memory against writel. > Indeed, but it's in an example for when to use dma_wmb(),

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Benjamin Herrenschmidt
On Mon, 2018-03-26 at 10:54 -0600, Jason Gunthorpe wrote: > On Mon, Mar 26, 2018 at 11:08:45AM +, David Laight wrote: > > > > This is a super performance critical operation for most drivers and > > > > directly impacts network performance. > > > > Perhaps there ought to be writel_nobarrier()

Re: [PATCH v9 21/24] perf tools: Add support for the SPF perf event

2018-03-26 Thread David Rientjes
On Tue, 13 Mar 2018, Laurent Dufour wrote: > Add support for the new speculative faults event. > > Signed-off-by: Laurent Dufour Acked-by: David Rientjes Aside: should there be a new spec_flt field for struct task_struct that complements

Re: [PATCH v9 20/24] perf: Add a speculative page fault sw event

2018-03-26 Thread David Rientjes
On Tue, 13 Mar 2018, Laurent Dufour wrote: > Add a new software event to count succeeded speculative page faults. > > Signed-off-by: Laurent Dufour Acked-by: David Rientjes

Re: [PATCH v9 23/24] x86/mm: Add speculative pagefault handling

2018-03-26 Thread David Rientjes
On Tue, 13 Mar 2018, Laurent Dufour wrote: > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > index e6af2b464c3d..a73cf227edd6 100644 > --- a/arch/x86/mm/fault.c > +++ b/arch/x86/mm/fault.c > @@ -1239,6 +1239,9 @@ __do_page_fault(struct pt_regs *regs, unsigned long > error_code, >

Re: [PATCH v9 24/24] powerpc/mm: Add speculative page fault

2018-03-26 Thread David Rientjes
On Tue, 13 Mar 2018, Laurent Dufour wrote: > diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c > index 866446cf2d9a..104f3cc86b51 100644 > --- a/arch/powerpc/mm/fault.c > +++ b/arch/powerpc/mm/fault.c > @@ -392,6 +392,9 @@ static int __do_page_fault(struct pt_regs *regs, unsigned >

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Arnd Bergmann
On Mon, Mar 26, 2018 at 11:09 PM, Jason Gunthorpe wrote: > On Mon, Mar 26, 2018 at 10:43:43PM +0200, Arnd Bergmann wrote: >> On Mon, Mar 26, 2018 at 10:25 PM, Jason Gunthorpe wrote: >> > On Mon, Mar 26, 2018 at 09:44:15PM +0200, Arnd Bergmann wrote: >> >> On Mon,

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Jason Gunthorpe
On Mon, Mar 26, 2018 at 10:43:43PM +0200, Arnd Bergmann wrote: > On Mon, Mar 26, 2018 at 10:25 PM, Jason Gunthorpe wrote: > > On Mon, Mar 26, 2018 at 09:44:15PM +0200, Arnd Bergmann wrote: > >> On Mon, Mar 26, 2018 at 6:54 PM, Jason Gunthorpe wrote: > >> > On Mon,

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Arnd Bergmann
On Mon, Mar 26, 2018 at 10:25 PM, Jason Gunthorpe wrote: > On Mon, Mar 26, 2018 at 09:44:15PM +0200, Arnd Bergmann wrote: >> On Mon, Mar 26, 2018 at 6:54 PM, Jason Gunthorpe wrote: >> > On Mon, Mar 26, 2018 at 11:08:45AM +, David Laight wrote: >> >> > > This is

Re: [RFC PATCH v2 0/2] Randomization of address chosen by mmap.

2018-03-26 Thread Ilya Smith
> On 26 Mar 2018, at 11:46, Michal Hocko wrote: > > On Fri 23-03-18 20:55:49, Ilya Smith wrote: >> >>> On 23 Mar 2018, at 15:48, Matthew Wilcox wrote: >>> >>> On Thu, Mar 22, 2018 at 07:36:36PM +0300, Ilya Smith wrote: Current implementation

[PATCH] powerpc: Clear branch trap (MSR.BE) before delivering SIGTRAP

2018-03-26 Thread Matt Evans
When using SIG_DBG_BRANCH_TRACING, MSR.BE is left enabled in the user context when single_step_exception() prepares the SIGTRAP delivery. The resulting branch-trap-within-the-SIGTRAP-handler isn't healthy. Commit 2538c2d08f46141550a1e68819efa8fe31c6e3dc broke this, by replacing an MSR mask

[PATCH script] hwmon: Use octal not symbolic permissions

2018-03-26 Thread Joe Perches
drivers/hwmon is the most frequent user of symbolic permissions like S_IRUGO in the kernel tree. $ git grep -w -P "S_[A-Z]{5,5}" | \ cut -f1 -d: | cut -f1-2 -d"/" | sed -r 's/[A-Za-z0-9_-]+\.[ch]$//' | \ sort | uniq -c | sort -rn | head 3862 drivers/hwmon 814 drivers/scsi 763

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Jason Gunthorpe
On Mon, Mar 26, 2018 at 09:44:15PM +0200, Arnd Bergmann wrote: > On Mon, Mar 26, 2018 at 6:54 PM, Jason Gunthorpe wrote: > > On Mon, Mar 26, 2018 at 11:08:45AM +, David Laight wrote: > >> > > This is a super performance critical operation for most drivers and > >> > > directly

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Arnd Bergmann
On Mon, Mar 26, 2018 at 6:54 PM, Jason Gunthorpe wrote: > On Mon, Mar 26, 2018 at 11:08:45AM +, David Laight wrote: >> > > This is a super performance critical operation for most drivers and >> > > directly impacts network performance. >> >> Perhaps there ought to be

Re: [PATCH v12 04/22] selftests/vm: typecast the pkey register

2018-03-26 Thread Thiago Jung Bauermann
Dave Hansen writes: > On 02/21/2018 05:55 PM, Ram Pai wrote: >> -static inline unsigned int _rdpkey_reg(int line) >> +static inline pkey_reg_t _rdpkey_reg(int line) >> { >> -unsigned int pkey_reg = __rdpkey_reg(); >> +pkey_reg_t pkey_reg = __rdpkey_reg(); >> >> -

Re: [PATCH 2/2] smp: introduce kick_active_cpus_sync()

2018-03-26 Thread Steven Rostedt
On Mon, 26 Mar 2018 10:53:13 +0200 Andrea Parri wrote: > > --- a/kernel/smp.c > > +++ b/kernel/smp.c > > @@ -724,6 +724,30 @@ void kick_all_cpus_sync(void) > > } > > EXPORT_SYMBOL_GPL(kick_all_cpus_sync); > > > > +/** > > + * kick_active_cpus_sync - Force

Re: [PATCH 17/21] powerpc: Add missing prototype for sys_debug_setcontext

2018-03-26 Thread Mathieu Malaterre
Michael, On Thu, Mar 8, 2018 at 11:36 AM, Michael Ellerman wrote: > Mathieu Malaterre writes: > >> On Sun, Mar 4, 2018 at 11:54 AM, Michael Ellerman >> wrote: >>> Mathieu Malaterre writes: >>> In commit

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Jason Gunthorpe
On Mon, Mar 26, 2018 at 11:08:45AM +, David Laight wrote: > > > This is a super performance critical operation for most drivers and > > > directly impacts network performance. > > Perhaps there ought to be writel_nobarrier() (etc) that never contain > any barriers at all. > This might mean

[PATCH v3 41/41] cxlflash: Handle spurious interrupts

2018-03-26 Thread Uma Krishnan
The following Oops can occur when there is heavy I/O traffic and the host is reset by a tool such as sg_reset. [c000200fff3fbc90] c0081690117c process_cmd_doneq+0x104/0x500 [cxlflash] (unreliable) [c000200fff3fbd80] c00816901648

[PATCH v3 40/41] cxlflash: Remove commmands from pending list on timeout

2018-03-26 Thread Uma Krishnan
The following Oops can occur if an internal command sent to the AFU does not complete within the timeout: [c00ff101b810] c00816020d94 term_mc+0xfc/0x1b0 [cxlflash] [c00ff101b8a0] c00816020fb0 term_afu+0x168/0x280 [cxlflash] [c00ff101b930] c008160232ec

[PATCH v3 39/41] cxlflash: Synchronize reset and remove ops

2018-03-26 Thread Uma Krishnan
The following Oops can be encountered if a device removal or system shutdown is initiated while an EEH recovery is in process: [c00ff2f479c0] c00815256f18 cxlflash_pci_slot_reset+0xa0/0x100 [cxlflash] [c00ff2f47a30] c0080dae22e0

[PATCH v3 38/41] cxlflash: Enable OCXL operations

2018-03-26 Thread Uma Krishnan
This commit enables the OCXL operations for the OCXL devices. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs --- drivers/scsi/cxlflash/main.c | 9 +++-- drivers/scsi/cxlflash/main.h | 1 + 2 files changed, 8 insertions(+), 2

[PATCH v3 37/41] cxlflash: Support AFU reset

2018-03-26 Thread Uma Krishnan
The cxlflash core driver resets the AFU when the master contexts are created in the initialization or recovery paths. Today, the OCXL provider service to perform this operation is pending implementation. To avoid a crash due to a missing fop, log an error once and return success to continue with

[PATCH v3 36/41] cxlflash: Register for translation errors

2018-03-26 Thread Uma Krishnan
While enabling a context on the link, a predefined callback can be registered with the OCXL provider services to be notified on translation errors. These errors can in turn be passed back to the user on a read operation. Signed-off-by: Uma Krishnan Acked-by: Matthew

[PATCH v3 35/41] cxlflash: Introduce OCXL context state machine

2018-03-26 Thread Uma Krishnan
In order to protect the OCXL hardware contexts from getting clobbered, a simple state machine is added to indicate when a context is in open, close or start state. The expected states are validated throughout the code to prevent illegal operations on a context. A mutex is added to protect writes

[PATCH v3 34/41] cxlflash: Update synchronous interrupt status bits

2018-03-26 Thread Uma Krishnan
The SISLite specification has been updated to define new synchronous interrupt status bits. These bits are set by the AFU when a given PASID or EA is bad and a synchronous interrupt is triggered. The SISLite header file is updated to support these new bits. Note that there are also some

[PATCH v3 33/41] cxlflash: Setup LISNs for master contexts

2018-03-26 Thread Uma Krishnan
Similar to user contexts, master contexts also require that the per-context LISN registers be programmed for certain AFUs. The mapped trigger page is obtained from underlying transport and registered with AFU for each master context. Signed-off-by: Uma Krishnan

[PATCH v3 32/41] cxlflash: Setup LISNs for user contexts

2018-03-26 Thread Uma Krishnan
The SISLite specification has been updated for OCXL to support communicating data to generate AFU interrupts to the AFU. This includes a new capability bit that is advertised for OCXL AFUs and new registers to hold the object handle and translation PASID of each interrupt. For Power, the object

[PATCH v3 31/41] cxlflash: Introduce object handle fop

2018-03-26 Thread Uma Krishnan
OCXL requires that AFUs use an opaque object handle to represent an AFU interrupt. The specification does not provide a common means to communicate the object handle to the AFU - each AFU must define this within the AFU specification. To support this model, the object handle must be passed back to

[PATCH v3 30/41] cxlflash: Support file descriptor mapping

2018-03-26 Thread Uma Krishnan
The cxlflash core fop API requires a way to invoke the fault and release handlers of underlying transports using their native file-based APIs. This provides the core with the ability to insert selectively itself into the processing stream of these operations for cleanup. Implement these two fops

[PATCH v3 29/41] cxlflash: Support adapter context mmap and release

2018-03-26 Thread Uma Krishnan
The cxlflash userspace API requires that users be able to mmap and release the adapter context. Support mapping by implementing the AFU mmap fop to map the context MMIO space and install the corresponding page table entry upon page fault. Similarly, implement the AFU release fop to terminate and

[PATCH v3 28/41] cxlflash: Support adapter context reading

2018-03-26 Thread Uma Krishnan
The cxlflash userspace API requires that users be able to read the adapter context for any pending events or interrupts from the AFU. Support reading various events by implementing the AFU read fop to copy out event data. Signed-off-by: Uma Krishnan Acked-by: Matthew

[PATCH v3 27/41] cxlflash: Support adapter context polling

2018-03-26 Thread Uma Krishnan
The cxlflash userspace API requires that users be able to poll the adapter context for any pending events or interrupts from the AFU. Support polling on various events by implementing the AFU poll fop using a waitqueue. Signed-off-by: Uma Krishnan Acked-by: Matthew R.

[PATCH v3 26/41] cxlflash: Support starting user contexts

2018-03-26 Thread Uma Krishnan
User contexts request interrupts and are started using the "start work" interface. Populate the start_work() fop to allocate and map interrupts before starting the user context. As part of starting the context, update the user process identification logic to properly derive the data required by

[PATCH v3 25/41] cxlflash: Support AFU interrupt mapping and registration

2018-03-26 Thread Uma Krishnan
Add support to map and unmap the irq space and manage irq registrations with the kernel for each allocated AFU interrupt. Also support mapping the physical trigger page to obtain an effective address that will be provided to the cxlflash core in a future commit. Signed-off-by: Uma Krishnan

[PATCH v3 24/41] cxlflash: Support AFU interrupt management

2018-03-26 Thread Uma Krishnan
Add support to allocate and free AFU interrupts using the OCXL provider services. The trigger page returned upon successful allocation will be mapped and exposed to the cxlflash core in a future commit. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs

[PATCH v3 23/41] cxlflash: Support process element lifecycle

2018-03-26 Thread Uma Krishnan
As part of the context lifecycle, the associated process element within the Shared Process Area (SPA) of the link must be updated. Each process is defined by various parameters (pid, tid, PASID mm) that are stored in the SPA upon starting a context and invalidated when a context is stopped. Use

[PATCH v3 22/41] cxlflash: Setup OCXL transaction layer

2018-03-26 Thread Uma Krishnan
The first function of the link needs to configure the transaction layer between the host and device. This is accomplished by a call to the OCXL provider services. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs ---

[PATCH v3 21/41] cxlflash: Setup function OCXL link

2018-03-26 Thread Uma Krishnan
After reading and modifying the function configuration, setup the OCXL link using the OCXL provider services. The link is released when the adapter is unconfigured. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs Reviewed-by: Frederic

[PATCH v3 20/41] cxlflash: Support reading adapter VPD data

2018-03-26 Thread Uma Krishnan
Use the PCI VPD services to support reading the VPD data of the underlying adapter. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs --- drivers/scsi/cxlflash/ocxl_hw.c | 15 +++ 1 file changed, 15 insertions(+) diff

[PATCH v3 19/41] cxlflash: Support AFU state toggling

2018-03-26 Thread Uma Krishnan
The AFU should be enabled following a successful configuration and disabled near the end of the cleanup path. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs Reviewed-by: Frederic Barrat ---

[PATCH v3 18/41] cxlflash: Support process specific mappings

2018-03-26 Thread Uma Krishnan
Once the context is started, the assigned MMIO space can be mapped and unmapped. Provide means to map and unmap the context MMIO space. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs --- drivers/scsi/cxlflash/ocxl_hw.c | 24

[PATCH v3 17/41] cxlflash: Support starting an adapter context

2018-03-26 Thread Uma Krishnan
Once the adapter context is created, it needs to be started by assigning the MMIO space for the context and by enabling the process element in the link. This commit adds the skeleton for starting the context and assigns the context specific MMIO space. Master contexts have access to the global

[PATCH v3 16/41] cxlflash: MMIO map the AFU

2018-03-26 Thread Uma Krishnan
When the AFU is configured, the global and per process MMIO regions are presented by the configuration space. Save these regions and map the global MMIO region that is used to access all of the control and provisioning data in the AFU. Signed-off-by: Uma Krishnan

[PATCH v3 15/41] cxlflash: Support image reload policy modification

2018-03-26 Thread Uma Krishnan
On a PERST, the AFU image can be reloaded or left intact. Provide means to set this image reload policy. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs --- drivers/scsi/cxlflash/ocxl_hw.c | 13 +

[PATCH v3 14/41] cxlflash: Support adapter context discovery

2018-03-26 Thread Uma Krishnan
Provide means to obtain the process element of an adapter context as well as locate an adapter context by file. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs --- drivers/scsi/cxlflash/ocxl_hw.c | 26 ++ 1

[PATCH v3 13/41] cxlflash: Support adapter file descriptors for OCXL

2018-03-26 Thread Uma Krishnan
Allocate a file descriptor for an adapter context when requested. In order to allocate inodes for the file descriptors, a pseudo filesystem is created and used. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs ---

[PATCH v3 12/41] cxlflash: Use IDR to manage adapter contexts

2018-03-26 Thread Uma Krishnan
A range of PASIDs are used as identifiers for the adapter contexts. These contexts may be destroyed and created randomly. Use an IDR to keep track of contexts that are in use and assign a unique identifier to new ones. Signed-off-by: Uma Krishnan Acked-by: Matthew R.

[PATCH v3 11/41] cxlflash: Adapter context support for OCXL

2018-03-26 Thread Uma Krishnan
Add support to create and release the adapter contexts for OCXL and provide means to specify certain contexts as a master. The existing cxlflash core has a design requirement that each host will have a single host context available by default. To satisfy this requirement, one host adapter context

[PATCH v3 10/41] cxlflash: Setup AFU PASID

2018-03-26 Thread Uma Krishnan
Per the OCXL specification, the maximum PASID supported by the AFU is indicated by a field within the configuration space. Similar to acTags, implementations can choose to use any sub-range of PASID within their assigned range. For cxlflash, the entire range is used. Signed-off-by: Uma Krishnan

[PATCH v3 09/41] cxlflash: Setup AFU acTag range

2018-03-26 Thread Uma Krishnan
The OCXL specification supports distributing acTags amongst different AFUs and functions on the link. As cxlflash devices are expected to only support a single AFU per function, the entire range that was assigned to the function is also assigned to the AFU. Signed-off-by: Uma Krishnan

[PATCH v3 08/41] cxlflash: Read host AFU configuration

2018-03-26 Thread Uma Krishnan
The host AFU configuration is read on the initialization path to identify the features and configuration of the AFU. This data is cached for use in later configuration steps. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs

[PATCH v3 07/41] cxlflash: Setup function acTag range

2018-03-26 Thread Uma Krishnan
The OCXL specification supports distributing acTags amongst different AFUs and functions on the link. The platform-specific acTag range for the link is obtained using the OCXL provider services and then assigned to the host function based on implementation. Signed-off-by: Uma Krishnan

[PATCH v3 06/41] cxlflash: Read host function configuration

2018-03-26 Thread Uma Krishnan
Per the OCXL specification, the underlying host can have multiple AFUs per function with each function supporting its own configuration. The host function configuration is read on the initialization path to evaluate the number of functions present and identify the features and configuration of the

[PATCH v3 05/41] cxlflash: Hardware AFU for OCXL

2018-03-26 Thread Uma Krishnan
When an adapter is initialized, transport specific configuration and MMIO mapping details need to be saved. For CXL, this data is managed by the underlying kernel module. To maintain a separation between the cxlflash core and underlying transports, introduce a new structure to store data specific

[PATCH v3 04/41] cxlflash: Introduce OCXL backend

2018-03-26 Thread Uma Krishnan
Add initial infrastructure to support a new cxlflash transport, OCXL. Claim a dependency on OCXL and add a new file, ocxl_hw.c, which will host the backend routines that are specific to OCXL. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs

[PATCH v3 03/41] cxlflash: Add argument identifier names

2018-03-26 Thread Uma Krishnan
Checkpatch throws a warning when the argument identifier names are not included in the function definitions. To avoid these warnings, argument identifiers are added in the existing function definitions. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs

[PATCH v3 02/41] cxlflash: Avoid clobbering context control register value

2018-03-26 Thread Uma Krishnan
From: "Matthew R. Ochs" The SISLite specification originally defined the context control register with a single field of bits to represent the LISN and also stipulated that the register reset value be 0. The cxlflash driver took advantage of this when programming the

[PATCH v3 01/41] cxlflash: Preserve number of interrupts for master contexts

2018-03-26 Thread Uma Krishnan
The number of interrupts requested for user contexts are stored in the context specific structures and utilized to manage the interrupts. For the master contexts, this number is only used once and therefore not saved. To prepare for future commits where the number of interrupts will be required

[PATCH v3 00/41] cxlflash: OCXL transport support and miscellaneous fixes

2018-03-26 Thread Uma Krishnan
This patch series adds OCXL support to the cxlflash driver. With this support, new devices using the OCXL transport will be supported by the cxlflash driver along with the existing CXL devices. An effort is made to keep this transport specific function independent of the existing core driver that

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Sinan Kaya
On 3/26/2018 9:43 AM, Arnd Bergmann wrote: > On Wed, Mar 21, 2018 at 2:58 PM, Sinan Kaya wrote: >> On 3/21/2018 8:53 AM, Sinan Kaya wrote: >>> BTW, I have no idea what compiler barrier does on PPC and if >>> >>> wrltel() == compiler barrier() + wrltel_relaxed() >>> >>> can

[RFC PATCH] powerpc/xmon: Use OPAL_DEBUG to debug srest in OPAL

2018-03-26 Thread Nicholas Piggin
xmon can be entered via sreset NMI (from a management sreset, or an NMI IPI), which can interrupt OPAL. Add checks to xmon to see if pc or sp are within OPAL memory, and if so, then use OPAL_DEBUG to print the opal stack and return the Linux stack, which can then be dumped by xmon The OPAL side

  1   2   >