Re: [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules

2018-09-06 Thread Ley Foon Tan
On Wed, 2018-09-05 at 18:53 -0500, Rob Herring wrote: > There is nothing arch specific about building dtb files other than > their > location under /arch/*/boot/dts/. Keeping each arch aligned is a > pain. > The dependencies and supported targets are all slightly different. > Also, a

Re: [RFC 0/4] Virtio uses DMA API for all devices

2018-09-06 Thread Jiandi An
On 08/09/2018 12:40 AM, Christoph Hellwig wrote: > On Thu, Aug 09, 2018 at 08:13:32AM +1000, Benjamin Herrenschmidt wrote: - if (xen_domain()) + if (xen_domain() || pseries_secure_vm()) return true; >>> >>> I don't think it's pseries specific actually. E.g. I suspect

Re: [PATCH] [RFC v2] Drop all 00-INDEX files from Documentation/

2018-09-06 Thread Daniel Vetter
On Thu, Sep 6, 2018 at 6:01 PM, Steven Rostedt wrote: > On Thu, 6 Sep 2018 09:58:04 -0600 > Jonathan Corbet wrote: > >> Thanks, >> >> jon (who is increasingly inclined to apply this patch) > > As Colin Kaepernick now says... "Just do it!" > > ;-) +1 But I'm biased, I'm part of the party that

Re: [PATCH] [RFC v2] Drop all 00-INDEX files from Documentation/

2018-09-06 Thread Steven Rostedt
On Thu, 6 Sep 2018 09:58:04 -0600 Jonathan Corbet wrote: > Thanks, > > jon (who is increasingly inclined to apply this patch) As Colin Kaepernick now says... "Just do it!" ;-) -- Steve

Re: [PATCH] [RFC v2] Drop all 00-INDEX files from Documentation/

2018-09-06 Thread Jonathan Corbet
On Tue, 4 Sep 2018 09:59:08 -0400 Steven Rostedt wrote: > On Tue, 4 Sep 2018 13:30:30 +0200 > Pavel Machek wrote: > > > I'd say this is still quite valueable, and it might be worth fixing, > > rather then removing completely. > > I agree. Perhaps we should have a 00-DESCRIPTION file in each

Re: [PATCH] MAINTAINERS: add maintainer entries for RPA pci hotplug drivers

2018-09-06 Thread Bjorn Helgaas
On Mon, Aug 20, 2018 at 06:20:31PM -0700, Tyrel Datwyler wrote: > Adding myself as maintiner of the IBM RPA hotplug modules located in > drivers/pci/hotplug directory. These modules provide kernel interfaces > for support of Dynamic Logical Partitioning (DLPAR) of Logical and > Physical IO slots,

Re: [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules

2018-09-06 Thread Paul Burton
Hi Rob, On Wed, Sep 05, 2018 at 06:53:24PM -0500, Rob Herring wrote: > There is nothing arch specific about building dtb files other than their > location under /arch/*/boot/dts/. Keeping each arch aligned is a pain. > The dependencies and supported targets are all slightly different. > Also, a

Re: [RFC PATCH 07/29] memblock: remove _virt from APIs returning virtual address

2018-09-06 Thread Michal Hocko
On Thu 06-09-18 16:39:58, Mike Rapoport wrote: > On Thu, Sep 06, 2018 at 03:01:02PM +0200, Michal Hocko wrote: > > On Thu 06-09-18 15:43:21, Mike Rapoport wrote: > > > On Thu, Sep 06, 2018 at 09:28:00AM +0200, Michal Hocko wrote: > > > > On Wed 05-09-18 20:20:18, Mike Rapoport wrote: > > > > > On

Re: [RFC PATCH 07/29] memblock: remove _virt from APIs returning virtual address

2018-09-06 Thread Mike Rapoport
On Thu, Sep 06, 2018 at 03:01:02PM +0200, Michal Hocko wrote: > On Thu 06-09-18 15:43:21, Mike Rapoport wrote: > > On Thu, Sep 06, 2018 at 09:28:00AM +0200, Michal Hocko wrote: > > > On Wed 05-09-18 20:20:18, Mike Rapoport wrote: > > > > On Wed, Sep 05, 2018 at 12:04:36PM -0500, Rob Herring wrote:

Re: [RFC PATCH V2 1/4] mm: Export alloc_migrate_huge_page

2018-09-06 Thread Aneesh Kumar K.V
On 09/06/2018 06:05 PM, Michal Hocko wrote: On Thu 06-09-18 14:31:11, Michal Hocko wrote: On Thu 06-09-18 11:13:39, Aneesh Kumar K.V wrote: We want to use this to support customized huge page migration. Please be much more specific. Ideally including the user. Btw. why do you want to skip

Re: [RFC PATCH V2 4/4] powerpc/mm/iommu: Allow migration of cma allocated pages during mm_iommu_get

2018-09-06 Thread Aneesh Kumar K.V
On 09/06/2018 06:23 PM, Michal Hocko wrote: On Thu 06-09-18 11:13:42, Aneesh Kumar K.V wrote: Current code doesn't do page migration if the page allocated is a compound page. With HugeTLB migration support, we can end up allocating hugetlb pages from CMA region. Also THP pages can be allocated

Re: [RFC PATCH 00/29] mm: remove bootmem allocator

2018-09-06 Thread Mike Rapoport
On Thu, Sep 06, 2018 at 10:33:48AM +0800, Greentime Hu wrote: > Mike Rapoport 於 2018年9月6日 週四 上午12:04寫道: > > > > Hi, > > > > These patches switch early memory managment to use memblock directly > > without any bootmem compatibility wrappers. As the result both bootmem and > > nobootmem are

Re: [RFC PATCH V2 2/4] mm: Add get_user_pages_cma_migrate

2018-09-06 Thread Aneesh Kumar K.V
On 09/06/2018 06:15 PM, Michal Hocko wrote: On Thu 06-09-18 11:13:40, Aneesh Kumar K.V wrote: This helper does a get_user_pages_fast and if it find pages in the CMA area it will try to migrate them before taking page reference. This makes sure that we don't keep non-movable pages (due to page

Re: [RFC PATCH 00/29] mm: remove bootmem allocator

2018-09-06 Thread Mike Rapoport
On Thu, Sep 06, 2018 at 01:04:47PM +, Pasha Tatashin wrote: > > > On 9/6/18 5:15 AM, Michal Hocko wrote: > > On Wed 05-09-18 18:59:15, Mike Rapoport wrote: > > [...] > >> 325 files changed, 846 insertions(+), 2478 deletions(-) > >> delete mode 100644 include/linux/bootmem.h > >> delete

Re: [RFC PATCH 00/29] mm: remove bootmem allocator

2018-09-06 Thread Mike Rapoport
On Thu, Sep 06, 2018 at 11:15:38AM +0200, Michal Hocko wrote: > On Wed 05-09-18 18:59:15, Mike Rapoport wrote: > [...] > > 325 files changed, 846 insertions(+), 2478 deletions(-) > > delete mode 100644 include/linux/bootmem.h > > delete mode 100644 mm/bootmem.c > > delete mode 100644

Re: [RFC PATCH 21/29] memblock: replace alloc_bootmem with memblock_alloc

2018-09-06 Thread Mike Rapoport
On Thu, Sep 06, 2018 at 10:55:15AM +0200, Michal Hocko wrote: > On Wed 05-09-18 18:59:36, Mike Rapoport wrote: > > The conversion is done using the following semantic patch: > > > > @@ > > expression e; > > @@ > > - __alloc_bootmem(e) > > Did you mean alloc_bottmem? Anyway the only difference

Re: [PATCH 3/3] tty: hvc: hvc_write() fix break condition

2018-09-06 Thread Nicholas Piggin
On Wed, 5 Sep 2018 22:14:39 +1000 Nicholas Piggin wrote: > Commit 550ddadcc758 ("tty: hvc: hvc_write() may sleep") broke the > termination condition in case the driver stops accepting characters. > This can result in unnecessary polling of the busy driver. > > Restore it by testing the

Re: [RFC PATCH 00/29] mm: remove bootmem allocator

2018-09-06 Thread Pasha Tatashin
On 9/6/18 5:15 AM, Michal Hocko wrote: > On Wed 05-09-18 18:59:15, Mike Rapoport wrote: > [...] >> 325 files changed, 846 insertions(+), 2478 deletions(-) >> delete mode 100644 include/linux/bootmem.h >> delete mode 100644 mm/bootmem.c >> delete mode 100644 mm/nobootmem.c > > This is really

Re: [RFC PATCH 07/29] memblock: remove _virt from APIs returning virtual address

2018-09-06 Thread Michal Hocko
On Thu 06-09-18 15:43:21, Mike Rapoport wrote: > On Thu, Sep 06, 2018 at 09:28:00AM +0200, Michal Hocko wrote: > > On Wed 05-09-18 20:20:18, Mike Rapoport wrote: > > > On Wed, Sep 05, 2018 at 12:04:36PM -0500, Rob Herring wrote: > > > > On Wed, Sep 5, 2018 at 11:00 AM Mike Rapoport > > > >

Re: [RFC PATCH 20/29] memblock: replace __alloc_bootmem with memblock_alloc_from

2018-09-06 Thread Mike Rapoport
On Thu, Sep 06, 2018 at 10:52:05AM +0200, Michal Hocko wrote: > On Wed 05-09-18 18:59:35, Mike Rapoport wrote: > > The conversion is done using the following semantic patch: > > > > @@ > > expression e1, e2, e3; > > @@ > > - __alloc_bootmem(e1, e2, e3) > > + memblock_alloc(e1, e2, e3) > > This

Re: [RFC PATCH 14/29] memblock: add align parameter to memblock_alloc_node()

2018-09-06 Thread Mike Rapoport
On Thu, Sep 06, 2018 at 10:06:14AM +0200, Michal Hocko wrote: > On Wed 05-09-18 18:59:29, Mike Rapoport wrote: > > With the align parameter memblock_alloc_node() can be used as drop in > > replacement for alloc_bootmem_pages_node(). > > Why do we need an additional translation later? Sparse code

Re: [RFC PATCH V2 4/4] powerpc/mm/iommu: Allow migration of cma allocated pages during mm_iommu_get

2018-09-06 Thread Michal Hocko
On Thu 06-09-18 11:13:42, Aneesh Kumar K.V wrote: > Current code doesn't do page migration if the page allocated is a compound > page. > With HugeTLB migration support, we can end up allocating hugetlb pages from > CMA region. Also THP pages can be allocated from CMA region. This patch > updates

Re: [RFC PATCH 16/29] memblock: replace __alloc_bootmem_node with appropriate memblock_ API

2018-09-06 Thread Mike Rapoport
On Thu, Sep 06, 2018 at 10:38:41AM +0200, Michal Hocko wrote: > On Wed 05-09-18 18:59:31, Mike Rapoport wrote: > > Use memblock_alloc_try_nid whenever goal (i.e. mininal address is > > specified) and memblock_alloc_node otherwise. > > I suspect you wanted to say (i.e. minimal address) is

Re: [RFC PATCH V2 2/4] mm: Add get_user_pages_cma_migrate

2018-09-06 Thread Michal Hocko
On Thu 06-09-18 11:13:40, Aneesh Kumar K.V wrote: > This helper does a get_user_pages_fast and if it find pages in the CMA area > it will try to migrate them before taking page reference. This makes sure that > we don't keep non-movable pages (due to page reference count) in the CMA area. > Not

Re: [RFC PATCH 13/29] memblock: replace __alloc_bootmem_nopanic with memblock_alloc_from_nopanic

2018-09-06 Thread Mike Rapoport
On Thu, Sep 06, 2018 at 09:57:21AM +0200, Michal Hocko wrote: > On Wed 05-09-18 18:59:28, Mike Rapoport wrote: > > Signed-off-by: Mike Rapoport > > The translation is simpler here but still a word or two would be nice. > Empty changelogs suck. This is one of the things left to sort out :) >

Re: [RFC PATCH 07/29] memblock: remove _virt from APIs returning virtual address

2018-09-06 Thread Mike Rapoport
On Thu, Sep 06, 2018 at 09:28:00AM +0200, Michal Hocko wrote: > On Wed 05-09-18 20:20:18, Mike Rapoport wrote: > > On Wed, Sep 05, 2018 at 12:04:36PM -0500, Rob Herring wrote: > > > On Wed, Sep 5, 2018 at 11:00 AM Mike Rapoport > > > wrote: > > > > > > > > The conversion is done using > > > > >

Re: [RFC PATCH V2 1/4] mm: Export alloc_migrate_huge_page

2018-09-06 Thread Michal Hocko
On Thu 06-09-18 14:31:11, Michal Hocko wrote: > On Thu 06-09-18 11:13:39, Aneesh Kumar K.V wrote: > > We want to use this to support customized huge page migration. > > Please be much more specific. Ideally including the user. Btw. why do > you want to skip the hugetlb pools? In other words

Re: [RFC PATCH V2 1/4] mm: Export alloc_migrate_huge_page

2018-09-06 Thread Michal Hocko
On Thu 06-09-18 11:13:39, Aneesh Kumar K.V wrote: > We want to use this to support customized huge page migration. Please be much more specific. Ideally including the user. Btw. why do you want to skip the hugetlb pools? In other words alloc_huge_page_node* which are intended to an external use?

[PATCH v2 5/5] PCI/powerpc/eeh: Add pcibios hooks for preparing to rescan

2018-09-06 Thread Sergey Miroshnichenko
Reading an empty slot returns all ones, which triggers a false EEH error event on PowerNV. New callbacks pcibios_rescan_prepare/done are introduced to pause/resume the EEH during rescan. Signed-off-by: Sergey Miroshnichenko --- arch/powerpc/include/asm/eeh.h | 2 ++

[PATCH v2 4/5] powerpc/powernv/pci: Enable reassigning the bus numbers

2018-09-06 Thread Sergey Miroshnichenko
PowerNV doesn't depend on PCIe topology info from DT anymore, and now it is able to enumerate the fabric and assign the bus numbers. Signed-off-by: Sergey Miroshnichenko --- arch/powerpc/platforms/powernv/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 3/5] powerpc/pci: Use DT to create pci_dn for root bridges only

2018-09-06 Thread Sergey Miroshnichenko
Endpoint's pci_dn can be created dynamically. Signed-off-by: Sergey Miroshnichenko --- arch/powerpc/kernel/pci_dn.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/pci_dn.c b/arch/powerpc/kernel/pci_dn.c index 48ec16407835..3b4368f07c82 100644 ---

[PATCH v2 2/5] powerpc/pci: Create pci_dn on demand

2018-09-06 Thread Sergey Miroshnichenko
The pci_dn structures can be created not only from DT, but also directly from newly discovered PCIe devices, so allocate them dynamically. Signed-off-by: Sergey Miroshnichenko --- arch/powerpc/kernel/pci_dn.c | 76 1 file changed, 59 insertions(+), 17

[PATCH v2 1/5] powerpc/pci: Access PCI config space directly w/o pci_dn

2018-09-06 Thread Sergey Miroshnichenko
The pci_dn structures are retrieved from a DT, but hot-plugged PCIe devices don't have them. Don't stop PCIe I/O in absence of pci_dn, so it is now possible to discover new devices. Signed-off-by: Sergey Miroshnichenko --- arch/powerpc/kernel/rtas_pci.c | 97 +++-

[PATCH v2 0/5] powerpc/powernv/pci: Discover surprise-hotplugged PCIe devices during rescan

2018-09-06 Thread Sergey Miroshnichenko
This patchset allows hotplugged PCIe devices to be enumerated during a bus rescan being issued via sysfs on PowerNV platforms, when the "Presence Detect Changed" interrupt is not available. As a first part of our work on adding support for hotplugging PCIe bridges full of devices (without special

Re: [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules

2018-09-06 Thread Will Deacon
On Wed, Sep 05, 2018 at 06:53:24PM -0500, Rob Herring wrote: > There is nothing arch specific about building dtb files other than their > location under /arch/*/boot/dts/. Keeping each arch aligned is a pain. > The dependencies and supported targets are all slightly different. > Also, a

Re: [RFC PATCH v1 00/17] ban the use of _PAGE_XXX flags outside platform specific code

2018-09-06 Thread Aneesh Kumar K.V
Christophe Leroy writes: > Today flags like for instance _PAGE_RW or _PAGE_USER are used through > common parts of code. > Using those directly in common parts of code have proven to lead to > mistakes or misbehaviour, because their use is not always as trivial > as one could think. > > For

[PATCH kernel] KVM: PPC: Remove redundand permission bits removal

2018-09-06 Thread Alexey Kardashevskiy
The kvmppc_gpa_to_ua() helper itself takes care of the permission bits in the TCE and yet every single caller removes them. This changes semantics of kvmppc_gpa_to_ua() so it takes TCEs (which are GPAs + TCE permission bits) to make the callers simpler. This should cause no behavioural change.

[RFC PATCH kernel v2] KVM: PPC: Avoid marking DMA-mapped pages dirty in real mode

2018-09-06 Thread Alexey Kardashevskiy
At the moment the real mode handler of H_PUT_TCE calls iommu_tce_xchg_rm() which in turn reads the old TCE and if it was a valid entry - marks the physical page dirty if it was mapped for writing. Since it is the real mode, realmode_pfn_to_page() is used instead of pfn_to_page() to get the page

Re: [RFC PATCH 00/29] mm: remove bootmem allocator

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:15, Mike Rapoport wrote: [...] > 325 files changed, 846 insertions(+), 2478 deletions(-) > delete mode 100644 include/linux/bootmem.h > delete mode 100644 mm/bootmem.c > delete mode 100644 mm/nobootmem.c This is really impressive! Thanks a lot for working on this. I wish

Re: [RFC PATCH 28/29] memblock: replace BOOTMEM_ALLOC_* with MEMBLOCK variants

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:43, Mike Rapoport wrote: > Drop BOOTMEM_ALLOC_ACCESSIBLE and BOOTMEM_ALLOC_ANYWHERE in favor of > identical MEMBLOCK definitions. > > Signed-off-by: Mike Rapoport Acked-by: Michal Hocko > --- > arch/ia64/mm/discontig.c | 2 +- > arch/powerpc/kernel/setup_64.c | 2

Re: [RFC PATCH 27/29] mm: remove nobootmem

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:42, Mike Rapoport wrote: > Move a few remaining functions from nobootmem.c to memblock.c and remove > nobootmem > > Signed-off-by: Mike Rapoport Acked-by: Michal Hocko > --- > mm/Makefile| 1 - > mm/memblock.c | 104 ++

Re: [RFC PATCH 26/29] memblock: rename __free_pages_bootmem to memblock_free_pages

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:41, Mike Rapoport wrote: > The conversion is done using > > sed -i 's@__free_pages_bootmem@memblock_free_pages@' \ > $(git grep -l __free_pages_bootmem) > > Signed-off-by: Mike Rapoport Acked-by: Michal Hocko > --- > mm/internal.h | 2 +- > mm/memblock.c | 2 +-

Re: [PATCH 1/2] powerpc/process: fix nested output in show_user_instructions()

2018-09-06 Thread Christophe LEROY
Le 21/08/2018 à 08:27, Michael Ellerman a écrit : Christophe Leroy writes: When two processes crash at the same time, we sometimes encounter nesting in the middle of a line: I think "interleaved" is the right word, rather than "nesting". They're actually (potentially) completely

Re: [RFC PATCH 25/29] memblock: rename free_all_bootmem to memblock_free_all

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:40, Mike Rapoport wrote: > The conversion is done using > > sed -i 's@free_all_bootmem@memblock_free_all@' \ > $(git grep -l free_all_bootmem) > > Signed-off-by: Mike Rapoport Acked-by: Michal Hocko -- Michal Hocko SUSE Labs

Re: [RFC PATCH 24/29] memblock: replace free_bootmem_late with memblock_free_late

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:39, Mike Rapoport wrote: > The free_bootmem_late and memblock_free_late do exactly the same thing: > they iterate over a range and give pages to the page allocator. > > Replace calls to free_bootmem_late with calls to memblock_free_late and > remove the bootmem variant. > >

Re: [RFC PATCH 23/29] memblock: replace free_bootmem{_node} with memblock_free

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:38, Mike Rapoport wrote: > The free_bootmem and free_bootmem_node are merely wrappers for > memblock_free. Replace their usage with a call to memblock_free using the > following semantic patch: > > @@ > expression e1, e2, e3; > @@ > ( > - free_bootmem(e1, e2) > +

Re: [RFC PATCH 22/29] mm: nobootmem: remove bootmem allocation APIs

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:37, Mike Rapoport wrote: > The bootmem compatibility APIs are not used and can be removed. > > Signed-off-by: Mike Rapoport I am happy to see this finally go Acked-by: Michal Hocko > --- > include/linux/bootmem.h | 47 -- > mm/nobootmem.c | 224 >

Re: [RFC PATCH 21/29] memblock: replace alloc_bootmem with memblock_alloc

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:36, Mike Rapoport wrote: > The conversion is done using the following semantic patch: > > @@ > expression e; > @@ > - __alloc_bootmem(e) Did you mean alloc_bottmem? Anyway the only difference from _alloc_bootmem is SMP_CACHE_BYTES and so you can use 0 alignment for

Re: [RFC PATCH 20/29] memblock: replace __alloc_bootmem with memblock_alloc_from

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:35, Mike Rapoport wrote: > The conversion is done using the following semantic patch: > > @@ > expression e1, e2, e3; > @@ > - __alloc_bootmem(e1, e2, e3) > + memblock_alloc(e1, e2, e3) This is not that straightforward. memblock_virt_alloc with 0 alignment uses

[PATCH v2 2/2] powerpc/process: Constify the number of insns printed by show instructions functions.

2018-09-06 Thread Christophe Leroy
instructions_to_print var is assigned value 16 and there is no way to change it. This patch replaces it by a constant. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/process.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/kernel/process.c

[PATCH v2 1/2] powerpc/process: fix interleaved output in show_user_instructions()

2018-09-06 Thread Christophe Leroy
When two processes crash at the same time, we sometimes encounter interleaving in the middle of a line: [4.365317] init[1]: segfault (11) at 0 nip 0 lr 0 code 1 [4.370452] init[1]: code: [4.372042] init[74]: segfault (11) at 10a74 nip 1000c198 lr

Re: [RFC PATCH 19/29] memblock: replace alloc_bootmem_pages with memblock_alloc

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:34, Mike Rapoport wrote: > The conversion is done using the following semantic patch: > > @@ > expression e; > @@ > - alloc_bootmem_pages(e) > + memblock_alloc(e, PAGE_SIZE) > > Signed-off-by: Mike Rapoport Same as the previous patch Acked-by: Michal Hocko > --- >

Re: [RFC PATCH 18/29] memblock: replace alloc_bootmem_low_pages with memblock_alloc_low

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:33, Mike Rapoport wrote: > The conversion is done using the following semantic patch: > > @@ > expression e; > @@ > - alloc_bootmem_low_pages(e) > + memblock_alloc_low(e, PAGE_SIZE) > > Signed-off-by: Mike Rapoport Again, I trust Coccinelle to do the right thing and from

Re: [RFC PATCH 17/29] memblock: replace alloc_bootmem_node with memblock_alloc_node

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:32, Mike Rapoport wrote: > Signed-off-by: Mike Rapoport ENOCHAGELOG again The conversion itself looks good to me Acked-by: Michal Hocko > --- > arch/alpha/kernel/pci_iommu.c | 4 ++-- > arch/ia64/sn/kernel/io_common.c | 7 ++- > arch/ia64/sn/kernel/setup.c | 4

Re: [RFC PATCH 16/29] memblock: replace __alloc_bootmem_node with appropriate memblock_ API

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:31, Mike Rapoport wrote: > Use memblock_alloc_try_nid whenever goal (i.e. mininal address is > specified) and memblock_alloc_node otherwise. I suspect you wanted to say (i.e. minimal address) is specified > Signed-off-by: Mike Rapoport Acked-by: Michal Hocko One note

Re: [RFC PATCH 04/29] mm: remove bootmem allocator implementation.

2018-09-06 Thread Michal Hocko
On Thu 06-09-18 09:30:23, Michal Hocko wrote: > Is there any reason to keep > > ifdef CONFIG_NO_BOOTMEM > obj-y += nobootmem.o > else > obj-y += bootmem.o > endif > > behind? I can see you have done so in an earlier patch. I have missed that. -- Michal Hocko

Re: [RFC PATCH 15/29] memblock: replace alloc_bootmem_pages_node with memblock_alloc_node

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:30, Mike Rapoport wrote: > Signed-off-by: Mike Rapoport again a short work of wisdom please. The change itself looks good. Acked-by: Michal Hocko > --- > arch/ia64/mm/init.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [RFC PATCH 14/29] memblock: add align parameter to memblock_alloc_node()

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:29, Mike Rapoport wrote: > With the align parameter memblock_alloc_node() can be used as drop in > replacement for alloc_bootmem_pages_node(). Why do we need an additional translation later? Sparse code which is the only one to use it already uses memblock_alloc_try_nid

Re: [RFC PATCH 13/29] memblock: replace __alloc_bootmem_nopanic with memblock_alloc_from_nopanic

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:28, Mike Rapoport wrote: > Signed-off-by: Mike Rapoport The translation is simpler here but still a word or two would be nice. Empty changelogs suck. To the change Acked-by: Michal Hocko > --- > arch/arc/kernel/unwind.c | 4 ++-- > arch/x86/kernel/setup_percpu.c |

Re: [RFC PATCH 12/29] memblock: replace alloc_bootmem_low with memblock_alloc_low

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:27, Mike Rapoport wrote: > The alloc_bootmem_low(size) allocates low memory with default alignement > and can be replcaed by memblock_alloc_low(size, 0) > > Signed-off-by: Mike Rapoport Again _virt renaming thing... Acked-by: Michal Hocko > --- >

Re: [RFC PATCH 11/29] memblock: replace alloc_bootmem_pages_nopanic with memblock_alloc_nopanic

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:26, Mike Rapoport wrote: > The alloc_bootmem_pages_nopanic(size) is a shortcut for > __alloc_bootmem_nopanic(x, PAGE_SIZE, BOOTMEM_LOW_LIMIT) and can be > replaced by memblock_alloc_nopanic(size, PAGE_SIZE) It is not so straightforward because you really have to go deep down

Re: [RFC PATCH 10/29] memblock: replace __alloc_bootmem_node_nopanic with memblock_alloc_try_nid_nopanic

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:25, Mike Rapoport wrote: > The __alloc_bootmem_node_nopanic() is used only once, there is no reason to > add a wrapper for memblock_alloc_try_nid_nopanic for it. OK, it took me a bit longer to see they are equivalent. Both zero the memory and fallback to a different node if

Re: [RFC PATCH 09/29] memblock: replace alloc_bootmem_low with memblock_alloc_low

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:24, Mike Rapoport wrote: > The functions are equivalent, just the later does not require nobootmem > translation layer. > > Signed-off-by: Mike Rapoport modulo @memblock_alloc_low@@memblock_virt_alloc_low@ Acked-by: Michal Hocko > --- > arch/x86/kernel/tce_64.c | 2 +- >

Re: [RFC PATCH 08/29] memblock: replace alloc_bootmem_align with memblock_alloc

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:23, Mike Rapoport wrote: > The functions are equivalent, just the later does not require nobootmem > translation layer. > > Signed-off-by: Mike Rapoport Acked-by: Michal Hocko > --- > arch/x86/xen/p2m.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [RFC PATCH 06/29] memblock: rename memblock_alloc{_nid, _try_nid} to memblock_phys_alloc*

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:21, Mike Rapoport wrote: > This will allow using memblock_alloc for memblock allocations returning > virtual address. The description confused me at first because it talks about a future patch rather than this one. Anyway unlike the other renaming patch I agree with this

Re: [RFC PATCH 04/29] mm: remove bootmem allocator implementation.

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 18:59:19, Mike Rapoport wrote: > All architectures have been converted to use MEMBLOCK + NO_BOOTMEM. The > bootmem allocator implementation can be removed. \o/ Is there any reason to keep ifdef CONFIG_NO_BOOTMEM obj-y += nobootmem.o else obj-y

Re: [RFC PATCH 07/29] memblock: remove _virt from APIs returning virtual address

2018-09-06 Thread Michal Hocko
On Wed 05-09-18 20:20:18, Mike Rapoport wrote: > On Wed, Sep 05, 2018 at 12:04:36PM -0500, Rob Herring wrote: > > On Wed, Sep 5, 2018 at 11:00 AM Mike Rapoport > > wrote: > > > > > > The conversion is done using > > > > > > sed -i 's@memblock_virt_alloc@memblock_alloc@g' \ > > > $(git

[PATCH v2] powerpc/Makefiles: Fix clang/llvm build

2018-09-06 Thread Joel Stanley
From: Anton Blanchard Commit 15a3204d24a3 ("powerpc/64s: Set assembler machine type to POWER4") passes -mpower4 to the assembler. We have more recent instructions in our assembly files, but gas permits them. The clang/llvm integrated assembler is more strict, and we get a build failure. Fix