Re: [PATCH 1/2] powerpc/64s: Work around spurious warning on old gccs with -fsanitize-coverage

2019-02-06 Thread Segher Boessenkool
On Thu, Feb 07, 2019 at 05:59:48PM +1100, Andrew Donnellan wrote: > On 7/2/19 5:37 pm, Segher Boessenkool wrote: > >On Thu, Feb 07, 2019 at 04:33:23PM +1100, Andrew Donnellan wrote: > >>Some older gccs ( >>cause a spurious uninitialised variable warning in dt_cpu_ftrs.c: > >> > >>

[PATCH v3 5/5] powerpc/perf: Trace imc PMU functions

2019-02-06 Thread Anju T Sudhakar
Add PMU functions to support trace-imc and define the format for trace-imc events. Signed-off-by: Anju T Sudhakar Reviewed-by: Madhavan Srinivasan --- arch/powerpc/perf/imc-pmu.c | 197 +++- 1 file changed, 196 insertions(+), 1 deletion(-) diff --git

[PATCH v3 4/5] powerpc/perf: Trace imc events detection and cpuhotplug

2019-02-06 Thread Anju T Sudhakar
Patch detects trace-imc events, does memory initilizations for each online cpu, and registers cpuhotplug call-backs. Signed-off-by: Anju T Sudhakar Reviewed-by: Madhavan Srinivasan --- arch/powerpc/perf/imc-pmu.c | 91 +++

[PATCH v3 3/5] powerpc/perf: Add privileged access check for thread_imc

2019-02-06 Thread Anju T Sudhakar
From: Madhavan Srinivasan Add code to restrict user access to thread_imc pmu since some event report privilege level information. Fixes: f74c89bd80fb3 ('powerpc/perf: Add thread IMC PMU support') Signed-off-by: Madhavan Srinivasan Signed-off-by: Anju T Sudhakar ---

[PATCH v3 2/5] powerpc/perf: Rearrange setting of ldbar for thread-imc

2019-02-06 Thread Anju T Sudhakar
LDBAR holds the memory address allocated for each cpu. For thread-imc the mode bit (i.e bit 1) of LDBAR is set to accumulation. Currently, ldbar is loaded with per cpu memory address and mode set to accumulation at boot time. To enable trace-imc, the mode bit of ldbar should be set to 'trace'. So

[PATCH v3 0/5] powerpc/perf: IMC trace-mode support

2019-02-06 Thread Anju T Sudhakar
IMC (In-Memory collection counters) is a hardware monitoring facility that collects large number of hardware performance events. POWER9 support two modes for IMC which are the Accumulation mode and Trace mode. In Accumulation mode, event counts are accumulated in

[PATCH v3 1/5] powerpc/include: Add data structures and macros for IMC trace mode

2019-02-06 Thread Anju T Sudhakar
Add the macros needed for IMC (In-Memory Collection Counters) trace-mode and data structure to hold the trace-imc record data. Also, add the new type "OPAL_IMC_COUNTERS_TRACE" in 'opal-api.h', since there is a new switch case added in the opal-calls for IMC. Signed-off-by: Anju T Sudhakar

Re: [PATCH 1/2] powerpc/64s: Work around spurious warning on old gccs with -fsanitize-coverage

2019-02-06 Thread Andrew Donnellan
On 7/2/19 5:37 pm, Segher Boessenkool wrote: On Thu, Feb 07, 2019 at 04:33:23PM +1100, Andrew Donnellan wrote: Some older gccs (cpu_ftr_bit_mask) It seems to me the warning is correct? If enable_unknown is false and no cpu_feature is found, it will in if (m->cpu_ftr_bit_mask)

Re: [PATCH 1/2] powerpc/64s: Work around spurious warning on old gccs with -fsanitize-coverage

2019-02-06 Thread Segher Boessenkool
On Thu, Feb 07, 2019 at 04:33:23PM +1100, Andrew Donnellan wrote: > Some older gccs ( cause a spurious uninitialised variable warning in dt_cpu_ftrs.c: > > arch/powerpc/kernel/dt_cpu_ftrs.c: In function > ‘cpufeatures_process_feature’: > arch/powerpc/kernel/dt_cpu_ftrs.c:686:7: warning: ‘m’

[PATCH 0/1] Start conversion of PowerPC docs

2019-02-06 Thread Tobin C. Harding
Hi Michael, As discussed at LCA here is the start to the docs conversion for PowerPC to RST. This applies cleanly on top of the mainline (5.20-rc5) and Jon's tree (docs-next branch). I'm guessing it should go in through the PowerPC tree because I doubt you want to review this Jon, it's one big

[PATCH 1/1] docs: powerpc: Convert to RST format

2019-02-06 Thread Tobin C. Harding
The PowerPC docs have yet to be converted to RST format. Let's kick it off by doing all the files that _don't_ contain ASCII art. - Add SPDX license identifier to each new RST file. .. SPDX-License-Identifier: GPL-2.0 - User correct heading adornments. - Make all lines < 72 characters in

Re: [PATCH] powerpc/powernv/idle: Restore IAMR after idle

2019-02-06 Thread Russell Currey
On Thu, 2019-02-07 at 15:08 +1000, Nicholas Piggin wrote: > Russell Currey's on February 6, 2019 4:28 pm: > > Without restoring the IAMR after idle, execution prevention on > > POWER9 > > with Radix MMU is overwritten and the kernel can freely execute > > userspace without > > faulting. > > > >

Re: [PATCH] powerpc/powernv/idle: Restore IAMR after idle

2019-02-06 Thread Russell Currey
On Thu, 2019-02-07 at 15:29 +1100, Michael Ellerman wrote: > Russell Currey writes: > > > > Fixes: 3b10d0095a1e ("powerpc/mm/radix: Prevent kernel execution of > > user > > space") > > Don't word wrap the fixes line please. My bad, will teach my editor :) > > Cc: > > Signed-off-by: Russell

Re: [PATCH v16 16/21] powerpc: Activate CONFIG_THREAD_INFO_IN_TASK

2019-02-06 Thread Christophe Leroy
Le 07/02/2019 à 05:53, Nicholas Piggin a écrit : Michael Ellerman's on February 5, 2019 9:32 pm: From: Christophe Leroy This patch activates CONFIG_THREAD_INFO_IN_TASK which moves the thread_info into task_struct. Moving thread_info into task_struct has the following advantages: - It

Re: [PATCH] powerpc/44x: Force PCI on for CURRITUCK

2019-02-06 Thread Christoph Hellwig
Thanks, this looks good to me: Reviewed-by: Christoph Hellwig

[PATCH 2/2] powerpc: Enable kcov

2019-02-06 Thread Andrew Donnellan
kcov provides kernel coverage data that's useful for fuzzing tools like syzkaller. Wire up kcov support on powerpc. Disable kcov instrumentation on the same files where we currently disable gcov and UBSan instrumentation. Signed-off-by: Andrew Donnellan Acked-by: Dmitry Vyukov ---

[PATCH 1/2] powerpc/64s: Work around spurious warning on old gccs with -fsanitize-coverage

2019-02-06 Thread Andrew Donnellan
Some older gccs (cpu_ftr_bit_mask) An upcoming patch will enable support for kcov, which requires -fsanitize-coverage=trace-pc. Work around this by explicitly initialising m to NULL. Signed-off-by: Andrew Donnellan --- arch/powerpc/kernel/dt_cpu_ftrs.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH 2/2] powerpc: Fix defconfig choice logic when cross compiling

2019-02-06 Thread Michael Ellerman
Our logic for choosing defconfig doesn't work well in some situations. For example if you're on a ppc64le machine but you specify a non-empty CROSS_COMPILE, in order to use a non-default toolchain, then defconfig will give you ppc64_defconfig (big endian): $ make

[PATCH 1/2] powerpc/32: Add ppc_defconfig

2019-02-06 Thread Michael Ellerman
Add a generic 32-bit defconfig called ppc_defconfig. This means we'll have a defconfig matching "uname -m" for all cases. This config is mostly intended for build testing but if someone wants to tweak it to get it booting on something that would be fine too. Signed-off-by: Michael Ellerman ---

Re: [PATCH v2] powerpc/mm: move a KERN_WARNING message to pr_debug()

2019-02-06 Thread David Gibson
On Tue, Feb 05, 2019 at 09:21:33PM +0100, Laurent Vivier wrote: > resize_hpt_for_hotplug() reports a warning when it cannot > increase the hash page table ("Unable to resize hash page > table to target order") but this is not blocking and > can make user thinks something has not worked properly. >

Re: [PATCH] powerpc/powernv/idle: Restore IAMR after idle

2019-02-06 Thread Nicholas Piggin
Russell Currey's on February 6, 2019 4:28 pm: > Without restoring the IAMR after idle, execution prevention on POWER9 > with Radix MMU is overwritten and the kernel can freely execute userspace > without > faulting. > > This is necessary when returning from any stop state that modifies user >

Re: [PATCH v3 1/2] mm: add probe_user_read()

2019-02-06 Thread Michael Ellerman
Murilo Opsfelder Araujo writes: >> diff --git a/include/linux/uaccess.h b/include/linux/uaccess.h >> index 37b226e8df13..ef99edd63da3 100644 >> --- a/include/linux/uaccess.h >> +++ b/include/linux/uaccess.h >> @@ -263,6 +263,40 @@ extern long strncpy_from_unsafe(char *dst, const void >>

[PATCH] KVM: PPC: Book3S HV: Optimise mmio emulation for devices on FAST_MMIO_BUS

2019-02-06 Thread Suraj Jitindar Singh
Devices on the KVM_FAST_MMIO_BUS by definition have length zero and are thus used for notification purposes rather than data transfer. For example eventfd for virtio devices. This means that when emulating mmio instructions which target devices on this bus we can immediately handle them and

Re: [PATCH v16 16/21] powerpc: Activate CONFIG_THREAD_INFO_IN_TASK

2019-02-06 Thread Nicholas Piggin
Michael Ellerman's on February 5, 2019 9:32 pm: > From: Christophe Leroy > > This patch activates CONFIG_THREAD_INFO_IN_TASK which > moves the thread_info into task_struct. > > Moving thread_info into task_struct has the following advantages: > - It protects thread_info from corruption in the

Re: [PATCH v03] powerpc/numa: Perform full re-add of CPU for PRRN/VPHN topology update

2019-02-06 Thread kbuild test robot
Hi Michael, Thank you for the patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v5.0-rc4 next-20190206] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v16 16/21] powerpc: Activate CONFIG_THREAD_INFO_IN_TASK

2019-02-06 Thread Nicholas Piggin
Michael Ellerman's on February 5, 2019 9:32 pm: > From: Christophe Leroy > > This patch activates CONFIG_THREAD_INFO_IN_TASK which > moves the thread_info into task_struct. > > Moving thread_info into task_struct has the following advantages: > - It protects thread_info from corruption in the

Re: [PATCH v16 19/21] powerpc/32: Remove CURRENT_THREAD_INFO and rename TI_CPU

2019-02-06 Thread Nicholas Piggin
Nicholas Piggin's on February 7, 2019 2:27 pm: > Michael Ellerman's on February 5, 2019 9:32 pm: >> From: Christophe Leroy >> >> Now that thread_info is similar to task_struct, its address is in r2 >> so CURRENT_THREAD_INFO() macro is useless. This patch removes it. > > You wouldn't want to

Re: use generic DMA mapping code in powerpc V4

2019-02-06 Thread Christian Zigotzky
Hi Christoph, I also didn’t notice the 32-bit DMA mask in your patch. I have to read your patches and descriptions carefully in the future. I will test your new patch at the weekend. Thanks, Christian Sent from my iPhone > On 6. Feb 2019, at 16:16, Christoph Hellwig wrote: > >> On Wed, Feb

Re: [PATCH v2] powerpc/mm: move a KERN_WARNING message to pr_debug()

2019-02-06 Thread Michael Ellerman
Hi Laurent, I'm not sure I'm convinced about this one. It seems like we're just throwing away the warning because it's annoying. Laurent Vivier writes: > resize_hpt_for_hotplug() reports a warning when it cannot > increase the hash page table ("Unable to resize hash page > table to target

Re: [PATCH] powerpc/powernv/idle: Restore IAMR after idle

2019-02-06 Thread Michael Ellerman
Russell Currey writes: > Without restoring the IAMR after idle, execution prevention on POWER9 > with Radix MMU is overwritten and the kernel can freely execute userspace > without > faulting. > > This is necessary when returning from any stop state that modifies user > state, as well as

Re: [PATCH v16 19/21] powerpc/32: Remove CURRENT_THREAD_INFO and rename TI_CPU

2019-02-06 Thread Nicholas Piggin
Michael Ellerman's on February 5, 2019 9:32 pm: > From: Christophe Leroy > > Now that thread_info is similar to task_struct, its address is in r2 > so CURRENT_THREAD_INFO() macro is useless. This patch removes it. You wouldn't want to keep CURRENT_THREAD_INFO(r2) to mean get the thread info

Re: [PATCH v16 20/21] powerpc/64: Replace CURRENT_THREAD_INFO with PACA_CURRENT_TI

2019-02-06 Thread Nicholas Piggin
Michael Ellerman's on February 5, 2019 9:32 pm: > From: Christophe Leroy > > Now that current_thread_info is located at the beginning of 'current' > task struct, CURRENT_THREAD_INFO macro is not really needed any more. > > This patch replaces it by loads of the value at PACA_CURRENT_TI(r13). >

Re: [PATCH v16 14/21] powerpc: Use task_stack_page() in current_pt_regs()

2019-02-06 Thread Nicholas Piggin
Michael Ellerman's on February 5, 2019 9:32 pm: > From: Christophe Leroy > > Change current_pt_regs() to use task_stack_page() rather than > current_thread_info() so that it keeps working once we enable > THREAD_INFO_IN_TASK. > > Signed-off-by: Christophe Leroy > [mpe: Split out of large

Re: [PATCH v16 05/21] powerpc: prep stack walkers for THREAD_INFO_IN_TASK

2019-02-06 Thread Nicholas Piggin
Michael Ellerman's on February 5, 2019 9:32 pm: > From: Christophe Leroy > > [text copied from commit 9bbd4c56b0b6 > ("arm64: prep stack walkers for THREAD_INFO_IN_TASK")] > > When CONFIG_THREAD_INFO_IN_TASK is selected, task stacks may be freed > before a task is destroyed. To account for

Re: [PATCH v16 01/21] powerpc/irq: use memblock functions returning virtual address

2019-02-06 Thread Nicholas Piggin
Michael Ellerman's on February 5, 2019 9:31 pm: > From: Christophe Leroy > > Since only the virtual address of allocated blocks is used, > lets use functions returning directly virtual address. > > Those functions have the advantage of also zeroing the block. > > Suggested-by: Mike Rapoport >

Re: [PATCH 00/19] KVM: PPC: Book3S HV: add XIVE native exploitation mode

2019-02-06 Thread David Gibson
On Wed, Feb 06, 2019 at 08:35:24AM +0100, Cédric Le Goater wrote: > On 2/6/19 2:18 AM, David Gibson wrote: > > On Wed, Feb 06, 2019 at 09:13:15AM +1100, Paul Mackerras wrote: > >> On Tue, Feb 05, 2019 at 12:31:28PM +0100, Cédric Le Goater wrote: > >> As for nesting, I suggest for the

Re: [PATCH 06/19] KVM: PPC: Book3S HV: add a GET_ESB_FD control to the XIVE native device

2019-02-06 Thread David Gibson
On Wed, Feb 06, 2019 at 08:21:10AM +0100, Cédric Le Goater wrote: > On 2/6/19 2:23 AM, David Gibson wrote: > > On Tue, Feb 05, 2019 at 01:55:40PM +0100, Cédric Le Goater wrote: > >> On 2/5/19 6:28 AM, David Gibson wrote: > >>> On Mon, Feb 04, 2019 at 12:30:39PM +0100, Cédric Le Goater wrote: >

Re: [PATCH 15/19] KVM: PPC: Book3S HV: add get/set accessors for the source configuration

2019-02-06 Thread David Gibson
On Wed, Feb 06, 2019 at 08:07:36AM +0100, Cédric Le Goater wrote: > On 2/6/19 2:24 AM, David Gibson wrote: > > On Wed, Feb 06, 2019 at 12:23:29PM +1100, David Gibson wrote: > >> On Tue, Feb 05, 2019 at 02:03:11PM +0100, Cédric Le Goater wrote: > >>> On 2/5/19 6:32 AM, David Gibson wrote: > On

[PATCH] powerpc/44x: Force PCI on for CURRITUCK

2019-02-06 Thread Michael Ellerman
The recent rework of PCI kconfig symbols exposed an existing bug in the CURRITUCK kconfig logic. It selects PPC4xx_PCI_EXPRESS which depends on PCI, but PCI is user selectable and might be disabled, leading to a warning: WARNING: unmet direct dependencies detected for PPC4xx_PCI_EXPRESS

Re: BUG: memcmp(): Accessing invalid memory location

2019-02-06 Thread Chandan Rajendra
On Thursday, February 7, 2019 5:27:09 AM IST Michael Ellerman wrote: > Chandan Rajendra writes: > > On Wednesday, February 6, 2019 5:20:04 PM IST Michael Ellerman wrote: > >> Chandan Rajendra writes: > >> > On Friday, February 1, 2019 4:43:52 PM IST Michael Ellerman wrote: > >> >> Michael

Re: [PATCH net] net: fsl_ucc_hdlc: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

2019-02-06 Thread David Miller
From: Yang Wei Date: Wed, 6 Feb 2019 00:14:51 +0800 > From: Yang Wei > > dev_consume_skb_irq() should be called in hdlc_tx_done() when skb > xmit done. It makes drop profiles(dropwatch, perf) more friendly. > > Signed-off-by: Yang Wei Applied.

Re: [PATCH v16 19/21] powerpc/32: Remove CURRENT_THREAD_INFO and rename TI_CPU

2019-02-06 Thread Michael Ellerman
Michael Ellerman writes: > diff --git a/arch/powerpc/kernel/idle_6xx.S b/arch/powerpc/kernel/idle_6xx.S > index d9b6e7e0b5e3..5e69fefcd9c4 100644 > --- a/arch/powerpc/kernel/idle_6xx.S > +++ b/arch/powerpc/kernel/idle_6xx.S > @@ -159,9 +158,7 @@ _GLOBAL(power_save_ppc32_restore) > stw

Re: BUG: memcmp(): Accessing invalid memory location

2019-02-06 Thread Michael Ellerman
Chandan Rajendra writes: > On Wednesday, February 6, 2019 5:20:04 PM IST Michael Ellerman wrote: >> Chandan Rajendra writes: >> > On Friday, February 1, 2019 4:43:52 PM IST Michael Ellerman wrote: >> >> Michael Ellerman writes: >> >> >> >> > Adding Simon who wrote the code. >> >> > >> >> >

RE: [PATCH v4 1/2] dt-bindings: soc: fsl: Document Qixis FPGA usage

2019-02-06 Thread Leo Li
> -Original Message- > From: Pankaj Bansal > Sent: Tuesday, February 5, 2019 4:15 AM > To: Leo Li ; Rob Herring ; Mark > Rutland > Cc: linuxppc-dev@lists.ozlabs.org; linux-arm-ker...@lists.infradead.org; > open list : OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > ; Pankaj Bansal >

[PATCH v03] powerpc/numa: Perform full re-add of CPU for PRRN/VPHN topology update

2019-02-06 Thread Michael Bringmann
On pseries systems, performing changes to a partition's affinity can result in altering the nodes a CPU is assigned to the current system. For example, some systems are subject to resource balancing operations by the operator or control software. In such environments, system CPUs may be in node

Re: use generic DMA mapping code in powerpc V4

2019-02-06 Thread Christoph Hellwig
On Wed, Feb 06, 2019 at 04:15:05PM +0100, Christoph Hellwig wrote: > The last good one was 29e7e2287e196f48fe5d2a6e017617723ea979bf > ("dma-direct: we might need GFP_DMA for 32-bit dma masks"), if I > remember correctly. powerpc/dma: use the dma_direct mapping routines > was the one that you said

Re: use generic DMA mapping code in powerpc V4

2019-02-06 Thread Christoph Hellwig
On Wed, Feb 06, 2019 at 02:45:34PM +0100, Christian Zigotzky wrote: > I patched the source code from the Git 'powerpc-dma.6' with your patch > today. Unfortunately the P.A. Semi Ethernet doesn't work with the patched > Git kernel. > > After that I tried it with the patch applied over the working

Re: use generic DMA mapping code in powerpc V4

2019-02-06 Thread Christian Zigotzky
On 04 February 2019 at 01:38PM, Christoph Hellwig wrote: It seems like the pasemi driver fails to set a DMA mask, but seems otherwise 64-bit DMA capable. The old PPC code didn't verify the dma mask during the map operations, but the x86-derived generic code does. This patch just sets the DMA

[PATCH] powerpc/64: Fix memcmp reading past the end of src/dest

2019-02-06 Thread Michael Ellerman
Chandan reported that fstests' generic/026 test hit a crash: BUG: Unable to handle kernel data access at 0xc0062ac4 Faulting instruction address: 0xc0092240 Oops: Kernel access of bad area, sig: 11 [#1] LE SMP NR_CPUS=2048 DEBUG_PAGEALLOC NUMA pSeries CPU: 0 PID: 27828

Re: BUG: memcmp(): Accessing invalid memory location

2019-02-06 Thread Chandan Rajendra
On Wednesday, February 6, 2019 5:20:04 PM IST Michael Ellerman wrote: > Chandan Rajendra writes: > > On Friday, February 1, 2019 4:43:52 PM IST Michael Ellerman wrote: > >> Michael Ellerman writes: > >> > >> > Adding Simon who wrote the code. > >> > > >> > Chandan Rajendra writes: > >> >> When

Re: [PATCH v2] powerpc/perf: Use PVR rather than oprofile field to determine CPU version

2019-02-06 Thread Madhavan Srinivasan
On 06/02/19 12:00 PM, Rashmica Gupta wrote: Currently the perf CPU backend drivers detect what CPU they're on using cur_cpu_spec->oprofile_cpu_type. Although that works, it's a bit crufty to be using oprofile related fields, especially seeing as oprofile is more or less unused these days. It

Re: [PATCH net-next v5 11/12] socket: Rename SO_RCVTIMEO/ SO_SNDTIMEO with _OLD suffixes

2019-02-06 Thread Michael Ellerman
Deepa Dinamani writes: > SO_RCVTIMEO and SO_SNDTIMEO socket options use struct timeval > as the time format. struct timeval is not y2038 safe. > The subsequent patches in the series add support for new socket > timeout options with _NEW suffix that will use y2038 safe > data structures. Although

Re: [PATCH net-next v5 12/12] sock: Add SO_RCVTIMEO_NEW and SO_SNDTIMEO_NEW

2019-02-06 Thread Michael Ellerman
Deepa Dinamani writes: > Add new socket timeout options that are y2038 safe. > > Signed-off-by: Deepa Dinamani > Acked-by: Willem de Bruijn > Cc: ccaul...@redhat.com > Cc: da...@davemloft.net > Cc: del...@gmx.de > Cc: pau...@samba.org > Cc: r...@linux-mips.org > Cc: r...@twiddle.net > Cc:

Re: BUG: memcmp(): Accessing invalid memory location

2019-02-06 Thread Michael Ellerman
Chandan Rajendra writes: > On Friday, February 1, 2019 4:43:52 PM IST Michael Ellerman wrote: >> Michael Ellerman writes: >> >> > Adding Simon who wrote the code. >> > >> > Chandan Rajendra writes: >> >> When executing fstests' generic/026 test, I hit the following call trace, >> >> >> >> [

Re: [PATCH] powerpc/prom_init: add __init markers to all functions

2019-02-06 Thread Michael Ellerman
Masahiro Yamada writes: > On Tue, Feb 5, 2019 at 7:33 PM Michael Ellerman wrote: >> >> Masahiro Yamada writes: >> >> > It is fragile to rely on the compiler's optimization to avoid the >> > section mismatch. Some functions may not be necessarily inlined >> > when the compiler's inlining

Re: [PATCH 1/4] powerpc/64s: Clear on-stack exception marker upon exception return

2019-02-06 Thread Balbir Singh
On Wed, Feb 6, 2019 at 3:44 PM Michael Ellerman wrote: > > Balbir Singh writes: > > On Tue, Feb 5, 2019 at 10:24 PM Michael Ellerman > > wrote: > >> Balbir Singh writes: > >> > On Sat, Feb 2, 2019 at 12:14 PM Balbir Singh > >> > wrote: > >> >> On Tue, Jan 22, 2019 at 10:57:21AM -0500, Joe